Fwd: master branch: dhcp and ATTR_FLAGS.encoded: few questions.

Alan DeKok aland at deployingradius.com
Fri May 6 11:18:45 CEST 2011


Ruslan Shevchenko wrote:
> I try to compile freeradius trunk with WITH_DHCP flags, found few issues:
> 
> 1. encoded  bit-field is removed from ATTR_FLAGS.
>  (bit it still used in dhcp.c, so compilation is broken)
>  It's correct, that check of encoded field can be safely removed from
> dhcp, becouse this flag was used to reflect stage of packet
> processing,
>  not stage of flag  ?

  Yes, that needs to be fixed.

> 2. in ATTRF_FLAGS size of do_xlat bitfueld is set to zero

  ? Nope.  It's a 1-bit bitfield.

> 3. listener.c contains reference to undfined function fr_ipaddr_any.

  That's a typo.  I'll commit a fix.

  Alan DeKok.



More information about the Freeradius-Devel mailing list