Commit report for master branch

Mon Feb 18 00:00:02 CET 2013

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server)

======
Be explicit about why were not building rlm_rest

Arran Cudbard-Bell at 2013-02-17T21:55:11Z
Files modified:
	* src/modules/rlm_rest/configure
	* src/modules/rlm_rest/configure.in

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/2a9039c6a2555f7e4093c8160d422a548eafbbe3
====== 
Update autoconf.h.in

Arran Cudbard-Bell at 2013-02-17T21:45:15Z
Files modified:
	* src/include/autoconf.h.in

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/6b7e8f6594602b5aa474ccdb11d497cad249454d
====== 
Check for libcurl >= 17.9.1

Disable definitions for ancient code depending on libcurl

Arran Cudbard-Bell at 2013-02-17T21:45:15Z
Files modified:
	* src/modules/rlm_rest/configure
	* src/modules/rlm_rest/configure.in
	* src/modules/rlm_rest/rest.h

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/e31d57ae947785dea5ee36f7b1889d69296a144b
====== 
dir can't be NULL

Alan T. DeKok at 2013-02-17T21:38:52Z
Files modified:
	* src/lib/dict.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/bb53413fc918049a249131b7b5cd4bdd09bd77ce
====== 
Check pointers before using them

Alan T. DeKok at 2013-02-17T21:37:32Z
Files modified:
	* src/modules/rlm_sql/rlm_sql.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/4ce5c62d41dd921e83deeb7cf4bab3849722636a
====== 
Check length of ascend secrets

Alan T. DeKok at 2013-02-17T21:35:22Z
Files modified:
	* src/lib/radius.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/5cea200145a381064cff819497fd4a626503c5c8
====== 
Remove finger functionality from radwho.  No one uses it (or should)

Alan T. DeKok at 2013-02-17T21:22:30Z
Files modified:
	* man/man1/radwho.1
	* src/main/radwho.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/7d9e39991f505a65d09ea48bcfe0ba237ce662d8
====== 
Check for NULL before incrementing

Alan T. DeKok at 2013-02-17T21:19:03Z
Files modified:
	* scripts/jlibtool.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/e731205fd21eb8534d17fe10b7b1c45e414445a0
====== 
Check array[0], not array

Alan T. DeKok at 2013-02-17T21:16:18Z
Files modified:
	* src/lib/valuepair.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/7c009f3b4890c0b7f956b7488d16eae61174f227
====== 
Error if the dictionaries weren't initialized

Alan T. DeKok at 2013-02-17T21:15:25Z
Files modified:
	* src/main/dhcpd.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/10f7b6463ead59d654a2fea5fe4fbabc33b71488
====== 
Correct args to memset

Alan T. DeKok at 2013-02-17T21:14:22Z
Files modified:
	* src/modules/rlm_dhcp/rlm_dhcp.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/9ead7a00c9376c3b693289143822d79026a9dc78
====== 
Use strlcpy instead of strcpy

Alan T. DeKok at 2013-02-17T21:13:19Z
Files modified:
	* src/modules/rlm_mschap/smbencrypt.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/1b49c9e223f0893248f787e79882fd975721c5ce
====== 
Use sizeof instead of strlen

Alan T. DeKok at 2013-02-17T21:12:32Z
Files modified:
	* scripts/jlibtool.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/e6f6cec324ec9d4f7e95b41b52012f602a8f8c8d
====== 
Return on error

Alan T. DeKok at 2013-02-17T21:11:31Z
Files modified:
	* src/lib/tcp.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/d53bb68b1dc9e169d10b411c051a6137658232b7
====== 
EOL is EOL

Alan T. DeKok at 2013-02-17T21:09:16Z
Files modified:
	* src/lib/base64.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/8847b3b9073b605da2c979afa8d38ee9ed4ff66e
====== 
EOL is EOL

Alan T. DeKok at 2013-02-17T21:06:49Z
Files modified:
	* src/include/base64.h

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/59f270b46e7273bb9440630ac6fb41744cb5b845
====== 
Fix build error

Alan T. DeKok at 2013-02-17T21:00:15Z
Files modified:
	* src/lib/packet.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/56e4d2e36b806fc1ec7351f5bd12786b18b6fe3d
====== 
d_namlen is BSD, not posix

Alan T. DeKok at 2013-02-17T20:52:05Z
Files modified:
	* scripts/jlibtool.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/cac4dd549c3f258d6f50a7d26aa03aeb1dba1698
====== 
Fix for coverity (printf of non null terminated string)

Arran Cudbard-Bell at 2013-02-17T20:41:20Z
Files modified:
	* src/main/radwho.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/098e1103ec3f7b3f161aa13deaefcf5d38e74aba
====== 
Clean up and sanitize pairread()

Should fix a number of coverity issues

Alan T. DeKok at 2013-02-17T20:37:29Z
Files modified:
	* src/lib/valuepair.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/ac7a8091a8c90b2080c87ef36dabdfda6187c1b9
====== 
Fix for coverity (potential buffer overflow in radlog_request)

Arran Cudbard-Bell at 2013-02-17T20:23:43Z
Files modified:
	* src/main/log.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/4b1083ae919bd7bc1de460af34230037f7f8e65c
====== 
Fix race condition in conf file

Closes Coverity #720457

Alan T. DeKok at 2013-02-17T19:32:03Z
Files modified:
	* src/main/conffile.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/7632754dab591a26b8a66e1207cc1e08e3ac2884
====== 
Fix typo

Alan T. DeKok at 2013-02-17T19:30:39Z
Files modified:
	* src/modules/rlm_otp/otp_radstate.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/612feb2ca22e061c1767e25355188b23c3f51d6d
====== 
Check for =~ and !~

Fixes Coverity #982075

Alan T. DeKok at 2013-02-17T19:24:10Z
Files modified:
	* src/modules/rlm_expr/paircmp.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/770d15d95dd2d5408eaafba9637f5641d06ae6b2
====== 
Check for no challenge/response in packet

Closes Coverity #720480

Alan T. DeKok at 2013-02-17T19:23:00Z
Files modified:
	* src/modules/rlm_otp/otp_mppe.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/a596c76d59f86473d5b6dccac336df579d755be3
====== 
Remove unused variables

Alan T. DeKok at 2013-02-17T19:23:00Z
Files modified:
	* src/modules/rlm_perl/rlm_perl.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/832f93ced43743bc7e365179aee26cc316674286
====== 
Remove unused variable

Alan T. DeKok at 2013-02-17T19:23:00Z
Files modified:
	* src/modules/rlm_preprocess/rlm_preprocess.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/a3d72b7c772b2755a13984300b4dfde177baccbd
====== 
Fix for coverity (redundant default statement)

Arran Cudbard-Bell at 2013-02-17T19:12:52Z
Files modified:
	* src/modules/rlm_sqlippool/rlm_sqlippool.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/fbecea6756016f3ef6513b841097943597ac4762
====== 
Fix for coverity (redundant condition)

Arran Cudbard-Bell at 2013-02-17T19:10:36Z
Files modified:
	* src/main/conffile.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/c219f1699c50f7733270603cdfdb84d957f78806
====== 
Fix for coverity (duplicate case statements)

Arran Cudbard-Bell at 2013-02-17T19:07:38Z
Files modified:
	* src/main/acct.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/2029c2d5a14e503c3bba282075bd63be418438bb
====== 
Fix for coverity (remove redundant default statement)

Arran Cudbard-Bell at 2013-02-17T19:04:15Z
Files modified:
	* src/lib/filters.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/68d25bb44c2280f29bf347271061e60ea6e79b1c
====== 
Output proper error messages for prthread_setspecific failure in rlm_perl.c and lib/log.c

Arran Cudbard-Bell at 2013-02-17T19:02:59Z
Files modified:
	* src/lib/log.c
	* src/modules/rlm_perl/rlm_perl.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/1e3d3d20ee161a7f09c336723b0b6ab4817fb73e
====== 
Fix for coverity (verify we parsed the proxy config section ok)

Arran Cudbard-Bell at 2013-02-17T18:53:50Z
Files modified:
	* src/main/realms.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/82395d4dd28b4af8bea6c8c372f00c1b4ff1b251
====== 
Fix for covertiy

Arran Cudbard-Bell at 2013-02-17T18:49:57Z
Files modified:
	* src/main/process.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/17a4a389bce8aea4bf994362258b2ac54b355802
====== 
Fix for coverity (check setsockopt in listen.c)

Arran Cudbard-Bell at 2013-02-17T18:48:31Z
Files modified:
	* src/main/listen.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/ef8306e091e2fa104671ff0c754c4dae5499da82
====== 
Fix for coverity (check return of ip_hton in detail.c)

Arran Cudbard-Bell at 2013-02-17T18:41:00Z
Files modified:
	* src/main/detail.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/c53bbff9685fb051dcce2ac1b568e81aa8678c03
====== 
Check return code of dup()

Closes Coverity #720380, 81, 82

Alan T. DeKok at 2013-02-17T18:21:31Z
Files modified:
	* src/main/command.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/5c0a721f842216058097edd5648ad5ec58a2f05c
====== 
Don't check array for existence.

Closes Coverity #720384

Alan T. DeKok at 2013-02-17T18:21:31Z
Files modified:
	* src/modules/rlm_attr_rewrite/rlm_attr_rewrite.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/4dd0b168c4fea9c1c1a5e43a05763d2a9cead9ae
====== 
Don't check an array for existence

Closes Coverity #720389

Alan T. DeKok at 2013-02-17T18:21:31Z
Files modified:
	* src/modules/rlm_sql/rlm_sql.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/bfc45c05af3f394629501f45d9e492812d30d1ff
====== 
Fix for coverity (bail if we can't stat the file in detail_recv)

Arran Cudbard-Bell at 2013-02-17T18:17:37Z
Files modified:
	* src/main/detail.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/fccbe02926a506bced3b8e994e47b375449ab606
====== 
Fix for coverity (more radrecv stuff)

Arran Cudbard-Bell at 2013-02-17T18:17:36Z
Files modified:
	* src/lib/vqp.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/a888bada6b5a43b669fbe99cd5be9f2c42275727
====== 
Fix for coverity

Arran Cudbard-Bell at 2013-02-17T18:17:36Z
Files modified:
	* src/lib/radius.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/2bb9dfc704c80efed9b2a4839a1e9a576d5ded79
====== 
Use strlcpy, and check sizeof module name

Closes Covierty #720447

Alan T. DeKok at 2013-02-17T18:12:34Z
Files modified:
	* src/main/modules.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/ef206734051919569f79d1cd988f168d1235bb81
====== 
Use strlcpy

Alan T. DeKok at 2013-02-17T18:12:34Z
Files modified:
	* src/modules/rlm_realm/rlm_realm.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/a5148102e2cbc4ed3f4a4971af8f3a09464ff339
====== 
Fail safely if the directory exists in rad_mkdir

Maybe another thread is making the directory.  If so, it's OK

Closes Coverity #720459

Alan T. DeKok at 2013-02-17T18:12:33Z
Files modified:
	* src/main/util.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/be1cb3220b42cc71129b8db29349c4bee413ec33
====== 
Initialize IPaddr

Closes Coverity #720462

Alan T. DeKok at 2013-02-17T18:12:33Z
Files modified:
	* src/main/stats.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/fd22b98fbc41550d0af4e64eef3a02f1bb4f2744
====== 
Sign error

Closes Coverity #720436

Alan T. DeKok at 2013-02-17T18:12:32Z
Files modified:
	* src/modules/rlm_mschap/rlm_mschap.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/df26f8e3092b4b2d9812b34d7a51a1a06ad3ca27
====== 
Clear memory using correct size

Closes Coverity #720439, 40, 41

Alan T. DeKok at 2013-02-17T18:12:32Z
Files modified:
	* src/main/conffile.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/7c4090f6fb22bb65f3b3b1baaaed508914e186c7
====== 
Don't expand variables if cs==NULL

Closes Coverity #720373

Alan T. DeKok at 2013-02-17T18:12:32Z
Files modified:
	* src/main/conffile.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/fff985ef94b3dddf009d2ff056b9c6de1e16107f
====== 
Fix for coverity (don't need to check recvfrom return in rad_recv_discard)

Arran Cudbard-Bell at 2013-02-17T18:06:27Z
Files modified:
	* src/lib/radius.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/acb0e4f38da4d68c0ae32deea7861a9e450109ab
====== 
Fix for coverity (check return value of setsockopt)

Arran Cudbard-Bell at 2013-02-17T18:00:19Z
Files modified:
	* src/lib/packet.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/a85825bf328e7c18e60d468a67d22b4e9308ebae
====== 
Fix for coverity

Arran Cudbard-Bell at 2013-02-17T18:00:18Z
Files modified:
	* src/lib/log.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/17cab809506a036384c1e01dae99833c6bfbb20d
====== 
Remove dead code

Closes Coverity #982076

Alan T. DeKok at 2013-02-17T17:40:32Z
Files modified:
	* scripts/jlibtool.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/a77d3f53e3bc9d8027a30b043f6e585692f337a8
====== 
Remove dead code.

Closes Coverity #982077

Alan T. DeKok at 2013-02-17T17:40:32Z
Files modified:
	* scripts/jlibtool.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/c19336641925e3cfd8c8a1386d32c3ce5c45063f
====== 
Use correct flag for check

Closes Coverity #982078

Alan T. DeKok at 2013-02-17T17:40:32Z
Files modified:
	* src/main/command.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/eb8ad4bf91dac9b0452ba38f2f194f1edf47fdc9
====== 
Don't free data returned from gdbm_fetch

Closes Coverity #982067, 982068, 982069

Alan T. DeKok at 2013-02-17T17:40:32Z
Files modified:
	* src/modules/rlm_ippool/rlm_ippool_tool.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/1cc2f03df968dbb8393829ded5ebe7692f3adb4e
====== 
Remove dead code.

Closes Coverity #982080, 982079

Alan T. DeKok at 2013-02-17T17:40:32Z
Files modified:
	* src/modules/rlm_ippool/rlm_ippool_tool.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/f04478426b17856ad6969c7889695928daa629b9
====== 
Check for NULL da.  Only if dictionary files are broken.

Closes Coverity #982081

Alan T. DeKok at 2013-02-17T17:40:31Z
Files modified:
	* src/lib/radius.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/bd769d812e24d13b1a5c290455fc601c53ad046d
====== 
value may be NULL.  Only for admin mistake.

Closes Coverity #982082

Alan T. DeKok at 2013-02-17T17:40:31Z
Files modified:
	* src/main/mainconfig.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/20f742385b733860352e368956b2eba0e7deaadd
====== 
Check for NULL.

Closes Coverity #982083 (false positive)

Alan T. DeKok at 2013-02-17T17:40:31Z
Files modified:
	* src/modules/rlm_krb5/rlm_krb5.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/e84e123c05efcabbb847dc77c30e0fad3ccb5765
====== 
Limit attrlen to 128K.

Closes Coverity #982085

Alan T. DeKok at 2013-02-17T17:40:31Z
Files modified:
	* src/lib/radius.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/91a9f1cfa530e5efb80eedc3a39beb5d36325ca6
====== 
Fix for coverity

Arran Cudbard-Bell at 2013-02-17T17:39:09Z
Files modified:
	* src/modules/rlm_sql/sql.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/5696d1fb433ec3763446e395593aaa0ba89ccc88
====== 
Fix for coverity

Arran Cudbard-Bell at 2013-02-17T17:35:40Z
Files modified:
	* src/modules/rlm_radutmp/rlm_radutmp.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/8281a5a3b7e14d5b363588c2aadcd49917eb09d1
====== 
Fix for coverity

Arran Cudbard-Bell at 2013-02-17T17:27:01Z
Files modified:
	* src/main/tls.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/83e49a1650032f04d3a162c578957022d36950b0
====== 
Fix for coverity

Arran Cudbard-Bell at 2013-02-17T17:23:09Z
Files modified:
	* src/main/dhcpd.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/7f62f2cda675e037155da057c6bb45471673efd9
====== 
Fix for coverity (don't segv if the ruby function returns an array during intiialisation)

Arran Cudbard-Bell at 2013-02-17T17:17:12Z
Files modified:
	* src/modules/rlm_ruby/rlm_ruby.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/a4b978a3a2a21614517861dfc313a2e9c2765628
====== 
Fix for coverity (assign return from recvfrom to a local signed variable so we can check for error conditions)

Arran Cudbard-Bell at 2013-02-17T16:58:22Z
Files modified:
	* src/lib/dhcp.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/f5fd9379b53d992e37c9f28303d940e3cbe2fafd
====== 
Unlock on error

Closes Coverity #982086

Alan T. DeKok at 2013-02-17T16:44:06Z
Files modified:
	* src/modules/rlm_cache/rlm_cache.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/06f8f31406011a683c4be44b067cc16185fd9947
====== 
Add missing break

Closes Coverity #982087

Alan T. DeKok at 2013-02-17T16:44:06Z
Files modified:
	* src/modules/rlm_dbm/rlm_dbm_parser.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/42e4d3f8f4106dde0096aa47c95d2921cf3f2ce4
====== 
Add missing break

Closes Coverity #982088

Alan T. DeKok at 2013-02-17T16:44:06Z
Files modified:
	* src/modules/rlm_krb5/rlm_krb5.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/d21249cdc0a3c6fa24af35325c273e06e2d4e16a
====== 
Note fall-through

Closes Coverity #982089

Alan T. DeKok at 2013-02-17T16:44:06Z
Files modified:
	* src/modules/rlm_ldap/rlm_ldap.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/f3e46e68c4009c95863b10fd7018d744dc5ae7ed
====== 
Add missing break

closes Coverity #982090

Alan T. DeKok at 2013-02-17T16:44:06Z
Files modified:
	* src/modules/rlm_rest/rest.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/b24bded5a3698cace087ffa6bc70b645fea0257a
====== 
Remove unnecessary check

Closes Coverity #982093

Alan T. DeKok at 2013-02-17T16:44:05Z
Files modified:
	* src/modules/rlm_counter/rlm_counter.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/24c3fbff4b37bfebdde9b78394aea7923b1f400f
====== 
Use sizeof(struct) not sizeof(*struct)

Closes Coverity #982094

Alan T. DeKok at 2013-02-17T16:44:05Z
Files modified:
	* src/modules/rlm_dhcp/rlm_dhcp.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/be2b69a0a88f7b39ecd8a7555caba8015f80ae45
====== 
There's no need to memset data to zero

Closes Coverity #982095

Alan T. DeKok at 2013-02-17T16:44:05Z
Files modified:
	* src/main/tls_listen.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/f31806e62c31860e52f60448235950c1dae4f16b
====== 
Check size of raw attributes in TTLS

Closes Coverity #982096

Alan T. DeKok at 2013-02-17T16:44:05Z
Files modified:
	* src/modules/rlm_eap/types/rlm_eap_ttls/ttls.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/8079cb3ae0dfb41635d4aa9c619c272f23363a21
====== 
Free vp on error

Closes Coverity #982097

Alan T. DeKok at 2013-02-17T16:44:05Z
Files modified:
	* src/lib/dhcp.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/da3cef52927de4db7b4eea4d4485aaf1660edbb3
====== 
Fix for coverity (check return value of cf_section_parse)

Arran Cudbard-Bell at 2013-02-17T05:15:17Z
Files modified:
	* src/modules/rlm_rest/rlm_rest.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/a56a79b379b851985b3fb07f3e573eca91f9ecfb
====== 
Fix for coverity (potential segv for very long libpaths in run_mode)

Arran Cudbard-Bell at 2013-02-17T05:06:58Z
Files modified:
	* scripts/jlibtool.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/153acd39b134e124d81d44e21b26781b42264d38
====== 
Fix for coverity (potential segv for argument names over 49 bytes in jlibtool)

Arran Cudbard-Bell at 2013-02-17T05:01:53Z
Files modified:
	* scripts/jlibtool.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/a6694d004a789fdd26ab8e4ecefa426b18981a37
====== 
Fix for coverity (fix potential buffer overflow in cleanup_tmp_dir)

Arran Cudbard-Bell at 2013-02-17T04:58:28Z
Files modified:
	* scripts/jlibtool.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/3f89fc68cb4ba022925c1d29f9e5e5ea22563060
====== 
Fix for coverity (zero out sizeof(*fi) not sizeof(fi) in fr_fifo_free)

Arran Cudbard-Bell at 2013-02-17T04:49:08Z
Files modified:
	* src/lib/fifo.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/1165b126e74f6f88ad509804af371272b6db29de
====== 
Fix for coverity (zero out sizeof(*packet) not sizeof(packet) in fr_dhcp_rcv)

Arran Cudbard-Bell at 2013-02-17T04:47:17Z
Files modified:
	* src/lib/dhcp.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/99d4186dd12f3b731b0cec8117b4e9362c5e0a4c
====== 
Fix const warning in jlibtool

Arran Cudbard-Bell at 2013-02-17T04:44:36Z
Files modified:
	* scripts/jlibtool.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/0add5a2b425a2fa6e076ef580c27698a4311dff8
====== 
Fix for coverity (ensure inst is not NULL before dereferencing it in eap_pwd_initiate)

Arran Cudbard-Bell at 2013-02-17T04:44:36Z
Files modified:
	* src/modules/rlm_eap/types/rlm_eap_pwd/rlm_eap_pwd.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/4d921cfe4deb2e72537909d51605df7a84999df6
====== 
Fix for covertiy (ensure we have a home_server when insert_into_proxy_hash is called)

Arran Cudbard-Bell at 2013-02-17T04:44:35Z
Files modified:
	* src/main/process.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/bc2627498bbc9a18caff3543c1e593c437bfc89b
====== 
Fix for coverity (don't leak memory on run_mode)

Arran Cudbard-Bell at 2013-02-17T04:33:42Z
Files modified:
	* scripts/jlibtool.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/5e99511fe7a105e4d177651e04439f16ed873f26
====== 
Fix for coverity (fix run command so it doesn't leak memory allocated for the command)

Arran Cudbard-Bell at 2013-02-17T04:29:58Z
Files modified:
	* scripts/jlibtool.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/2fdf68bb24f3019d717a7d6368a78f23e616be3f
====== 
Fix for coverity (fix load_install_path so it doesn't leak memory if passed a non absolute path)

Arran Cudbard-Bell at 2013-02-17T04:23:14Z
Files modified:
	* scripts/jlibtool.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/91f76e5c5f58a93c8d3f9b0894b978a114cb246e
====== 
Fix for coverity (fix cleanup_tmp_dir so it doesn't leak directory handles)

Arran Cudbard-Bell at 2013-02-17T04:20:35Z
Files modified:
	* scripts/jlibtool.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/98e02023b4295d8266d856119b63f0023abd755b
====== 
Fix for coverity (don't leak memory if the object doesn't exist)

Arran Cudbard-Bell at 2013-02-17T04:17:53Z
Files modified:
	* scripts/jlibtool.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/e5230679ff0153fff00a292ff48eb377b86ab26d
====== 
Fix for coverity (don't leak memory if we can't find the library)

Arran Cudbard-Bell at 2013-02-17T04:16:22Z
Files modified:
	* scripts/jlibtool.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/a14c46cd8b8bfa85408e2aca14d947bb89f07bc9
====== 
Fix for coverity (don't leak memory in add_rpath_noinstall)

Arran Cudbard-Bell at 2013-02-17T04:06:41Z
Files modified:
	* scripts/jlibtool.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/3fd80b6bade74e77970f0a0b8cff756972103865
====== 
Fix for coverity (should use zu for sizeof)

Arran Cudbard-Bell at 2013-02-17T04:04:07Z
Files modified:
	* src/lib/dhcp.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/78fecf9ca90a6c180654ebdd057ace401f4d0f54
====== 
Fix for coverity (don't segfault if rlm_realm is called in the recv-coa section and Operator-Name isn't present)

Arran Cudbard-Bell at 2013-02-17T03:58:22Z
Files modified:
	* src/modules/rlm_realm/rlm_realm.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/f470232910c2d1893fa69f0697e9a27bdb699d24
====== 
Fix for coverity (may pass NULL char pointer to strstr)

Arran Cudbard-Bell at 2013-02-17T03:52:22Z
Files modified:
	* scripts/jlibtool.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/58f508192ca42f7ded2e6e619cfd89348ed1a859
====== 
Fix for coverity (array will always decompose to a pointer which will always be true)

Arran Cudbard-Bell at 2013-02-17T03:46:37Z
Files modified:
	* src/main/dhcpd.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/6ee893b30fe37ed1f878cbadae455b18856e75d8
====== 
Fix for coverity (fall-through is intentional)

Arran Cudbard-Bell at 2013-02-17T03:43:30Z
Files modified:
	* src/main/valuepair.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/fb6cb54f7099577779f315b88803c2051f46c4f0
====== 
For for coverity (don't segfault in cf_log_err if we get a NULL ci)

Arran Cudbard-Bell at 2013-02-17T03:38:07Z
Files modified:
	* src/main/conffile.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/d1e442601d80f7e87b362f980d9652a8fd46c267
====== 
Fix for coverity (fr_server_domain_socket should check is path is NULL)

Arran Cudbard-Bell at 2013-02-17T03:29:45Z
Files modified:
	* src/main/command.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/4c2df4e13d40fa90b03ed61aab44a8f15a95735e
====== 
-- 
This commit summary was generated @2013-02-18T00:00:02Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed).