Exec problems in FR3.0
Alan DeKok
aland at deployingradius.com
Thu Jun 13 19:02:12 CEST 2013
Phil Mayers wrote:
> Looks like this commit broke things:
>
> https://github.com/FreeRADIUS/freeradius-server/commit/4c3030db2743e682c58a0fba30b43d066f22beb0
Arg.
> What's the rational for rad_expand_xlat having "const" on the argv input
> argument? Doesn't seem useful.
It's a signal that the rad_expand_xlat() function doesn't muck with
argv. It's useful.
Maybe getting rid of argv_p, and changing it to:
argc = rad_expand_xlat(request, cmd, MAX_ARGV, (char const **) argv, 1,
sizeof(argv_buf), argv_buf);
?
Alan DeKok.
More information about the Freeradius-Devel
mailing list