Version 2.2.2 has been released

[Matthew Newton]

On Mon, Nov 04, 2013 at 01:33:36PM -0800, Alan DeKok wrote:
> Matthew Newton wrote:
> > In authenticate, they are all set to '1':
> > 
> >   https://github.com/FreeRADIUS/freeradius-server/blob/master/src/main/modcall.c#L1086-L1097
> 
>   For the modules in authenticate.  It's a little weird.
> 
>   The sub-sections of authenticate use the "authorize" priorities and codes.

OK thanks, that clarifies it. Weird gives me an excuse to be
confused :)

Out of interest, having just stared at that code, priority is set
to -1 on line 448:

https://github.com/FreeRADIUS/freeradius-server/blob/release_2_2_2/src/main/modcall.c#L448

and then not touched (apart from setting to -1 again on line 732)
until it is tested on line 806:

https://github.com/FreeRADIUS/freeradius-server/blob/release_2_2_2/src/main/modcall.c#L806

Is there any way that condition (priority <= 0) can ever be false?

It's subsequenty set to c->actions[result] on line 825, which is
then tested on line 832, but at 846 we jump back to 'redo', which
immediately sets it back to -1 again.

So the condition on 806 _looks_ redundant? It wasn't there in the
v2.2.0 test:

https://github.com/FreeRADIUS/freeradius-server/blob/release_2_2_0/src/main/modcall.c#L725

Matthew


-- 
Matthew Newton, Ph.D. <mcn4 at le.ac.uk>

Systems Specialist, Infrastructure Services,
I.T. Services, University of Leicester, Leicester LE1 7RH, United Kingdom

For IT help contact helpdesk extn. 2253, <ithelp at le.ac.uk>