Commit report for master branch

[Herwin Weststrate]

On 02-03-15 00:00, The git bot wrote:
> Encode / decode ethernet data types
> 
> Alan T. DeKok at 2015-03-01T15:59:36Z
> Files modified:
> 	* src/modules/proto_vmps/vqp.c
> 
> Commit diff:
> https://github.com/FreeRADIUS/freeradius-server/commit/c96776ddfb2baf57a50934097d34c7159ca5d2f1

I admit I've got no idea what vmps is, but the 4 in the memcpy feels wrong

+   case PW_TYPE_ETHERNET:
+     if (length != 6) goto unknown;
+
+     memcpy(&vp->vp_ether, ptr, 4);
+     vp->vp_length = 6;
+     break;

Especially when combined with this snippet later on

+   case PW_TYPE_ETHERNET:
+     memcpy(ptr, vp->vp_ether, vp->vp_length);



-- 
Herwin Weststrate