Commit report for master branch

Alan DeKok aland at deployingradius.com
Mon Mar 2 09:15:23 CET 2015


  That's a typo. I'll fix it. 

> On Mar 2, 2015, at 2:56 AM, Herwin Weststrate <herwin at quarantainenet.nl> wrote:
> 
>> On 02-03-15 00:00, The git bot wrote:
>> Encode / decode ethernet data types
>> 
>> Alan T. DeKok at 2015-03-01T15:59:36Z
>> Files modified:
>>    * src/modules/proto_vmps/vqp.c
>> 
>> Commit diff:
>> https://github.com/FreeRADIUS/freeradius-server/commit/c96776ddfb2baf57a50934097d34c7159ca5d2f1
> 
> I admit I've got no idea what vmps is, but the 4 in the memcpy feels wrong
> 
> +   case PW_TYPE_ETHERNET:
> +     if (length != 6) goto unknown;
> +
> +     memcpy(&vp->vp_ether, ptr, 4);
> +     vp->vp_length = 6;
> +     break;
> 
> Especially when combined with this snippet later on
> 
> +   case PW_TYPE_ETHERNET:
> +     memcpy(ptr, vp->vp_ether, vp->vp_length);
> 
> 
> 
> -- 
> Herwin Weststrate
> 
> -
> List info/subscribe/unsubscribe? See http://www.freeradius.org/list/devel.html



More information about the Freeradius-Devel mailing list