Commit report for v3.1.x branch - logrotate

[Matthew Newton]

On Thu, Sep 17, 2015 at 11:45:29PM +0100, Arran Cudbard-Bell wrote:
> > The right way is to move the logfile, then signal the daemon to
> > reopen its logfile, which is what the original version did.
> 
> Yes, but not signal it with -HUP.

Fair enough.

> > But the question really is how to signal. "killall -HUP radiusd"
> 
> You use the control socket.

That would work.

> Using HUP for reloading the config, and reopening log handles is
> idiotic in the extreme.  I have no idea why multiple daemons use
> this method, other than perhaps laziness, and the lack of
> another 'standardised' signal.

You're right. It should use -USR1 to reload the config, and -HUP
for reopening the log files ;-P

Is there a control socket command to do it - can't see one in
3.0.x? If so then radmin directly in the logrotate could work (if
permissions are OK). But would need control-socket enabling by
default, which it isn't at present.

Incidentally, "help hup" in radmin segfaults the server. Pull
request incoming.

Matthew


-- 
Matthew Newton, Ph.D. <mcn4 at le.ac.uk>

Systems Specialist, Infrastructure Services,
I.T. Services, University of Leicester, Leicester LE1 7RH, United Kingdom

For IT help contact helpdesk extn. 2253, <ithelp at le.ac.uk>