[master] function fr_dhcpv4_encode is badly broken

[Chaigneau, Nicolas]

It's still not working.
It seems hardware type and len are not set.

Here is the packet data:

0000   01 00 00 00 00 00 00 2a 00 00 00 00 00 00 00 00
0010   00 00 00 00 00 00 00 00 0a 0b 13 03 01 06 44 48
0020   42 66 00 5a 00 00 00 00 00 00 00 00 00 00 00 00
0030   00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0040   00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0050   00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0060   00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0070   00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0080   00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0090   00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
00a0   00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
00b0   00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
00c0   00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
00d0   00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
00e0   00 00 00 00 63 82 53 63 35 01 01 03 ff 00 00 00
00f0   00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0100   00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0110   00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0120   00 00 00 00 00 00 00 00 00 00 00 00


I have a .pcap file, if that can help ?
I'm looking at it with Wireshark, which shows the following:

Internet Protocol Version 4, Src: 10.11.19.3, Dst: 10.11.19.28
User Datagram Protocol, Src Port: 67, Dst Port: 67
Dynamic Host Configuration Protocol
    Message type: Boot Request (1)
    Hardware type: NET/ROM pseudo (0x00)
    Hardware address length: 0
    Hops: 0
    Transaction ID: 0x0000002a
    Seconds elapsed: 0
    Bootp flags: 0x0000 (Unicast)
    Client IP address: 0.0.0.0
    Your (client) IP address: 0.0.0.0
    Next server IP address: 0.0.0.0
    Relay agent IP address: 10.11.19.3
    Client address not given
    Server host name not given
    Boot file name not given
    Bootp vendor specific options: ff0000000000000000000000000000000000000000000000...



> > 
> > Likely since this commit:
> > https://github.com/FreeRADIUS/freeradius-server/commit/3f3afcee211407fb293186416241a149136a7464
>
>   I've pushed a fix for some things.  Turns out the encoder was wrong :(.   Our regression tests should have caught that.
>
>   It still prints out some attributes twice.  That isn't a huge problem, but it is confusing.
>
>   Alan DeKok.

This message contains information that may be privileged or confidential and is the property of the Capgemini Group. It is intended only for the person to whom it is addressed. If you are not the intended recipient, you are not authorized to read, print, retain, copy, disseminate, distribute, or use this message or any part thereof. If you receive this message in error, please notify the sender immediately and delete all copies of this message.