[master] function fr_dhcpv4_encode is badly broken

[Alan DeKok]

On Nov 6, 2020, at 1:32 PM, Chaigneau, Nicolas via Freeradius-Devel <freeradius-devel at lists.freeradius.org> wrote:
> It's still not working.
> It seems hardware type and len are not set.

  Yeah, I've fixed the encoder and added test cases so that this won't happen again.

Sending DHCP-Discover Id 0000002a from 10.11.19.3:67 to 10.11.19.28:67 length 300
	DHCP-Client-Hardware-Address = 44:48:42:66:00:5a
	DHCP-Transaction-Id = 42
	DHCP-Gateway-IP-Address = 10.11.19.3
	Packet-Src-Port = 67
	Packet-Src-IP-Address = 10.11.19.3
	DHCP-Message-Type := DHCP-Discover
	DHCP-Opcode = Client-Message
	DHCP-Hardware-Type = Ethernet
	DHCP-Hardware-Address-Length = 6
	DHCP-Hop-Count = 0
	DHCP-Transaction-Id = 42
	DHCP-Number-of-Seconds = 0
	DHCP-Flags = 0
	DHCP-Client-IP-Address = 0.0.0.0
	DHCP-Your-IP-Address = 0.0.0.0
	DHCP-Server-IP-Address = 0.0.0.0
	DHCP-Gateway-IP-Address = 10.11.19.3
	DHCP-Client-Hardware-Address = 44:48:42:66:00:5a
	DHCP-Message-Type = DHCP-Discover
	DHCP-Network-Subnet = 10.11.19.3/32

  and "dhcpclient -x ..." now prints this too:

	opcode: 01
	hwtype: 01
	hwaddrlen: 06
	hop_count: 00
	xid: 00 00 00 2a
	seconds: 00 00
	flags: 00 00
	ciaddr: 00 00 00 00
	yiaddr: 00 00 00 00
	siaddr: 00 00 00 00
	giaddr: 0a 0b 13 03
	chaddr: 44 48 42 66 00 5a 00 00 00 00 00 00 00 00 00 00
	server_hostname: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
		00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
		00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
		00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
	boot_filename: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
		00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
		00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
		00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
		00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
		00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
		00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
		00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
	magic:	63 82 53 63
	options
		35  01  01
		ff  00

  Alan DeKok.