rlm_sql.c in 2.0.0-pre2

[Arran Cudbard-Bell]

Alan DeKok wrote:
> Alexander Serkin wrote:
>> Hi,
>> Is the "read_groups" configuration paramter reading strings 
>> intentionally removed from rlm_sql.c? Why?
> 
>   I don't think it was ever added.  I'm not sure the functionality is
> even tested.
> 
>   i.e. Does it work?
> 
>   Alan DeKok.
> - 
> List info/subscribe/unsubscribe? See http://www.freeradius.org/list/users.html

Read Groups in SQL ? Yes, very very well tested. It's horribly broken in 
1.*.* though, or at least it was for me.

Unfortunately whoever modified rlm_sql in cvs head chose a very 
inefficient querying system.

First you query to pull out group membership, second you query to get 
each groups check items, then to get each groups reply items ... It just 
doesn't scale when a users a member of lots of groups.

Previously you pulled out all the records for all the groups a user was 
a member of in two queries, one for check items and one for reply items..

---

Still think it would be a nice idea to have the option to disable single 
user lookups, SQL queries really are very expensive .

-- 
Arran Cudbard-Bell (A.Cudbard-Bell at sussex.ac.uk)
Authentication, Authorisation and Accounting Officer
Infrastructure Services | ENG1 E1-1-08
University Of Sussex, Brighton
EXT:01273 873900 | INT: 3900