Trivial patch for rlm_acctlog in 2.0.5

Kostas Zorbadelos kzorba at
Tue Aug 12 14:02:10 CEST 2008

Hello to everyone.

As we are preparing for migration to 2.X version in some of our production 
systems, I took a closer look at the sources and found the rlm_acctlog module 
that allows for the logging of various types of accounting messages in the 
radius logs. Moreover I saw that syslog support in 2.X is vastly improved 
over 1.X series.

My minor request is, could you include the following patch in later releases 
(so as to not maintain it internally)?

--- rlm_acctlog.c.orig      2007-11-12 00:11:51.000000000 +0200
+++ rlm_acctlog.c       2008-08-08 13:54:34.000000000 +0300
@@ -79,7 +79,7 @@
        rlm_acctlog_t *inst;
        VALUE_PAIR *pair;

-       char    logstr[MAX_STRING_LEN];
+       char    logstr[1024];
        int     acctstatustype = 0;

The idea is to have a bigger buffer than 253 characters for logging. Some old 
syslog implementations can have a 1024 character limit I think, so I guess 
that would be enough :)

Thanks and keep up the good work.

Kostas Zorbadelos

More information about the Freeradius-Users mailing list