strange rlm_expiration behavior

[Flamur Rogova]

Nicolas Goutte wrote:
> Previous answers to questions about user expiration told to write dates 
> like
>     Expiration := "May 10 2008 21:00:00"
> 
> So in your case, you should perhaps try:
>     Expiration := "Jan 01 2009 00:00:00"
> 
> Have a nice day!
> 
> Am 01.10.2008 um 11:31 schrieb Flamur Rogova:
> 
>> Hi,
>> I am having strange behavior of rlm_expiration where it always returns 
>> "userlock", no matter what I put as expiration value.
>>
>> my radius install is latest from git repository, with default 
>> configuration (unchanged in any way),
>>
>> rlm_expiration rejects this user, date "10 Jan 2009", although it 
>> should be accepted...
>>
>> could somebody confirm working rlm_expiration on latest sources ?
>>
>>
>> home raddb # cat users
>> a       Cleartext-Password := a, Expiration := "10 Jan 2009"
>>         Reply-Message = "ok"
>>


Hi,
Nicolas, the date formats you specified is ok, but the one I used is ok 
too, so both "May 10 2008 21:00:00" and "May 10 2008" are valid formats.

On version 2.1.1, on users file rlm_expiration doesn't work. It gives 
userlock on any date value, even on invalid dates, unlike version 2.0.5 
which on invalid dates gives '...failed to parse time string "10 Jan abc"'

But I discovered that on rlm_sql I get correct behavior of expiration 
module, on the same radius version...

also, on the same machine, I have version 2.0.5 with working 
rlm_expiration module on both users file and sql

I have limited knowledge of C but I cant see any difference between 
2.0.5 and 2.1.1 versions of rlm_expiration.c

radius01 raddb # diff 
/home/sysadm/freeradius-server-2.0.5/src/modules/rlm_expiration/rlm_expiration.c 
/home/sysadm/freeradius-serve
r-2.1.1/src/modules/rlm_expiration/rlm_expiration.c
4c4
<  * Version:  $Id: rlm_expiration.c,v 1.16 2007/05/14 22:27:16 nbk Exp $
---
 >  * Version:  $Id$
25c25
< RCSID("$Id: rlm_expiration.c,v 1.16 2007/05/14 22:27:16 nbk Exp $")
---
 > RCSID("$Id$")
75c75
<               DEBUG("rlm_expiration: Checking Expiration time: 
'%s'",check_item->vp_strvalue);
---
 >               RDEBUG("Checking Expiration time: 
'%s'",check_item->vp_strvalue);
80c80
<                       DEBUG("rlm_expiration: Account has expired");
---
 >                       RDEBUG("Account has expired");


Has anybody seen similar behavior of rlm_expiration on v. 2.1.1 ?