default linelog Accounting-Request handling broken?

Josip Rodin joy at entuzijast.net
Sun Dec 6 18:01:16 CET 2009


On Wed, Nov 25, 2009 at 02:33:30AM +0100, Josip Rodin wrote:
> [myownlittle_linelog]       expand: %{%{Packet-Type}:-format} -> Accounting-Request
> [myownlittle_linelog] Entry ".Accounting-Request" is not a variable assignment 

Speaking of which, while browsing 558c51a711d7a326604eda0fc51040cbda2b77a8
I just noticed that it would be good for these error messages be elevated
so that users can see them outside of debug mode. Specifically:

RDEBUG2("Badly formatted variable: %s", *from);
RDEBUG2("Badly formatted variable: %s", p);
RDEBUG2("No trailing :- after variable at %s", p);
RDEBUG2("Invalid text after :- at %s", p);

Those should be error log, while:

RDEBUG2("Improperly nested variable; %%{%s}", p);
RDEBUG2("WARNING: Deprecated conditional expansion \":-\".  See \"man unlang\" for details");
RDEBUG2("WARNING: Unknown module \"%s\" in string expansion \"%%%s\"", xlat_name, *from);

Those looks like info messages.

-- 
     2. That which causes joy or happiness.



More information about the Freeradius-Users mailing list