default linelog Accounting-Request handling broken?

[Alan DeKok]

Josip Rodin wrote:
> Speaking of which, while browsing 558c51a711d7a326604eda0fc51040cbda2b77a8
> I just noticed that it would be good for these error messages be elevated
> so that users can see them outside of debug mode. Specifically:
> 
> RDEBUG2("Badly formatted variable: %s", *from);
> RDEBUG2("Badly formatted variable: %s", p);
> RDEBUG2("No trailing :- after variable at %s", p);
> RDEBUG2("Invalid text after :- at %s", p);
> 
> Those should be error log, while:
> 
> RDEBUG2("Improperly nested variable; %%{%s}", p);
> RDEBUG2("WARNING: Deprecated conditional expansion \":-\".  See \"man unlang\" for details");
> RDEBUG2("WARNING: Unknown module \"%s\" in string expansion \"%%%s\"", xlat_name, *from);
> 
> Those looks like info messages.

  Are you sure you want these messages for *every* packet?  Wouldn't it
be better to warn about mis-configurations in debug mode only?

  Alan DeKok.