too long Calling Station Ids

[Josip Rodin]

Hi,

Just ran across this IRL:

	Calling-Station-Id: GigabitEthernet 1/0/3.2045:2045#587202578###pppoe c0:d0:44:e4:cf:3b#

But:

Mon Nov 29 16:54:16 2010 : Error: [our_sql] Couldn't insert SQL accounting START record - ERROR:  value too long for type character varying(50)

The situation is actually a bit inconsistent:

raddb/sql/mssql/schema.sql:     [CallingStationId] [varchar] (30) DEFAULT ('') FOR [CallingStationId],
raddb/sql/mysql/schema.sql:  callingstationid varchar(50) NOT NULL default '',
raddb/sql/postgresql/schema.sql:        CallingStationId        VARCHAR(50),
raddb/sql/postgresql/schema.sql:        CallingStationId        VARCHAR(50),

Is there really much point in limiting this?
The specification seems to say it's a string of an arbitrary length...

-- 
     2. That which causes joy or happiness.