radsqlrelay: can't it just give up sometimes?

[Alan DeKok]

Stefan Winter wrote:
> I keep having issues now and then with radsqlrelay. Sometimes we get
> some accounting records which miss attributes or come with too
> unexpected values - the resulting SQL queries then sometimes are bogus.
> My last instance of this generated in radsqlrelay:
> 
> Incorrect integer value: '' for column 'AcctSessionTime' at row 1
>
> radsqlrelay keeps being excited over the query in question *forever* and
> retries to eternity.

  The solution is to fix radsqlrelay.  It should treat fail differently
from "sql down".  The failed queries can get written to a different log
file.

> Can't radqlrelay be a bit more clever about this, like try three times,
> and if the query is consistently rejected, save it to a ".reject" file
> and move on?

  <cough>  Patch?

  It shouldn't be hard.  The main difficulty is figuring out the return
code from $dbinfo->{handle}->do($query).  It's possible, I just haven't
looked.

  Alan DeKok.