rlm_sql_null holding locks and hanging radsqlrelay.

[Matthew Schumacher]

On 11/14/19 4:58 PM, Matthew Newton wrote:
> On Thu, 2019-11-14 at 14:45 -0800, Matthew Schumacher wrote:
>> Last year you directed me to patch rad_unlockfd() to use F_UNLCK
>> instead
>> of F_WRLCK.  I did that and things have been stable, but while
>> building
>> the latest patches for 3.0.20 I noticed that the 3.0.x branch still
>> uses
>> F_WRLCK.
> What makes you think that?
>
> https://github.com/FreeRADIUS/freeradius-server/blob/v3.0.x/src/lib/misc.c#L811
>
Oh, I see what the problem is, my patch worked with offset so I assumed 
the code wasn't changed:

patching file src/lib/misc.c
Hunk #1 succeeded at 783 (offset -7 lines).

But patch got confused and changed rad_lockfd_nonblock().

Thanks for responding.