Exec module questions, v4

[FRANKS, Andy (SHREWSBURY AND TELFORD HOSPITAL NHS TRUST)]

Thanks very much for the fixes, appreciated.

Noted re the long-lived running script. I was probably a bit ambiguous in the last email ; the timeout was introduced by compiling libkqueue to try and get around the exec race condition talked about, rather than using the built-in libkqueue* packages.
The built-in ones execute quickly but don't always report output / exit codes, but with the source-built libkqueue it just doesn't finish execution, timing out. Not a fault of Freeradius.

Thank you again
Andy

-----Original Message-----
From: Alan DeKok <aland at deployingradius.com>
Sent: 04 August 2020 13:19
To: FreeRadius users mailing list <freeradius-users at lists.freeradius.org>
Cc: FRANKS, Andy (SHREWSBURY AND TELFORD HOSPITAL NHS TRUST) <andy.franks1 at nhs.net>
Subject: Re: Exec module questions, v4

On Aug 4, 2020, at 6:15 AM, FRANKS, Andy (SHREWSBURY AND TELFORD HOSPITAL NHS TRUST) via Freeradius-Users <freeradius-users at lists.freeradius.org> wrote:
>  Thanks for the update to the program last week, just testing here.
> It seems to be taking the return code (when available) as multiple of 256 of the actual exit code, unless 0 now:

  OK.  I've pushed a fix.

> Another kqueue issue?
>
> I did try libkqueue 2.4.0 , compiled from the github repo, but I guess it's in test, as it never exits, then freeradius crashes.. just in case of interest, please ignore if not;

  An assert is not a crash.  It's a positive signal that the server caught something wrong, and died rather than running in an unknown state.

> (0)    ERROR: Timeout running program - killing it and failing the request
> (0)    Running request
> (0)    tmpl - Resuming execution
> ASSERT FAILED src/lib/unlang/tmpl.c[316]: state->pid > 0

  I've pushed a fix for that, too.

  But to be honest, you really shouldn't be running a long-lived radclient program from `exec`.  See raddb/mods-available/radius.  The server supports sending RADIUS packets natively, as with v3.

  Alan DeKok.




********************************************************************************************************************

This message may contain confidential information. If you are not the intended recipient please inform the
sender that you have received the message in error before deleting it.
Please do not disclose, copy or distribute information in this e-mail or take any action in relation to its contents. To do so is strictly prohibited and may be unlawful. Thank you for your co-operation.

NHSmail is the secure email and directory service available for all NHS staff in England and Scotland. NHSmail is approved for exchanging patient data and other sensitive information with NHSmail and other accredited email services.

For more information and to find out how you can switch, https://portal.nhs.net/help/joiningnhsmail