DHCP server crashed when receiving unknown option in Request

[Alan DeKok]

On Jun 30, 2020, at 3:48 AM, Chinnapaiyan, Nagamani <Nagamani.Chinnapaiyan at viasat.com> wrote:
> 
> Hi,
> 
> We encountered a radiusd crash, when it received unknown option-145 in the Request packet(which is not defined in dictionary). Expected behavior is to ignore any unknown options and continue processing the packet.
> Also please ensure(from code) radiusd is not crashing if the some known options are malformed in an incoming packet. Expected behavior is to ignore the packet and continue running.

  We do know that.  We have literally hundreds of tests for this, and other circumstances.

> (1470)  Tue Jun 30 06:21:11 2020 : Debug :   perl - &request:DHCP-V-I-Vendor-Class = $RAD_REQUEST{'DHCP-V-I-Vendor-Class'} -> ''
> 
> CONSISTENCY CHECK FAILED src/lib/util/pair.c[883]: VALUE_PAIR (raw/unknown) attribute 0x314a3a0 "Attr-145" data type incorrect.  Expected octets, got <INVALID>
> 
> ASSERT FAILED src/lib/util/pair.c[3050]: 0

  The current "master" branch has no such messages at line 883 or 3050.  Please ensure that you're running the latest branch.  The code in "master" changes a lot.  So it's not productive for us to track down issues which may have already been fixed months ago.

  Alan DeKok.