WiMAX style continuation field used by other vendor

[Alan DeKok]

On Apr 26, 2021, at 9:29 AM, Benjamin Thompson <b.thompson at latera.ru> wrote:
> I am working with some Telrad equipment and have found that it uses
> attributes with vendor ID 5323 and which have the continuation field
> (format=1,1,c) as used in WiMAX attributes.

  OMG what a terrible idea.  This is one of the worst things I've seen in years.

> I tried to add a dictionary with this format string but FreeRADIUS refused
> to start with the error "Only WiMAX VSAs can have continuations".

  Yes.  The source is hard-coded to use the WiMAX vendor ID.

> I traced the error to this section of code (dict.c line 2097):
> 
> if ((*pvalue != VENDORPEC_WIMAX) ||
>    (type != 1) || (length != 1)) {
>    fr_strerror_printf("dict_init: %s[%d]: Only WiMAX VSAs can have
> continuations",
>                               fn, line);
>    return -1;
> }

  There's a lot more to it than that.  See src/lib/radius.c, and look for WiMAX.

> I would like to ask whether it would be OK to allow continuations for other
> vendors too here (I am happy to submit a patch).

  Sure.

  Do you have dictionary file that you can share?

  Alan DeKok.