On 14 Mar 2014, at 14:37, Chaigneau, Nicolas <nicolas.chaigneau@capgemini.com> wrote:
Here it is (see attached file "rlm_perl.c").
A few notes:
- I put "//NCH:" markers to identify parts of the code I changed.
- I didn't bother xlat'ing eventual ${} in "perl_conf" items (didn't need it), but maybe it could be useful.
- I used a "hack" in my struct perl_conf_t: the first item is a pointer to the struct itself. (this allowed me to get around the bug I found in hash.c. This won't be needed anymore now it's fixed. Anyway, the code works with or without the hash fix)
- I didn't free memory in mod_detach, this should be done... not critical though, since the perl module is not "RLM_TYPE_HUP_SAFE".
Thanks for looking. I'm interested if you see anything wrong.
Well you've pretty much guaranteed that this isn't going to get merged by your method of submission. If someone cares enough they can send a pull request. Arran Cudbard-Bell <a.cudbardb@freeradius.org> FreeRADIUS Development Team FD31 3077 42EC 7FCD 32FE 5EE2 56CF 27F9 30A8 CAA2