On Wednesday 16 August 2006 18:09, Alex French wrote:
Boina,
That works fine for me (patching against a clean 1.1.2 tree) I've only tested == and := operators but they seem fine.
Only one point to note; if you do not include an element in the hash with the same name as the attribute ( e.g. due to a typo or just a misconfiguration), the server hangs completely the first time something gets passed through the perl module and needs a kill -9 to stop it. I know you can't protect people against their own configuration errors, but perhaps it would be nicer to log an error (or just ignore the attribute).
Thanks for suggestion i will correct this matter.
Anyway, thanks very much for the patch!
Thanks,
On 15/08/06, Boian Jordanov <bjordanov@orbitel.bg> wrote:
On Monday 14 August 2006 21:27, Alex French wrote:
Boian,
Thanks, if you have a patch that actually implements the hash for the operator etc, that would be great (in fact, why not just submit it as a feature). If it's just to change the operator hardcoded in rlm_perl.c, that's fine, I have that recompiled and installed at the moment,
Yep, i have the patch that implements the operator with hash ref. Test it and if you like it i will submit it in CVS HEAD.
For example to change Operator for Framed-MTU
$hash{'Framed-MTU'} = "100"; $hash{'Operator'} = "=="; $RAD_REPLY{'Framed-MTU'} = \%hash;
-- Best Regards, Boian Jordanov SNE Orbitel - Next Generation Telecom tel. +359 2 4004 723 tel. +359 2 4004 002
- List info/subscribe/unsubscribe? See http://www.freeradius.org/list/users.html
-- Best Regards, Boian Jordanov SNE Orbitel - Next Generation Telecom tel. +359 2 4004 723 tel. +359 2 4004 002