16 Nov
2012
16 Nov
'12
11:14 a.m.
Edgar Fuß wrote:
Digging through the rlm_perl source, I stumbled over the following:
1. Is it on purpose that it normally checks USE_ITHREADS and only perl_xlat checks WITH_ITHREADS?
No. It should be fixed.
2. Is it also on purpose that radiusd::radog is newXS'd only after perl_parse()?
No idea.
That hit me because as it is, you can't log anything (like a version number) inside the script's body/main program (or call it initialization routine).
Well, patches are welcome.
3. I also noticed that tests like #if PERL_REVISION >= 5 && PERL_VERSION <8 would trigger for 6.0 if that is ever going to happen.
Sure. Send a patch. Alan DeKok.