Ah, great Alan, thanks for the update. I'll maybe have a look into running it a different way, maybe through python or similar for the time being, possibly that's what people more typically do with CoA logoff requests. Happy to also try any libkqueue patches, if that can be compiled separately. I've submitted a separate crash report about a loop on github, but I might be able to work around it too, not the right place to discuss here. Kind regards Andy -----Original Message----- From: Freeradius-Users <freeradius-users-bounces+andy.franks1=nhs.net@lists.freeradius.org> On Behalf Of Alan DeKok Sent: 31 July 2020 14:15 To: FreeRadius users mailing list <freeradius-users@lists.freeradius.org> Subject: Re: Exec module questions, v4 On Jul 31, 2020, at 9:00 AM, FRANKS, Andy (SHREWSBURY AND TELFORD HOSPITAL NHS TRUST) via Freeradius-Users <freeradius-users@lists.freeradius.org> wrote:
Does the exec module in v4 still support "non-xlat" use, i.e. where you stipulate a program, run it, maybe collect output pairs values?
It should. The main issue is that we're using libkqueue for our event library. And llibkqueue doesn't have good support for handling child processes. We have patches for it, but they need to be integrated back into the main libkqueue distribution.
Some observations
- The stdout output "pickup" didn't seem to be consistent, here I've used radtest to fire a test auth twice in a row without changing anything (let me know if you'd like to see the complete output)
Yes. There are race conditions using libkqueue. So the result from the child is sometimes picked up, and sometimes not. :( We're working on fixing it.
- Also, the module return code isn't the same as it used to be, i.e. where 0 was ok, 1 was reject, 2 fail, as per https://networkradius.com/doc/3.0.10/raddb/mods-available/exec.html
Ah yes... I'll push a fix.
We used to rely on the text output, even if the exit code was non zero, and that exit code value to do some more stuff after a CoA request.
It should still get the text output when the exit code is >= 0
I should try modifying my unlang to do some xlats instead, but thought I'd ask first - is it just me - do I not understand deliberate changes that have taken place?
It should behave largely the same as v3. Alan DeKok. - List info/subscribe/unsubscribe? See http://www.freeradius.org/list/users.html ******************************************************************************************************************** This message may contain confidential information. If you are not the intended recipient please inform the sender that you have received the message in error before deleting it. Please do not disclose, copy or distribute information in this e-mail or take any action in relation to its contents. To do so is strictly prohibited and may be unlawful. Thank you for your co-operation. NHSmail is the secure email and directory service available for all NHS staff in England and Scotland. NHSmail is approved for exchanging patient data and other sensitive information with NHSmail and other accredited email services. For more information and to find out how you can switch, https://portal.nhs.net/help/joiningnhsmail