October 2005 - Freeradius-Devel - lists.freeradius.org

Automatic report from sources (radiusd) between 07.10.2005 - 08.10.2005 GMT
by Automatic cvs log generator 08 Oct '05

08 Oct '05

CVS log entries from 07.10.2005 (Fri) 08:00:01 - 08.10.2005 (Sat) 08:00:00 GMT ===================================================== Summary by authors ===================================================== Author: aland File: radiusd/src/modules/rlm_eap/types/rlm_eap_psk/eap_psk.h; Revisions: 1.1 File: radiusd/configure.in; Revisions: 1.221 File: radiusd/src/modules/rlm_eap/types/rlm_eap_psk/CTR.cpp; Revisions: 1.1 File: radiusd/src/modules/rlm_eap/types/rlm_eap_psk/userinfo.c; Revisions: 1.1 File: radiusd/src/modules/rlm_eap/types/rlm_eap_psk/BlockCipher.h; Revisions: 1.1 File: radiusd/src/main/listen.c; Revisions: 1.38 File: radiusd/src/modules/rlm_eap/types/rlm_eap_psk/rlm_eap_psk.cpp; Revisions: 1.1 File: radiusd/src/modules/rlm_eap/types/rlm_eap_psk/SOBMMO.cpp; Revisions: 1.1 File: radiusd/src/modules/rlm_eap/types/rlm_eap_psk/CTR.h; Revisions: 1.1 File: radiusd/src/modules/rlm_eap/types/rlm_eap_psk/userinfo.h; Revisions: 1.1 File: radiusd/src/modules/rlm_eap/types/rlm_eap_psk/SOBMMO.h; Revisions: 1.1 File: radiusd/src/modules/rules.mak; Revisions: 1.57 File: radiusd/src/modules/rlm_eap/types/rlm_eap_psk/Makefile.in; Revisions: 1.1 File: radiusd/src/modules/rlm_eap/types/rlm_eap_psk/eap_psk_ssm.cpp; Revisions: 1.1 File: radiusd/src/modules/rlm_eap/types/rlm_eap_psk/AES.cpp; Revisions: 1.1 File: radiusd/src/modules/rlm_eap/types/rlm_eap_psk/eap_psk_ssm.h; Revisions: 1.1 File: radiusd/src/modules/rlm_eap/types/rlm_eap_psk/users.psk; Revisions: 1.1 File: radiusd/src/modules/rlm_eap/types/rlm_eap_psk/EAX.cpp; Revisions: 1.1 File: radiusd/src/modules/rlm_eap/types/rlm_eap_psk/AES.h; Revisions: 1.1 File: radiusd/src/modules/rlm_eap/types/rlm_eap_psk/OMAC.cpp; Revisions: 1.1 File: radiusd/src/modules/rlm_eap/types/rlm_eap_psk/EAX.h; Revisions: 1.1 File: radiusd/src/modules/rlm_eap/types/rlm_eap_psk/eap_psk.cpp; Revisions: 1.1 File: radiusd/src/modules/rlm_eap/types/rlm_eap_psk/OMAC.h; Revisions: 1.1 ===================================================== Combined list of identical log entries ===================================================== Description: Foundational work for building C++ modules. The header files need to be fixed, however. Modified files: File: radiusd/configure.in; Revision: 1.221; Date: 2005/10/07 23:54:53; Author: aland; Lines: (+2 -1) File: radiusd/src/modules/rules.mak; Revision: 1.57; Date: 2005/10/07 23:54:54; Author: aland; Lines: (+9 -1) ------------------------------- Description: Added EAP-PSK from: http://perso.rd.francetelecom.fr/bersani/EAP_PSK/EAP-PSKWindowsimplementati… It's GPL licensed. Changes from that library: - removed HORRID #include ....../rlm_ldap/rlm_ldap.c WTF? - minor updates for vp_strvalue - move Makefile to Makefile.in, because without other changes to the server to make headers build with C++, this won't build. Untested... use at your own risk! Modified files: File: radiusd/src/modules/rlm_eap/types/rlm_eap_psk/AES.cpp; Revision: 1.1; Date: 2005/10/07 23:51:11; Author: aland; File: radiusd/src/modules/rlm_eap/types/rlm_eap_psk/AES.h; Revision: 1.1; Date: 2005/10/07 23:51:11; Author: aland; File: radiusd/src/modules/rlm_eap/types/rlm_eap_psk/BlockCipher.h; Revision: 1.1; Date: 2005/10/07 23:51:11; Author: aland; File: radiusd/src/modules/rlm_eap/types/rlm_eap_psk/CTR.cpp; Revision: 1.1; Date: 2005/10/07 23:51:11; Author: aland; File: radiusd/src/modules/rlm_eap/types/rlm_eap_psk/CTR.h; Revision: 1.1; Date: 2005/10/07 23:51:11; Author: aland; File: radiusd/src/modules/rlm_eap/types/rlm_eap_psk/EAX.cpp; Revision: 1.1; Date: 2005/10/07 23:51:11; Author: aland; File: radiusd/src/modules/rlm_eap/types/rlm_eap_psk/EAX.h; Revision: 1.1; Date: 2005/10/07 23:51:11; Author: aland; File: radiusd/src/modules/rlm_eap/types/rlm_eap_psk/Makefile.in; Revision: 1.1; Date: 2005/10/07 23:51:12; Author: aland; File: radiusd/src/modules/rlm_eap/types/rlm_eap_psk/OMAC.cpp; Revision: 1.1; Date: 2005/10/07 23:51:12; Author: aland; File: radiusd/src/modules/rlm_eap/types/rlm_eap_psk/OMAC.h; Revision: 1.1; Date: 2005/10/07 23:51:12; Author: aland; File: radiusd/src/modules/rlm_eap/types/rlm_eap_psk/SOBMMO.cpp; Revision: 1.1; Date: 2005/10/07 23:51:12; Author: aland; File: radiusd/src/modules/rlm_eap/types/rlm_eap_psk/SOBMMO.h; Revision: 1.1; Date: 2005/10/07 23:51:12; Author: aland; File: radiusd/src/modules/rlm_eap/types/rlm_eap_psk/eap_psk.cpp; Revision: 1.1; Date: 2005/10/07 23:51:12; Author: aland; File: radiusd/src/modules/rlm_eap/types/rlm_eap_psk/eap_psk.h; Revision: 1.1; Date: 2005/10/07 23:51:12; Author: aland; File: radiusd/src/modules/rlm_eap/types/rlm_eap_psk/eap_psk_ssm.cpp; Revision: 1.1; Date: 2005/10/07 23:51:12; Author: aland; File: radiusd/src/modules/rlm_eap/types/rlm_eap_psk/eap_psk_ssm.h; Revision: 1.1; Date: 2005/10/07 23:51:12; Author: aland; File: radiusd/src/modules/rlm_eap/types/rlm_eap_psk/rlm_eap_psk.cpp; Revision: 1.1; Date: 2005/10/07 23:51:13; Author: aland; File: radiusd/src/modules/rlm_eap/types/rlm_eap_psk/userinfo.c; Revision: 1.1; Date: 2005/10/07 23:51:13; Author: aland; File: radiusd/src/modules/rlm_eap/types/rlm_eap_psk/userinfo.h; Revision: 1.1; Date: 2005/10/07 23:51:13; Author: aland; File: radiusd/src/modules/rlm_eap/types/rlm_eap_psk/users.psk; Revision: 1.1; Date: 2005/10/07 23:51:13; Author: aland; ===================================================== Log entries ===================================================== Description: Don't set things twice Modified files: File: radiusd/src/main/listen.c; Revision: 1.38; Date: 2005/10/07 21:37:49; Author: aland; Lines: (+1 -7) ===================================================== Summary of modified files ===================================================== File: radiusd/configure.in Revisions: 1.221 Authors: aland (+2 -1) ------------------------------- File: radiusd/src/main/listen.c Revisions: 1.38 Authors: aland (+1 -7) ------------------------------- File: radiusd/src/modules/rlm_eap/types/rlm_eap_psk/AES.cpp Revisions: 1.1 Authors: aland ------------------------------- File: radiusd/src/modules/rlm_eap/types/rlm_eap_psk/AES.h Revisions: 1.1 Authors: aland ------------------------------- File: radiusd/src/modules/rlm_eap/types/rlm_eap_psk/BlockCipher.h Revisions: 1.1 Authors: aland ------------------------------- File: radiusd/src/modules/rlm_eap/types/rlm_eap_psk/CTR.cpp Revisions: 1.1 Authors: aland ------------------------------- File: radiusd/src/modules/rlm_eap/types/rlm_eap_psk/CTR.h Revisions: 1.1 Authors: aland ------------------------------- File: radiusd/src/modules/rlm_eap/types/rlm_eap_psk/EAX.cpp Revisions: 1.1 Authors: aland ------------------------------- File: radiusd/src/modules/rlm_eap/types/rlm_eap_psk/EAX.h Revisions: 1.1 Authors: aland ------------------------------- File: radiusd/src/modules/rlm_eap/types/rlm_eap_psk/Makefile.in Revisions: 1.1 Authors: aland ------------------------------- File: radiusd/src/modules/rlm_eap/types/rlm_eap_psk/OMAC.cpp Revisions: 1.1 Authors: aland ------------------------------- File: radiusd/src/modules/rlm_eap/types/rlm_eap_psk/OMAC.h Revisions: 1.1 Authors: aland ------------------------------- File: radiusd/src/modules/rlm_eap/types/rlm_eap_psk/SOBMMO.cpp Revisions: 1.1 Authors: aland ------------------------------- File: radiusd/src/modules/rlm_eap/types/rlm_eap_psk/SOBMMO.h Revisions: 1.1 Authors: aland ------------------------------- File: radiusd/src/modules/rlm_eap/types/rlm_eap_psk/eap_psk.cpp Revisions: 1.1 Authors: aland ------------------------------- File: radiusd/src/modules/rlm_eap/types/rlm_eap_psk/eap_psk.h Revisions: 1.1 Authors: aland ------------------------------- File: radiusd/src/modules/rlm_eap/types/rlm_eap_psk/eap_psk_ssm.cpp Revisions: 1.1 Authors: aland ------------------------------- File: radiusd/src/modules/rlm_eap/types/rlm_eap_psk/eap_psk_ssm.h Revisions: 1.1 Authors: aland ------------------------------- File: radiusd/src/modules/rlm_eap/types/rlm_eap_psk/rlm_eap_psk.cpp Revisions: 1.1 Authors: aland ------------------------------- File: radiusd/src/modules/rlm_eap/types/rlm_eap_psk/userinfo.c Revisions: 1.1 Authors: aland ------------------------------- File: radiusd/src/modules/rlm_eap/types/rlm_eap_psk/userinfo.h Revisions: 1.1 Authors: aland ------------------------------- File: radiusd/src/modules/rlm_eap/types/rlm_eap_psk/users.psk Revisions: 1.1 Authors: aland ------------------------------- File: radiusd/src/modules/rules.mak Revisions: 1.57 Authors: aland (+9 -1) -- Automatic cron job from /web/pages/us.freeradius.org/bin/new_makelog.pl

1 0

proxy_outstanding
by Joe Maimon 07 Oct '05

07 Oct '05

Is only ever set to 1 from what I can grep of the code. So when listen.c calls /* * Find the original request in the request list */ oldreq = rl_find_proxy(packet); which in turn executes node = rbtree_find(proxy_tree, &myrequest); if (node) { maybe = rbtree_node2data(proxy_tree, node); rad_assert(maybe->proxy_outstanding > 0); maybe->proxy_outstanding--; /* * Received all of the replies we expect. * delete it from both trees. */ if (maybe->proxy_outstanding == 0) { rl_delete_proxy(&myrequest, node); } } pthread_mutex_unlock(&proxy_mutex); return maybe; How can it be possible (what parts of the code have I not paid sufficient attention to) for this to happen in listen.c ? /* * If there is already a reply, maybe this one is a * duplicate? */ if (oldreq->proxy_reply) { if (memcmp(oldreq->proxy_reply->vector, packet->vector, sizeof(oldreq->proxy_reply->vector)) == 0) { radlog(L_ERR, "Discarding duplicate reply from home server %s port %d - ID: %d for request %d", inet_ntop(packet->src_ipaddr.af,

3 5

Automatic report from sources (radiusd) between 06.10.2005 - 07.10.2005 GMT
by Automatic cvs log generator 07 Oct '05

07 Oct '05

CVS log entries from 06.10.2005 (Thu) 08:00:01 - 07.10.2005 (Fri) 08:00:01 GMT ===================================================== Summary by authors ===================================================== Author: aland File: radiusd/src/lib/valuepair.c; Revisions: 1.98 Author: fcusack File: radiusd/src/modules/rlm_otp/otp_cardops.c; Revisions: 1.39 Author: pnixon File: radiusd/doc/configurable_failover; Revisions: 1.9 File: radiusd/doc/load-balance.txt; Revisions: 1.4 File: radiusd/doc/proxy; Revisions: 1.8 File: radiusd/doc/rlm_dbm; Revisions: 1.3 ===================================================== Combined list of identical log entries ===================================================== Description: spelling fixes Modified files: File: radiusd/doc/configurable_failover; Revision: 1.9; Date: 2005/10/06 16:24:33; Author: pnixon; Lines: (+3 -3) File: radiusd/doc/load-balance.txt; Revision: 1.4; Date: 2005/10/06 16:24:33; Author: pnixon; Lines: (+2 -2) File: radiusd/doc/proxy; Revision: 1.8; Date: 2005/10/06 17:36:50; Author: pnixon; Lines: (+4 -4) ===================================================== Log entries ===================================================== Description: spelling fix Modified files: File: radiusd/doc/rlm_dbm; Revision: 1.3; Date: 2005/10/06 17:44:23; Author: pnixon; Lines: (+2 -2) ------------------------------- Description: Handle regex comparisons. Patch from Joe Maimon Modified files: File: radiusd/src/lib/valuepair.c; Revision: 1.98; Date: 2005/10/06 17:31:56; Author: aland; Lines: (+10 -2) ------------------------------- Description: fix unsigned vs signed comparison Modified files: File: radiusd/src/modules/rlm_otp/otp_cardops.c; Revision: 1.39; Date: 2005/10/07 06:11:00; Author: fcusack; Lines: (+6 -6) ===================================================== Summary of modified files ===================================================== File: radiusd/doc/configurable_failover Revisions: 1.9 Authors: pnixon (+3 -3) ------------------------------- File: radiusd/doc/load-balance.txt Revisions: 1.4 Authors: pnixon (+2 -2) ------------------------------- File: radiusd/doc/proxy Revisions: 1.8 Authors: pnixon (+4 -4) ------------------------------- File: radiusd/doc/rlm_dbm Revisions: 1.3 Authors: pnixon (+2 -2) ------------------------------- File: radiusd/src/lib/valuepair.c Revisions: 1.98 Authors: aland (+10 -2) ------------------------------- File: radiusd/src/modules/rlm_otp/otp_cardops.c Revisions: 1.39 Authors: fcusack (+6 -6) -- Automatic cron job from /web/pages/us.freeradius.org/bin/new_makelog.pl

1 0

Re: sql_ippool module with two databases
by Ruslan A Dautkhanov 07 Oct '05

07 Oct '05

Hello Stylianos Stylianou wrote: > Hi, > > > > I have compiled freeradius-1.0.5 in Redhat Enterprise Linux 4 with > your module and it works without any problem with mysql 4.X database. > > > > I have only one problem to solve. I am trying to add two > sql-instance-name in file sqlippool.sqls so that there is a redundancy > in the module. > > In the radius.conf file I manage to do this with the following: > > > > group { > > sql_1 { > > fail = 1 > > notfound = return > > noop = 2 > > ok = return > > updated = 3 > > reject = return > > userlock = 4 > > invalid = 5 > > handled = 6 > > } > > sql_2 { > > fail = 1 > > notfound = return > > noop = 2 > > ok = return > > updated = 3 > > reject = return > > userlock = 4 > > invalid = 5 > > handled = 6 > > } > > } > > > > So, if sql_1 server goes down, the authentication and accounting is > going to be ok since radius is going to use sql_2 server, but the > allocation of ips not. > > > > Is there a way to "tell" the module to use two sql servers, the one > redundant to the other? > > > Current revision of sqlippool can't make this functionality, as I know. To be sure ask for it at freeradius-devel(a)lists.freeradius.org . If it's really not possible, then only one solution possible - search for utilities for your RDBMS, which can make redundancy. I know it's possible in PostgreSQL, but I havn't any experience with MySQL. -- best regards, Ruslan A Dautkhanov rusland(a)scn.ru

1 0

fixing regex for PW_TYPE_IPADDR
by Joe Maimon 06 Oct '05

06 Oct '05

Apparently without this pairmake() in src/lib/valuepair.c will cause to be ignored a/v with regex ops that look like incomplete ip addresses. diff -u ../../../../cvs/cvs-20050929/radiusd/src/lib/valuepair.c valuepair.c --- ../../../../cvs/cvs-20050929/radiusd/src/lib/valuepair.c 2005-09-13 21:03:06.000000000 -0400 +++ valuepair.c 2005-10-03 07:44:05.000000000 -0400 @@ -723,6 +723,11 @@ break; case PW_TYPE_IPADDR: + /* jm hack*/ + if (vp->operator == T_OP_REG_EQ || + vp->operator == T_OP_REG_NE) + break; + /* * FIXME: complain if hostname * cannot be resolved, or resolve later!

2 1

Adding strlcpy and strlcat replacements to libradius
by Nicolas Baradakis 06 Oct '05

06 Oct '05

I think we may perhaps add an autoconf test to detect whether the system provides the srtlcpy and strlcat functions from OpenBSD. If they're not present, we'd compile a replacement in libradius. These functions provide a consistent, unambiguous API described in this paper: http://www.usenix.org/events/usenix99/full_papers/millert/millert_html/inde… I know that our home-made strNcpy already ensures NUL-terminaison, but it has some weakness: - it seems it's wrong when N <= 0 - it's not easy to check if truncation has occurred I don't plan to change the code everywhere, but I'd like to have the functions available when writing new code. If I get approbation, I suggest to bring the following files in libradius. As to my understanding their licence allows us to do that: ftp://ftp.openbsd.org/pub/OpenBSD/src/lib/libc/string/strlcpy.c ftp://ftp.openbsd.org/pub/OpenBSD/src/lib/libc/string/strlcat.c -- Nicolas Baradakis

6 14

Automatic report from sources (radiusd) between 05.10.2005 - 06.10.2005 GMT
by Automatic cvs log generator 06 Oct '05

06 Oct '05

CVS log entries from 05.10.2005 (Wed) 08:00:01 - 06.10.2005 (Thu) 08:00:01 GMT ===================================================== Summary by authors ===================================================== Author: fcusack File: radiusd/src/modules/rlm_otp/cardops/cryptocard.h; Revisions: 1.20, 1.19 File: radiusd/src/modules/rlm_otp/otp_cardops.h; Revisions: 1.22, 1.21 File: radiusd/src/modules/rlm_otp/cardops/cryptocard.c; Revisions: 1.20, 1.19 File: radiusd/src/modules/rlm_otp/otp_cardops.c; Revisions: 1.38, 1.37 Author: nbk File: radiusd/src/include/md4.h; Revisions: 1.10 File: radiusd/src/include/md5.h; Revisions: 1.15 File: radiusd/src/include/libradius.h; Revisions: 1.106 ===================================================== Combined list of identical log entries ===================================================== Description: add maxtwin() cardops method to allow dynamic twin setting Modified files: File: radiusd/src/modules/rlm_otp/otp_cardops.c; Revision: 1.38; Date: 2005/10/05 22:40:33; Author: fcusack; Lines: (+5 -4) File: radiusd/src/modules/rlm_otp/otp_cardops.h; Revision: 1.22; Date: 2005/10/05 22:40:33; Author: fcusack; Lines: (+3 -1) File: radiusd/src/modules/rlm_otp/cardops/cryptocard.c; Revision: 1.20; Date: 2005/10/05 22:40:33; Author: fcusack; Lines: (+22 -1) File: radiusd/src/modules/rlm_otp/cardops/cryptocard.h; Revision: 1.20; Date: 2005/10/05 22:40:33; Author: fcusack; Lines: (+3 -1) ------------------------------- Description: pass 'when' and 'twin' to updatecsd(), so that time sync cards can calculate drift Modified files: File: radiusd/src/modules/rlm_otp/otp_cardops.c; Revision: 1.37; Date: 2005/10/05 22:16:50; Author: fcusack; Lines: (+4 -4) File: radiusd/src/modules/rlm_otp/otp_cardops.h; Revision: 1.21; Date: 2005/10/05 22:16:51; Author: fcusack; Lines: (+3 -2) File: radiusd/src/modules/rlm_otp/cardops/cryptocard.c; Revision: 1.19; Date: 2005/10/05 22:16:51; Author: fcusack; Lines: (+9 -1) File: radiusd/src/modules/rlm_otp/cardops/cryptocard.h; Revision: 1.19; Date: 2005/10/05 22:16:51; Author: fcusack; Lines: (+2 -2) ------------------------------- Description: Delete #include "autoconf.h" from other header files. It's annoying for the people who want to use the libradius in an external program. Modified files: File: radiusd/src/include/libradius.h; Revision: 1.106; Date: 2005/10/05 10:17:50; Author: nbk; Lines: (+1 -2) File: radiusd/src/include/md4.h; Revision: 1.10; Date: 2005/10/05 10:17:50; Author: nbk; Lines: (+1 -4) File: radiusd/src/include/md5.h; Revision: 1.15; Date: 2005/10/05 10:17:50; Author: nbk; Lines: (+1 -3) ===================================================== Log entries ===================================================== ===================================================== Summary of modified files ===================================================== File: radiusd/src/include/libradius.h Revisions: 1.106 Authors: nbk (+1 -2) ------------------------------- File: radiusd/src/include/md4.h Revisions: 1.10 Authors: nbk (+1 -4) ------------------------------- File: radiusd/src/include/md5.h Revisions: 1.15 Authors: nbk (+1 -3) ------------------------------- File: radiusd/src/modules/rlm_otp/cardops/cryptocard.c Revisions: 1.20, 1.19 Authors: fcusack (+22 -1), fcusack (+9 -1) ------------------------------- File: radiusd/src/modules/rlm_otp/cardops/cryptocard.h Revisions: 1.20, 1.19 Authors: fcusack (+3 -1), fcusack (+2 -2) ------------------------------- File: radiusd/src/modules/rlm_otp/otp_cardops.c Revisions: 1.38, 1.37 Authors: fcusack (+5 -4), fcusack (+4 -4) ------------------------------- File: radiusd/src/modules/rlm_otp/otp_cardops.h Revisions: 1.22, 1.21 Authors: fcusack (+3 -1), fcusack (+3 -2) -- Automatic cron job from /web/pages/us.freeradius.org/bin/new_makelog.pl

1 0

Automatic report from sources (radiusd) between 04.10.2005 - 05.10.2005 GMT
by Automatic cvs log generator 05 Oct '05

05 Oct '05

CVS log entries from 04.10.2005 (Tue) 08:00:01 - 05.10.2005 (Wed) 08:00:01 GMT ===================================================== Summary by authors ===================================================== Author: aland File: radiusd/doc/mssql; Revisions: 1.1 ===================================================== Log entries ===================================================== Description: As posted to the list Modified files: File: radiusd/doc/mssql; Revision: 1.1; Date: 2005/10/04 17:28:40; Author: aland; ===================================================== Summary of modified files ===================================================== File: radiusd/doc/mssql Revisions: 1.1 Authors: aland -- Automatic cron job from /web/pages/us.freeradius.org/bin/new_makelog.pl

1 0

Automatic report from sources (radiusd) between 03.10.2005 - 04.10.2005 GMT
by Automatic cvs log generator 04 Oct '05

04 Oct '05

CVS log entries from 03.10.2005 (Mon) 08:00:00 - 04.10.2005 (Tue) 08:00:01 GMT ===================================================== Summary by authors ===================================================== Author: nbk File: radiusd/src/main/conffile.c; Revisions: 1.100.2.1 ===================================================== Log entries ===================================================== Description: Pull from CVS head: When including conf files, reference 'cs' rather than 'parent'. Modified files: File: radiusd/src/main/conffile.c; Revision: 1.100.2.1; Date: 2005/10/03 17:18:59; Author: nbk; Lines: (+3 -3) ===================================================== Summary of modified files ===================================================== File: radiusd/src/main/conffile.c Revisions: 1.100.2.1 Authors: nbk (+3 -3) -- Automatic cron job from /web/pages/us.freeradius.org/bin/new_makelog.pl

1 0

enable gprof for freeradius
by Tariq Rashid 03 Oct '05

03 Oct '05

hi - what is the appropriate point to enable gprof profile for freeradius? is it a configure script option? or is a "gcc -g" change to the top level Make.inc ? tariq

2 1