December 2006 - Freeradius-Devel - lists.freeradius.org

accounting_reply_query (corrected)
by halic 07 Dec '06

07 Dec '06

my previous message incuded one stupid error. sorry. here is corrected one. this is a simple patch to rlm_sql module. it allows module to get attributes from db and send them in Accounting-Response packet. "select-query" configured via default sql.conf; parameter is accounting_reply_query. it is useful to, for example, send "vendor-specific-drop" attribute to NAS in response to Interim-Update. other accounting_*_query parameters may not be defined. configuration example: accounting_reply_query="select id, login as UserName, 'Terminate-Session' as Attribute, 'Yes' as Value, '=' as op from clients where ballance <= 0 and '%{Acct-Status-Type}' = 'Interim-Update' and login = '%{User-Name}'" creating db-view is also a good choise; query like: accounting_reply_query="select id, UserName, Attribute, Value, op from acct_reply status_type = '%{Acct-Status-Type}' and UserName = '%{User-Name}'" my patched pppd recieves "Terminate-Session" attribute. mpd can also receive "Drop-User" attr. currenty a lot of billing systems use different nas-specific scripts to drop client with negative ballance. i think this patch is pretty usefull. sorry, but it's patch to 1.1.3 version; not devel, from cvs. due to bad internet i didnt downloaded cvs version. here it is: diff -urN freeradius-1.1.3/src/modules/rlm_sql/conf.h freeradius-1.1.3-oops/src/modules/rlm_sql/conf.h --- freeradius-1.1.3/src/modules/rlm_sql/conf.h Sat May 20 12:44:37 2006 +++ freeradius-1.1.3-oops/src/modules/rlm_sql/conf.h Wed Dec 6 21:56:15 2006 @@ -29,6 +29,7 @@ char *accounting_start_query_alt; char *accounting_stop_query; char *accounting_stop_query_alt; + char *accounting_reply_query; char *simul_count_query; char *simul_verify_query; char *groupmemb_query; diff -urN freeradius-1.1.3/src/modules/rlm_sql/rlm_sql.c freeradius-1.1.3-oops/src/modules/rlm_sql/rlm_sql.c --- freeradius-1.1.3/src/modules/rlm_sql/rlm_sql.c Sat May 20 12:44:37 2006 +++ freeradius-1.1.3-oops/src/modules/rlm_sql/rlm_sql.c Wed Dec 6 22:03:35 2006 @@ -103,6 +103,8 @@ offsetof(SQL_CONFIG,accounting_stop_query), NULL, ""}, {"accounting_stop_query_alt", PW_TYPE_STRING_PTR, offsetof(SQL_CONFIG,accounting_stop_query_alt), NULL, ""}, + {"accounting_reply_query", PW_TYPE_STRING_PTR, + offsetof(SQL_CONFIG,accounting_reply_query), NULL, ""}, {"group_membership_query", PW_TYPE_STRING_PTR, offsetof(SQL_CONFIG,groupmemb_query), NULL, ""}, {"connect_failure_retry_delay", PW_TYPE_INTEGER, @@ -887,6 +889,7 @@ char querystr[MAX_QUERY_LEN]; char logstr[MAX_QUERY_LEN]; char sqlusername[MAX_STRING_LEN]; + VALUE_PAIR *sql_reply = NULL; #ifdef CISCO_ACCOUNTING_HACK int acctsessiontime = 0; @@ -1103,6 +1106,19 @@ break; } + + radius_xlat(querystr, sizeof(querystr), inst->config->accounting_reply_query, request, sql_escape_func); + query_log(request, inst, querystr); + + if (*querystr) { + if(sqlsocket == NULL && (sqlsocket = sql_get_socket(inst)) == NULL) + return(RLM_MODULE_FAIL); + + sql_getvpdata(inst, sqlsocket, &sql_reply, querystr, PW_VP_USERDATA); + + pairxlatmove(request, &request->reply->vps, &sql_reply); + pairfree(&sql_reply); + } sql_release_socket(inst, sqlsocket);

2 1

accounting_reply_query
by halic 07 Dec '06

07 Dec '06

this is a simple patch to rlm_sql module. it allows module to get attributes from db and send them in Accounting-Response packet. "select-query" configured via default sql.conf; parameter is accounting_reply_query. it is useful to, for example, send "vendor-specific-drop" attribute to NAS in response to Interim-Update. other accounting_*_query parameters may not be defined. configuration example: accounting_reply_query="select id, login as UserName, 'Terminate-Session' as Attribute, 'Yes' as Value, '=' as op from clients where ballance <= 0 and '%{Acct-Status-Type}' = 'Interim-Update' and login = '%{User-Name}'" creating db-view is also a good choise; query like: accounting_reply_query="select id, UserName, Attribute, Value, op from acct_reply status_type = '%{Acct-Status-Type}' and UserName = '%{User-Name}'" my patched pppd recieves "Terminate-Session" attribute. mpd can also receive "Drop-User" attr. currenty a lot of billing systems use different nas-specific scripts to drop client with negative ballance. i think this patch is pretty usefull. sorry, but it's patch to 1.1.3 version; not devel, from cvs. due to bad internet i didnt downloaded cvs version. here it is: diff -urN freeradius-1.1.3/src/modules/rlm_sql/conf.h freeradius-1.1.3-oops/src/modules/rlm_sql/conf.h --- freeradius-1.1.3/src/modules/rlm_sql/conf.h Sat May 20 12:44:37 2006 +++ freeradius-1.1.3-oops/src/modules/rlm_sql/conf.h Wed Dec 6 21:56:15 2006 @@ -29,6 +29,7 @@ char *accounting_start_query_alt; char *accounting_stop_query; char *accounting_stop_query_alt; + char *accounting_reply_query; char *simul_count_query; char *simul_verify_query; char *groupmemb_query; diff -urN freeradius-1.1.3/src/modules/rlm_sql/rlm_sql.c freeradius-1.1.3-oops/src/modules/rlm_sql/rlm_sql.c --- freeradius-1.1.3/src/modules/rlm_sql/rlm_sql.c Sat May 20 12:44:37 2006 +++ freeradius-1.1.3-oops/src/modules/rlm_sql/rlm_sql.c Wed Dec 6 22:03:35 2006 @@ -103,6 +103,8 @@ offsetof(SQL_CONFIG,accounting_stop_query), NULL, ""}, {"accounting_stop_query_alt", PW_TYPE_STRING_PTR, offsetof(SQL_CONFIG,accounting_stop_query_alt), NULL, ""}, + {"accounting_reply_query", PW_TYPE_STRING_PTR, + offsetof(SQL_CONFIG,accounting_reply_query), NULL, ""}, {"group_membership_query", PW_TYPE_STRING_PTR, offsetof(SQL_CONFIG,groupmemb_query), NULL, ""}, {"connect_failure_retry_delay", PW_TYPE_INTEGER, @@ -887,6 +889,7 @@ char querystr[MAX_QUERY_LEN]; char logstr[MAX_QUERY_LEN]; char sqlusername[MAX_STRING_LEN]; + VALUE_PAIR *sql_reply = NULL; #ifdef CISCO_ACCOUNTING_HACK int acctsessiontime = 0; @@ -1103,6 +1106,19 @@ break; } + + radius_xlat(querystr, sizeof(querystr), inst->config->accounting_reply_query, request, sql_escape_func); + query_log(request, inst, querystr); + + if (*querystr) { + if(sqlsocket == NULL && (sqlsocket = sql_get_socket(inst)) == NULL) + return(RLM_MODULE_FAIL); + + sql_getvpdata(inst, sqlsocket, &sql_reply, "SELECT 4 as id, 'dayset' as UserName, 'Terminate-Session' as Attribute, 'Yes' as Value, '=' as op", PW_VP_USERDATA); + + pairxlatmove(request, &request->reply->vps, &sql_reply); + pairfree(&sql_reply); + } sql_release_socket(inst, sqlsocket);

2 1

FreeRadius 1.1.3 Memory Leak
by Abdul Qadir 07 Dec '06

07 Dec '06

Hi, I just configured radius 1.1.3 and found that there are some memory leaks in it. Here is the output of Valgrind ==30841== ERROR SUMMARY: 4365 errors from 82 contexts (suppressed: 44 from 2) ==30841== malloc/free: in use at exit: 1,354,452 bytes in 25,976 blocks. ==30841== malloc/free: 35,826 allocs, 9,850 frees, 3,185,516 bytes allocated. ==30841== For counts of detected errors, rerun with: -v ==30841== searching for pointers to 25,976 not-freed blocks. ==30841== checked 75,458,816 bytes. ==30841== ==30841== ==30841== 11 bytes in 1 blocks are possibly lost in loss record 12 of 93 ==30841== at 0x43BF53F: malloc (m_replacemalloc/vg_replace_malloc.c:149) ==30841== by 0x441F567: (within /usr/lib/libltdl.so.3.1.0) ==30841== by 0x44200B1: (within /usr/lib/libltdl.so.3.1.0) ==30841== by 0x4420CB7: (within /usr/lib/libltdl.so.3.1.0) ==30841== by 0x4421881: lt_dlopenext (in /usr/lib/libltdl.so.3.1.0) ==30841== by 0x8052C5A: (within /usr/local/sbin/radiusd) ==30841== by 0x8052F66: find_module_instance (in /usr/local/sbin/radiusd) ==30841== by 0x8054564: (within /usr/local/sbin/radiusd) ==30841== by 0x805475B: compile_modsingle (in /usr/local/sbin/radiusd) ==30841== by 0x8053422: (within /usr/local/sbin/radiusd) ==30841== by 0x8053958: setup_modules (in /usr/local/sbin/radiusd) ==30841== by 0x805683D: main (in /usr/local/sbin/radiusd) ==30841== ==30841== ==30841== 97 bytes in 6 blocks are definitely lost in loss record 43 of 93 ==30841== at 0x43BF53F: malloc (m_replacemalloc/vg_replace_malloc.c:149) ==30841== by 0x441F567: (within /usr/lib/libltdl.so.3.1.0) ==30841== by 0x44200B1: (within /usr/lib/libltdl.so.3.1.0) ==30841== by 0x4420CB7: (within /usr/lib/libltdl.so.3.1.0) ==30841== by 0x4421881: lt_dlopenext (in /usr/lib/libltdl.so.3.1.0) ==30841== by 0x8052C5A: (within /usr/local/sbin/radiusd) ==30841== by 0x8052F66: find_module_instance (in /usr/local/sbin/radiusd) ==30841== by 0x8054564: (within /usr/local/sbin/radiusd) ==30841== by 0x805475B: compile_modsingle (in /usr/local/sbin/radiusd) ==30841== by 0x8053422: (within /usr/local/sbin/radiusd) ==30841== by 0x8053958: setup_modules (in /usr/local/sbin/radiusd) ==30841== by 0x805683D: main (in /usr/local/sbin/radiusd) ==30841== ==30841== ==30841== 476 bytes in 7 blocks are possibly lost in loss record 68 of 93 ==30841== at 0x43C0C58: calloc (m_replacemalloc/vg_replace_malloc.c:279) ==30841== by 0x8464EA: _dl_allocate_tls (in /lib/ld-2.3.3.so) ==30841== by 0xAB978D: pthread_create@@GLIBC_2.1 (in /lib/tls/libpthread-2.3.3.so) ==30841== by 0x8059A3E: (within /usr/local/sbin/radiusd) ==30841== by 0x8059D20: thread_pool_init (in /usr/local/sbin/radiusd) ==30841== by 0x8056A8B: main (in /usr/local/sbin/radiusd) ==30841== ==30841== LEAK SUMMARY: ==30841== definitely lost: 97 bytes in 6 blocks. ==30841== possibly lost: 487 bytes in 8 blocks. ==30841== still reachable: 1,353,868 bytes in 25,962 blocks. ==30841== suppressed: 0 bytes in 0 blocks. ==30841== Reachable blocks (those to which a pointer was found) are not shown. ==30841== To see them, rerun with: --show-reachable=yes Can any one help me how to fix this.? Best Regards, Abdul Qadir --------------------------------- Need a quick answer? Get one in minutes from people who know. Ask your question on Yahoo! Answers.

2 1

Automatic report from sources (radiusd) between 03.12.2006 - 04.12.2006 GMT
by Automatic cvs log generator 04 Dec '06

04 Dec '06

CVS log entries from 03.12.2006 (Sun) 09:00:01 - 04.12.2006 (Mon) 09:00:04 GMT ===================================================== Summary by authors ===================================================== Author: bjordanov File: radiusd/src/modules/rlm_perl/rlm_perl.c; Revisions: 1.45 ===================================================== Log entries ===================================================== Description: Added new hash RAD_CONFIG Modified files: File: radiusd/src/modules/rlm_perl/rlm_perl.c; Revision: 1.45; Date: 2006/12/04 08:49:38; Author: bjordanov; Lines: (+8 -2) ===================================================== Summary of modified files ===================================================== File: radiusd/src/modules/rlm_perl/rlm_perl.c Revisions: 1.45 Authors: bjordanov (+8 -2) -- Automatic cron job from /web/pages/us.freeradius.org/bin/new_makelog.pl

1 0