October 2007 - Freeradius-Devel - lists.freeradius.org

Dial-up Admin patches
by Scott Lambert 11 Oct '07

11 Oct '07

These patches: 1) Let dialup_admin/bin/log_badlogins read the NAS table from SQL. 2) Make dialup_admin/bin/log_badlogins record the bad password in the callerid field. It is very useful for my support technicians to be able to look at the failed logins table and determine how the user has mis-typed their password, and the caller id field seemed to have the available chars. 3) Change the sort order in dialup_admin/htdocs/accounting.php3 so that the most recent entries are at the top. This usually prevents a lot of scrolling for my techs. 4) Remember the server for which we are showing stats on dialup_admin/htdocs/stats.php3 so that the techs doesn't have to reselect the NAS option every time the refresh the page. 5) Fix the html in dialup_admin/htdocs/user_finger.php3 so that NAS farther down the page do not get farther and farther apart. 6) MySQL 5 did not like the "DEFAULT '0'" for the auto-increment id fields in dialup_admin/sql/mysql/(badusers|userinfo).sql. I simply removed that phrase. Additionally, badusers.sql had a KEY defined on a Date column which apparanlty has been renamed to IncidentDate. I think thats about it for this patch set. Would it be an evil thing to repo-mv *.php3 to *.php and update the code to follow? Has anybody done any work toward making dialup_admin run under PHP5? It appears that PHP4 is on it's last legs. I'm not sure I can do it in a reasonable amount of time since to me "PHP is just this language, you know?" If I can't do it quickly, I probably won't get a chance to do it. -- Scott Lambert KC5MLE Unix SysAdmin lambert(a)lambertfam.org Yes, that was a HHGTTG reference.

1 1

Automatic report from sources (radiusd) between 09.10.2007 - 10.10.2007 GMT
by Automatic cvs log generator 10 Oct '07

10 Oct '07

CVS log entries from 09.10.2007 (Tue) 08:00:01 - 10.10.2007 (Wed) 08:00:02 GMT ===================================================== Summary by authors ===================================================== Author: aland File: radiusd/src/main/threads.c; Revisions: 1.137 File: radiusd/src/main/radiusd.c; Revisions: 1.376 File: radiusd/raddb/policy.txt; Revisions: 1.3 File: radiusd/src/modules/rlm_mschap/rlm_mschap.c; Revisions: 1.93, 1.92 File: radiusd/src/main/listen.c; Revisions: 1.105 File: radiusd/src/include/radiusd.h; Revisions: 1.250, 1.249, 1.248, 1.247 File: radiusd/doc/ChangeLog; Revisions: 1.78 File: radiusd/raddb/experimental.conf; Revisions: 1.37 File: radiusd/src/lib/event.c; Revisions: 1.10 File: radiusd/src/modules/rlm_mschap/opendir.c; Revisions: 1.7, 1.6, 1.5, 1.4 File: radiusd/raddb/protocol_filter.conf; Revisions: 1.3 File: radiusd/src/main/mainconfig.c; Revisions: 1.127, 1.126 File: radiusd/src/main/util.c; Revisions: 1.64 File: radiusd/src/main/client.c; Revisions: 1.70, 1.69 File: radiusd/raddb/sites-available/example; Revisions: 1.2 File: radiusd/src/main/event.c; Revisions: 1.60, 1.59, 1.58 File: radiusd/raddb/sites-available/README; Revisions: 1.3 File: radiusd/src/main/realms.c; Revisions: 1.37, 1.36, 1.35 File: radiusd/src/include/event.h; Revisions: 1.6 File: radiusd/raddb/proxy.conf; Revisions: 1.29 File: radiusd/src/main/conffile.c; Revisions: 1.182 File: radiusd/src/include/realms.h; Revisions: 1.15 ===================================================== Combined list of identical log entries ===================================================== Description: Rename "server_pool" to "home_server_pool". It's clearer Modified files: File: radiusd/raddb/proxy.conf; Revision: 1.29; Date: 2007/10/09 14:15:34; Author: aland; Lines: (+6 -6) File: radiusd/src/main/realms.c; Revision: 1.36; Date: 2007/10/09 14:15:35; Author: aland; Lines: (+14 -8) ------------------------------- Description: Add %{home_server:foo} and %{home_server_pool:foo} server_pool -> home_server_pool rename will happen in a later commit Modified files: File: radiusd/src/include/realms.h; Revision: 1.15; Date: 2007/10/09 14:12:26; Author: aland; Lines: (+6 -2) File: radiusd/src/main/realms.c; Revision: 1.35; Date: 2007/10/09 14:12:27; Author: aland; Lines: (+68 -2) ------------------------------- Description: Move add_reply to mschap_add_reply, so that the opendir code can use it Modified files: File: radiusd/src/modules/rlm_mschap/opendir.c; Revision: 1.4; Date: 2007/10/09 12:07:48; Author: aland; Lines: (+5 -5) File: radiusd/src/modules/rlm_mschap/rlm_mschap.c; Revision: 1.92; Date: 2007/10/09 12:07:48; Author: aland; Lines: (+19 -15) ------------------------------- Description: Clean up threads, and add thread pool lock/unlock functions, in preparation for HUP Modified files: File: radiusd/src/include/radiusd.h; Revision: 1.250; Date: 2007/10/09 15:00:40; Author: aland; Lines: (+4 -2) File: radiusd/src/main/radiusd.c; Revision: 1.376; Date: 2007/10/09 15:00:40; Author: aland; Lines: (+13 -6) File: radiusd/src/main/threads.c; Revision: 1.137; Date: 2007/10/09 15:00:40; Author: aland; Lines: (+6 -15) ------------------------------- Description: Increment/decrement refcount on mainconfig, in preparation for HUP support (some time in the future) Modified files: File: radiusd/src/include/radiusd.h; Revision: 1.248; Date: 2007/10/09 14:39:36; Author: aland; Lines: (+3 -3) File: radiusd/src/main/event.c; Revision: 1.59; Date: 2007/10/09 14:39:36; Author: aland; Lines: (+4 -3) File: radiusd/src/main/util.c; Revision: 1.64; Date: 2007/10/09 14:39:37; Author: aland; Lines: (+8 -2) ------------------------------- Description: listen / client config changes server -> virtual_server for clarity. "server = " is also accepted for compatibilty with 2.0-pre* Modified files: File: radiusd/raddb/sites-available/README; Revision: 1.3; Date: 2007/10/09 14:25:35; Author: aland; Lines: (+12 -11) File: radiusd/raddb/sites-available/example; Revision: 1.2; Date: 2007/10/09 14:25:36; Author: aland; Lines: (+3 -3) File: radiusd/src/main/client.c; Revision: 1.70; Date: 2007/10/09 14:25:35; Author: aland; Lines: (+5 -3) File: radiusd/src/main/listen.c; Revision: 1.105; Date: 2007/10/09 14:25:35; Author: aland; Lines: (+7 -3) ------------------------------- Description: No one uses protocol_filter. It's useless now that "unlang" is here Modified files: File: radiusd/raddb/experimental.conf; Revision: 1.37; Date: 2007/10/09 13:43:43; Author: aland; Lines: (+1 -16) File: radiusd/raddb/protocol_filter.conf; Revision: 1.3; Date: 2007/10/09 13:43:43; Author: aland; Lines: (+1 -1) ------------------------------- Description: #if __APPLE__ to #ifdef __APPLE__ Modified files: File: radiusd/src/modules/rlm_mschap/opendir.c; Revision: 1.5; Date: 2007/10/09 12:08:48; Author: aland; Lines: (+2 -2) File: radiusd/src/modules/rlm_mschap/rlm_mschap.c; Revision: 1.93; Date: 2007/10/09 12:08:48; Author: aland; Lines: (+3 -3) ------------------------------- Description: Added %{client:foo} expansion Modified files: File: radiusd/src/include/radiusd.h; Revision: 1.247; Date: 2007/10/09 14:07:32; Author: aland; Lines: (+3 -2) File: radiusd/src/main/client.c; Revision: 1.69; Date: 2007/10/09 14:07:32; Author: aland; Lines: (+3 -2) File: radiusd/src/main/mainconfig.c; Revision: 1.126; Date: 2007/10/09 14:07:32; Author: aland; Lines: (+32 -2) ------------------------------- Description: Move uid_name and gid_name out of global variable, as they're only of use to mainconfig.c Modified files: File: radiusd/src/include/radiusd.h; Revision: 1.249; Date: 2007/10/09 14:45:58; Author: aland; Lines: (+2 -4) File: radiusd/src/main/mainconfig.c; Revision: 1.127; Date: 2007/10/09 14:45:59; Author: aland; Lines: (+21 -18) ------------------------------- Description: Parse, validate, and use "virtual_server" configuration in home_server_pool. When set, pre/post proxy sections are run through this virtual server. Note that we don't do this for realms. It *might* be useful, but we'll leave it out for now Modified files: File: radiusd/src/main/event.c; Revision: 1.58; Date: 2007/10/09 14:30:49; Author: aland; Lines: (+30 -4) File: radiusd/src/main/realms.c; Revision: 1.37; Date: 2007/10/09 14:30:50; Author: aland; Lines: (+18 -2) ------------------------------- Description: Add argument to loop exit, and cache FD_SET Modified files: File: radiusd/src/include/event.h; Revision: 1.6; Date: 2007/10/09 13:24:22; Author: aland; Lines: (+3 -3) File: radiusd/src/lib/event.c; Revision: 1.10; Date: 2007/10/09 13:24:23; Author: aland; Lines: (+20 -7) ===================================================== Log entries ===================================================== Description: In preparation for 2.0 Modified files: File: radiusd/doc/ChangeLog; Revision: 1.78; Date: 2007/10/09 13:40:14; Author: aland; Lines: (+12 -24) ------------------------------- Description: Recommend that people don't use rlm_policy Modified files: File: radiusd/raddb/policy.txt; Revision: 1.3; Date: 2007/10/09 13:44:10; Author: aland; Lines: (+11 -3) ------------------------------- Description: Debug print IP addresses. Modified files: File: radiusd/src/main/conffile.c; Revision: 1.182; Date: 2007/10/09 13:46:24; Author: aland; Lines: (+9 -4) ------------------------------- Description: Clarify thread handling and debug messages Modified files: File: radiusd/src/main/event.c; Revision: 1.60; Date: 2007/10/09 14:50:08; Author: aland; Lines: (+6 -5) ------------------------------- Description: Whitespace changes (indenting and formatting to meet FreeRADIUS style) Modified files: File: radiusd/src/modules/rlm_mschap/opendir.c; Revision: 1.7; Date: 2007/10/09 12:19:55; Author: aland; Lines: (+85 -78) ------------------------------- Description: // -> /* ... */ and other ANSI C fixes Modified files: File: radiusd/src/modules/rlm_mschap/opendir.c; Revision: 1.6; Date: 2007/10/09 12:12:33; Author: aland; Lines: (+12 -15) ===================================================== Summary of modified files ===================================================== File: radiusd/doc/ChangeLog Revisions: 1.78 Authors: aland (+12 -24) ------------------------------- File: radiusd/raddb/experimental.conf Revisions: 1.37 Authors: aland (+1 -16) ------------------------------- File: radiusd/raddb/policy.txt Revisions: 1.3 Authors: aland (+11 -3) ------------------------------- File: radiusd/raddb/protocol_filter.conf Revisions: 1.3 Authors: aland (+1 -1) ------------------------------- File: radiusd/raddb/proxy.conf Revisions: 1.29 Authors: aland (+6 -6) ------------------------------- File: radiusd/raddb/sites-available/README Revisions: 1.3 Authors: aland (+12 -11) ------------------------------- File: radiusd/raddb/sites-available/example Revisions: 1.2 Authors: aland (+3 -3) ------------------------------- File: radiusd/src/include/event.h Revisions: 1.6 Authors: aland (+3 -3) ------------------------------- File: radiusd/src/include/radiusd.h Revisions: 1.250, 1.249, 1.248, 1.247 Authors: aland (+4 -2), aland (+2 -4), aland (+3 -3), aland (+3 -2) ------------------------------- File: radiusd/src/include/realms.h Revisions: 1.15 Authors: aland (+6 -2) ------------------------------- File: radiusd/src/lib/event.c Revisions: 1.10 Authors: aland (+20 -7) ------------------------------- File: radiusd/src/main/client.c Revisions: 1.70, 1.69 Authors: aland (+5 -3), aland (+3 -2) ------------------------------- File: radiusd/src/main/conffile.c Revisions: 1.182 Authors: aland (+9 -4) ------------------------------- File: radiusd/src/main/event.c Revisions: 1.60, 1.59, 1.58 Authors: aland (+6 -5), aland (+4 -3), aland (+30 -4) ------------------------------- File: radiusd/src/main/listen.c Revisions: 1.105 Authors: aland (+7 -3) ------------------------------- File: radiusd/src/main/mainconfig.c Revisions: 1.127, 1.126 Authors: aland (+21 -18), aland (+32 -2) ------------------------------- File: radiusd/src/main/radiusd.c Revisions: 1.376 Authors: aland (+13 -6) ------------------------------- File: radiusd/src/main/realms.c Revisions: 1.37, 1.36, 1.35 Authors: aland (+18 -2), aland (+14 -8), aland (+68 -2) ------------------------------- File: radiusd/src/main/threads.c Revisions: 1.137 Authors: aland (+6 -15) ------------------------------- File: radiusd/src/main/util.c Revisions: 1.64 Authors: aland (+8 -2) ------------------------------- File: radiusd/src/modules/rlm_mschap/opendir.c Revisions: 1.7, 1.6, 1.5, 1.4 Authors: aland (+85 -78), aland (+12 -15), aland (+2 -2), aland (+5 -5) ------------------------------- File: radiusd/src/modules/rlm_mschap/rlm_mschap.c Revisions: 1.93, 1.92 Authors: aland (+3 -3), aland (+19 -15) -- Automatic cron job from /web/pages/us.freeradius.org/bin/new_makelog.pl

1 0

Automatic report from sources (radiusclient) between 08.10.2007 - 09.10.2007 GMT
by Automatic cvs log generator 09 Oct '07

09 Oct '07

CVS log entries from 08.10.2007 (Mon) 07:00:00 - 09.10.2007 (Tue) 07:00:02 GMT ===================================================== Summary by authors ===================================================== Author: cparker File: radiusclient/src/radembedded.c; Revisions: 1.3 ===================================================== Log entries ===================================================== Description: Add missing #include <stdlib.h> to src/radembedded.c Reported by norm(a)goes.com Modified files: File: radiusclient/src/radembedded.c; Revision: 1.3; Date: 2007/10/08 15:48:06; Author: cparker; Lines: (+1 -0) ===================================================== Summary of modified files ===================================================== File: radiusclient/src/radembedded.c Revisions: 1.3 Authors: cparker (+1 -0) -- Automatic cron job from /web/pages/us.freeradius.org/bin/rc-new_makelog.pl

1 0

Re: Caveat: schema differences in Acct(Start|Stop)Time
by Stefan Winter 08 Oct '07

08 Oct '07

Hi, > > I agree that MySQL should change also, but at the time I go pushback for > > making backwards incompatible schema changes which some third party > > billing systems seem to rely on. I think the 2.0 release is the correct > > time to standardise all of this though.. > > Yes, please. > > Alan DeKok. I now have an (untested) patch for the schema defs and queries for trunk on my disk. What is the preferred patch format again? That info doesn't seem to be on the Wiki yet - or apologies if I didn't find it. I agree that backward uncompatible changes in 1.1.x are not a good idea. Greetings, Stefan -- Stefan WINTER Stiftung RESTENA - Réseau Téléinformatique de l'Education Nationale et de la Recherche Ingenieur Forschung & Entwicklung 6, rue Richard Coudenhove-Kalergi L-1359 Luxembourg E-Mail: stefan.winter(a)restena.lu Tel.: +352 424409-1 http://www.restena.lu Fax: +352 422473

2 2

Automatic report from sources (radiusclient) between 05.10.2007 - 06.10.2007 GMT
by Automatic cvs log generator 06 Oct '07

06 Oct '07

CVS log entries from 05.10.2007 (Fri) 07:00:00 - 06.10.2007 (Sat) 07:00:00 GMT ===================================================== Summary by authors ===================================================== Author: cparker File: radiusclient/include/freeradius-client.h; Revisions: 1.9 ===================================================== Log entries ===================================================== Description: Remove typedef error ( no need to typedef uint32_t to uint32_t ). Reported by: norm(a)goes.com Modified files: File: radiusclient/include/freeradius-client.h; Revision: 1.9; Date: 2007/10/05 15:37:26; Author: cparker; Lines: (+1 -2) ===================================================== Summary of modified files ===================================================== File: radiusclient/include/freeradius-client.h Revisions: 1.9 Authors: cparker (+1 -2) -- Automatic cron job from /web/pages/us.freeradius.org/bin/rc-new_makelog.pl

1 0

Automatic report from sources (radiusd) between 04.10.2007 - 05.10.2007 GMT
by Automatic cvs log generator 05 Oct '07

05 Oct '07

CVS log entries from 04.10.2007 (Thu) 08:00:00 - 05.10.2007 (Fri) 08:00:00 GMT ===================================================== Summary by authors ===================================================== Author: aland File: radiusd/share/dictionary; Revisions: 1.149 File: radiusd/share/dictionary.slipstream; Revisions: 1.1 ===================================================== Combined list of identical log entries ===================================================== Description: As posted to the list Modified files: File: radiusd/share/dictionary; Revision: 1.149; Date: 2007/10/05 07:10:32; Author: aland; Lines: (+2 -1) File: radiusd/share/dictionary.slipstream; Revision: 1.1; Date: 2007/10/05 07:10:32; Author: aland; ===================================================== Log entries ===================================================== ===================================================== Summary of modified files ===================================================== File: radiusd/share/dictionary Revisions: 1.149 Authors: aland (+2 -1) ------------------------------- File: radiusd/share/dictionary.slipstream Revisions: 1.1 Authors: aland -- Automatic cron job from /web/pages/us.freeradius.org/bin/new_makelog.pl

1 0

Automatic report from sources (radiusd) between 03.10.2007 - 04.10.2007 GMT
by Automatic cvs log generator 04 Oct '07

04 Oct '07

CVS log entries from 03.10.2007 (Wed) 08:00:01 - 04.10.2007 (Thu) 08:00:00 GMT ===================================================== Summary by authors ===================================================== Author: aland File: radiusd/src/modules/rlm_exec/rlm_exec.c; Revisions: 1.28 File: radiusd/src/main/modules.c; Revisions: 1.145 File: radiusd/src/main/event.c; Revisions: 1.57 File: radiusd/src/main/threads.c; Revisions: 1.136 File: radiusd/src/main/mainconfig.c; Revisions: 1.125 File: radiusd/src/main/radiusd.c; Revisions: 1.375 File: radiusd/src/main/conffile.c; Revisions: 1.181 File: radiusd/src/main/listen.c; Revisions: 1.104 ===================================================== Combined list of identical log entries ===================================================== Description: More re-arrangements to clarify the code. Cleaned up debug output so it should be even easier to understand. Modified files: File: radiusd/src/main/conffile.c; Revision: 1.181; Date: 2007/10/03 13:29:04; Author: aland; Lines: (+4 -4) File: radiusd/src/main/event.c; Revision: 1.57; Date: 2007/10/03 13:29:04; Author: aland; Lines: (+31 -57) File: radiusd/src/main/listen.c; Revision: 1.104; Date: 2007/10/03 13:29:04; Author: aland; Lines: (+8 -7) File: radiusd/src/main/mainconfig.c; Revision: 1.125; Date: 2007/10/03 13:29:05; Author: aland; Lines: (+11 -33) File: radiusd/src/main/modules.c; Revision: 1.145; Date: 2007/10/03 13:29:05; Author: aland; Lines: (+10 -64) File: radiusd/src/main/radiusd.c; Revision: 1.375; Date: 2007/10/03 13:29:05; Author: aland; Lines: (+28 -29) File: radiusd/src/main/threads.c; Revision: 1.136; Date: 2007/10/03 13:29:06; Author: aland; Lines: (+2 -3) ===================================================== Log entries ===================================================== Description: Removed useless error message Modified files: File: radiusd/src/modules/rlm_exec/rlm_exec.c; Revision: 1.28; Date: 2007/10/03 12:18:48; Author: aland; Lines: (+2 -11) ===================================================== Summary of modified files ===================================================== File: radiusd/src/main/conffile.c Revisions: 1.181 Authors: aland (+4 -4) ------------------------------- File: radiusd/src/main/event.c Revisions: 1.57 Authors: aland (+31 -57) ------------------------------- File: radiusd/src/main/listen.c Revisions: 1.104 Authors: aland (+8 -7) ------------------------------- File: radiusd/src/main/mainconfig.c Revisions: 1.125 Authors: aland (+11 -33) ------------------------------- File: radiusd/src/main/modules.c Revisions: 1.145 Authors: aland (+10 -64) ------------------------------- File: radiusd/src/main/radiusd.c Revisions: 1.375 Authors: aland (+28 -29) ------------------------------- File: radiusd/src/main/threads.c Revisions: 1.136 Authors: aland (+2 -3) ------------------------------- File: radiusd/src/modules/rlm_exec/rlm_exec.c Revisions: 1.28 Authors: aland (+2 -11) -- Automatic cron job from /web/pages/us.freeradius.org/bin/new_makelog.pl

1 0

Automatic report from sources (radiusd) between 02.10.2007 - 03.10.2007 GMT
by Automatic cvs log generator 03 Oct '07

03 Oct '07

CVS log entries from 02.10.2007 (Tue) 08:00:01 - 03.10.2007 (Wed) 08:00:01 GMT ===================================================== Summary by authors ===================================================== Author: aland File: radiusd/src/modules/rlm_sqlippool/rlm_sqlippool.c; Revisions: 1.34, 1.33 Author: fcusack File: radiusd/src/modules/rlm_otp/otp_pw_valid.c; Revisions: 1.1.2.15 File: radiusd/src/modules/rlm_otp/otp.h; Revisions: 1.28.2.14 ===================================================== Combined list of identical log entries ===================================================== Description: NEXT_PASSCODE -> NEXTPASSCODE, to be consistent with HEAD and external sources Modified files: File: radiusd/src/modules/rlm_otp/otp.h; Revision: 1.28.2.14; Date: 2007/10/02 22:19:47; Author: fcusack; Lines: (+3 -3) File: radiusd/src/modules/rlm_otp/otp_pw_valid.c; Revision: 1.1.2.15; Date: 2007/10/02 22:19:47; Author: fcusack; Lines: (+3 -3) ===================================================== Log entries ===================================================== Description: Clean up compiler warnings and remove exit(0) Modified files: File: radiusd/src/modules/rlm_sqlippool/rlm_sqlippool.c; Revision: 1.34; Date: 2007/10/03 06:33:53; Author: aland; Lines: (+31 -39) ------------------------------- Description: More sanity checks on the module instance handles. Patch from Stephan Jaeger. Modified files: File: radiusd/src/modules/rlm_sqlippool/rlm_sqlippool.c; Revision: 1.33; Date: 2007/10/03 06:29:49; Author: aland; Lines: (+15 -4) ===================================================== Summary of modified files ===================================================== File: radiusd/src/modules/rlm_otp/otp.h Revisions: 1.28.2.14 Authors: fcusack (+3 -3) ------------------------------- File: radiusd/src/modules/rlm_otp/otp_pw_valid.c Revisions: 1.1.2.15 Authors: fcusack (+3 -3) ------------------------------- File: radiusd/src/modules/rlm_sqlippool/rlm_sqlippool.c Revisions: 1.34, 1.33 Authors: aland (+31 -39), aland (+15 -4) -- Automatic cron job from /web/pages/us.freeradius.org/bin/new_makelog.pl

1 0

rlm_sqlippool segfaults on wrong/missing rlm_sql instance
by Stephan Jaeger 03 Oct '07

03 Oct '07

Hi, rlm_sqlippool segfaults if you specify a non existing sql module instance. I modified it a bit to behave like rlm_sqlhpwippool, it now throws an error if the specified module instance does not exist: Tue Jul 31 11:23:16 2007 : Error: ERROR: Cannot find a configuration entry for module "foobar". Tue Jul 31 11:23:16 2007 : Error: sqlippool_instantiate: failed to find sql instance named foobar And also throws an error if the specified module is not an instance of rlm_sql: Tue Jul 31 11:28:24 2007 : Error: sqlippool_instantiate: given instance (expr) is not an instance of the rlm_sql module Regards Stephan Jaeger -- Stephan Jaeger <stephan.jaeger(a)ewetel.de> EWE TEL GmbH

2 1

Rlm_sqlippool + mssql bug
by Gabriel 02 Oct '07

02 Oct '07

I am currently working on the rlm_sqlippool module to work with ms sql. I believe I discovered a bug in the sqlippool_query1 function and was able to fix it. Somehow the function uses the return of rlm_sql_fetch_row as a strlen of the result. It then uses this return "r" to do a strncpy to the return string value of this rlm_sqlippool. The problem is, it seems that rlm_sql_fetch_row returns 0 in the case of ms sql and then the strncpy fails. How do I go about submitting a patch about this problem? -Gabriel

3 2