December 2007 - Freeradius-Devel - lists.freeradius.org

rlm_ippool & MPP
by Alan DeKok 06 Dec '07

06 Dec '07

Does this even work? Looking in 1.1.x and in CVS head, the "cli" field of each entry is initialized. and later compared to the Calling-Station-Id. However, the Calling-Station-Id is ever *stored* in the "cli" field. So the MPP code can't possible do anything. I suggest deleting it... Kostas? Comments? I think I'm also going to take a sweep through it, re-formatting it to match the rest of the code. It may also be worth adding an "expired" GDBM, keyed off of "timestamp + IP". That way, the time taken to find an expired entry is minimal. Alan DeKok.

1 0

Automatic report from sources (radiusd) between 05.12.2007 - 06.12.2007 GMT
by Automatic cvs log generator 06 Dec '07

06 Dec '07

CVS log entries from 05.12.2007 (Wed) 09:00:00 - 06.12.2007 (Thu) 09:00:01 GMT ===================================================== Summary by authors ===================================================== Author: aland File: radiusd/src/modules/rlm_pap/rlm_pap.c; Revisions: 1.60 File: radiusd/src/main/event.c; Revisions: 1.74 File: radiusd/src/modules/rlm_preprocess/rlm_preprocess.c; Revisions: 1.79 File: radiusd/src/lib/valuepair.c; Revisions: 1.129 File: radiusd/src/include/libradius.h; Revisions: 1.147 ===================================================== Combined list of identical log entries ===================================================== Description: Remove 'caseless' from VALUE_PAIR flags. It's not needed. Added 'unknown_attr' to VALUE_PAIR flags, which tracks if vp->name points to a DICT_ATTR entry name or not. vp->name is now a pointer, rather than a character array. Updated code to have "vp->name = da->name" for known attributes. Otherwise, the memory allocated for the VALUE_PAIR is increased by ~24 characters. The name is printed there (Vendor-X-Attr-Y), and vp->name is pointed to the string. Updated paircopy() to look at vp->flags.unknown_attr, if set, it allocates more room for the name, and does a memcpy() of the VALUE_PAIR + the name. Updated rlm_preprocess to NOT print to vp->name. Nothing else in the code should now write to vp->name Updated paircreate() to simplify printing of Vendor-X-Attr-Y Updated pairmake_any() to simplify parsing of Vendor-X-Attr-Y. It now also checks size of attribute values (e.g. 1-octet, 2-octet, etc). It now parses the octet string as an octet string, no matter what the final type is. So you can have "Attr-5 = 0x00000001", and have it show up as "NAS-Port = 1". Modified files: File: radiusd/src/include/libradius.h; Revision: 1.147; Date: 2007/12/05 10:22:41; Author: aland; Lines: (+4 -4) File: radiusd/src/lib/valuepair.c; Revision: 1.129; Date: 2007/12/05 10:22:41; Author: aland; Lines: (+201 -88) File: radiusd/src/modules/rlm_preprocess/rlm_preprocess.c; Revision: 1.79; Date: 2007/12/05 10:22:41; Author: aland; Lines: (+10 -5) ===================================================== Log entries ===================================================== Description: Delay a little longer in wait_a_bit. It can't hurt. rcode is ssize_t, not size_t Modified files: File: radiusd/src/main/event.c; Revision: 1.74; Date: 2007/12/06 08:53:11; Author: aland; Lines: (+5 -5) ------------------------------- Description: Signed / unsigned issues And oracle LM/NT password headers, as posted to the list Modified files: File: radiusd/src/modules/rlm_pap/rlm_pap.c; Revision: 1.60; Date: 2007/12/05 14:44:22; Author: aland; Lines: (+18 -16) ===================================================== Summary of modified files ===================================================== File: radiusd/src/include/libradius.h Revisions: 1.147 Authors: aland (+4 -4) ------------------------------- File: radiusd/src/lib/valuepair.c Revisions: 1.129 Authors: aland (+201 -88) ------------------------------- File: radiusd/src/main/event.c Revisions: 1.74 Authors: aland (+5 -5) ------------------------------- File: radiusd/src/modules/rlm_pap/rlm_pap.c Revisions: 1.60 Authors: aland (+18 -16) ------------------------------- File: radiusd/src/modules/rlm_preprocess/rlm_preprocess.c Revisions: 1.79 Authors: aland (+10 -5) -- Automatic cron job from /web/pages/us.freeradius.org/bin/new_makelog.pl

1 0

Automatic report from sources (radiusd) between 04.12.2007 - 05.12.2007 GMT
by Automatic cvs log generator 05 Dec '07

05 Dec '07

CVS log entries from 04.12.2007 (Tue) 09:00:00 - 05.12.2007 (Wed) 09:00:00 GMT ===================================================== Summary by authors ===================================================== Author: nbk File: radiusd/src/main/radrelay.c; Revisions: 1.22.2.3.2.5 ===================================================== Log entries ===================================================== Description: Update radrelay to interact correctly with rlm_detail. This fixes the error message "Failed to aquire filelock" reported to the mailing list. The new method is now: 1. Open detail.work if it exists, or move detail to detail.work 2. Lock detail.work to wait for any rlm_detail to finish writing one last record 3. Read records 4. Close (and unlock) detail.work 5. Delete detail.work Many thanks to Brian De Wolf <bldewolf(a)csupomona.edu> for writing the patch. Modified files: File: radiusd/src/main/radrelay.c; Revision: 1.22.2.3.2.5; Date: 2007/12/04 17:22:53; Author: nbk; Lines: (+32 -97) ===================================================== Summary of modified files ===================================================== File: radiusd/src/main/radrelay.c Revisions: 1.22.2.3.2.5 Authors: nbk (+32 -97) -- Automatic cron job from /web/pages/us.freeradius.org/bin/new_makelog.pl

1 0

1.1.7 rlm_detail locking is broken
by Brian De Wolf 04 Dec '07

04 Dec '07

Hello, I recently installed freeradius and have it forwarding accounting information. I noticed that there were a lot of failed locks in the logs, so I began to investigate. In rlm_detail, I found this loop for locking: do { if (inst->locking) { lseek(outfd, 0L, SEEK_SET); if (rad_lockfd_nonblock(outfd, 0) < 0) { close(outfd); tv.tv_sec = 0; tv.tv_usec = 25000; select(0, NULL, NULL, NULL, &tv); lock_count++; } else { DEBUG("rlm_detail: Acquired filelock, tried %d time(s)", lock_count + 1); locked = 1; } } } while (!locked && inst->locking && lock_count < 80); This loop, if it fails on the first lock, might as well not try again. Why? Because it closes the file descriptor when it fails. All of the following calls just come back with 'bad file descriptor'. The oddest part about this is that I had found this thread: http://osdir.com/ml/freeradius.devel/2005-03/msg00112.html It looks like the locking should work perfectly! But it seems these changes never found their way into the 1.x series, despite having occurred two years ago. I poked around in CVS and found revision 1.43 which is when the corrected locking was added. I took a diff of revision 1.42 and 1.43, and applied it by hand to 1.1.7. I haven't had any complaints from freeradius about locking issues since. I have attached the patch. Is there any reason this never found its way into the 1.x series? I see it's in the CVS head. --- src/modules/rlm_detail/rlm_detail.c.orig 2007-11-21 14:53:45.000000000 -0800 +++ src/modules/rlm_detail/rlm_detail.c 2007-11-26 11:41:58.000000000 -0800 @@ -271,25 +271,24 @@ *p = '/'; } /* else there was no directory delimiter. */ - /* - * Open & create the file, with the given permissions. - */ - if ((outfd = open(buffer, O_WRONLY | O_APPEND | O_CREAT, - inst->detailperm)) < 0) { - radlog(L_ERR, "rlm_detail: Couldn't open file %s: %s", - buffer, strerror(errno)); - return RLM_MODULE_FAIL; - } - - /* - * If we're not using locking, we'll just pass straight though - * the while loop. - * If we fail to aquire the filelock in 80 tries (approximately - * two seconds) we bail out. - */ locked = 0; lock_count = 0; do { + /* + * Open & create the file, with the given + * permissions. + */ + if ((outfd = open(buffer, O_WRONLY | O_APPEND | O_CREAT, + inst->detailperm)) < 0) { + radlog(L_ERR, "rlm_detail: Couldn't open file %s: %s", + buffer, strerror(errno)); + return RLM_MODULE_FAIL; + } + + /* + * If we fail to aquire the filelock in 80 tries + * (approximately two seconds) we bail out. + */ if (inst->locking) { lseek(outfd, 0L, SEEK_SET); if (rad_lockfd_nonblock(outfd, 0) < 0) { @@ -298,15 +297,36 @@ tv.tv_usec = 25000; select(0, NULL, NULL, NULL, &tv); lock_count++; - } else { - DEBUG("rlm_detail: Acquired filelock, tried %d time(s)", - lock_count + 1); - locked = 1; + continue; + } + + /* + * The file might have been deleted by + * radrelay while we tried to acquire + * the lock (race condition) + */ + if (fstat(outfd, &st) != 0) { + radlog(L_ERR, "rlm_detail: Couldn't stat file %s: %s", + buffer, strerror(errno)); + close(outfd); + return RLM_MODULE_FAIL; } + if (st.st_nlink == 0) { + DEBUG("rlm_detail: File %s removed by another program, retrying", + buffer); + close(outfd); + lock_count = 0; + continue; + } + + DEBUG("rlm_detail: Acquired filelock, tried %d time(s)", + lock_count + 1); + locked = 1; } - } while (!locked && inst->locking && lock_count < 80); + } while (inst->locking && !locked && lock_count < 80); - if (!locked && inst->locking && lock_count >= 80) { + if (inst->locking && !locked) { + close(outfd); radlog(L_ERR, "rlm_detail: Failed to aquire filelock for %s, giving up", buffer); return RLM_MODULE_FAIL;

3 8

Automatic report from sources (radiusd) between 02.12.2007 - 03.12.2007 GMT
by Automatic cvs log generator 03 Dec '07

03 Dec '07

CVS log entries from 02.12.2007 (Sun) 09:00:01 - 03.12.2007 (Mon) 09:00:01 GMT ===================================================== Summary by authors ===================================================== Author: aland File: radiusd/src/main/modules.c; Revisions: 1.153 File: radiusd/src/include/smux.h; Revisions: 1.12 File: radiusd/src/main/mainconfig.c; Revisions: 1.135 File: radiusd/src/main/radiusd.c; Revisions: 1.383 File: radiusd/src/modules/rlm_detail/rlm_detail.c; Revisions: 1.65 File: radiusd/src/main/smux.c; Revisions: 1.26 File: radiusd/src/main/radius_snmp.c; Revisions: 1.44 ===================================================== Combined list of identical log entries ===================================================== Description: Call lt_dlexit() AFTER detach modules. Call xlat_free() AFTER detach modules. Move module instances to a tree, in preparation for getting rid of cf_data (which should help with HUP) Modified files: File: radiusd/src/main/mainconfig.c; Revision: 1.135; Date: 2007/12/02 15:48:14; Author: aland; Lines: (+2 -4) File: radiusd/src/main/modules.c; Revision: 1.153; Date: 2007/12/02 15:48:15; Author: aland; Lines: (+53 -12) File: radiusd/src/main/radiusd.c; Revision: 1.383; Date: 2007/12/02 15:48:14; Author: aland; Lines: (+4 -2) ===================================================== Log entries ===================================================== Description: Reference net-snmp API, if it exists Modified files: File: radiusd/src/include/smux.h; Revision: 1.12; Date: 2007/12/02 16:52:51; Author: aland; Lines: (+8 -4) ------------------------------- Description: Fix more compiler warnings Modified files: File: radiusd/src/main/radius_snmp.c; Revision: 1.44; Date: 2007/12/02 16:43:16; Author: aland; Lines: (+62 -62) ------------------------------- Description: Fix all compiler warnings. With luck, this will fix 64-bit issues, too Modified files: File: radiusd/src/main/smux.c; Revision: 1.26; Date: 2007/12/02 16:37:16; Author: aland; Lines: (+44 -43) ------------------------------- Description: Safer way of setting things Modified files: File: radiusd/src/modules/rlm_detail/rlm_detail.c; Revision: 1.65; Date: 2007/12/02 23:40:32; Author: aland; Lines: (+4 -3) ===================================================== Summary of modified files ===================================================== File: radiusd/src/include/smux.h Revisions: 1.12 Authors: aland (+8 -4) ------------------------------- File: radiusd/src/main/mainconfig.c Revisions: 1.135 Authors: aland (+2 -4) ------------------------------- File: radiusd/src/main/modules.c Revisions: 1.153 Authors: aland (+53 -12) ------------------------------- File: radiusd/src/main/radius_snmp.c Revisions: 1.44 Authors: aland (+62 -62) ------------------------------- File: radiusd/src/main/radiusd.c Revisions: 1.383 Authors: aland (+4 -2) ------------------------------- File: radiusd/src/main/smux.c Revisions: 1.26 Authors: aland (+44 -43) ------------------------------- File: radiusd/src/modules/rlm_detail/rlm_detail.c Revisions: 1.65 Authors: aland (+4 -3) -- Automatic cron job from /web/pages/us.freeradius.org/bin/new_makelog.pl

1 0

Automatic report from sources (radiusd) between 01.12.2007 - 02.12.2007 GMT
by Automatic cvs log generator 02 Dec '07

02 Dec '07

CVS log entries from 01.12.2007 (Sat) 09:00:01 - 02.12.2007 (Sun) 09:00:01 GMT ===================================================== Summary by authors ===================================================== Author: aland File: radiusd/src/main/radiusd.c; Revisions: 1.382 ===================================================== Log entries ===================================================== Description: Include file for prototypes Modified files: File: radiusd/src/main/radiusd.c; Revision: 1.382; Date: 2007/12/02 08:17:59; Author: aland; Lines: (+3 -2) ===================================================== Summary of modified files ===================================================== File: radiusd/src/main/radiusd.c Revisions: 1.382 Authors: aland (+3 -2) -- Automatic cron job from /web/pages/us.freeradius.org/bin/new_makelog.pl

1 0

Automatic report from sources (radiusd) between 30.11.2007 - 01.12.2007 GMT
by Automatic cvs log generator 01 Dec '07

01 Dec '07

CVS log entries from 30.11.2007 (Fri) 09:00:00 - 01.12.2007 (Sat) 09:00:01 GMT ===================================================== Summary by authors ===================================================== Author: aland File: radiusd/config.sub; Revisions: 1.3.8.1.2.1 File: radiusd/config.guess; Revisions: 1.4.6.1.2.1 Author: nbk File: radiusd/raddb/radiusd.conf.in; Revisions: 1.257, 1.188.2.4.2.20 File: radiusd/man/man5/rlm_sql_log.5; Revisions: 1.3, 1.2.2.2 ===================================================== Combined list of identical log entries ===================================================== Description: Add an example of the option "sql_user_name" to the config of module "rlm_sql_log" so the users can notice its existence. Modified files: File: radiusd/man/man5/rlm_sql_log.5; Revision: 1.3; Date: 2007/12/01 00:28:10; Author: nbk; Lines: (+3 -1) File: radiusd/man/man5/rlm_sql_log.5; Revision: 1.2.2.2; Date: 2007/12/01 00:28:49; Author: nbk; Lines: (+3 -1) File: radiusd/raddb/radiusd.conf.in; Revision: 1.257; Date: 2007/12/01 00:28:09; Author: nbk; Lines: (+3 -2) File: radiusd/raddb/radiusd.conf.in; Revision: 1.188.2.4.2.20; Date: 2007/12/01 00:28:48; Author: nbk; Lines: (+3 -2) ------------------------------- Description: Pulled from GNU. This should fix bug #496 Modified files: File: radiusd/config.guess; Revision: 1.4.6.1.2.1; Date: 2007/11/30 23:02:54; Author: aland; Lines: (+355 -298) File: radiusd/config.sub; Revision: 1.3.8.1.2.1; Date: 2007/11/30 23:02:54; Author: aland; Lines: (+139 -58) ===================================================== Log entries ===================================================== ===================================================== Summary of modified files ===================================================== File: radiusd/config.guess Revisions: 1.4.6.1.2.1 Authors: aland (+355 -298) ------------------------------- File: radiusd/config.sub Revisions: 1.3.8.1.2.1 Authors: aland (+139 -58) ------------------------------- File: radiusd/man/man5/rlm_sql_log.5 Revisions: 1.3, 1.2.2.2 Authors: nbk (+3 -1), nbk (+3 -1) ------------------------------- File: radiusd/raddb/radiusd.conf.in Revisions: 1.257, 1.188.2.4.2.20 Authors: nbk (+3 -2), nbk (+3 -2) -- Automatic cron job from /web/pages/us.freeradius.org/bin/new_makelog.pl

1 0