February 2010 - Freeradius-Devel - lists.freeradius.org

[trivial PATCH 07/22] [log.c] eliminate build warnings
by Wang Tinggong 01 Feb '10

01 Feb '10

Signed-off-by: Wang Tinggong <wangtinggong(a)gmail.com> --- src/main/log.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/main/log.c b/src/main/log.c index 2786fa1..482b7a3 100644 --- a/src/main/log.c +++ b/src/main/log.c @@ -41,6 +41,8 @@ static int openlog_run = 0; static int can_update_log_fp = TRUE; static FILE *log_fp = NULL; +extern void force_log_reopen(void); + /* * Logging facility names */ -- 1.6.0.6

1 0

[trivial PATCH 06/22] [event.c] eliminate build warnings
by Wang Tinggong 01 Feb '10

01 Feb '10

Signed-off-by: Wang Tinggong <wangtinggong(a)gmail.com> --- src/main/event.c | 15 ++++++++++++++- 1 files changed, 14 insertions(+), 1 deletions(-) diff --git a/src/main/event.c b/src/main/event.c index 069b785..3faa023 100644 --- a/src/main/event.c +++ b/src/main/event.c @@ -46,6 +46,9 @@ extern int check_config; extern void force_log_reopen(void); extern char *debug_condition; +extern void revive_home_server(void *ctx); +extern void mark_home_server_dead(home_server *home, struct timeval *when); + /* * Ridiculous amounts of local state. */ @@ -1108,6 +1111,14 @@ static void no_response_to_proxied_request(void *ctx) ping_home_server(home); } } +#else +void revive_home_server(void *ctx) +{ +} + +void mark_home_server_dead(home_server *home, struct timeval *when) +{ +} #endif static void wait_a_bit(void *ctx) @@ -1179,7 +1190,9 @@ static void wait_a_bit(void *ctx) break; } - stop_processing: + /* + * stop_processing + */ #if defined(HAVE_PTHREAD_H) || defined(WITH_PROXY) /* * A child thread MAY still be running on the -- 1.6.0.6

1 0

[trivial PATCH 05/22] [evaluate.c] eliminate build warnings
by Wang Tinggong 01 Feb '10

01 Feb '10

Signed-off-by: Wang Tinggong <wangtinggong(a)gmail.com> --- src/main/evaluate.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/main/evaluate.c b/src/main/evaluate.c index 6fae2be..d213ba2 100644 --- a/src/main/evaluate.c +++ b/src/main/evaluate.c @@ -49,6 +49,8 @@ RCSID("$Id$") #ifdef WITH_UNLANG +extern int radius_get_vp(REQUEST *request, const char *name, VALUE_PAIR **vp_p); + static int all_digits(const char *string) { const char *p = string; -- 1.6.0.6

1 0

[trivial PATCH 04/22] [print.c] eliminate build warnings
by Wang Tinggong 01 Feb '10

01 Feb '10

Signed-off-by: Wang Tinggong <wangtinggong(a)gmail.com> --- src/lib/print.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/lib/print.c b/src/lib/print.c index e122a74..fe7da1d 100644 --- a/src/lib/print.c +++ b/src/lib/print.c @@ -35,7 +35,7 @@ RCSID("$Id$") * Note that we don't care about the length of the input string, * because '\0' is an invalid UTF-8 character. */ -int fr_utf8_char(const uint8_t *str) +unsigned int fr_utf8_char(const uint8_t *str) { if (*str < 0x20) return 0; -- 1.6.0.6

1 0

[trivial PATCH 03/22] [packet.c] eliminate build warnings
by Wang Tinggong 01 Feb '10

01 Feb '10

Signed-off-by: Wang Tinggong <wangtinggong(a)gmail.com> --- src/lib/packet.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/src/lib/packet.c b/src/lib/packet.c index ffb4e4c..94352b5 100644 --- a/src/lib/packet.c +++ b/src/lib/packet.c @@ -655,7 +655,7 @@ int fr_packet_list_num_elements(fr_packet_list_t *pl) int fr_packet_list_id_alloc(fr_packet_list_t *pl, RADIUS_PACKET *request) { - int i, id, start, fd; + int i, id, start; int src_any = 0; uint32_t free_mask; fr_packet_dst2id_t my_pd, *pd; @@ -721,7 +721,6 @@ int fr_packet_list_id_alloc(fr_packet_list_t *pl, id = start = (int) fr_rand() & 0xff; while (pd->id[id] == pl->mask) { /* all sockets are using this ID */ - redo: id++; id &= 0xff; if (id == start) return 0; -- 1.6.0.6

1 0

[trivial PATCH 02/22] [event.c] eliminate build warnings
by Wang Tinggong 01 Feb '10

01 Feb '10

Signed-off-by: Wang Tinggong <wangtinggong(a)gmail.com> --- src/lib/event.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/lib/event.c b/src/lib/event.c index 84a928b..6f91661 100644 --- a/src/lib/event.c +++ b/src/lib/event.c @@ -322,13 +322,13 @@ int fr_event_loop(fr_event_list_t *el) el->exit = 0; el->dispatch = 1; el->changed = 1; + maxfd = 0; while (!el->exit) { /* * Cache the list of FD's to watch. */ if (el->changed) { - maxfd = 0; FD_ZERO(&master_fds); for (i = 0; i < el->max_readers; i++) { -- 1.6.0.6

1 0

git tree build error
by WANG Tinggong 01 Feb '10

01 Feb '10

hi all, i got the latest freeRadius tree from git://git.freeradius.org/freeradius-server.git , and i try to compile it under these steps: 1. ./configure 2. make after that, i encountered an error: In file included from /home/wtg/develop/freeradius-server/src/freeradius-devel/radiusd.h:154, from frs_acct.c:30: /home/wtg/develop/freeradius-server/src/freeradius-devel/smodule.h:146: error: expected specifier-qualifier-list before ‘fr_tcp_radius_t’ git-log says after commit e04b62, fr_tcp_radius_t structure and API are deleted, but it still stay in src/main/listen.c src/include/smodule.h is it a bug?

2 2

[PATCH] radiusd.h: fix error "expected specifier-qualifier-list before 'RADCLIENT' "
by Wang Tinggong 01 Feb '10

01 Feb '10

Signed-off-by: Wang Tinggong <wangtinggong(a)gmail.com> --- src/include/radiusd.h | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/src/include/radiusd.h b/src/include/radiusd.h index 8ec5bbb..486cbe0 100644 --- a/src/include/radiusd.h +++ b/src/include/radiusd.h @@ -104,9 +104,6 @@ typedef struct auth_req REQUEST; typedef struct radclient_list RADCLIENT_LIST; -#include <freeradius-devel/smodule.h> - - /* * See util.c */ @@ -153,6 +150,7 @@ typedef struct radclient { #endif } RADCLIENT; +#include <freeradius-devel/smodule.h> /* * For listening on multiple IP's and ports. -- 1.6.0.6

2 2

[PATCH] event.c: eliminate warning "‘maxfd’ may be used uninitialized"
by Wang Tinggong 01 Feb '10

01 Feb '10

Signed-off-by: Wang Tinggong <wangtinggong(a)gmail.com> --- src/lib/event.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/lib/event.c b/src/lib/event.c index 84a928b..6f91661 100644 --- a/src/lib/event.c +++ b/src/lib/event.c @@ -322,13 +322,13 @@ int fr_event_loop(fr_event_list_t *el) el->exit = 0; el->dispatch = 1; el->changed = 1; + maxfd = 0; while (!el->exit) { /* * Cache the list of FD's to watch. */ if (el->changed) { - maxfd = 0; FD_ZERO(&master_fds); for (i = 0; i < el->max_readers; i++) { -- 1.6.0.6

1 0