May 2011 - Freeradius-Devel - lists.freeradius.org

GIT Log for 2011-05-26 23:33 GMT
by aland＠deployingradius.com 26 May '11

26 May '11

commit af5034a66dccdb042a7187917e14770c9595ebf4 Author: Alan T. DeKok <aland(a)freeradius.org> Date: Thu May 26 13:59:10 2011 +0200 Bump buffer size for regex matches Files changed: src/main/evaluate.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) ====================================================================== commit 835fe07a60db9ecd83b5ef521330eb9c110210f3 Author: Alan T. DeKok <aland(a)freeradius.org> Date: Thu May 26 10:54:25 2011 +0200 Terminate string when using %{Attribute-Name[*]} Files changed: src/main/xlat.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) ======================================================================

1 0

Authenticate against group in AD and MySql DB
by bladan 26 May '11

26 May '11

Hi all. I have a solution where users are able to login to a wireless network with help of FreeRadius and MySql. The users resides in the MySql database. A customer would like to be able to authenticate users in a group in an Active Directory as well. So if a user login FreeRadius will first check if the user is part of the group in Active Directory and if not failover to MySql. If not present in MySql either the user will not be logged in. I'm not very good at FreeRadius because I've inheritated the solution. But as I understand it this should be possible. Could anyone confirm this and maybe also provide some input on how to set it up? The MySql authentication is already working. Thanks! Johan -- View this message in context: http://freeradius.1045715.n5.nabble.com/Authenticate-against-group-in-AD-an… Sent from the FreeRadius - Dev mailing list archive at Nabble.com.

1 0

freeradius2.1.10 crash @ request_stats_final
by winson 26 May '11

26 May '11

Hi, I am using freeradius 2.1.10 and it has crashed @ the following line (debug via gdb) of request_stats_final where in the macro is called for #define INC_ACCT(_x) radius_acct_stats._x++;request->listener->stats._x++;if (request->client && request->client->acct) request->client->acct->_x++ #0 0x0041fdc8 in request_stats_final (request=0x1907d10) at stats.c:122 #1 0x0042656c in ev_request_free (prequest=0x7ffa5ae8) at event.c:182 #2 0x00426b74 in wait_a_bit (ctx=<value optimized out>) at event.c:1310 #3 0x0042a594 in no_response_to_proxied_request (ctx=0x1907d10) at event.c:1086 #4 0x2aaf3938 in fr_event_run (el=0x18f2920, when=<value optimized out>) at event.c:220 #5 0x2aaf3c7c in fr_event_loop (el=0x18f2920) at event.c:399 #6 0x0041f7b8 in main (argc=2, argv=0x7ffa5f14) at radiusd.c:410 I have also merged the latest code changes present @ https://github.com/alandekok/freeradius-server/blob/master/src/main/stats.c and added few null checks (attached stats.c). though the crash has reoccurred. Please let me know if there is anything I am missing out as a fix for the crash. Also, Is there any specific reason why the /src/main/event.c file has been moved in the master dir ? Regards, Winson -- View this message in context: http://freeradius.1045715.n5.nabble.com/freeradius2-1-10-crash-request-stat… Sent from the FreeRadius - Dev mailing list archive at Nabble.com.

2 3

GIT Log for 2011-05-25 23:33 GMT
by aland＠deployingradius.com 25 May '11

25 May '11

commit b47a1d9b71452b50b5a6743b057cbfeefd82d2ff Author: Alan T. DeKok <aland(a)freeradius.org> Date: Wed May 25 14:56:02 2011 +0200 Fix API for 3.0 Files changed: src/modules/rlm_replicate/rlm_replicate.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) ====================================================================== commit cb999fbe9b3ccb64e42d1a92bb8e43f62bb6a9de Author: Alan T. DeKok <aland(a)freeradius.org> Date: Wed May 25 14:42:34 2011 +0200 Handle CHAP-Challenge Files changed: src/modules/rlm_replicate/rlm_replicate.c | 23 ++++++++++++++++++++++- 1 files changed, 22 insertions(+), 1 deletions(-) ====================================================================== commit afb64103d654e95076d889d0f909ad749e351105 Author: Alan T. DeKok <aland(a)freeradius.org> Date: Wed May 25 12:31:25 2011 +0200 Use rlm_redis CFLAGS and LDFLAGS This lets the module build Files changed: src/modules/rlm_rediswho/Makefile.in | 4 +- src/modules/rlm_rediswho/configure | 1500 ++++++++++++++++++++++++++++++++- src/modules/rlm_rediswho/configure.in | 114 +++- 3 files changed, 1599 insertions(+), 19 deletions(-) ====================================================================== commit 3ff4bea8dcd52936be0650ed53063b83cfd59cd0 Author: Alan T. DeKok <aland(a)freeradius.org> Date: Wed May 25 11:46:06 2011 +0200 Mark "replicate" as stable Files changed: src/modules/stable | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) ====================================================================== commit 23ad656957a4bb8206fc795c9666d58aac3ec516 Author: Alan T. DeKok <aland(a)freeradius.org> Date: Wed May 25 11:43:35 2011 +0200 Ensure AF for src IP matches AF for dst IP Files changed: src/main/realms.c | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-) ====================================================================== commit 2bfa67e32442d83d69b7124c49636252ef5e6c05 Author: Alan T. DeKok <aland(a)freeradius.org> Date: Wed May 25 11:43:12 2011 +0200 Make it build && work. Apparently infinite loops are bad. Who knew? Files changed: src/modules/rlm_replicate/rlm_replicate.c | 14 +++++++++----- 1 files changed, 9 insertions(+), 5 deletions(-) ====================================================================== commit 59b12ab7ce9eb31e3ee375f482bc3aec9ca98380 Author: Alan T. DeKok <aland(a)freeradius.org> Date: Wed May 25 10:52:35 2011 +0200 Make errors more prominent Files changed: src/main/xlat.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) ====================================================================== commit f680813db7f264a627ea147bc9d5b47ace062a99 Author: Alan T. DeKok <aland(a)freeradius.org> Date: Wed May 25 10:21:41 2011 +0200 Initial version of rlm_replicate Allows replication of packets (send without response), to multiple destinations. Files changed: raddb/modules/replicate | 40 ++++++ src/modules/rlm_replicate/Makefile | 11 ++ src/modules/rlm_replicate/rlm_replicate.c | 191 +++++++++++++++++++++++++++++ 3 files changed, 242 insertions(+), 0 deletions(-) ======================================================================

1 0

Error for mismatched brackets
by Brian Candler 25 May '11

25 May '11

We recently got caught with someone writing ++++? if ("%{request:Assigned-IP-Address)" !~ /./) instead of ++++? if ("%{request:Assigned-IP-Address}" !~ /./) I stared at it for ages but couldn't see the problem, until I put the server into debug mode and picked through it with a fine-toothed comb. Could I suggest these sort of syntactic bugs be bumped up to an ERROR rather than DEBUG, similar to commit 0dbd06ce ? Regards, Brian.

2 3

Dependency detection problem for rlm_rediswho
by Brian Candler 25 May '11

25 May '11

I am trying a ./configure --with-experimental-modules This stage completes successfully, but when I do 'make' it dies because it tries to build rlm_rediswho, even though hiredis.h is missing. ./configure did detect this correctly for rlm_redis, and set targetname to empty in the Makefile: === configuring in ./src/modules/rlm_redis (/u/home/brian/git/freeradius-server/./src/modules/rlm_redis) configure: running /bin/bash ./configure '--prefix=/usr/local' '--with-experimental-modules' '--enable-ltdl-install' --cache-file=/dev/null --srcdir=. checking for gcc... gcc checking for C compiler default output file name... a.out checking whether the C compiler works... yes checking whether we are cross compiling... no checking for suffix of executables... checking for suffix of object files... o checking whether we are using the GNU C compiler... yes checking whether gcc accepts -g... yes checking for gcc option to accept ISO C89... none needed checking for redisConnect in -lhiredis... no configure: WARNING: hiredis libraries not found. Use --with-redis-lib-dir=<path>. checking for hiredis.h... no configure: WARNING: hiredis headers not found. Use --with-redis-include-dir=<path>. configure: WARNING: silently not building rlm_redis. configure: WARNING: FAILURE: rlm_redis requires: libhiredis hiredis.h. configure: creating ./config.status config.status: creating Makefile But it didn't for rlm_rediswho: === configuring in ./src/modules/rlm_rediswho (/u/home/brian/git/freeradius-server/./src/modules/rlm_rediswho) configure: running /bin/bash ./configure '--prefix=/usr/local' '--with-experimental-modules' '--enable-ltdl-install' --cache-file=/dev/null --srcdir=. configure: creating ./config.status config.status: creating Makefile So I think the configure.in in rlm_rediswho needs expanding somehow. Whilst rlm_rediswho doesn't directly use hiredis.h, it does #include <rlm_redis.h> and that file has #include <hiredis/hiredis.h> I'm not sure of the best solution, short of duplicating the configure logic between rlm_redis and rlm_rediswho. For the moment, my workaround is: ./configure --with-experimental-modules --without-rlm_rediswho Regards, Brian. P.S. I notice that src/modules/stable contains "rlm_ns_mta_md5" but there appears to be no such module. Is this folded into rlm_pap now?

2 1

GIT Log for 2011-05-24 23:33 GMT
by aland＠deployingradius.com 24 May '11

24 May '11

commit 1575e242d9cf10172eb9a90c0bc73bdf72d1bafd Author: Alan T. DeKok <aland(a)freeradius.org> Date: Tue May 24 14:35:40 2011 +0200 This attribute is string. Closes #160 share/dictionary.3gpp2 | 10 +++++++++- 1 files changed, 9 insertions(+), 1 deletions(-)

1 0

expansion of %{client:shortname}
by Alan Buxey 24 May '11

24 May '11

hi, I know there have been discussions of this in the past - but I was doing some stuff today and came across something related thats already been mentioned but still appears to be absent if I use %{client:shortname} and my clients.conf contains shortname = blahblah then i get a string expansion in unlang of "blahblah" = good (and, in fact I can add any random line to the client stanza and it will work as per email from Alan some months back) = good however, If my clients are in SQL (postgresql or MySQL) then the expansion doesnt work, %{client:shortname} expands to "" what work needs to be done, or area of code explored for this expansion to work when the clients are in SQL? (i see from the startup in debg mode that the shortnames in the SQL are all read and noted...) many thanks alan

2 1

GIT Log for 2011-05-23 23:33 GMT
by aland＠deployingradius.com 23 May '11

23 May '11

commit 4c0d5e3474fc821e47645a21541326e9b7da1452 Author: Alan T. DeKok <aland(a)freeradius.org> Date: Mon May 23 16:06:50 2011 +0200 Print, parse, and encode, decode "long" attributes Files changed: src/include/radius.h | 2 + src/lib/print.c | 5 +++- src/lib/radius.c | 12 +++++++++- src/lib/valuepair.c | 52 +++++++++++++++++++++++++++++++++---------------- 4 files changed, 51 insertions(+), 20 deletions(-) ====================================================================== commit 3fae677915aead04b8e9ca53824d683438a32816 Author: Alexander Clouter <alex(a)digriz.org.uk> Date: Mon May 23 11:43:04 2011 +0100 debian/patches/dialupadmin-help.diff wrong filename 'dpkg-buildpackage -b -us -uc -rfakeroot' grumbles as the following file no longer exists. The patch fixes things, but it might be worth 'resync'ing as the large upstream Debian resync was Dec 2009 (5ed6809a). Signed-off-by: Alexander Clouter <alex(a)digriz.org.uk> Files changed: debian/patches/dialupadmin-help.diff | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) ====================================================================== commit 1ed057699787ffe64786d4f42fe72d8f6b2cfa9e Author: Alan T. DeKok <aland(a)freeradius.org> Date: Mon May 23 12:15:09 2011 +0200 Set limits on string/octet attributes Files changed: src/lib/valuepair.c | 12 +++++++++++- 1 files changed, 11 insertions(+), 1 deletions(-) ====================================================================== commit 2f61484e06dc17dc44788aae4c252d607aa53326 Author: Alan T. DeKok <aland(a)freeradius.org> Date: Mon May 23 11:32:44 2011 +0200 Added dependencies so "make attrs" will automagically make radattr Files changed: src/tests/Makefile | 8 +++++++- 1 files changed, 7 insertions(+), 1 deletions(-) ====================================================================== commit 3a33739872bf68276b5872807587e9e051903a26 Author: Alan T. DeKok <aland(a)freeradius.org> Date: Sat May 21 08:53:19 2011 +0200 Catch more corner cases Memory leak in esoteric circumstances. "long" data wasn't handled properly. Files changed: src/lib/radius.c | 26 ++++++++++++++++++++++++++ 1 files changed, 26 insertions(+), 0 deletions(-) ======================================================================

1 0

[PATCH] debian/patches/dialupadmin-help.diff wrong filename
by Alexander Clouter 23 May '11

23 May '11

'dpkg-buildpackage -b -us -uc -rfakeroot' grumbles as the following file no longer exists. The patch fixes things, but it might be worth 'resync'ing as the large upstream Debian resync was Dec 2009 (5ed6809a). Signed-off-by: Alexander Clouter <alex(a)digriz.org.uk> diff --git a/debian/patches/dialupadmin-help.diff b/debian/patches/dialupadmin-help.diff index a591d9e..a6a3965 100644 --- a/debian/patches/dialupadmin-help.diff +++ b/debian/patches/dialupadmin-help.diff @@ -1,8 +1,8 @@ ## 02-dialupadmin-help.dpatch by Mark Hymers <mark(a)hymers.org.uk> ## DP: Fix README location ---- old/dialup_admin/htdocs/help/help.php3 (revision 1519) -+++ new/dialup_admin/htdocs/help/help.php3 (working copy) +--- old/dialup_admin/htdocs/help/help.php (revision 1519) ++++ new/dialup_admin/htdocs/help/help.php (working copy) @@ -48,13 +48,13 @@ <?php $in_file = '';

2 1