October 2012 - Freeradius-Devel - lists.freeradius.org

rlm_cache locking (or not)
by Phil Mayers 27 Oct '12

27 Oct '12

On 26/10/12 15:34, Phil Mayers wrote: > I was about to say "that worked like a charm" then radiusd segfaulted :o( > > I'll try to get a core dump. > Ugh. Horrible pointer corruption; little useful in the backtrace I'm afraid, but the various pointers were invalid by stack frame #5 #0 0x000000357f630215 in raise () from /lib64/libc.so.6 #1 0x000000357f631cc0 in abort () from /lib64/libc.so.6 #2 0x000000357f66a7fb in __libc_message () from /lib64/libc.so.6 #3 0x000000357f671ce2 in _int_free () from /lib64/libc.so.6 #4 0x000000357f67590c in free () from /lib64/libc.so.6 #5 0x00002aaaad3444ac in cache_entry_free (data=0xc00aa0) at rlm_cache.c:77 #6 0x00000031bb212eac in rbtree_delete (tree=0xbd5530, Z=0xbfd050) at rbtree.c:412 #7 0x00000031bb21302b in rbtree_deletebydata (tree=0xbd5530, data=<value optimized out>) at rbtree.c:461 #8 0x00002aaaad344465 in cache_find (inst=0xbd4eb0, request=0x2aaab8001150, key=0x41e013c0 "172.16.250.14.Stop.508aa231/dc:2b:61:b0:cd:7c/653919") at rlm_cache.c:164 #9 0x00002aaaad344652 in cache_it (instance=0xbd4eb0, request=0x2aaab8001150) at rlm_cache.c:567 #10 0x000000000041c951 in call_modsingle (component=3, c=<value optimized out>, request=0x2aaab8001150) at modcall.c:304 Looking at the code, I'm not entirely sure it's thread-safe; I don't see any locking around anything. What's to stop cache_entry_free running at the same time as the node is being accessed in another thread? Or the rbtree being corrupted? I've had to roll the change back, so I can't give more details at the moment.

3 6

Commit report for master branch
by announce＠freeradius.org 26 Oct '12

26 Oct '12

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Use redis escape function Alan T. DeKok@2012-10-26T13:48:23Z Files modified: * src/modules/rlm_rediswho/rlm_rediswho.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/dc74102ca0d75b9e682a… ====== -- This commit summary was generated @2012-10-26T18:00:01Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

Commit report for v2.1.x branch
by announce＠freeradius.org 26 Oct '12

26 Oct '12

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Use redis escape function Alan T. DeKok@2012-10-26T13:46:05Z Files modified: * src/modules/rlm_rediswho/rlm_rediswho.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/6e8e5ab2510f999b68a9… ====== Note changes Alan T. DeKok@2012-10-26T10:34:23Z Files modified: * doc/ChangeLog Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/9e5960b55bc8755cff11… ====== Create threads as joinable, not detached. Stop and join all threads before detaching modules. This prevents a crash on exit where the modules are free'd before the threads stop using them. Iliya Peregoudov (via Alan T. DeKok)@2012-10-26T10:34:23Z Files modified: * src/include/radiusd.h * src/main/event.c * src/main/threads.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/fe2066fdf9d73c8dc53c… ====== -- This commit summary was generated @2012-10-26T18:00:01Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

Commit report for master branch
by announce＠freeradius.org 25 Oct '12

25 Oct '12

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Understand extended format attrs, too Alan T. DeKok@2012-10-25T14:04:23Z Files modified: * share/format.pl Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/35998cb0bfff03d9b203… ====== Create threads as joinable, not detached. Stop and join all threads before detaching modules. This prevents a crash on exit where the modules are free'd before the threads stop using them. Iliya Peregoudov (via Alan T. DeKok)@2012-10-25T14:04:23Z Files modified: * src/include/radiusd.h * src/main/process.c * src/main/threads.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/3758d9b1c7636571f323… ====== Add proxim dictionary Arran Cudbard-Bell@2012-10-25T11:53:55Z Files modified: * share/dictionary * share/dictionary.proxim Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/3a5534e09966af937372… ====== Pass correct arguments to memcpy Copying pointers means you pass a pointer to the pointer. Alan T. DeKok@2012-10-25T10:10:22Z Files modified: * src/modules/rlm_krb5/rlm_krb5.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/8829737fde77cbfd4677… ====== Merge branch 'master' of github.com:FreeRADIUS/freeradius-server Alan T. DeKok@2012-10-25T10:04:48Z Files modified: * raddb/policy.d/cui * src/modules/rlm_krb5/rlm_krb5.c * src/main/exec.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/ab4ab0c284b3b1754274… ====== -- This commit summary was generated @2012-10-25T18:00:01Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

Commit report for v2.1.x branch
by announce＠freeradius.org 25 Oct '12

25 Oct '12

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Add proxim dictionary Arran Cudbard-Bell@2012-10-25T11:55:30Z Files modified: * share/dictionary * share/dictionary.proxim Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/ea828e5d1e4734efd8ca… ====== Pass correct arguments to memcpy Copying pointers means you pass a pointer to the pointer. Alan T. DeKok (via Arran Cudbard-Bell)@2012-10-25T11:55:20Z Files modified: * src/modules/rlm_krb5/rlm_krb5.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/197af098df8c35689e9e… ====== -- This commit summary was generated @2012-10-25T18:00:01Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

Commit report for master branch
by announce＠freeradius.org 24 Oct '12

24 Oct '12

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Merge pull request #112 from armitasp/master Minor formatting fix. add_cui should be add-cui Arran Cudbard-Bell@2012-10-24T09:13:34Z Files modified: * raddb/policy.d/cui Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/c63f7d209bd5a3964465… ====== Minor formatting fix. add_cui should be add-cui Scott Armitage@2012-10-23T21:36:11Z Files modified: * raddb/policy.d/cui Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/00a7e0d4e51bfeab78d9… ====== -- This commit summary was generated @2012-10-24T18:00:01Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

SIGTERM -> SIGSEGV
by Stefan Winter 23 Oct '12

23 Oct '12

Hi, I believe this has been reported earlier and it's not very grave, but anyway: When shutting down the server normally, it will almost cleanly shut down, including "Exiting normally" in the logs, but will generate a SIGSEGV after that. So, something in the terminal cleanup seems wrong. It's not a big deal usually, because after all the process is going to die anyway. However, now with systemd, things are slightly different. systemd will watch over the return code of any PID under its responsibility and memorizes these return codes for later debugging by the admin. So these days, I'd appreciate if even during shutdown time, things are "clean". I looked through the shutdown in radiusd.c main() and spotted - I believe - two spots where things go wrong: - rcode is derived from a function, and can be an arbitrary number; and the process in the end returns rcode - 1. On failures it gets set to 2 (i.e. return 1) but on normal shutdown, it doesn't get set. I "fixed" the situation by adding a "rcode = 1" right after the "Exiting normally." This ensures that the process returns 0 once it gets to its return statement. - It never gets there; the SIGSEGV on my system is generated during the call to free_mainconfig(). Once comment that line out, I get a clean shutdown. I'm not sure this is a sane approach, it's rather a brute fix with the axe. Anyway, trivial patch below. --- freeradius-server-2.2.0/src/main/radiusd.c 2012-09-10 13:51:34.000000000 +0200 +++ freeradius-server-2.2.0-patched/src/main/radiusd.c 2012-10-12 10:14:02.136026913 +0200 @@ -416,6 +416,7 @@ rcode = 2; } else { radlog(L_INFO, "Exiting normally."); + rcode = 1; } /* @@ -448,7 +449,7 @@ /* * Free the configuration items. */ - free_mainconfig(); + /* free_mainconfig(); */ /* * Detach any modules. Greetings, Stefan Winter -- Stefan WINTER Ingenieur de Recherche Fondation RESTENA - Réseau Téléinformatique de l'Education Nationale et de la Recherche 6, rue Richard Coudenhove-Kalergi L-1359 Luxembourg Tel: +352 424409 1 Fax: +352 422473

3 4

Commit report for v2.1.x branch
by announce＠freeradius.org 23 Oct '12

23 Oct '12

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== More formatting fixes Arran Cudbard-Bell@2012-10-23T15:18:42Z Files modified: * src/modules/rlm_krb5/rlm_krb5.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/311b8c1537825d184977… ====== Improve Kerberos support when using Heimdal - Allow specifying a keytab location - Improved logging Patch obtained from Thomas Kula <kula(a)tproa.net> - Fix krb_auth parameters/casting - Use strlcpy() instead of strncpy() - Fix style issues Ryan Steinmetz (via Arran Cudbard-Bell)@2012-10-23T15:18:31Z Files modified: * src/modules/rlm_krb5/rlm_krb5.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/3864f83d95c48b4e14f6… ====== -- This commit summary was generated @2012-10-23T18:00:01Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

Commit report for master branch
by announce＠freeradius.org 23 Oct '12

23 Oct '12

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== More formatting fixes Arran Cudbard-Bell@2012-10-23T15:16:53Z Files modified: * src/modules/rlm_krb5/rlm_krb5.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/d86daa9e572c86f3f5e2… ====== Improve Kerberos support when using Heimdal - Allow specifying a keytab location - Improved logging Patch obtained from Thomas Kula <kula(a)tproa.net> - Fix krb_auth parameters/casting - Use strlcpy() instead of strncpy() - Fix style issues Ryan Steinmetz (via Arran Cudbard-Bell)@2012-10-23T13:38:44Z Files modified: * src/modules/rlm_krb5/rlm_krb5.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/63de016e22e1d14cbc1f… ====== -- This commit summary was generated @2012-10-23T18:00:01Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

Re: segfault
by Alan Buxey 23 Oct '12

23 Oct '12

debug log please (and upgrade, 2.1.10 is old and buggy...and has a security issue) alan

1 0