October 2013 - Freeradius-Devel - lists.freeradius.org

Commit report for v2.x.x branch
by announce＠freeradius.org 24 Oct '13

24 Oct '13

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Fix typo in version.c Arran Cudbard-Bell@2013-10-24T18:07:25Z Files modified: * src/main/version.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/602d7a0295a7188c0f55… ====== Ignore dSYM extension Arran Cudbard-Bell@2013-10-24T18:06:43Z Files modified: * .gitignore Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/5eede34b7ff42129152a… ====== Ignore sw_vers subversion when selecting SDK Arran Cudbard-Bell@2013-10-24T17:18:19Z Files modified: * configure * configure.in Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/5c77c6603234abab3253… ====== Fix clang build under mavericks (OSX 10.9) Arran Cudbard-Bell@2013-10-24T00:30:09Z Files modified: * configure * configure.in Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/f58847f2ddb5c47bdf9a… ====== -- This commit summary was generated @2013-10-25T00:00:02Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

Commit report for master branch
by announce＠freeradius.org 24 Oct '13

24 Oct '13

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Slightly better fix for determining staged library location Arran Cudbard-Bell@2013-10-24T20:49:56Z Files modified: * Makefile * scripts/jlibtool.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/48d68f81510096d610da… ====== Typo Arran Cudbard-Bell@2013-10-24T18:47:00Z Files modified: * scripts/jlibtool.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/b0319d3f93a8a0b4d16c… ====== Fix typo in version.c Arran Cudbard-Bell@2013-10-24T18:35:08Z Files modified: * src/main/version.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/cd1646808389feed11c6… ====== Fix some jlibtool warnings Arran Cudbard-Bell@2013-10-24T18:35:08Z Files modified: * scripts/jlibtool.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/6465f8dc1992479b01c7… ====== Fix sdk name for OSX < 10.9 and most likely > 10.9 Add dependency for freeradius-devel to jlibtool Arran Cudbard-Bell@2013-10-24T16:20:22Z Files modified: * configure * configure.ac * scripts/libtool.mk Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/14195da19610b22bd9a4… ====== Fix, sanitize, and tidy the logic around return codes in rlm_sql Arran Cudbard-Bell@2013-10-24T00:15:42Z Files modified: * src/main/valuepair.c * src/modules/rlm_sql/rlm_sql.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/386313a1fe0b0486fcc7… ====== Fix clang build under mavericks (OSX 10.9) Arran Cudbard-Bell@2013-10-24T00:15:42Z Files modified: * configure * configure.ac * scripts/jlibtool.c * scripts/libtool.mk Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/1471d5af1b9879ab0c31… ====== -- This commit summary was generated @2013-10-25T00:00:02Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

OSX 10.9 Mavericks
by Arran Cudbard-Bell 23 Oct '13

23 Oct '13

Now builds, despite Apple gutting /usr/include and /usr/lib. It’ll default to the version of the SDK appropriate for your OS, and should work OK with 3rd party clang and gcc (after the hacks that just went in). case "$host" in *-darwin*) dnl # dnl # The version of GCC apple ships with Mavericks works out of the dnl # box, and presumably selects the highest version SDK for OSX. dnl # AC_MSG_CHECKING([if cc is apple llvm]) if ! $CC --version 2>&1 | grep -I 'Apple LLVM' > /dev/null; then AC_MSG_RESULT(no) AC_CHECK_PROG(SW_VERS, sw_vers, yes, no) AC_CHECK_PROG(XCODEBUILD, xcodebuild, yes, no) if test "x$SW_VERS" = "xyes" && test "x$XCODEBUILD" = "xyes"; then AC_MSG_NOTICE([determining OSX SDK path]) osx_sdk_path=$(xcodebuild -version -sdk macosx$(sw_vers -productVersion) Path) AC_MSG_RESULT([$osx_sdk_path]) dnl # dnl # We need to export these, else the child configure scripts all fail dnl # their compiler checks. dnl # export CFLAGS="--sysroot=$osx_sdk_path $CFLAGS" export CPPFLAGS="--sysroot=$osx_sdk_path $CPPFLAGS" export LDFLAGS="-L$osx_sdk_path/usr/lib/ $LDFLAGS" fi else AC_MSG_RESULT(yes) fi ;; Mmm crunchy. Let me know if this breaks older OSX versions. Arran Cudbard-Bell <a.cudbardb(a)freeradius.org> FreeRADIUS Development Team

1 0

Commit report for master branch
by announce＠freeradius.org 23 Oct '13

23 Oct '13

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Set targetname="" if the module is disabled Alan T. DeKok@2013-10-23T23:09:52Z Files modified: * src/modules/rlm_ruby/configure * src/modules/rlm_ruby/configure.ac Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/9a2b87fb2109d20e8b26… ====== If we're not building a module, don't install examples Alan T. DeKok@2013-10-23T21:58:53Z Files modified: * src/modules/rlm_counter/all.mk.in * src/modules/rlm_perl/all.mk.in * src/modules/rlm_python/all.mk.in * src/modules/rlm_ruby/all.mk.in Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/028fc324466c1f20121a… ====== Only TCP packets should be non-blocking And then only if they don't have dedicated worker threads Alan T. DeKok@2013-10-23T17:15:42Z Files modified: * src/main/listen.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/f50802aa96e5f0b1995d… ====== UDP packets should be blocking by default. There's no benefit to making them non-blocking. Alan T. DeKok@2013-10-23T17:14:45Z Files modified: * src/lib/packet.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/b95bb46f04ea025d47bf… ====== recvfrom returns ssize_t, not size_t Alan T. DeKok@2013-10-23T17:14:22Z Files modified: * src/modules/proto_dhcp/dhcp.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/683b2ed48eda23a75ba8… ====== Fix error message for reply Alan T. DeKok@2013-10-23T17:12:50Z Files modified: * src/modules/proto_dhcp/dhcpclient.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/211f9cb7a85918a9cb1a… ====== Encode correct fields (ether, not octets) Alan T. DeKok@2013-10-23T17:12:49Z Files modified: * src/modules/proto_dhcp/dhcp.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/5b5967ed6df79ba070fd… ====== Encode the reply, not the packet Alan T. DeKok@2013-10-23T17:12:47Z Files modified: * src/modules/proto_dhcp/dhcpd.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/4a44ee41cfe9ba4b862c… ====== Fix paircursor bugs Alan T. DeKok@2013-10-23T17:12:46Z Files modified: * src/modules/proto_dhcp/dhcp.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/014ccd9553d4035f4ca3… ====== Default to recvfrom if we dont have IPv6_RECVPKTINFO Arran Cudbard-Bell@2013-10-23T14:23:40Z Files modified: * src/lib/udpfromto.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/57d2b3782f4e2e40b643… ====== -- This commit summary was generated @2013-10-24T00:00:01Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

Commit report for v3.0.x branch
by announce＠freeradius.org 23 Oct '13

23 Oct '13

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Set targetname="" if the module is disabled Alan T. DeKok@2013-10-23T23:09:39Z Files modified: * src/modules/rlm_ruby/configure * src/modules/rlm_ruby/configure.ac Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/40cfe2ca41992a7c1d88… ====== If we're not building a module, don't install examples Alan T. DeKok@2013-10-23T21:57:28Z Files modified: * src/modules/rlm_counter/all.mk.in * src/modules/rlm_perl/all.mk.in * src/modules/rlm_python/all.mk.in * src/modules/rlm_ruby/all.mk.in Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/7dfbd77ffb55bb4be25b… ====== Only TCP packets should be non-blocking And then only if they don't have dedicated worker threads Alan T. DeKok@2013-10-23T17:12:11Z Files modified: * src/main/listen.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/e4ff607e82662d338915… ====== UDP packets should be blocking by default. There's no benefit to making them non-blocking. Alan T. DeKok@2013-10-23T17:11:44Z Files modified: * src/lib/packet.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/d6333bc399f45c7158e6… ====== recvfrom returns ssize_t, not size_t Alan T. DeKok@2013-10-23T17:02:09Z Files modified: * src/modules/proto_dhcp/dhcp.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/910699ebe032a7b05123… ====== Fix error message for reply Alan T. DeKok@2013-10-23T16:53:22Z Files modified: * src/modules/proto_dhcp/dhcpclient.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/443bdeab547cdc0b9fae… ====== Encode correct fields (ether, not octets) Alan T. DeKok@2013-10-23T16:50:13Z Files modified: * src/modules/proto_dhcp/dhcp.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/03d1e8f693afa8861cac… ====== Encode the reply, not the packet Alan T. DeKok@2013-10-23T16:50:13Z Files modified: * src/modules/proto_dhcp/dhcpd.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/82dc18e670985c720b73… ====== Fix paircursor bugs Alan T. DeKok@2013-10-23T16:50:13Z Files modified: * src/modules/proto_dhcp/dhcp.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/b76654ee34de5688a6ae… ====== Update gitignore to ignore analyzer output Arran Cudbard-Bell@2013-10-23T14:24:30Z Files modified: * .gitignore Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/06e20c347421f3067735… ====== Default to recvfrom if we dont have IPv6_RECVPKTINFO Arran Cudbard-Bell@2013-10-23T14:24:26Z Files modified: * src/lib/udpfromto.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/056739e90296d7d3c45c… ====== -- This commit summary was generated @2013-10-24T00:00:01Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

Commit report for v2.x.x branch
by announce＠freeradius.org 23 Oct '13

23 Oct '13

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== recvfrom returns ssize_t, not size_t Alan T. DeKok@2013-10-23T17:18:36Z Files modified: * src/lib/dhcp.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/f7e91726f336dbd1253e… ====== -- This commit summary was generated @2013-10-24T00:00:01Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

Commit report for v2.x.x branch
by announce＠freeradius.org 21 Oct '13

21 Oct '13

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Restore old behavior for if(...) Manual pull of 4c389d44 Alan T. DeKok@2013-10-21T15:07:11Z Files modified: * src/main/modcall.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/3a07b030a873a2a86385… ====== -- This commit summary was generated @2013-10-22T00:00:02Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

Commit report for master branch
by announce＠freeradius.org 21 Oct '13

21 Oct '13

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Update gitignore to ignore analyzer output Arran Cudbard-Bell@2013-10-21T16:06:05Z Files modified: * .gitignore Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/c0b7dc470a9b8abcc3b3… ====== Use consistent variable names, write directly to output buffer in vp_prints_value to avoid unnecessary strcpy. Arran Cudbard-Bell@2013-10-21T16:06:05Z Files modified: * src/include/libradius.h * src/lib/filters.c * src/lib/print.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/6ab68d22c3dbf56d2fc2… ====== Document timeout here, too Alan T. DeKok@2013-10-21T15:05:56Z Files modified: * raddb/mods-available/exec Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/436fd0cd54d8cf2f0bb9… ====== Merge pull request #451 from philmayers/fix-if-modreturn Restore most-recent return code match in if()/elsif() Alan DeKok@2013-10-21T15:04:37Z Files modified: * src/main/modcall.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/80723b4853cc5d468fa2… ====== Restore most-recent return code match in if()/elsif() This puts the old behaviour back of matching the most recent return code, not the highest priority one. Phil Mayers@2013-10-14T18:31:15Z Files modified: * src/main/modcall.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/51c4341951f60d10e3f3… ====== -- This commit summary was generated @2013-10-22T00:00:02Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

Commit report for v3.0.x branch
by announce＠freeradius.org 21 Oct '13

21 Oct '13

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Restore most-recent return code match in if()/elsif() This puts the old behaviour back of matching the most recent return code, not the highest priority one. Phil Mayers (via Alan T. DeKok)@2013-10-21T15:05:12Z Files modified: * src/main/modcall.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/4c389d4411d02bfc53c1… ====== -- This commit summary was generated @2013-10-22T00:00:02Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

Module return codes
by Phil Mayers 21 Oct '13

21 Oct '13

Where did we get with this? At the moment, I can't proceed with a migration to 3.x in the absence of last return code, and I don't want to use my local patch if it's not going upstream. It doesn't look easy to do this with an xlat; the "last" return code only exists as local variable(s) in modcall_* functions, so we'd need to grow the request object to store it. Even the highest-prio code only exists on the relevant modcall_stack_entry_t struct, and an xlat has no easy way to know the position in the modcall stack/tree. I would appreciate a steer; we have serious problems with load spikes and time spent on this in 2.x is wasted IMO, so I need to get onto 3.x and then tackle the problem.

2 1