November 2013 - Freeradius-Devel - lists.freeradius.org

Commit report for v3.0.x branch
by announce＠freeradius.org 26 Nov '13

26 Nov '13

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Add note about access attribute 'false' value Arran Cudbard-Bell@2013-11-26T18:30:43Z Files modified: * raddb/mods-available/ldap Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/352dd5ad2f4725497f58… ====== Process attribute maps if we just have a generic attribute set Arran Cudbard-Bell@2013-11-26T18:18:59Z Files modified: * src/lib/valuepair.c * src/modules/rlm_ldap/rlm_ldap.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/785d43872b2bc9a7734e… ====== Use the map functions to parse VALUE_PAIR string tuples Arran Cudbard-Bell@2013-11-26T18:18:59Z Files modified: * src/include/libradius.h * src/include/radiusd.h * src/main/valuepair.c * src/modules/rlm_ldap/attrmap.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/e938e21db11db4cd1a29… ====== Formatting Arran Cudbard-Bell@2013-11-26T18:18:59Z Files modified: * src/modules/rlm_ldap/edir.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/66c25980a58a0d014493… ====== attribute with value 'false' always negates result of LDAP access_check Arran Cudbard-Bell@2013-11-26T18:18:59Z Files modified: * src/modules/rlm_ldap/ldap.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/4881d90172fc420d3da7… ====== Run tests only when doing "make test" Alan T. DeKok@2013-11-26T17:08:18Z Files modified: * Makefile * src/tests/keywords/all.mk * src/tests/unit/all.mk Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/df63036b04edf3d97e48… ====== Ensure that "break" can only occur in "foreach" sections Alan T. DeKok@2013-11-26T17:03:11Z Files modified: * src/main/modcall.c * src/tests/keywords/break-error Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/f24d68ed6782d561c5a3… ====== Ensure we only grab one error message Alan T. DeKok@2013-11-26T17:02:34Z Files modified: * src/tests/keywords/all.mk Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/398ac6b23ce0d4fdc770… ====== Make "break" jump out of the "foreach" loop and add a test to that effect! Alan T. DeKok@2013-11-26T16:49:29Z Files modified: * src/main/modcall.c * src/tests/keywords/foreach-break * src/tests/keywords/foreach-break.attrs Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/05585f5a37f86d19aa1b… ====== Print input VPs to the log Alan T. DeKok@2013-11-26T16:31:31Z Files modified: * src/main/unittest.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/0076edefee60bf5cf1b6… ====== Simple tests for parse errors Alan T. DeKok@2013-11-26T15:54:49Z Files modified: * src/tests/keywords/all.mk * src/tests/keywords/update-error * src/tests/keywords/update-error-2 Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/5a27e7a68862a1eafaef… ====== >From extreme Alan T. DeKok@2013-11-26T14:52:35Z Files modified: * share/dictionary.extreme Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/b6acbdae469e24233b16… ====== -- This commit summary was generated @2013-11-27T00:00:01Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

Commit report for master branch
by announce＠freeradius.org 26 Nov '13

26 Nov '13

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Add note about access attribute 'false' value Arran Cudbard-Bell@2013-11-26T18:30:14Z Files modified: * raddb/mods-available/ldap Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/62f9e9079eb2156cf29b… ====== Process attribute maps if we just have a generic attribute set Arran Cudbard-Bell@2013-11-26T18:19:19Z Files modified: * src/lib/valuepair.c * src/modules/rlm_ldap/rlm_ldap.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/3f72f74e0a1d2ab1d186… ====== Use the map functions to parse VALUE_PAIR string tuples Arran Cudbard-Bell@2013-11-26T18:19:19Z Files modified: * src/include/libradius.h * src/include/radiusd.h * src/main/valuepair.c * src/modules/rlm_ldap/attrmap.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/24b6e16e7c7a313dbcd1… ====== Formatting Arran Cudbard-Bell@2013-11-26T18:19:19Z Files modified: * src/modules/rlm_ldap/edir.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/4c62c37b0b7953e72d89… ====== attribute with value 'false' always negates result of LDAP access_check Arran Cudbard-Bell@2013-11-26T18:19:19Z Files modified: * src/modules/rlm_ldap/ldap.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/d1c8edf071f09a727a6d… ====== Run tests only when doing "make test" Alan T. DeKok@2013-11-26T17:11:57Z Files modified: * Makefile * src/tests/keywords/all.mk * src/tests/unit/all.mk Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/d1ddd264926cdd528897… ====== Ensure that "break" can only occur in "foreach" sections Alan T. DeKok@2013-11-26T17:11:55Z Files modified: * src/main/modcall.c * src/tests/keywords/break-error Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/bf05a210fcda9032694f… ====== Ensure we only grab one error message Alan T. DeKok@2013-11-26T17:11:54Z Files modified: * src/tests/keywords/all.mk Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/43b18b7df20c4dcb1fef… ====== Make "break" jump out of the "foreach" loop and add a test to that effect! Alan T. DeKok@2013-11-26T17:11:53Z Files modified: * src/main/modcall.c * src/tests/keywords/foreach-break * src/tests/keywords/foreach-break.attrs Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/e3efcd13bce73e446943… ====== Print input VPs to the log Alan T. DeKok@2013-11-26T17:11:29Z Files modified: * src/main/unittest.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/d3c1098c3514aa0a3b1f… ====== Simple tests for parse errors Alan T. DeKok@2013-11-26T17:08:50Z Files modified: * src/tests/keywords/all.mk * src/tests/keywords/update-error * src/tests/keywords/update-error-2 Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/6b2fe7acb6a748afdd9b… ====== >From extreme Alan T. DeKok@2013-11-26T14:52:46Z Files modified: * share/dictionary.extreme Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/3ec510bd674fdaec0df5… ====== -- This commit summary was generated @2013-11-27T00:00:01Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

Commit report for v2.x.x branch
by announce＠freeradius.org 26 Nov '13

26 Nov '13

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== >From extreme Alan T. DeKok@2013-11-26T14:52:20Z Files modified: * share/dictionary.extreme Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/14b4485b467c5bb8a932… ====== -- This commit summary was generated @2013-11-27T00:00:01Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

FR 2.2.1 rlm_sqlippool / mysql 5.5.31 - deadlocks
by George Chelidze 26 Nov '13

26 Nov '13

Hello, I have recently switched from ippool to sqlippool. I decided to use Calling-Station-Id as a pool-key: pool-key = "%{Calling-Station-Id}" related queries in sqlippool.conf: allocate-find = "SELECT framedipaddress FROM ${ippool_table} WHERE pool_name = '%{control:Pool-Name}' AND expiry_time IS NULL ORDER BY RAND() LIMIT 1 FOR UPDATE" allocate-update = "UPDATE ${ippool_table} SET nasipaddress = '%{NAS-IP-Address}', pool_key = '${pool-key}', expiry_time = NOW() + INTERVAL ${lease-duration} SECOND WHERE framedipaddress = '%I' AND expiry_time IS NULL" allocate-clear = "UPDATE ${ippool_table} SET nasipaddress = '', pool_key = 0, expiry_time = NULL WHERE expiry_time <= NOW() - INTERVAL 1 SECOND" and radippool table structure: CREATE TABLE `radippool` ( `id` int(11) NOT NULL AUTO_INCREMENT, `pool_name` varchar(30) NOT NULL, `framedipaddress` varchar(15) NOT NULL DEFAULT '', `nasipaddress` varchar(15) NOT NULL DEFAULT '', `expiry_time` datetime DEFAULT NULL, `pool_key` varchar(30) NOT NULL, PRIMARY KEY (`id`), KEY `radippool_poolname_expire` (`pool_name`,`expiry_time`), KEY `framedipaddress` (`framedipaddress`), KEY `radippool_nasip_poolkey_ipaddress` (`nasipaddress`,`pool_key`,`framedipaddress`) ) ENGINE=InnoDB AUTO_INCREMENT=65025 DEFAULT CHARSET=latin1; At the first glance everything seemed to be fine, however after some time, I realized that there were a number of deadlocks every now and then. Attached you can sample outputs from "SHOW ENGINE INNODB STATUS" I have tried to lower the transaction isolation level to READ-COMMITED, but it didn't help. Investigating the source code for rlm_sqlippool brought me to an idea that moving "CLEAR" query to the distinct transaction can help, because I can't really see any good reason to keep it in the same transaction with "FIND". I have made required minor changes and gave it a try: for two days the server is running without a single deadlock. $ diff orig/rlm_sqlippool.c rlm_sqlippool.c 586a587,598 > * COMMIT > */ > sqlippool_command(data->allocate_commit, sqlsocket, instance, > request, (char *) NULL, 0); > > /* > * BEGIN > */ > sqlippool_command(data->allocate_begin, sqlsocket, data, request, > (char *) NULL, 0); > > /* $ uname -a Linux radius 3.2.0-4-amd64 #1 SMP Debian 3.2.51-1 x86_64 GNU/Linux $ mysql --version mysql Ver 14.14 Distrib 5.5.31, for debian-linux-gnu (x86_64) using readline 6.2 Best Regards, -- George Chelidze Software Developer Magticom Ltd.

4 6

How to modify rlm_example to implement a new eap-type authentication
by Michael kevin 25 Nov '13

25 Nov '13

Hi all, I followed the site http://wiki.freeradius.org/contributing/Modules2 I tried to modify rlm_example.c to implement a new eap-type authentication(eg something like eap-MD5). I read the above site several times, but I still do not know what I should do for"Comfiguring the Module"in the"Compiling Your Module" section on the above site. the above site said below: You need to make two modifications to the FreeRadius configuration files to add your rlm. First you need to create a module configuration file in the modules directory. See modules/rlm_example for a sample. The contents of the file should look something like: # xxx module xxx { host = "myhost" } This establishes the configuration parameters for the module. Each module gets a separate file. Next you need to add an entry in the appropriate instantiation section for xxx so that it will be called at the proper time. If you are only running one virtual server then you can use the default file in the sites-available directory. In that file you would add your module to the appropriate section. For example in this case: # Authorization. First preprocess (hints and huntgroups files), authorize { preprocess files xxx } Finally you need to check the sites-enabled/ directory and make sure there is a link to the sites-available/ file that includes your module. The link for "default" should already be present. As I konw now,there is two steps I need to do,but I still do not understand how to do them exactly. Can anybody help me or give me some suggestion?The more detailed the better!Thanks! Best regards!

1 0

Commit report for v3.0.x branch
by announce＠freeradius.org 25 Nov '13

25 Nov '13

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Ensure a one-way check Alan T. DeKok@2013-11-25T21:37:57Z Files modified: * src/modules/rlm_sqlippool/rlm_sqlippool.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/9a29cba563f4cfb00d8c… ====== Do allocate_clear no more than once per second To lower the load on the database. Alan T. DeKok@2013-11-25T21:26:30Z Files modified: * src/modules/rlm_sqlippool/rlm_sqlippool.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/5fe088b4a520c49b8c7c… ====== Put a separate transaction around allocate_clear to deal with MySQL issues. It reduces deadlocks Alan T. DeKok@2013-11-25T21:25:15Z Files modified: * src/modules/rlm_sqlippool/rlm_sqlippool.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/32051760a1326963dd9d… ====== -- This commit summary was generated @2013-11-26T00:00:02Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

Commit report for v2.x.x branch
by announce＠freeradius.org 25 Nov '13

25 Nov '13

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Ensure a one-way check Alan T. DeKok@2013-11-25T21:38:28Z Files modified: * src/modules/rlm_sqlippool/rlm_sqlippool.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/5929ccae94954dd85c8d… ====== Do allocate_clear no more than once per second To lowe the load on the database. Alan T. DeKok@2013-11-25T21:23:35Z Files modified: * src/modules/rlm_sqlippool/rlm_sqlippool.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/fd20157b947d19426d5e… ====== Put a separate transaction around allocate_clear to deal with MySQL issues. It reduces deadlocks Alan T. DeKok@2013-11-25T21:23:35Z Files modified: * src/modules/rlm_sqlippool/rlm_sqlippool.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/8b94c282daae3cd5c262… ====== -- This commit summary was generated @2013-11-26T00:00:02Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

Commit report for master branch
by announce＠freeradius.org 25 Nov '13

25 Nov '13

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Ensure a one-way check Alan T. DeKok@2013-11-25T21:38:55Z Files modified: * src/modules/rlm_sqlippool/rlm_sqlippool.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/31d8638235007a72097b… ====== Do allocate_clear no more than once per second To lower the load on the database. Alan T. DeKok@2013-11-25T21:27:04Z Files modified: * src/modules/rlm_sqlippool/rlm_sqlippool.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/1578f43f3bf10ad03a0a… ====== Put a separate transaction around allocate_clear to deal with MySQL issues. It reduces deadlocks Alan T. DeKok@2013-11-25T21:27:03Z Files modified: * src/modules/rlm_sqlippool/rlm_sqlippool.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/8b52f1361c9b8abe4d66… ====== -- This commit summary was generated @2013-11-26T00:00:02Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

Commit report for master branch
by announce＠freeradius.org 22 Nov '13

22 Nov '13

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Don't need debugging when we open a new TLS socket Alan T. DeKok@2013-11-22T16:12:36Z Files modified: * src/main/tls_listen.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/39650013dda81cc22dac… ====== Don't worry about threading when doing radiusd -C Manual merge of 539540 Alan T. DeKok@2013-11-22T15:53:01Z Files modified: * src/main/listen.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/276aed55c952df7053e6… ====== Fix the test. Fixes #480 Returns aren't recursive. See doc/configuration/configurable_failover.rst The "Handle accounting packets" line doesn't do "detail2" if "detail1" succeeds. However, it DOES do the "redundant" block immediately following the "group" which contains both "detail1" and "detail2" Alan T. DeKok (via Arran Cudbard-Bell)@2013-11-22T12:23:43Z Files modified: * src/tests/keywords/return-group Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/b1e19b3cca36336ec607… ====== Add return and return-group tests Arran Cudbard-Bell@2013-11-22T00:48:12Z Files modified: * src/tests/keywords/return * src/tests/keywords/return-group * src/tests/keywords/return-group.attrs * src/tests/keywords/return.attrs Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/6cb5a75e55e70572bbd5… ====== -- This commit summary was generated @2013-11-23T00:00:11Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

Commit report for v3.0.x branch
by announce＠freeradius.org 22 Nov '13

22 Nov '13

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Don't need debugging when we open a new TLS socket Alan T. DeKok@2013-11-22T16:12:17Z Files modified: * src/main/tls_listen.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/2edbf3637493b6bbb7b2… ====== Don't worry about threading when doing radiusd -C We're not opening sockets or starting threads, so the error message isn't necessary Alan T. DeKok@2013-11-22T15:50:26Z Files modified: * src/main/listen.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/539540fd2b7ff34cfaf4… ====== Fix the test. Fixes #480 Returns aren't recursive. See doc/configuration/configurable_failover.rst The "Handle accounting packets" line doesn't do "detail2" if "detail1" succeeds. However, it DOES do the "redundant" block immediately following the "group" which contains both "detail1" and "detail2" Alan T. DeKok@2013-11-22T04:30:05Z Files modified: * src/tests/keywords/return-group Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/075b76e6897c3c9b3a81… ====== Add return and return-group tests Arran Cudbard-Bell@2013-11-22T00:49:49Z Files modified: * src/tests/keywords/return * src/tests/keywords/return-group * src/tests/keywords/return-group.attrs * src/tests/keywords/return.attrs Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/91a3a61a65cd5c7bfc0e… ====== -- This commit summary was generated @2013-11-23T00:00:11Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0