June 2013 - Freeradius-Devel - lists.freeradius.org

rlm_sql: zero session length
by Josip Almasi 17 Jun '13

17 Jun '13

Hi all, I see rlm_sql complaining about stop packets with zero session length, and then just ignoring them. This misleading message actually tells that Acct-Session-Time = 0. And the code check for <= 0:) The RFC tells nothing about valid values for it, it simply states it's number of seconds. Well, these days we can do a lot in a second. I.e. we can perform a single HTTP GET, in order to download a MMS. And in that case, we get invalid radacct table, due to intentionally dropped records. Or, in VoIP, Acct-Session-Time of zero means a call was attempted, but was not accepted. (details are in another attribute) Or... anyway, it's not a big deal, though I'd rather have consistent radacct table. Why is this if statement there anyway, some buggy NASes? If so, why not just let user handle it in unlang? IMHO that needs to be removed, or if written for a good reason, made configurable. With rfc-compliant default:) Regards...

2 3

Commit report for master branch
by announce＠freeradius.org 16 Jun '13

16 Jun '13

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== If "epoch" shouldn't be set, remove it from the example config Alan T. DeKok@2013-06-16T15:51:09Z Files modified: * raddb/mods-available/cache Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/1337de235e509b5e587e… ====== It's OK if the string stops after the expansion. Fixes #310 Alan T. DeKok@2013-06-16T15:51:09Z Files modified: * src/main/xlat.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/cb05d2832f143e607bba… ====== more rlm_exec fixes don't constify argv pointers returned by rad_expand_xlat Arran Cudbard-Bell@2013-06-16T03:25:24Z Files modified: * src/include/radiusd.h * src/main/exec.c * src/main/util.c * src/modules/rlm_exec/rlm_exec.c * src/modules/rlm_redis/rlm_redis.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/23937185e629ff522fec… ====== -- This commit summary was generated @2013-06-17T00:00:02Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

Segfault in detail module
by Stelian Ionescu 16 Jun '13

16 Jun '13

Its configuration is detailfile = ${radacctdir}/detail/%{Client-IP-Address}-%Y%m%d.active detailperm = 0600 header = "%t" (24) Found Post-Proxy-Type Fail (24) # Executing group from file /etc/raddb/sites-enabled/default (24) group Fail { (24) - entering group Fail {...} LITERAL: /var/log/radius/radacct/detail/%{Client-IP-Address}-%Y%m%d.active LITERAL: /var/log/radius/radacct/detail/%{Client-IP-Address}-%Y%m%d.active --> %{Client-IP-Address}-%Y%m%d.active EXPANSION: %{Client-IP-Address}-%Y%m%d.active Looking for attribute name in Client-IP-Address LITERAL: -%Y%m%d.active PERCENT: -%Y%m%d.active --> Y LITERAL: %m%d.active PERCENT: %m%d.active --> m LITERAL: %d.active PERCENT: %d.active --> d LITERAL: .active xlat aprint 0 xlat aprint 3 expand attr Client-IP-Address --> '172.20.10.121' xlat aprint 0 xlat aprint 1 xlat aprint 1 xlat aprint 1 xlat aprint 0 (24) detail:linkem.com : expand: '/var/log/radius/radacct/detail/%{Client-IP-Address}-%Y%m%d.active' -> '/var/log/radius/radacct/detail/172.20.10.121-20130615.active' (24) detail:linkem.com : /var/log/radius/radacct/detail/%{Client-IP-Address}-%Y%m%d.active expands to /var/log/radius/radacct/detail/172.20.10.121-20130615.active LITERAL: %t PERCENT: %t --> t (24) ERROR: detail:linkem.com : %t Program received signal SIGSEGV, Segmentation fault. 0x00007ffff5f6e0ac in vfprintf () from /lib64/libc.so.6 Missing separate debuginfos, use: debuginfo-install freeradius-3.0.0-22.el6.x86_64 (gdb) bt full #0 0x00007ffff5f6e0ac in vfprintf () from /lib64/libc.so.6 No symbol table info available. #1 0x00007ffff6025a80 in __vsnprintf_chk () from /lib64/libc.so.6 No symbol table info available. #2 0x00007ffff6f8c403 in talloc_vasprintf () from /usr/lib64/libtalloc.so.2 No symbol table info available. #3 0x00007ffff75d2540 in module_failure_msg (request=0x99bfa0, fmt=0x7ffff75dffff "%.*s^ %s") at src/main/valuepair.c:1295 ap = {{gp_offset = 16, fp_offset = 48, overflow_arg_area = 0x7fffffffb070, reg_save_area = 0x7fffffffaf90}} p = <value optimized out> vp = 0x995fb0 #4 0x00007ffff75d9130 in xlat_tokenize_request (out=0x7fffffffb108, outlen=256, request=0x99bfa0, fmt=0x8b4e50 "%t", escape=0, escape_ctx=0x0) at src/main/xlat.c:1314 indent = 2 slen = -2 tokens = <value optimized out> error = 0x51a0e7ed <Address 0x51a0e7ed out of bounds> #5 xlat_expand (out=0x7fffffffb108, outlen=256, request=0x99bfa0, fmt=0x8b4e50 "%t", escape=0, escape_ctx=0x0) at src/main/xlat.c:1802 buff = <value optimized out> len = <value optimized out> node = 0x0 #6 0x00007ffff75d9303 in radius_xlat (out=0x7fffffffd140 "\200\067+\366\377\177", outlen=<value optimized out>, request=<value optimized out>, fmt=<value optimized out>, escape=<value optimized out>, ctx=<value optimized out>) at src/main/xlat.c:1835 No locals. #7 0x00007fffeffe56b3 in do_detail (instance=0x8b4cb0, request=0x99bfa0, packet=0x9ad500, compat=1) at src/modules/rlm_detail/rlm_detail.c:342 outfd = 21 timestamp = "\200\067+\366\377\177\000\000Y\331;\367\377\177\000\000\000\000\000\000\000\000\000\000\315y\371\365\377\177\000\000\320\326\377\377\377\177\000\000\200\067+\366\377\177\000\000`\330\377\377\377\177\000\000U\000\000\000\000\000\000\000p\330\377\377\377\177\000\000Y\331;\367\377\177\000\000\250\377\377\377\377\377\377\377N\244\366\365\377\177\000\000\030\000\000\000\060\000\000\000\000\325\377\377\377\177\000\000@\324\377\377\377\177\000\000\300\331\377\377\377\177\000\000\005\313\a\366\377\177\000\000\347\243\366\365\377\177\000\000\005\313\a\366\377\177\000\000\000\000\000\000\000\000\000\000P\327\377\377\377\177\000\000\347\243\366\365\377\177\000\000(\331;\367\377\177\000\000\000\000\000\000\000\000\000\000\001", '\000' <repeats 15 times>"\274, \327\377\377\377\177\000\000`\331\377\377\377\177\000\000P\332\377\377\377\177\000\000\366X\371\365\377\177\000\000\000\327\377\377\377\177\000\000\001\000\000\000\000\000\000" buffer = "/var/log/radius/radacct/detail/172.20.10.121-20130615.active\000\177\000\000\277\322\377\377\377\177\000\000\300\262\377\377\377\177\000\000\277\322\377\377\377\177\000\000\240\277\231\000\000\000\000\000\300\262\377\377\377\177\000\000\020\000\000\000\000\000\000\000\001", '\000' <repeats 15 times>, "\001\000\000\000\000\000\000\000\270\227]\367\377\177\000\000(\000\000\000\060\000\000\000\260\262\377\377\377\177\000\000\360\261\377\377\377\177\000\000\347\243\366\365\377\177\000\000JGD", '\000' <repeats 13 times>, "\030\000\000\000\000\000\000\000\034\277]\367\377\177\000\000\300\262\377\377\377\177\000\000\360\247\201\000\000\000\000\000\360@D\000\000\000\000\000@$+\366\377\177", '\000' <repeats 18 times>"\354, \267\377\377\377\177\000\000\b\270\377\377\377\177\000\000\024\000\000\000\000\000\000\000(\270"... p = <value optimized out> st = {st_dev = 140737488345440, st_ino = 10060898, st_nlink = 140737488345680, st_mode = 4126779614, st_uid = 32767, st_gid = 4294957408, __pad0 = 32767, st_rdev = 140737488345424, st_size = 85, st_blksize = 140737488345808, st_blocks = 140737343504710, st_atim = {tv_sec = 140737319969767, tv_nsec = 140737343504710}, st_mtim = {tv_sec = 0, tv_nsec = 4429803}, st_ctim = {tv_sec = 140737488345584, tv_nsec = 140733193388032}, __unused = { 140733193388032, 140737321093882, 140737488345616}} locked = 0 lock_count = 0 tv = {tv_sec = 1, tv_usec = 0} vp = <value optimized out> fsize = 0 fp = <value optimized out> gid = <value optimized out> grp = <value optimized out> endptr = 0x9af <Address 0x9af out of bounds> inst = 0x8b4cb0 #8 0x00007fffeffe5f1d in mod_post_proxy (instance=<value optimized out>, request=0x99bfa0) at src/modules/rlm_detail/rlm_detail.c:566 rcode = <value optimized out> -- Stelian Ionescu a.k.a. fe[nl]ix Quidquid latine dictum sit, altum videtur. http://common-lisp.net/project/iolib

3 3

Faulty acct_unique policy
by Stelian Ionescu 15 Jun '13

15 Jun '13

Using the default acct_unique policy from policy.d/accounting, I got this: (14) # Executing section preacct from file /etc/raddb/sites-enabled/default (14) group preacct { (14) - entering group preacct {...} (14) [preprocess] = ok (14) policy acct_unique { (14) - entering policy acct_unique {...} (14) ? if ("%{string:Class}" =~ /ai:([0-9a-f]{32})/i) LITERAL: %{string:Class} LITERAL: %{string:Class} --> %{string:Class} EXPANSION: %{string:Class} MOD: string --> LITERAL: Class} xlat aprint 2 xlat aprint 0 expand mod string --> 'Class' (14) ERROR: Evaluation of condition failed for some reason. (14) else else { (14) - entering else else {...} (14) update request { -- Stelian Ionescu a.k.a. fe[nl]ix Quidquid latine dictum sit, altum videtur. http://common-lisp.net/project/iolib

1 0

Commit report for master branch
by announce＠freeradius.org 14 Jun '13

14 Jun '13

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== other fix for rlm_exec Arran Cudbard-Bell@2013-06-14T20:08:32Z Files modified: * src/main/exec.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/5c6d909c4b167bbc0c9c… ====== Actually add the module failure msg Arran Cudbard-Bell@2013-06-14T19:05:15Z Files modified: * src/modules/rlm_exec/rlm_exec.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/6f5a53d4ff88960297b1… ====== Exec patch (from Alan D) Arran Cudbard-Bell@2013-06-14T18:01:26Z Files modified: * src/main/exec.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/c14c40a4a004ec6199df… ====== update function documentation Arran Cudbard-Bell@2013-06-14T18:01:26Z Files modified: * src/main/exec.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/93a2999462d9ab229b0c… ====== Don't require an input list, the program can be passed arguments Arran Cudbard-Bell@2013-06-14T18:01:26Z Files modified: * src/modules/rlm_exec/rlm_exec.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/5aaa917111295b12abe2… ====== Merge pull request #305 from skids/vpiter Fixes foreach and adds a test for it. Arran Cudbard-Bell@2013-06-14T07:43:31Z Files modified: * src/main/modcall.c * src/tests/Makefile * src/tests/config/test.conf * src/tests/vpiter Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/fda8d82b3e63ab148312… ====== Add missing file for test. Make test more greppable in src/test/radius.log. skids@2013-06-14T05:44:46Z Files modified: * src/tests/config/test.conf * src/tests/vpiter Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/6ff815640ea90ae07a7c… ====== Add QA test for foreach. skids@2013-06-14T05:34:50Z Files modified: * src/tests/Makefile * src/tests/config/test.conf Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/e0d2342ddd05d74efc4e… ====== Fix foreach modcall. It was spinning infinitely. skids@2013-06-14T05:32:19Z Files modified: * src/main/modcall.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/eee057bf98175a05a8d9… ====== -- This commit summary was generated @2013-06-15T00:00:08Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

3.0 SQL pooling question
by Phil Mayers 14 Jun '13

14 Jun '13

In 3.0, is there a way to consider a SQL connection dead if it returns a certain class of errors, then close and re-open it? We had a problem overnight with postgres and query-planner caching for long-lived connections. Since we "do ITIL" (sigh) I have to write the problem up and submit a "possible solutions". If 3.0 can handle that for us, I can put that down as a "planned" item.

3 4

Commit report for master branch
by announce＠freeradius.org 13 Jun '13

13 Jun '13

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Merge pull request #304 from olivierbeytrison/fr3-eduroam-hes Fix User-Name tolower expansion Alan DeKok@2013-06-13T17:00:48Z Files modified: * raddb/policy.d/cui Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/59fe3caca755e1dafc7a… ====== Fix User-Name tolower expansion Olivier Beytrison@2013-06-13T16:33:59Z Files modified: * raddb/policy.d/cui Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/90f7ec59e759e335b6cc… ====== Use SHA1 for CUI Arran Cudbard-Bell@2013-06-13T11:31:13Z Files modified: * raddb/policy.d/cui Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/d3add7ba2708dbeb5a1f… ====== -- This commit summary was generated @2013-06-14T00:00:02Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

Commit report for v2.x.x branch
by announce＠freeradius.org 13 Jun '13

13 Jun '13

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Fix digest size for sha1 Arran Cudbard-Bell@2013-06-13T11:26:05Z Files modified: * src/modules/rlm_expr/rlm_expr.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/9772b22a3392222b58dd… ====== -- This commit summary was generated @2013-06-14T00:00:02Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

Re: Exec problems in FR3.0
by Phil Mayers 13 Jun '13

13 Jun '13

On 13/06/13 17:14, Phil Mayers wrote: > On 13/06/13 16:24, Franks Andy (RLZ) IT Systems Engineer wrote: >> Sorry to send yet more emails with issues. I’ve moved to FR3 to test SQL >> stuff and am having some problems with getting exec modules I previously >> used to work. I know I could rewrite these in perl, but they worked >> before in FR2.2.1 and Iwant to solve why they won’t work now. > > Confirmed. Looks like a bug has crept into the exec code in HEAD: > > 28619 execve(0x6461202e2e2e2000, [0x6461202e2e2e2000, > 0x77656e20676e6964, 0x2074656b636f7320, 0x7325, 0x612064656c696146, > 0x727020676e696464, 0x6b636f732079786f, > 0x7325203a7465, 0x612064656c696146, 0x766520676e696464, > 0x646e616820746e65, 0x20726f662072656c, 0x2174656b636f73, > 0x7265206c61746146, 0x6565726620726f72, 0x636f > 7320676e697a, ...], [/* 2 vars */]) = -1 EFAULT (Bad address) > 28619 write(1, "\33[1m\33[33m(0) WARNING: myexec : F"..., 91) = 91 > > Will investigate. > Looks like this commit broke things: https://github.com/FreeRADIUS/freeradius-server/commit/4c3030db2743e682c58a… What's the rational for rad_expand_xlat having "const" on the argv input argument? Doesn't seem useful.

2 1

Commit report for master branch
by announce＠freeradius.org 12 Jun '13

12 Jun '13

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Latest set of updates Alan T. DeKok@2013-06-12T16:39:13Z Files modified: * doc/ChangeLog Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/7494597d03d11c8dc50d… ====== Fix typo Alan T. DeKok@2013-06-12T15:53:13Z Files modified: * src/lib/valuepair.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/9f2dd2b527e32df8bf15… ====== Allow most types to be assigned to an "octets" type Without the RADIUS header. This allows for potentially cute tricks with things. Alan T. DeKok@2013-06-12T15:15:01Z Files modified: * src/lib/valuepair.c * src/main/map.c * src/main/valuepair.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/2d6ae520ccbc106bf870… ====== Simple test for single-character expansion Alan T. DeKok@2013-06-12T15:14:43Z Files modified: * src/tests/xlat.txt Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/d834c855d0dce81d96ab… ====== Fix typos Alan T. DeKok@2013-06-12T15:14:18Z Files modified: * src/lib/dict.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/71c7535949bdecf08f03… ====== -- This commit summary was generated @2013-06-13T00:00:02Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0