March 2014 - Freeradius-Devel - lists.freeradius.org

Commit report for master branch
by announce＠freeradius.org 12 Mar '14

12 Mar '14

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Formatting and extra debugging in rlm_attr_filter Arran Cudbard-Bell@2014-03-12T23:11:24Z Files modified: * src/modules/rlm_attr_filter/rlm_attr_filter.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/951c07100cd77c7444ba… ====== Compare da not just attribute number (fix clashing vendor and RFC space attributes) Arran Cudbard-Bell@2014-03-12T23:11:24Z Files modified: * src/modules/rlm_attr_filter/rlm_attr_filter.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/9a754f821655b3968b74… ====== Fix typos Alan T. DeKok@2014-03-12T22:37:26Z Files modified: * share/dictionary.cisco.vpn3000 Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/ce35f709cc186a36eab8… ====== Re-arrange normalization code in parser also make map return a valid map, no matter what the operator having hacks in the map parser to deal with =* and ~* is wrong Alan T. DeKok@2014-03-12T19:36:01Z Files modified: * src/main/map.c * src/main/parser.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/fc2ec9ca76a4150eed7c… ====== Print out more information with -xx Alan T. DeKok@2014-03-12T19:36:00Z Files modified: * src/main/radattr.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/b9ec7d4fe88761cd4978… ====== Normalize literals in conditions if ('') is false if ("foo") is true if (bar) is invalid, as the condition needs to be a module rcode Alan T. DeKok@2014-03-12T19:35:58Z Files modified: * src/main/parser.c * src/tests/unit/condition.txt Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/39f978c6e24dff19111d… ====== Updated example Alan T. DeKok@2014-03-12T19:35:57Z Files modified: * raddb/mods-available/passwd Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/d064da3225cc733a23ca… ====== dhcp config comments about mac2ip Matthew Newton (via Arran Cudbard-Bell)@2014-03-12T17:57:04Z Files modified: * raddb/sites-available/dhcp Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/9ca33ad8fb95e5b3487a… ====== add comments about dhcp listen section Matthew Newton (via Arran Cudbard-Bell)@2014-03-12T17:57:01Z Files modified: * raddb/sites-available/dhcp Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/705e666873a9dfe09a7b… ====== add DHCP-Do-Not-Respond value to make it easier to not respond Matthew Newton (via Arran Cudbard-Bell)@2014-03-12T17:55:14Z Files modified: * raddb/sites-available/dhcp * share/dictionary.dhcp Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/72321852e77b0df8ef6f… ====== add some dhcp comment documentation Matthew Newton (via Arran Cudbard-Bell)@2014-03-12T17:55:11Z Files modified: * raddb/sites-available/dhcp Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/06f536b7a34c552d3953… ====== don't respond to dhcp if there is nowhere to respond to Matthew Newton (via Arran Cudbard-Bell)@2014-03-12T17:54:53Z Files modified: * src/modules/proto_dhcp/dhcpd.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/0f5b4a5d36976a838cf7… ====== Allow sorting with a comparator Arran Cudbard-Bell@2014-03-12T11:21:06Z Files modified: * src/include/libradius.h * src/lib/valuepair.c * src/main/radsniff.c * src/modules/rlm_rest/rest.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/01ab242c413aff478464… ====== Rename one/two to a/b in pair comparison functions to be consistent Arran Cudbard-Bell@2014-03-12T11:10:36Z Files modified: * src/include/libradius.h * src/lib/valuepair.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/786673eb4d35256d3412… ====== Minor formatting in dhcp.c Arran Cudbard-Bell@2014-03-12T10:16:46Z Files modified: * src/modules/proto_dhcp/dhcp.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/5e2fa41d6311c21a0e0a… ====== Space for clarity Alan T. DeKok (via Arran Cudbard-Bell)@2014-03-12T07:28:53Z Files modified: * src/main/conffile.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/c32d2b643b991532891a… ====== Clarify comment Alan T. DeKok (via Arran Cudbard-Bell)@2014-03-12T07:28:49Z Files modified: * src/main/map.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/475804ee5ba8c6e8b5e3… ====== Load protocol-specific dictionaries if built with them. The code in parser.c does static evaluation of things like if (DHCP-foo == ...) When the DHCP dictionaries aren't loaded, that turns into static comparison of two strings, which is always false. Changing it to if (&DHCP-foo == ...) makes it bail with an unknown attribute error. This is because we don't have pass2 fixups for that case. Alan T. DeKok (via Arran Cudbard-Bell)@2014-03-12T07:28:46Z Files modified: * src/main/mainconfig.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/69b0ddc042b9f91ce71d… ====== Clarify error message Alan T. DeKok (via Arran Cudbard-Bell)@2014-03-12T07:28:42Z Files modified: * src/main/parser.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/1d4b8eda47bf22411b64… ====== More debugging for evaluation protected by a #ifdef, so normal people don't see it Alan T. DeKok (via Arran Cudbard-Bell)@2014-03-12T07:28:38Z Files modified: * src/main/evaluate.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/eb737f0e87288590b98b… ====== -- This commit summary was generated @2014-03-13T00:00:14Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

Commit report for v2.x.x branch
by announce＠freeradius.org 12 Mar '14

12 Mar '14

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Fix typo Alan T. DeKok@2014-03-12T23:06:04Z Files modified: * raddb/modules/unix Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/ca1293626da9e727aa4a… ====== Fix typos Alan T. DeKok@2014-03-12T22:36:55Z Files modified: * share/dictionary.cisco.vpn3000 Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/70a939194018246b66c0… ====== Update example text Alan T. DeKok@2014-03-12T16:03:15Z Files modified: * raddb/modules/passwd Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/400979676d092e2771d2… ====== -- This commit summary was generated @2014-03-13T00:00:12Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

Typos in dictionary.cisco.vpn3000
by Brian Candler 12 Mar '14

12 Mar '14

I just spotted some typos: "CPVN" instead of "CVPN" $ grep CPVN share/dictionary.cisco.vpn3000 ATTRIBUTE CPVN3000-Smart-Tunnel-Auto 138 integer ATTRIBUTE CPVN3000-VLAN 140 integer ATTRIBUTE CPVN3000-NAC-Settings 141 string ATTRIBUTE CPVN3000-Member-Of 145 string ATTRIBUTE CPVN3000-Address-Pools 217 string ATTRIBUTE CPVN3000-IPv6-Address-Pools 218 string ATTRIBUTE CPVN3000-IPv6-VPN-Filter 219 string ATTRIBUTE CPVN3000-WebVPN-Macro-Value1 223 string ATTRIBUTE CPVN3000-WebVPN-Macro-Value2 224 string VALUE CPVN3000-Smart-Tunnel-Auto Disabled 0 VALUE CPVN3000-Smart-Tunnel-Auto Enabled 1 VALUE CPVN3000-Smart-Tunnel-Auto Auto 2 Regards, Brian.

2 1

DHCP w/ FHRP and duplicate requests
by Phil Mayers 12 Mar '14

12 Mar '14

All, I haven't had the chance to try FR DHCP yet, but I ran into a problem with ISC yesterday and I thought I'd mention something worth considering. If you have something like VRRP/HSRP for first-hop resilience, both routers will forward the DHCP packet, and you'll get two copies that differ only in giaddr, very close together in time. For fixed IPs this isn't usually a problem, but if you're allocating a lease by DB lookup, I guess it would be possible for 2 DISCOVERs to get 2 different OFFERs, particularly if you're threaded. I'm wondering if the radius "duplicate packet detection" code could be re-used here? It seems like rlm_cache would probably run "too late"? Note that you do have to respond to both packets; if you don't, the one you do respond to might fail uRPF check because it might be routed by router A, but directed to router B, and will thus arrive at router B with an invalid source for the ingress interface. ISC sort-of does the right thing here unless you've got ping-check enabled and it's an initial lease allocation *or* you've got delayed-ack enabled for fsync performance. In that case it drops the 2nd duplicate and you run into uRPF problems. Anyway, just a thought.

3 6

Modified version of rlm_counter for FR3
by Marco Marino 12 Mar '14

12 Mar '14

Hi, on bitbucket there is my version of rlm_counter for FR3 (search for rlm_counter-v3 , user = ntt1985). Let me know if this version can be useful for other users. Every question/comment/criticism is welcome. Thanks MM

4 7

Release of Version 3.0.2
by Alan DeKok 11 Mar '14

11 Mar '14

Version 3.0.2 is late due to some last minute issues. We're sorry for the delay. I think we're good to release 3.0.2 this week. Alan DeKok.

2 7

Commit report for v3.0.x branch
by announce＠freeradius.org 11 Mar '14

11 Mar '14

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Switch some talloc_free's to TALLOC_FREE's Arran Cudbard-Bell@2014-03-11T21:23:56Z Files modified: * src/main/parser.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/e24b046d910e9d9d7bd4… ====== Load DHCP + VMPS dictionaries before loading any modules So that the attribute definitions are available to the modules and their configuration Alan T. DeKok@2014-03-11T15:21:10Z Files modified: * src/main/modules.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/e5c24ab1eb65631ab9a6… ====== Copy pointer, not thing it's pointing to Alan T. DeKok@2014-03-11T15:09:03Z Files modified: * src/lib/hash.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/0d1d179bbe5a59521b39… ====== Merge pull request #544 from spaetow/v3.0.x Update freeradius.spec Arran Cudbard-Bell@2014-03-11T13:07:06Z Files modified: * redhat/freeradius.spec Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/e10055c5a6430b81f70c… ====== Update freeradius.spec Add the DHCP IPPOOL to the Oracle module. Stefan Paetow@2014-03-11T12:54:38Z Files modified: * redhat/freeradius.spec Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/b5c8066094cd39e0b93a… ====== -- This commit summary was generated @2014-03-12T00:00:02Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

Commit report for master branch
by announce＠freeradius.org 11 Mar '14

11 Mar '14

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Switch some talloc_free's to TALLOC_FREE's Arran Cudbard-Bell@2014-03-11T21:24:23Z Files modified: * src/main/parser.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/b71e3534b2e6f757edb6… ====== Load DHCP + VMPS dictionaries before loading any modules So that the attribute definitions are available to the modules and their configuration Alan T. DeKok@2014-03-11T15:22:34Z Files modified: * src/main/modules.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/fbe5234fad692850ee07… ====== Update freeradius.spec Add the DHCP IPPOOL to the Oracle module. Stefan Paetow (via Arran Cudbard-Bell)@2014-03-11T13:08:08Z Files modified: * redhat/freeradius.spec Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/efe6879621878c5b3554… ====== -- This commit summary was generated @2014-03-12T00:00:01Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

3.0.x / possible bug in hash.c (function fr_hash_table_walk)
by Chaigneau, Nicolas 11 Mar '14

11 Mar '14

Hello, I think there might be a bug in the hash.c (function fr_hash_table_walk). At line 616 we currently have : memcpy(&arg, node->data, sizeof(arg)); Shouldn't this be instead : memcpy(&arg, &node->data, sizeof(arg)); The current behaviour implies that the callback gets the first member of the struct used as hash element (instead of the pointer on the struct). If this member happens to be the hash key, we can still access the struct itself through fr_hash_table_finddata, but... it's a bit messy ! The walk function is used internally, but from what I understand only to force walking over the hash, without actually accessing its content. Regards, Nicolas. This message contains information that may be privileged or confidential and is the property of the Capgemini Group. It is intended only for the person to whom it is addressed. If you are not the intended recipient, you are not authorized to read, print, retain, copy, disseminate, distribute, or use this message or any part thereof. If you receive this message in error, please notify the sender immediately and delete all copies of this message.

2 1

Commit report for v3.0.x branch
by announce＠freeradius.org 10 Mar '14

10 Mar '14

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Set fields to NULL after free'ing them Alan T. DeKok@2014-03-10T23:37:22Z Files modified: * src/modules/rlm_passwd/rlm_passwd.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/cd39cbde2830e10cb466… ====== Merge pull request #542 from mcnewton/v3.0.x fixup comment on unix opening bracket Arran Cudbard-Bell@2014-03-10T22:30:07Z Files modified: * raddb/mods-available/unix Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/6d2036f17bed34dc6322… ====== fixup comment on unix opening bracket Matthew Newton@2014-03-10T22:24:11Z Files modified: * raddb/mods-available/unix Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/ab95b64a5b27b2db03ff… ====== Fix documentation in comments Alan T. DeKok@2014-03-10T19:36:37Z Files modified: * raddb/mods-available/unix Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/6cebeeab304145b74851… ====== Decoded passwords have to have {...} Alan T. DeKok@2014-03-10T13:26:59Z Files modified: * src/modules/rlm_pap/rlm_pap.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/99bba7c5046b2eced2ea… ====== Note recent changes Alan T. DeKok@2014-03-10T13:21:59Z Files modified: * doc/ChangeLog Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/b518970de229beb89037… ====== -- This commit summary was generated @2014-03-11T00:00:12Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0