July 2014 - Freeradius-Devel - lists.freeradius.org

Commit report for v3.0.x branch
by announce＠freeradius.org 04 Jul '14

04 Jul '14

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Merge pull request #725 from nchaigne/v3.0.x radeapclient - fix send_packet Arran Cudbard-Bell@2014-07-04T17:08:19Z Files modified: * src/modules/rlm_eap/radeapclient.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/f3100c303c7cf6e5f509… ====== radeapclient - fix send_packet I spotted two errors in radeapclient.c, introduced in the following previous commits. With this fix, radeapclient is now useable again. 1) Commit: c8a062a112f17a5810d311dc0e0acfe963b2d440 (2014/06/13) - send_packet(rep, &req); - - if (!req) return -1; + send_packet(req, &rep); + if (!rep) { Arguments got reversed. Hence segmentation fault later when doing: for (vp = req->vps; vp != NULL; vp = vpnext) { Bit of caution on the wording used in radeapclient: "req" is the request coming FROM the server. (because this is not a "request" in RADIUS sense, but an EAP-Request within the EAP-SIM transaction.) "rep" is the response from the client TO the server (EAP-Response). 2) Commit: bc3676835c3dcc220ab518d4c3c35962bc0f8be2 (2014/05/02) In "send_packet": + if (!req || !rep || !*rep) return -1; *rep == NULL is the expected behaviour... Nicolas C@2014-07-04T17:03:33Z Files modified: * src/modules/rlm_eap/radeapclient.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/53c1ce349b07a6e51dcc… ====== In redhat spec file, update dependency on json-c to version 0.10 as 0.11 only exists for fedora and 0.10 builds ok Philippe Wooding (via Alan T. DeKok)@2014-07-04T16:01:54Z Files modified: * redhat/freeradius.spec Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/c0e3a5330804c0873621… ====== Update redhat spec file to reflect the fact rlm_host is no longer experimental. Philippe Wooding (via Alan T. DeKok)@2014-07-04T16:01:34Z Files modified: * redhat/freeradius.spec Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/3fb6571b943ae2f1eb48… ====== -- This commit summary was generated @2014-07-05T00:00:02Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

Commit report for master branch
by announce＠freeradius.org 04 Jul '14

04 Jul '14

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== radeapclient - fix send_packet I spotted two errors in radeapclient.c, introduced in the following previous commits. With this fix, radeapclient is now useable again. 1) Commit: c8a062a112f17a5810d311dc0e0acfe963b2d440 (2014/06/13) - send_packet(rep, &req); - - if (!req) return -1; + send_packet(req, &rep); + if (!rep) { Arguments got reversed. Hence segmentation fault later when doing: for (vp = req->vps; vp != NULL; vp = vpnext) { Bit of caution on the wording used in radeapclient: "req" is the request coming FROM the server. (because this is not a "request" in RADIUS sense, but an EAP-Request within the EAP-SIM transaction.) "rep" is the response from the client TO the server (EAP-Response). 2) Commit: bc3676835c3dcc220ab518d4c3c35962bc0f8be2 (2014/05/02) In "send_packet": + if (!req || !rep || !*rep) return -1; *rep == NULL is the expected behaviour... Nicolas C (via Arran Cudbard-Bell)@2014-07-04T17:09:17Z Files modified: * src/modules/rlm_eap/radeapclient.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/4f50d728a9e3f5fb6aea… ====== Merge pull request #724 from pwdng/master Update redhat spec file Arran Cudbard-Bell@2014-07-04T15:54:54Z Files modified: * redhat/freeradius.spec Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/1ff282afcc477b90869d… ====== In redhat spec file, update dependency on json-c to version 0.10 as 0.11 only exists for fedora and 0.10 builds ok Philippe Wooding@2014-07-04T14:03:19Z Files modified: * redhat/freeradius.spec Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/30efae5bc96185eab3e9… ====== Update list of installed files in redhat spec file Philippe Wooding@2014-07-04T14:03:19Z Files modified: * redhat/freeradius.spec Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/472b5574d7423bc4fb5e… ====== Update redhat spec file to reflect the fact rlm_host is no longer experimental. Philippe Wooding@2014-07-04T12:30:39Z Files modified: * redhat/freeradius.spec Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/a9084db4c17dc77d2d32… ====== Revert version to 3.1.0 in redhat spec. Philippe Wooding@2014-07-04T12:13:30Z Files modified: * redhat/freeradius.spec Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/b1ce69e0e2fd9f290759… ====== -- This commit summary was generated @2014-07-05T00:00:02Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

Commit report for v3.0.x branch
by announce＠freeradius.org 03 Jul '14

03 Jul '14

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Use correct type for length Alan T. DeKok@2014-07-03T01:59:51Z Files modified: * src/modules/rlm_eap/libeap/eap_chbind.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/0b6a39907161cf244351… ====== No need for casting in talloc_array_length() Alan T. DeKok@2014-07-03T01:45:37Z Files modified: * src/modules/rlm_eap/libeap/eap_chbind.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/cd41bcb584cb30f82713… ====== rad_vp2attr() returns -1 on error, 0 on "not enough room" Alan T. DeKok@2014-07-03T01:43:51Z Files modified: * src/modules/rlm_eap/libeap/eap_chbind.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/0000859a6f1b9438559d… ====== Channel bindings fixes -fix size calculation -skip unwanted attrs when copying -add safety check to copy code in case size is wrong -add cast to get correct result from talloc_array_length() Kevin Wasserman (via Alan T. DeKok)@2014-07-03T01:39:58Z Files modified: * src/modules/rlm_eap/libeap/eap_chbind.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/4c5834ebdd27ccc780ca… ====== Don't call free on talloc'ed channel bindings packet Kevin Wasserman (via Alan T. DeKok)@2014-07-03T01:39:54Z Files modified: * src/modules/rlm_eap/types/rlm_eap_ttls/ttls.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/b862293c1e25e33e7cec… ====== Fix cursor initialization bugs in eap_chbind_vp2packet Kevin Wasserman (via Alan T. DeKok)@2014-07-03T01:39:50Z Files modified: * src/modules/rlm_eap/libeap/eap_chbind.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/84b7c83d5127d04e9811… ====== -- This commit summary was generated @2014-07-04T00:00:02Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

Commit report for master branch
by announce＠freeradius.org 03 Jul '14

03 Jul '14

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Use correct type for length Alan T. DeKok@2014-07-03T02:00:10Z Files modified: * src/modules/rlm_eap/libeap/eap_chbind.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/ee44b6952e13b082573e… ====== No need for casting in talloc_array_length() Alan T. DeKok@2014-07-03T01:45:57Z Files modified: * src/modules/rlm_eap/libeap/eap_chbind.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/572c38c5823fd6551bd3… ====== Channel bindings fixes -fix size calculation -skip unwanted attrs when copying -add safety check to copy code in case size is wrong -add cast to get correct result from talloc_array_length() Kevin Wasserman (via Alan T. DeKok)@2014-07-03T01:44:25Z Files modified: * src/modules/rlm_eap/libeap/eap_chbind.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/9900f1166dec32c5818a… ====== Don't call free on talloc'ed channel bindings packet Kevin Wasserman (via Alan T. DeKok)@2014-07-03T01:44:24Z Files modified: * src/modules/rlm_eap/types/rlm_eap_ttls/ttls.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/fddcb36c9eb2eaa5716e… ====== Fix cursor initialization bugs in eap_chbind_vp2packet Kevin Wasserman (via Alan T. DeKok)@2014-07-03T01:44:23Z Files modified: * src/modules/rlm_eap/libeap/eap_chbind.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/56bb6254260b52a44042… ====== -- This commit summary was generated @2014-07-04T00:00:02Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

eap channel bindings fixes
by Kevin Wasserman 02 Jul '14

02 Jul '14

The attached patches address several bugs in eap channel bindings: Typos in calls to fr_cursor_init. Use of free() on talloc'ed ptr. Typo causing mis-computed buffer size. Use of wrong type in talloc_array_length. Kevin Wasserman Painless Security, LLC

2 1

Commit report for master branch
by announce＠freeradius.org 02 Jul '14

02 Jul '14

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Merge pull request #720 from qnet-herwin/perl_arrays Fixed adding attributes with multiple values to rlm_perl Arran Cudbard-Bell@2014-07-02T19:35:36Z Files modified: * src/modules/rlm_perl/rlm_perl.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/136839028c267856bc3c… ====== Fixed adding attributes with multiple values to rlm_perl Without this fix, the array in Perl would start with the value of the first attribute in the packet, combined with the actual values of the attribute. The debug log would look like this: $RAD_REPLY{'User-Name'}[0] = &reply:User-Name -> 'anonymous' $RAD_REPLY{'h323-credit-amount'}[1] = &reply:h323-credit-amount -> '100' $RAD_REPLY{'h323-credit-amount'}[2] = &reply:h323-credit-amount -> '101' The actual value of $RAD_REPLY{'h323-credit-amount'} is ['anonymous','100','101'] Herwin Weststrate@2014-07-02T19:21:01Z Files modified: * src/modules/rlm_perl/rlm_perl.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/bff37ca5088181511f59… ====== -- This commit summary was generated @2014-07-03T00:00:01Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

Commit report for v3.0.x branch
by announce＠freeradius.org 02 Jul '14

02 Jul '14

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Fixed adding attributes with multiple values to rlm_perl Without this fix, the array in Perl would start with the value of the first attribute in the packet, combined with the actual values of the attribute. The debug log would look like this: $RAD_REPLY{'User-Name'}[0] = &reply:User-Name -> 'anonymous' $RAD_REPLY{'h323-credit-amount'}[1] = &reply:h323-credit-amount -> '100' $RAD_REPLY{'h323-credit-amount'}[2] = &reply:h323-credit-amount -> '101' The actual value of $RAD_REPLY{'h323-credit-amount'} is ['anonymous','100','101'] Herwin Weststrate (via Arran Cudbard-Bell)@2014-07-02T19:36:09Z Files modified: * src/modules/rlm_perl/rlm_perl.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/c920cf0ff498b3695040… ====== -- This commit summary was generated @2014-07-03T00:00:01Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

Commit report for v3.0.x branch
by announce＠freeradius.org 01 Jul '14

01 Jul '14

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Merge pull request #719 from nchaigne/v3.0.x 3.0.x - Make EAP-SIM work again - proper encoding of EAP-SIM attributes ... Arran Cudbard-Bell@2014-07-01T19:48:25Z Files modified: * src/modules/rlm_eap/libeap/eapsimlib.c * src/modules/rlm_eap/radeapclient.c * src/modules/rlm_eap/types/rlm_eap_sim/rlm_eap_sim.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/fd45098b462a03a16a47… ====== 3.0.x - Make EAP-SIM work again - proper encoding of EAP-SIM attributes within EAP-Message This fix follows the issue I logged (on the mailing list, not on GitHub) on June 11th. As a reminder, the problem happened after a commit which (among other things) modified the EAP-SIM attributes. Since this commit, EAP-SIM authentication do not work because EAP-Message is not properly encoded anymore by FreeRADIUS. I believe the commit is the following: https://github.com/FreeRADIUS/freeradius-server/commit/39df09e42d80a96363be… So, here is a fix. I also fixed the attributes issue in radeapclient, but at the moment the binary is unusable: it crashes, and I don't have time to look into this. (I tested the fix with another EAP client) Nicolas C@2014-07-01T17:03:03Z Files modified: * src/modules/rlm_eap/libeap/eapsimlib.c * src/modules/rlm_eap/radeapclient.c * src/modules/rlm_eap/types/rlm_eap_sim/rlm_eap_sim.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/9ec3c382665a34595d65… ====== Inline breaks linking? Arran Cudbard-Bell@2014-07-01T15:58:31Z Files modified: * src/include/libradius.h * src/lib/dict.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/06e09be31d59ef4933ba… ====== Fix capitalisation in UKERNA dictionary Fixes #718 Arran Cudbard-Bell@2014-07-01T15:44:50Z Files modified: * share/dictionary.ukerna Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/2d1ef27ac98f646e5ba0… ====== Other things still reference dict_attr_allowed_chars Arran Cudbard-Bell@2014-07-01T15:43:07Z Files modified: * src/include/libradius.h * src/lib/dict.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/7af44b794161ffbb3201… ====== Fixed reference to config file Herwin Weststrate (via Arran Cudbard-Bell)@2014-07-01T13:42:00Z Files modified: * raddb/sites-available/default Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/40bee0edc4b7638717e3… ====== Readability fixes in mods-available/perl Alignment is now stable with any tab width. Herwin Weststrate (via Arran Cudbard-Bell)@2014-07-01T13:41:48Z Files modified: * raddb/mods-available/perl Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/8e7fc3460be51899fefb… ====== Fixed typo in rlm_sql.c s/afftected/affected/ Herwin Weststrate (via Arran Cudbard-Bell)@2014-07-01T13:40:19Z Files modified: * src/modules/rlm_sql/rlm_sql.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/a5d11402be8624845ef5… ====== Fixed some tabs/spaces in default virtual server Herwin Weststrate (via Arran Cudbard-Bell)@2014-07-01T13:40:14Z Files modified: * raddb/sites-available/default Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/bd6519551d5e09733e1b… ====== Use RFC language in eap.c messages Arran Cudbard-Bell@2014-07-01T13:39:38Z Files modified: * src/modules/rlm_eap/eap.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/852f3abe9b521d1b8448… ====== No need to call exit twice Arran Cudbard-Bell@2014-07-01T13:39:38Z Files modified: * src/lib/event.c * src/main/detail.c * src/main/radiusd.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/56a66de36cf920b89d4d… ====== Better errors on junk chars in dict.c Arran Cudbard-Bell@2014-07-01T13:39:38Z Files modified: * src/lib/dict.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/5a77de871d49ba43a33b… ====== -- This commit summary was generated @2014-07-02T00:00:01Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

Commit report for master branch
by announce＠freeradius.org 01 Jul '14

01 Jul '14

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== 3.0.x - Make EAP-SIM work again - proper encoding of EAP-SIM attributes within EAP-Message This fix follows the issue I logged (on the mailing list, not on GitHub) on June 11th. As a reminder, the problem happened after a commit which (among other things) modified the EAP-SIM attributes. Since this commit, EAP-SIM authentication do not work because EAP-Message is not properly encoded anymore by FreeRADIUS. I believe the commit is the following: https://github.com/FreeRADIUS/freeradius-server/commit/39df09e42d80a96363be… So, here is a fix. I also fixed the attributes issue in radeapclient, but at the moment the binary is unusable: it crashes, and I don't have time to look into this. (I tested the fix with another EAP client) Nicolas C (via Arran Cudbard-Bell)@2014-07-01T19:48:43Z Files modified: * src/modules/rlm_eap/libeap/eapsimlib.c * src/modules/rlm_eap/radeapclient.c * src/modules/rlm_eap/types/rlm_eap_sim/rlm_eap_sim.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/1fcbd068f044ce76aa03… ====== Inline breaks linking? Arran Cudbard-Bell@2014-07-01T15:58:37Z Files modified: * src/include/libradius.h * src/lib/dict.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/ab02411d66ed3ba2cb94… ====== Fix capitalisation in UKERNA dictionary Fixes #718 Arran Cudbard-Bell@2014-07-01T15:44:55Z Files modified: * share/dictionary.ukerna Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/fb1f9a7cf7480b1458a9… ====== Other things still reference dict_attr_allowed_chars Arran Cudbard-Bell@2014-07-01T15:42:53Z Files modified: * src/include/libradius.h * src/lib/dict.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/d992482da429cf205e79… ====== Fixed reference to config file Herwin Weststrate (via Arran Cudbard-Bell)@2014-07-01T15:42:53Z Files modified: * raddb/sites-available/default Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/00e8e42f1bb7cd2aca41… ====== Formatting fixes in rlm_perl Herwin Weststrate (via Arran Cudbard-Bell)@2014-07-01T15:42:53Z Files modified: * src/modules/rlm_perl/rlm_perl.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/f3e6a8995cd1e3738b2d… ====== Readability fixes in mods-available/perl Alignment is now stable with any tab width. Herwin Weststrate (via Arran Cudbard-Bell)@2014-07-01T15:42:52Z Files modified: * raddb/mods-available/perl Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/e9cd5f614a80d8e2a7eb… ====== Fixed typo in rlm_sql.c s/afftected/affected/ Herwin Weststrate (via Arran Cudbard-Bell)@2014-07-01T15:42:52Z Files modified: * src/modules/rlm_sql/rlm_sql.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/2c45895ef69a40edaf9b… ====== Fixed some tabs/spaces in default virtual server Herwin Weststrate (via Arran Cudbard-Bell)@2014-07-01T15:42:52Z Files modified: * raddb/sites-available/default Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/4116dc1c672062dfcf69… ====== Use RFC language in eap.c messages Arran Cudbard-Bell@2014-07-01T13:38:57Z Files modified: * src/modules/rlm_eap/eap.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/38327a7337b4aac18e7c… ====== No need to call exit twice Arran Cudbard-Bell@2014-07-01T13:38:57Z Files modified: * src/lib/event.c * src/main/detail.c * src/main/radiusd.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/c615ec735ce17d07f6cb… ====== Better errors on junk chars in dict.c Arran Cudbard-Bell@2014-07-01T13:38:57Z Files modified: * src/lib/dict.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/93ec9e971dab7a95fe2b… ====== -- This commit summary was generated @2014-07-02T00:00:01Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0