- Freeradius-Devel - lists.freeradius.org

access to proxy packet "radius id" in case of unresponsive proxy ?
by Chaigneau, Nicolas 03 Dec '15

03 Dec '15

Hello, For logging purposes, I'm trying to get the proxy packet "radius id". In post proxy, the proxy packet id is not available anymore (it has been reset to -1 by fr_packet_list_id_free when removed from proxy hash). When we have a response from the proxy server, we still can know this id (because it's the same as the proxy reply packet id, which is available). But in case of unresponsive proxy, it seems there's no way to do so. (except by changing FreeRADIUS code). Do you confirm this is not currently doable ? And if so, would it be possible to do something about this ? :) Regards, Nicolas. This message contains information that may be privileged or confidential and is the property of the Capgemini Group. It is intended only for the person to whom it is addressed. If you are not the intended recipient, you are not authorized to read, print, retain, copy, disseminate, distribute, or use this message or any part thereof. If you receive this message in error, please notify the sender immediately and delete all copies of this message.

4 5

Compound problems with 3.0.10 build
by Sam Hartman 02 Dec '15

02 Dec '15

Hi. I've been having trouble building 3.0.10. I traced it down to a couple of badly interacting things. IN 2b77b7e830222d0192f42efe66cae38f061aa34c two all.mk files were introduced in directories that have an all.mk.in. I don't understand why that commit is a good idea as configure will generate those files. Unfortunately, if building from git, it's very easy to get into a situation where make things the files are out-of-date immediately after a fresh configure. So as part of make it will try and reconfigure those files. So because we checked in all.mk files we end up building them twice instead of 0 times. Oops. Except it's worse than that because of the logic in makefile for getting configure_args. If you run configure like so, ./configure LDFLAGS='-L/usr/local/moonshot/lib -Wl,--rpath=/usr/local/moonshot/lib' Then the logic for extracting the configure arguments misses the interior quotes. So you end up rerunning configure like ./configure LDFLAGS=-L/usr/local/moonshot/lib -Wl,--rpath=/usr/local/moonshot/lib and that second configure line doesn't work as well as you might hope. I think extracting configure_args from the AC_CS_CONFIG setting in config.status might work much better. --Sam

2 2

New feature in v3.1.x
by Alan DeKok 01 Dec '15

01 Dec '15

I've just committed a new feature to the v3.1.x branch. It's called "queue_priority" for the thread pool. The idea is to allow the administrator to control how the server behaves in overload conditions. When a back-end database goes down, or 10K users log in at once, the server can't process packets as fast as they come in. This is "overload". The usual method of dealing with overload is to put the extra packets into a queue for later processing. But the question is, how should the queue be organized? In v3.0 and earlier, the queue had fixed behaviour. In v3.1.x, it is configurable. The 3 options are: time order packets by when they are received Note that replies from a home server are ordered by when the *original* packet came in, so they are prioritized. default Order by listener type proxy > auth > acct > detail > coa Packets from the same listener are ordered by "time". eap Order by ongoing EAP sessions. EAP authentication takes multiple rounds. This priority ensures that EAP sessions which are "further along" in the authentication process are handled with a higher priority. Packets with the same eap priority are ordered by "default" The "default" order is pretty much what was in 3.0 and earlier. If anyone has suggestions for additional prioritization methods, I'd be interested in hearing them. Alan DeKok.

1 0

Changes in 3.1
by Alan DeKok 27 Nov '15

27 Nov '15

We've removed rlm_counter and rlm_ippool. Those modules duplicate functionality already in rlm_sqlcounter and rlm_sql_ippool. If people want to use "local" counters or IP Pools, they can use sqlite. Maintaining duplicate sets of code is becoming a problem. Alan DeKok.

1 0

Plans to FreeRADIUS 3.0.11?
by Jorge Pereira 26 Nov '15

26 Nov '15

A(l|rr)an, have plans to release the 3.0.11? []s -- Jorge Pereira

2 1

3.0.x crash in _talloc_free()
by Matthew Newton 18 Nov '15

18 Nov '15

Hi, Just put our first real FR3 deployment live yesterday (3.0.x HEAD 46fb0cd312f0) :) Then quickly hit a crash :( Initial outputs (was running -X to start so these are single threaded) gave: ... (294) eap_tls: ocsp: Cert status: good (294) eap_tls: ocsp: Certificate is valid (294) eap_tls: TLS_accept: SSLv3 read client certificate A (294) eap_tls: <<< recv TLS 1.0 Handshake [length 0046], ClientKeyExchange *** glibc detected *** freeradius: free(): invalid pointer: 0x0000000001c7a140 *** ======= Backtrace: ========= ... and ... Waking up in 0.1 seconds. (4563) Cleaning up request packet ID 8 with timestamp +1917 (4564) Cleaning up request packet ID 9 with timestamp +1917 Waking up in 0.2 seconds. (4566) Cleaning up request packet ID 207 with timestamp +1917 *** glibc detected *** /usr/sbin/freeradius: free(): invalid next size (fast): 0x00000000019f4830 *** ======= Backtrace: ========= ... Haven't manage to get a core dump yet, but the panic action is working. Three crashes so far are the same, one slightly different. All are in _talloc_free: The three same ones error in the request_free (process.c:806) at the end of request_done. The other is in eappeap_process (peap.c:828). The fact it manages to get all the way through request_free without crashing, with all the checks that are done in there, before bombing out in the free seem slightly weird to me, as the data in *request must be sane. System is Debian wheezy with talloc 2.0.7. I think my next plan is to upgrade the system to jessie which has version 2.1.1 available and see if it's a bug in that old version of talloc that's being hit. Weird nobody else has reported it before, though; it's not a busy server and crashed four times so far this morning (though not at all overnight when less lightly loaded). Full startup output from -X and four gdb panic action dumps are at (yeah I know there are a few warnings in the config at the moment): https://gist.github.com/mcnewton/63a01685f3748e202e81 One snippet of panic_action output below. Any ideas? Cheers, Matthew Thread 1 (Thread 0x7fadf28dd720 (LWP 16110)): #0 0x00007fadf067a0ad in waitpid () from /lib/x86_64-linux-gnu/libc.so.6 No symbol table info available. #1 0x00007fadf060e989 in ?? () from /lib/x86_64-linux-gnu/libc.so.6 No symbol table info available. #2 0x00007fadf060ecc0 in system () from /lib/x86_64-linux-gnu/libc.so.6 No symbol table info available. #3 0x00007fadf22a80ab in fr_fault (sig=<optimized out>) at src/lib/debug.c:725 disable = false cmd = "gdb -silent -x /srv/radius/panic.gdb /usr/sbin/freeradius 16110 2>&1 | tee /var/log/freeradius/gdb-freeradius-16110.log", '\000' <repeats 412 times> out = 0x7ffcff10ec23 ".log" left = 417 ret = <optimized out> p = <optimized out> q = 0x0 code = <optimized out> #4 <signal handler called> No symbol table info available. #5 0x00007fadf0601165 in raise () from /lib/x86_64-linux-gnu/libc.so.6 No symbol table info available. #6 0x00007fadf06043e0 in abort () from /lib/x86_64-linux-gnu/libc.so.6 No symbol table info available. #7 0x00007fadf063b39b in ?? () from /lib/x86_64-linux-gnu/libc.so.6 No symbol table info available. #8 0x00007fadf0644be6 in ?? () from /lib/x86_64-linux-gnu/libc.so.6 No symbol table info available. #9 0x00007fadf064998c in free () from /lib/x86_64-linux-gnu/libc.so.6 No symbol table info available. #10 0x00007fadf1831089 in ?? () from /usr/lib/x86_64-linux-gnu/libtalloc.so.2 No symbol table info available. #11 0x00007fadf1831023 in ?? () from /usr/lib/x86_64-linux-gnu/libtalloc.so.2 No symbol table info available. #12 0x00007fadf1831023 in ?? () from /usr/lib/x86_64-linux-gnu/libtalloc.so.2 No symbol table info available. #13 0x00007fadf1831023 in ?? () from /usr/lib/x86_64-linux-gnu/libtalloc.so.2 No symbol table info available. #14 0x00007fadf182d8b3 in _talloc_free () from /usr/lib/x86_64-linux-gnu/libtalloc.so.2 No symbol table info available. #15 0x00000000004316fe in request_done (request=request@entry=0x7fade4101d00, action=action@entry=6) at src/main/process.c:806 now = {tv_sec = 0, tv_usec = 140384832071768} when = {tv_sec = 0, tv_usec = 140385039194508} #16 0x000000000043347d in request_cleanup_delay (request=0x7fade4101d00, action=<optimized out>) at src/main/process.c:1115 when = {tv_sec = 1447837345, tv_usec = 239972} now = {tv_sec = 1447837345, tv_usec = 240304} __FUNCTION__ = "request_cleanup_delay" #17 0x00007fadf22c44f4 in fr_event_run (el=el@entry=0x1ca51d0, when=when@entry=0x7ffcff10fee0) at src/lib/event.c:309 callback = 0x42f9e0 <request_timer> ctx = 0x7fade4101d00 ev = <optimized out> #18 0x00007fadf22c4a4e in fr_event_loop (el=0x1ca51d0) at src/lib/event.c:624 i = <optimized out> rcode = 0 when = {tv_sec = 1447837345, tv_usec = 240304} wake = <optimized out> maxfd = 20 read_fds = {fds_bits = {0 <repeats 16 times>}} master_fds = {fds_bits = {256000, 0 <repeats 15 times>}} #19 0x00000000004374c1 in radius_event_process () at src/main/process.c:5640 No locals. #20 0x000000000041100f in main (argc=3, argv=<optimized out>) at src/main/radiusd.c:578 rcode = 0 status = <optimized out> argval = <optimized out> spawn_flag = true display_version = false flag = 0 from_child = {4, 5} state = 0x668840 autofree = 0x1a76060 A debugging session is active. Inferior 1 [process 16110] will be detached. -- Matthew Newton, Ph.D. <mcn4(a)le.ac.uk> Systems Specialist, Infrastructure Services, I.T. Services, University of Leicester, Leicester LE1 7RH, United Kingdom For IT help contact helpdesk extn. 2253, <ithelp(a)le.ac.uk>

3 5

Commit report for v3.1.x branch
by announce＠freeradius.org 16 Nov '15

16 Nov '15

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Added framework for testing dictionaries to do: ensure that tests FAIL when we get invalid dictionaries Alan T. DeKok@2015-11-16T22:43:25Z Files modified: * src/tests/all.mk * src/tests/dict/all.mk * src/tests/dict/base.dict * src/tests/dict/empty.txt * src/tests/unit/all.mk Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/a37d4f1d4ff781dc41be… ====== Minor fix Arran Cudbard-Bell@2015-11-16T22:25:11Z Files modified: * src/include/missing-h * src/lib/missing.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/642d489757efb402e5b7… ====== fclose destroys file descriptor Closes #1390 Arran Cudbard-Bell@2015-11-16T21:58:20Z Files modified: * src/lib/missing.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/23ec1a8034ebbffe4606… ====== Check pointers before dereferencing them Alan T. DeKok@2015-11-16T21:55:35Z Files modified: * src/lib/dict.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/5dc58651081945011ed8… ====== Fixing the missing vdprintf() Jorge Pereira (via Arran Cudbard-Bell)@2015-11-16T21:35:01Z Files modified: * src/lib/missing.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/5497e2baa672cf2e952e… ====== Provide fdprintf if it's missing Closes #1366 Arran Cudbard-Bell@2015-11-16T20:44:41Z Files modified: * configure * configure.ac * src/include/autoconf.h.in * src/include/missing-h * src/lib/missing.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/28e6eebdbe053a374dd7… ====== Formatting Arran Cudbard-Bell@2015-11-16T20:41:04Z Files modified: * src/include/libradius.h Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/773922cb65fec6bd6462… ====== fast path for the common case Alan T. DeKok@2015-11-16T20:25:38Z Files modified: * src/lib/radius_encode.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/88294a09cc81cb879577… ====== Tests for encoding TLVs in extended attributes Alan T. DeKok@2015-11-16T20:25:38Z Files modified: * src/lib/radius_encode.c * src/tests/unit/extended.txt Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/8a26f6c234ce31946203… ====== more tests for encoding extended attrs Alan T. DeKok@2015-11-16T20:25:37Z Files modified: * src/tests/unit/dictionary.unit * src/tests/unit/extended.txt Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/dd4e399161b4fa8a1687… ====== Disallow more invalid data types in the encoder Alan T. DeKok@2015-11-16T20:25:37Z Files modified: * src/lib/radius_encode.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/d545abb2c9af89828cc3… ====== Ignore non-protocol attributes before doing any work Alan T. DeKok@2015-11-16T20:25:37Z Files modified: * src/lib/radius_encode.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/1408131e82ea4b0724f4… ====== Remove globals in dict.c Arran Cudbard-Bell@2015-11-16T18:39:41Z Files modified: * src/include/dict.h * src/lib/dict.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/532421d4885ee2a64afb… ====== Make encoder handle 32-bit EVS Alan T. DeKok@2015-11-16T17:15:20Z Files modified: * src/lib/radius_encode.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/d2dff716e62da0c3cc46… ====== RFC 6929 Section 2.6 says vendor IDs are 32-bits Alan T. DeKok@2015-11-16T17:08:17Z Files modified: * src/include/libradius.h * src/lib/dict.c * src/modules/rlm_eap/types/rlm_eap_ttls/ttls.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/2ba2a02fc5b321923174… ====== Added tests for extended types and fixed the code... Alan T. DeKok@2015-11-16T17:08:17Z Files modified: * src/lib/radius_encode.c * src/tests/unit/dictionary.unit * src/tests/unit/extended.txt Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/be15847100f514bd5c3e… ====== Add encode / decode for EAP-Message (concat type) Alan T. DeKok@2015-11-16T17:08:17Z Files modified: * src/tests/unit/rfc.txt Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/c4c327b4af6183eee588… ====== Dictionary for unit tests of extended attrs Alan T. DeKok@2015-11-16T17:07:12Z Files modified: * src/tests/unit/all.mk * src/tests/unit/dictionary.unit Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/eaf7fa29133d3ce5335b… ====== Fix encoding TLVs beneath VSAs Previously there was a double header on the first VSA Arran Cudbard-Bell@2015-11-16T16:20:08Z Files modified: * src/lib/radius_encode.c * src/tests/unit/rfc.txt * src/tests/unit/tlv.txt Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/671105b3147600b342a7… ====== Add start of MIB->RADIUS bindings Arran Cudbard-Bell@2015-11-16T16:20:08Z Files modified: * share/dictionary.freeradius Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/853eadbd8995f2483a5f… ====== Formatting Arran Cudbard-Bell@2015-11-16T16:20:08Z Files modified: * src/lib/radius_encode.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/1f3eb8374ec3c8e885be… ====== use fr_proto_tlv_stack_build function to build the initial stack Arran Cudbard-Bell@2015-11-16T16:20:08Z Files modified: * src/lib/radius_encode.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/d90258fba6777b9db593… ====== Fixes for BLOCK-TLV Arran Cudbard-Bell@2015-11-16T16:20:08Z Files modified: * src/include/dict.h * src/lib/dict.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/fbd7f1fd65a2d5f3052f… ====== Enforce 255 limit on more attribute types. And hoist more of the checks to the public encode routine Alan T. DeKok@2015-11-16T14:38:18Z Files modified: * src/lib/radius_encode.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/26fd3fa077994b09e2b0… ====== Remove unused flags Arran Cudbard-Bell@2015-11-16T06:25:57Z Files modified: * src/include/dict.h * src/lib/dict.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/84b0252b169c990577c4… ====== No rad_assert in lib Arran Cudbard-Bell@2015-11-16T05:51:30Z Files modified: * src/lib/dict.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/b548cb342604ec9f1541… ====== CSID #1339397 Arran Cudbard-Bell@2015-11-16T05:46:36Z Files modified: * src/main/conffile.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/fcec0a487af845a87c9e… ====== Coverity CSID #1339398 Arran Cudbard-Bell@2015-11-16T05:40:49Z Files modified: * src/lib/dict.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/fa0c4ac3fc1c51903345… ====== CSID #1339400 Arran Cudbard-Bell@2015-11-16T05:39:08Z Files modified: * src/lib/radius_encode.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/28b03167fe29e0393484… ====== CSID #1339402 Arran Cudbard-Bell@2015-11-16T05:37:28Z Files modified: * src/lib/dict.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/23a87a93a69a42f5c458… ====== CSID #1339403 Arran Cudbard-Bell@2015-11-16T05:36:22Z Files modified: * src/lib/dict.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/c57b57298652f880ff10… ====== Coverity CSID #1229410/9/8 Arran Cudbard-Bell@2015-11-16T05:33:01Z Files modified: * src/lib/pair.c * src/main/tmpl.c * src/modules/rlm_eap/types/rlm_eap_ttls/ttls.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/938bbc7899a5daa0438d… ====== CSID #1339411 Arran Cudbard-Bell@2015-11-16T05:30:10Z Files modified: * src/lib/radius_decode.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/ec3fb58df1004ccf06fd… ====== CSID #1264574 Arran Cudbard-Bell@2015-11-16T05:26:33Z Files modified: * src/lib/packet.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/bbe9e88041eac37a1f19… ====== CSID #1264577 Arran Cudbard-Bell@2015-11-16T05:25:26Z Files modified: * src/main/command.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/44e3a499145d66c2554a… ====== CSID #1264578 Arran Cudbard-Bell@2015-11-16T05:24:40Z Files modified: * src/main/tls_listen.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/d4e36358c12739072cec… ====== CSID #1264592 Arran Cudbard-Bell@2015-11-16T05:23:44Z Files modified: * src/main/tmpl.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/afeb49a31a6303f10ec7… ====== Coverity #1271302/3 Arran Cudbard-Bell@2015-11-16T05:21:21Z Files modified: * src/main/command.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/c4d6b9bee31c347c0650… ====== CSID #1271304 Arran Cudbard-Bell@2015-11-16T05:19:14Z Files modified: * src/main/command.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/b3108161709d1556479d… ====== CSID #1271305 Arran Cudbard-Bell@2015-11-16T05:17:53Z Files modified: * src/main/command.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/9f7591b66beb018306f5… ====== CSID #1316260 Arran Cudbard-Bell@2015-11-16T05:15:29Z Files modified: * src/modules/rlm_redis/cluster.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/586fb80c9282bae146a8… ====== CSID #1271302 Arran Cudbard-Bell@2015-11-16T05:10:58Z Files modified: * src/modules/proto_dhcp/dhcpd.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/921cc96e83f4ad4e6b94… ====== Increase maximum TLV nesting depth to 24 -+ 10,000 later *sigh* Arran Cudbard-Bell@2015-11-16T04:55:24Z Files modified: * src/include/dict.h Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/0adb5415e4bccdf122a7… ====== Same fixes for tlv encoder Arran Cudbard-Bell@2015-11-16T04:51:19Z Files modified: * src/modules/proto_dhcp/dhcp.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/7962b5f7d540311856b9… ====== Add support (and tests) for IPv6 addresses Arran Cudbard-Bell@2015-11-16T04:47:44Z Files modified: * src/modules/proto_dhcp/dhcp.c * src/tests/unit/dhcp.txt Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/f29ec14e92fac7178e19… ====== Encode IPv6 addresses in DHCP encoder Add tests for and fix attribute coalescing overflow Arran Cudbard-Bell@2015-11-16T04:42:17Z Files modified: * src/main/radattr.c * src/modules/proto_dhcp/dhcp.c * src/tests/unit/dhcp.txt Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/a1c09ce647eea80c3e09… ====== Test for (and fix) fixed attribute length coalescing Arran Cudbard-Bell@2015-11-16T03:55:11Z Files modified: * src/modules/proto_dhcp/dhcp.c * src/tests/unit/dhcp.txt Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/2b4bf951d2f7bea27ec5… ====== Minor fixes Arran Cudbard-Bell@2015-11-16T03:30:12Z Files modified: * src/lib/dict.c * src/modules/proto_dhcp/dhcp.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/cd33fc23277aa56fe1c9… ====== Fix doxygen issues Arran Cudbard-Bell@2015-11-16T03:16:55Z Files modified: * src/lib/dict.c * src/main/tmpl.c * src/modules/proto_dhcp/dhcp.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/5d43193d89e625fcf526… ====== Fix issues in dict.c found by gcc Arran Cudbard-Bell@2015-11-16T03:16:55Z Files modified: * src/lib/dict.c * src/lib/radius_decode.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/895c7dc5faad22071851… ====== Fix clan scan issues Arran Cudbard-Bell@2015-11-16T02:36:12Z Files modified: * src/include/dict.h * src/lib/dict.c * src/main/radattr.c * src/modules/proto_dhcp/dhcp.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/528273023118ef289e3a… ====== Better digest debug Arran Cudbard-Bell@2015-11-16T02:14:51Z Files modified: * src/modules/rlm_digest/rlm_digest.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/d104fa34b4027424f83b… ====== typo Arran Cudbard-Bell@2015-11-16T02:14:51Z Files modified: * src/lib/proto.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/fd8ac76eb899b1b3fb07… ====== Rework DHCP option decoder To be very similar to the RADIUS attribute decoder. Arran Cudbard-Bell@2015-11-16T02:14:51Z Files modified: * src/include/dhcp.h * src/main/radattr.c * src/modules/proto_dhcp/dhcp.c * src/modules/proto_dhcp/rlm_dhcp.c * src/tests/unit/dhcp.txt Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/b6596a90279fdbb8835e… ====== Restore old attribute insertion ordering Arran Cudbard-Bell@2015-11-16T02:14:51Z Files modified: * src/lib/dict.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/22113ad68a4168e5fe81… ====== Spurious newline Arran Cudbard-Bell@2015-11-16T00:44:14Z Files modified: * src/lib/proto.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/db0b078ee2c64ab09fa5… ====== Free unknown attributes in the pair where the pair already had an unknown attribute Arran Cudbard-Bell@2015-11-16T00:44:14Z Files modified: * src/lib/pair.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/aa2784e558d8b0ace873… ====== Formatting Arran Cudbard-Bell@2015-11-16T00:44:14Z Files modified: * src/include/libradius.h Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/95db1407931c578139d3… ====== Use common terminology Arran Cudbard-Bell@2015-11-16T00:44:13Z Files modified: * src/lib/radius_decode.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/088afbc6becf3a02c905… ====== Not needed Arran Cudbard-Bell@2015-11-16T00:44:13Z Files modified: * src/lib/radius_decode.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/ed0671bd5f486d85745f… ====== Fixup DHCP option encoder to use a tlv_stack The code is very similar to RADIUS, only much simpler Differences are option header length not included in length field, and coalescing of fixed length values. Arran Cudbard-Bell@2015-11-16T00:44:13Z Files modified: * src/include/dhcp.h * src/main/radattr.c * src/modules/proto_dhcp/dhcp.c * src/modules/proto_dhcp/rlm_dhcp.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/026e3473a8045a2deee4… ====== Stack builder should take DA not **vp Arran Cudbard-Bell@2015-11-16T00:44:13Z Files modified: * src/include/proto.h * src/lib/proto.c * src/lib/radius_encode.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/e45440e011d8a553acb8… ====== Better debug Arran Cudbard-Bell@2015-11-16T00:44:13Z Files modified: * src/include/proto.h * src/lib/proto.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/6841c68265c2a60ebece… ====== Name DHCP functions consistently Arran Cudbard-Bell@2015-11-16T00:44:13Z Files modified: * src/lib/proto.c * src/modules/proto_dhcp/dhcp.c * src/tests/unit/dhcp.txt Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/a89fa7ac8afd19019f89… ====== Move some protocol encoder/decoder functions into a common source file Arran Cudbard-Bell@2015-11-15T06:23:29Z Files modified: * src/include/dict.h * src/include/libradius.h * src/include/pair.h * src/include/proto.h * src/lib/all.mk * src/lib/proto.c * src/lib/radius_decode.c * src/lib/radius_encode.c * src/main/mainconfig.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/f499b7165bfc6f543ee1… ====== Remove attribute packing reminence Arran Cudbard-Bell@2015-11-15T03:29:58Z Files modified: * src/include/libradius.h * src/lib/dict.c * src/lib/radius_encode.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/eaa0fb56db6ab60b772d… ====== Rework OID parsing and printing functions to properly use the new attribute hierachy Arran Cudbard-Bell@2015-11-15T03:24:09Z Files modified: * src/include/libradius.h * src/lib/dict.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/716bc5fbb19dbe14a2ad… ====== Rename decoder functions Rework the decoder to always use parents properly Arran Cudbard-Bell@2015-11-15T03:24:09Z Files modified: * src/include/libradius.h * src/lib/pair.c * src/lib/radius.c * src/lib/radius_decode.c * src/main/map.c * src/main/radattr.c * src/modules/proto_arp/proto_arp.c * src/modules/rlm_eap/libeap/eap_chbind.c * src/modules/rlm_eap/rlm_eap.c * src/modules/rlm_eap/types/rlm_eap_ttls/ttls.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/6db3de7f6d4e9d25ab93… ====== Add functions to sanity check talloced dictionaries Arran Cudbard-Bell@2015-11-15T03:24:09Z Files modified: * src/include/libradius.h * src/lib/dict.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/483cedfb86828dfa8050… ====== Rework encoder functions to use attribute hierachy And a few other minior fixes Arran Cudbard-Bell@2015-11-15T03:24:09Z Files modified: * src/include/libradius.h * src/lib/dict.c * src/lib/radius_encode.c * src/main/radattr.c * src/main/radclient.c * src/main/unittest.c * src/modules/rlm_chap/rlm_chap.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/e5357aa231a5ae284695… ====== Fixup errors.txt to use new function names Arran Cudbard-Bell@2015-11-15T03:24:09Z Files modified: * src/tests/unit/errors.txt Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/66ca48f4db344bdd1abb… ====== Formatting Arran Cudbard-Bell@2015-11-15T03:24:08Z Files modified: * src/lib/radius_encode.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/83096015c559ae67b76d… ====== Add additional arguments to encoder functions Arran Cudbard-Bell@2015-11-15T03:24:08Z Files modified: * src/lib/radius_encode.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/6d5535ff065a4cf0bc86… ====== Rename and cleanup encoding functions Arran Cudbard-Bell@2015-11-15T03:24:08Z Files modified: * src/include/libradius.h * src/lib/radius.c * src/lib/radius_encode.c * src/main/radattr.c * src/main/radclient.c * src/main/unittest.c * src/main/xlat.c * src/modules/rlm_chap/rlm_chap.c * src/modules/rlm_eap/libeap/eap_chbind.c * src/modules/rlm_eap/radeapclient.c * src/modules/rlm_eap/rlm_eap.c * src/modules/rlm_eap/types/rlm_eap_leap/eap_leap.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/868620e46ad34f557163… ====== Split radius functions into three files It's just not fun working with a 5000 line file. Arran Cudbard-Bell@2015-11-15T03:24:08Z Files modified: * src/include/libradius.h * src/lib/all.mk * src/lib/radius.c * src/lib/radius_decode.c * src/lib/radius_encode.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/d65c86f4cefb5d0d1f4f… ====== Fix typos in WiMAX test Arran Cudbard-Bell@2015-11-15T03:24:08Z Files modified: * src/tests/unit/wimax.txt Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/d85d1e57422ebcab1e29… ====== Switch enum value lookup to use fr_dict_attr_t Attribute numbers are no longer unique Arran Cudbard-Bell@2015-11-15T03:24:08Z Files modified: * src/include/libradius.h * src/lib/dict.c * src/lib/value.c * src/main/acct.c * src/main/auth.c * src/main/listen.c * src/main/modcall.c * src/main/modules.c * src/main/process.c * src/main/xlat.c * src/modules/proto_dhcp/dhcpd.c * src/modules/rlm_eap/libeap/eapcommon.c * src/modules/rlm_eap/types/rlm_eap_gtc/rlm_eap_gtc.c * src/modules/rlm_exec/rlm_exec.c * src/modules/rlm_mschap/rlm_mschap.c * src/modules/rlm_pap/rlm_pap.c * src/modules/rlm_rediswho/rlm_rediswho.c * src/modules/rlm_yubikey/rlm_yubikey.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/8661250cf89dc488ae08… ====== Define complete hierarchy for unknown attributes Arran Cudbard-Bell@2015-11-15T03:24:08Z Files modified: * src/lib/dict.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/1c8de6ec8d1ff6b5f488… ====== Need to use child_by_num when looking up unknown attributes in the main dictionary Arran Cudbard-Bell@2015-11-15T03:24:07Z Files modified: * src/main/tmpl.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/a3c3383056363521d22f… ====== Fixup the RADIUS decoder and unknown attribute functions Arran Cudbard-Bell@2015-11-15T03:24:07Z Files modified: * src/include/libradius.h * src/include/tmpl.h * src/lib/dict.c * src/lib/pair.c * src/lib/radius.c * src/main/radattr.c * src/main/tmpl.c * src/modules/proto_dhcp/dhcp.c * src/modules/proto_vmps/vqp.c * src/modules/rlm_eap/libeap/eap_chbind.c * src/modules/rlm_eap/types/rlm_eap_ttls/ttls.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/1d6c8dbbbac1a2cf0cb8… ====== Accidentally removed return Arran Cudbard-Bell@2015-11-15T03:24:07Z Files modified: * src/lib/dict.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/ff5c0e561788acd2e165… ====== Only VSAs and top level attributes get inserted into the by_num hash Arran Cudbard-Bell@2015-11-15T03:24:07Z Files modified: * src/lib/dict.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/7dd1f7560a23cb9e9291… ====== Use same terminology as dictionary Arran Cudbard-Bell@2015-11-15T03:24:07Z Files modified: * src/lib/dict.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/5c3ecd0215050bbd1a34… ====== More reformatting in my_dict_init Arran Cudbard-Bell@2015-11-15T03:24:07Z Files modified: * src/lib/dict.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/e4f0e3c3155b8ae5f176… ====== Fixup BLOCK-TLV functionality We can do better checks now too! Arran Cudbard-Bell@2015-11-15T03:24:07Z Files modified: * src/lib/dict.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/6660a95446a3023dddf8… ====== Add child_by_da Arran Cudbard-Bell@2015-11-15T03:24:07Z Files modified: * src/lib/dict.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/0df0e82882790f003f68… ====== Re-Add support for EVS in my_dict_init Arran Cudbard-Bell@2015-11-15T03:24:07Z Files modified: * src/lib/dict.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/78604388b815571d64ff… ====== Formatting in my_dict_init Arran Cudbard-Bell@2015-11-15T03:24:07Z Files modified: * src/lib/dict.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/3fa225475e6aa1cebc40… ====== Packing Arran Cudbard-Bell@2015-11-15T03:24:07Z Files modified: * src/lib/dict.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/f7699a465007f773cd62… ====== Have the dictionary parser decide when to switch the parent context to VENDOR This works well, and a similar method can be applied to block TLVs Arran Cudbard-Bell@2015-11-15T03:24:06Z Files modified: * src/lib/dict.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/b3c9407c8383b6b2c13c… ====== Better error message Arran Cudbard-Bell@2015-11-15T03:24:06Z Files modified: * src/lib/dict.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/3e87716b473a771ff40c… ====== Move add vendor, and force it to add 26->Vendor Arran Cudbard-Bell@2015-11-15T03:24:06Z Files modified: * src/lib/dict.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/bd0a2f370d3e9b0fe052… ====== Remove attribute and vendor packing code in dict.c This leaves the server broken in regards to TLVs, but we'll fix that in a later commit Arran Cudbard-Bell@2015-11-15T03:24:06Z Files modified: * src/lib/dict.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/96a08c7b180e1c15a5fd… ====== Switch dict code to using type based validation instead of flag based Arran Cudbard-Bell@2015-11-15T03:24:06Z Files modified: * src/lib/dict.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/eeeb05322efa05caafe1… ====== Formatting Arran Cudbard-Bell@2015-11-15T03:24:06Z Files modified: * src/lib/dict.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/62f31b6c0e832b46d219… ====== Use new OID parsing function Arran Cudbard-Bell@2015-11-15T03:24:06Z Files modified: * src/include/libradius.h * src/lib/dict.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/2efc8dcace7d44dd7a6c… ====== Add PW_TYPE_VENDOR and use it to create attributes representing vendors Arran Cudbard-Bell@2015-11-15T03:24:06Z Files modified: * src/include/radius.h * src/lib/dict.c * src/lib/value.c * src/main/mainconfig.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/bf0d3f311b35e3f9a889… ====== Add allocation function for attributes Arran Cudbard-Bell@2015-11-15T03:24:06Z Files modified: * src/lib/dict.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/6fe75722cee5ab83a59b… ====== Add functions for recursively printing the dictionary Arran Cudbard-Bell@2015-11-15T03:24:06Z Files modified: * src/include/libradius.h * src/lib/dict.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/51f049567a83f4e71732… ====== Add functions to add and remove children from attributes This switches the code to using a bin based system for storing children Arran Cudbard-Bell@2015-11-15T03:24:05Z Files modified: * src/include/libradius.h * src/lib/dict.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/02c19d426d4fc47674fb… ====== -- This commit summary was generated @2015-11-17T00:00:06Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

Commit report for v3.0.x branch
by announce＠freeradius.org 16 Nov '15

16 Nov '15

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Minor fix Arran Cudbard-Bell@2015-11-16T22:25:18Z Files modified: * src/include/missing-h * src/lib/missing.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/46fb0cd312f060f96b33… ====== fclose destroys file descriptor Closes #1390 Arran Cudbard-Bell@2015-11-16T21:58:04Z Files modified: * src/lib/missing.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/8589e64954d911367c25… ====== Merge pull request #1389 from jpereira/fix/vdprintf1 Fixing the missing vdprintf() Arran Cudbard-Bell@2015-11-16T21:05:36Z Files modified: * src/lib/missing.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/3c6753df115504661a2b… ====== Fixing the missing vdprintf() Jorge Pereira@2015-11-16T21:03:22Z Files modified: * src/lib/missing.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/7023ee219ffbd304f762… ====== Provide fdprintf if it's missing Closes #1366 Arran Cudbard-Bell@2015-11-16T20:46:01Z Files modified: * configure * configure.ac * src/include/autoconf.h.in * src/include/missing-h * src/lib/missing.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/2f542301cda8908f5c23… ====== -- This commit summary was generated @2015-11-17T00:00:04Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

Ongoing re-architecture
by Alan DeKok 16 Nov '15

16 Nov '15

For people watching github... there's been a flurry of changes to the code in the last few weeks. This is all necessary for future expansion of the server. Arran has updated the way the dictionary API handles attributes. Previously, it assumed that all attributes could be packet into a 32-bit integer... via a terrible packing scheme. The idea at the time was that you could address any attribute at compile-time via a magic number. That functionality was never used. Worse, it prevented us from having TLVs nested more than 4 layers, and made other work harder. So it's been removed. Attributes can now be nested to almost any depth. After about 20, though, it starts getting silly. As a result of the previous change, the RADIUS encoder / decoder was updated. The decoder didn't change much, as it was already well abstracted. The encoder was almost completely re-written. It's now *much* simpler and easier to understand. What made this possible was the tests in src/tests. And the Coverity / clang scans. So we're sure that the new code works, and has minimal problems. I've been working on cleaning up the architecture of the server. Previously, the initialization code was scattered across multiple files, and wasn't very clear. If you now read radiusd.c, it's pretty clear what gets initialized, and in what order. There is more to do, of course. But the goal is a better structure which is easier to maintain, and easier to extend. Alan DeKok.

3 2

Commit report for v3.1.x branch
by announce＠freeradius.org 13 Nov '15

13 Nov '15

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Merge pull request #1386 from PP325/v3.1.x_lancom added IKEv2 Attributes to Lancom dictionary Alan DeKok@2015-11-13T16:43:51Z Files modified: * share/dictionary.lancom Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/50107c63d27686578513… ====== added IKEv2 Attributes to Lancom dictionary Pascal Penners@2015-11-13T15:44:42Z Files modified: * share/dictionary.lancom Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/15728501b35262f30179… ====== Fix oracle login errors Arran Cudbard-Bell@2015-11-13T13:49:19Z Files modified: * src/modules/rlm_sql/drivers/rlm_sql_oracle/rlm_sql_oracle.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/ba7700a613e587182abc… ====== More build warnings Alan T. DeKok@2015-11-13T02:22:25Z Files modified: * src/main/detail.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/2773b6c39025cc6caaee… ====== compile error Alan T. DeKok@2015-11-13T01:43:10Z Files modified: * src/main/detail.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/dab118c61c010a84a33c… ====== -- This commit summary was generated @2015-11-14T00:00:08Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0