- Freeradius-Devel - lists.freeradius.org

Commit report for v3.0.x branch
by announce＠freeradius.org 06 Dec '14

06 Dec '14

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Ensure data.ptr is always initialized Alan T. DeKok@2014-12-06T22:59:01Z Files modified: * src/main/modcall.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/842463307110efa798ba… ====== Doxygen Alan T. DeKok@2014-12-06T16:51:43Z Files modified: * src/lib/value.c * src/main/tmpl.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/fb46d81802956ed54f5f… ====== Don't free thing until we're done Alan T. DeKok@2014-12-06T16:49:30Z Files modified: * src/main/modcall.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/adf4d18e72f47a156b76… ====== Quiet scanner Alan T. DeKok@2014-12-06T16:45:27Z Files modified: * src/modules/rlm_cache/rlm_cache.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/a28bf065dea8a1aa83ec… ====== Remove unneeded variable Alan T. DeKok@2014-12-06T16:42:30Z Files modified: * src/main/radmin.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/10944ad216cf45f714bf… ====== Quiet scanner Alan T. DeKok@2014-12-06T16:42:18Z Files modified: * src/modules/rlm_sql/rlm_sql.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/70a9ff0d58547c01cf12… ====== Quiet scanner Alan T. DeKok@2014-12-06T16:42:08Z Files modified: * src/main/tmpl.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/8efb716a1d00d36f6fd9… ====== Quiet compiler Alan T. DeKok@2014-12-06T16:34:19Z Files modified: * src/main/evaluate.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/df7f4a6423d57e3e7430… ====== More escaping / unescaping fixes. The template names are now binary-safe if cf_new_escape The various parsing functions take a quotation character, so that they can do the correct de-escaping. The tests have been audited and updated. Alan T. DeKok@2014-12-06T16:18:14Z Files modified: * src/include/libradius.h * src/include/radiusd.h * src/include/tmpl.h * src/lib/pair.c * src/lib/value.c * src/main/evaluate.c * src/main/map.c * src/main/modcall.c * src/main/parser.c * src/main/tmpl.c * src/main/xlat.c * src/tests/keywords/escape * src/tests/keywords/escape-sequences * src/tests/unit/condition.txt Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/5ddd9b98085b10adf50d… ====== Number failure cases Alan T. DeKok@2014-12-06T16:18:14Z Files modified: * src/tests/keywords/length * src/tests/keywords/sha2 Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/d599bf3e95d94085520e… ====== Fix PREREQS so that the cache module builds Alan T. DeKok@2014-12-06T16:18:14Z Files modified: * src/modules/rlm_cache/rlm_cache.mk * src/tests/keywords/all.mk Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/d0f76d337fa65f3f24d2… ====== %n is allowed, too Alan T. DeKok@2014-12-06T16:18:14Z Files modified: * src/main/xlat.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/cfdda386c7e031ea0da3… ====== Make tmpl_alloc be binary safe Alan T. DeKok@2014-12-06T16:18:14Z Files modified: * src/main/tmpl.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/25e06cdf835566a57e28… ====== Use the new escaping for the tests Alan T. DeKok@2014-12-06T16:18:14Z Files modified: * src/main/radattr.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/e857d868df9939e28cc7… ====== Call fr_print_string instead of doing things ourselves Alan T. DeKok@2014-12-06T16:18:14Z Files modified: * src/main/tmpl.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/9c932807eac090591030… ====== Clarify fr_print_string Alan T. DeKok@2014-12-06T16:18:13Z Files modified: * src/lib/print.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/1af8b03400726acc5436… ====== Fix fr_print_string_len, too Alan T. DeKok@2014-12-06T16:18:13Z Files modified: * src/lib/print.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/8c29f52f04f449022c83… ====== Add filename unescape Arran Cudbard-Bell@2014-12-06T04:41:33Z Files modified: * src/include/radiusd.h * src/main/util.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/f9547b9e634ca0dec714… ====== Missed const Arran Cudbard-Bell@2014-12-06T04:41:26Z Files modified: * src/main/util.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/8d1b75e3307ecd3552ad… ====== Formatting Arran Cudbard-Bell@2014-12-06T03:58:38Z Files modified: * src/modules/rlm_cache/rlm_cache.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/8d4520478bb026387567… ====== Move exclusive file access functions into their own source file (exfile.c) Arran Cudbard-Bell@2014-12-06T03:57:24Z Files modified: * src/include/exfile.h * src/include/log.h * src/main/exfile.c * src/main/libfreeradius-server.mk * src/main/log.c * src/modules/rlm_detail/rlm_detail.c * src/modules/rlm_linelog/rlm_linelog.c * src/modules/rlm_sql/rlm_sql.c * src/modules/rlm_sql/rlm_sql.h * src/modules/rlm_sql/sql.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/9b3dad8830348632d267… ====== -- This commit summary was generated @2014-12-07T00:00:01Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

Commit report for master branch
by announce＠freeradius.org 06 Dec '14

06 Dec '14

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Ensure data.ptr is always initialized Alan T. DeKok@2014-12-06T22:59:13Z Files modified: * src/main/modcall.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/be9442b903666a0983e8… ====== Doxygen Alan T. DeKok@2014-12-06T16:51:51Z Files modified: * src/lib/value.c * src/main/tmpl.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/6dbeaf2a7e1e2cccd025… ====== Don't free thing until we're done Alan T. DeKok@2014-12-06T16:49:56Z Files modified: * src/main/modcall.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/71b1957c82ab9c928aa7… ====== Quiet scanner Alan T. DeKok@2014-12-06T16:49:55Z Files modified: * src/modules/rlm_cache/rlm_cache.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/b031495c2608faf0e67a… ====== Remove unneeded variable Alan T. DeKok@2014-12-06T16:49:54Z Files modified: * src/main/radmin.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/c2b0bcfe11874f9b812c… ====== Quiet scanner Alan T. DeKok@2014-12-06T16:49:51Z Files modified: * src/modules/rlm_sql/rlm_sql.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/942f2f5805d7b63aa0c2… ====== Quiet scanner Alan T. DeKok@2014-12-06T16:49:50Z Files modified: * src/main/tmpl.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/e8e37660628a10b81c2a… ====== Quiet compiler Alan T. DeKok@2014-12-06T16:49:49Z Files modified: * src/main/evaluate.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/8058c8c00e6dd472c7f0… ====== More escaping / unescaping fixes. The template names are now binary-safe if cf_new_escape The various parsing functions take a quotation character, so that they can do the correct de-escaping. The tests have been audited and updated. Alan T. DeKok@2014-12-06T16:19:07Z Files modified: * src/include/libradius.h * src/include/radiusd.h * src/include/tmpl.h * src/lib/pair.c * src/lib/value.c * src/main/evaluate.c * src/main/map.c * src/main/modcall.c * src/main/parser.c * src/main/tmpl.c * src/main/xlat.c * src/tests/keywords/escape * src/tests/keywords/escape-sequences * src/tests/unit/condition.txt Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/21d541eba2eeb926bda1… ====== Number failure cases Alan T. DeKok@2014-12-06T16:19:06Z Files modified: * src/tests/keywords/length * src/tests/keywords/sha2 Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/664bb816721b97eecfbe… ====== Fix PREREQS so that the cache module builds Alan T. DeKok@2014-12-06T16:19:04Z Files modified: * src/tests/keywords/all.mk Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/9aba84936a9965e8855a… ====== %n is allowed, too Alan T. DeKok@2014-12-06T16:19:02Z Files modified: * src/main/xlat.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/e2ec18c19db7e1fa0cd1… ====== Make tmpl_alloc be binary safe Alan T. DeKok@2014-12-06T16:19:00Z Files modified: * src/main/tmpl.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/c73488384a10d4b1dfe2… ====== Use the new escaping for the tests Alan T. DeKok@2014-12-06T16:18:58Z Files modified: * src/main/radattr.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/2898b5fc0e4e2307a696… ====== Call fr_print_string instead of doing things ourselves Alan T. DeKok@2014-12-06T16:18:56Z Files modified: * src/main/tmpl.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/0811d78d003a8bfc37d7… ====== Clarify fr_print_string Alan T. DeKok@2014-12-06T16:18:55Z Files modified: * src/lib/print.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/b6c0c1c8416fb48b2395… ====== Fix fr_print_string_len, too Alan T. DeKok@2014-12-06T16:18:54Z Files modified: * src/lib/print.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/848da208a3daf8c98382… ====== Add filename unescape Arran Cudbard-Bell@2014-12-06T04:41:09Z Files modified: * src/include/radiusd.h * src/main/util.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/b7d795853dca518d1d36… ====== Missed const Arran Cudbard-Bell@2014-12-06T04:36:39Z Files modified: * src/main/util.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/da544605c25f1d9c16ca… ====== Formatting Arran Cudbard-Bell@2014-12-06T03:58:58Z Files modified: * src/modules/rlm_cache/rlm_cache.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/bf36750a8fbf9bd50a7f… ====== Move exclusive file access functions into their own source file (exfile.c) Arran Cudbard-Bell@2014-12-06T03:58:51Z Files modified: * src/include/exfile.h * src/include/log.h * src/main/exfile.c * src/main/libfreeradius-server.mk * src/main/log.c * src/modules/rlm_detail/rlm_detail.c * src/modules/rlm_linelog/rlm_linelog.c * src/modules/rlm_sql/rlm_sql.c * src/modules/rlm_sql/rlm_sql.h * src/modules/rlm_sql/sql.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/c947aa9b7c99f19c0793… ====== -- This commit summary was generated @2014-12-07T00:00:01Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

Build issues - library paths, and debian pkg format
by Matthew Newton 05 Dec '14

05 Dec '14

Hi, Got a couple of issues building at the moment with v3.0.x - First, the libraries are getting the wrong paths again. I've been building over the last few days and have to run from within the build directory (even after --enable-developer=no and make install) otherwise I get something like /etc/freeradius/mods-enabled/cache_eap[4]: Failed to link to module 'rlm_cache': build/lib/.libs/rlm_cache_rbtree.so: cannot open shared object file: No such file or directory I've just build a debian package, and get the same thing trying to run the installed binary, so something's not building right. I seem to remember it coming up before, but can't find what the solution was at the time. Have I missed something obvious, or is something broken? Second, debian/source/format contains "3.0 (quilt)" which means that the debian build wants to find a tarball to create a diff. It can't find a tarball, so crashes out. Any reason not to set this to "3.0 (native)"? (I believe that's generally frowned upon for official Debian packages as they want an upstream tarball to diff against, but for the upstream distribution it doesn't make much sense...) Cheers, Matthew -- Matthew Newton, Ph.D. <mcn4(a)le.ac.uk> Systems Specialist, Infrastructure Services, I.T. Services, University of Leicester, Leicester LE1 7RH, United Kingdom For IT help contact helpdesk extn. 2253, <ithelp(a)le.ac.uk>

4 5

mschap via ntlm_auth over a socket
by Matthew Newton 05 Dec '14

05 Dec '14

Hi, We've been hit with the same issue that a lot of other sites seem to have seen, which is that one freeradius server just doesn't seem to be able to authenticate over a certain number of users per second, somewhere around 30 or so, to our AD domain controllers. Standard ntlm_auth -> winbind -> AD stuff. We've done things like tweak "winbind max domain connections" and "winbind max clients", but can't seem to get winbind to connect to more than one DC, or seemingly parallelise anything in any way. Though reading archives it looks like we may have to use Samba 4 for that (though I still don't understand the reason for the max connections option if it can't/won't do it; I must me missing something). I've done some digging, and looking at the winbind debug logs, it seems to be taking around 3ms to do an auth, give or take. However, using sysdig to watch the ntlm_auth process, it takes around 30ms to run. That would figure with the maximum ~30 auths per second. Now I'm not entirely sure either of these times are completely accurate, but they were far enough off to get me looking. It seems ntlm_auth has a "--helper-protocol" option to enable it to start and then process requests over stdin/stdout. This should at least cut out the process exec time. So I've hacked around and updated the mschap module in a couple of ways to allow use of this. First is to add a new option to mschap, "method", which specifies the auth method to use. Currently this can be internal, or ntlm_auth, selected depending on whether ntlm_auth is defined or not. That will now still work for backwards compatibility, but if the new "method" option is set, that overrides it. The second is to add a new method, "ntlmauth_socket", which uses a connection pool to talk to a UNIX socket to send/receive auth data to ntlm_auth. To use it you then have to add ntlm_auth to inetd to create the socket. That handles spawning enough ntlm_auth processes off to meet demand as the connection pool stuff opens the sockets. I've not been able to test it in production yet; a) because I only just wrote it, and b) because our servers are still FR2. So if anyone else is running FR3 with a heavy load and willing to try, it would be good. I fear with the amount of change control (and/or paranoia) we have now, it's going to take me a while to get FR3 near the wireless controllers :( I have tried it both standalone against Samba, and against the domain. I'm getting these results. Note that the test (eapol_test) is run sequentially, so I'm artificially limiting the throughput there. All tests PEAP/EAP-MSCHAPv2 and FR threaded (not in debug mode). Standalone machine, Samba 3, not AD. 1,000 auths: internal mschap: 21.7s using ntlm_auth exec: 29.7s with socket: 22.9s so the socket looks decidedly faster, close to the internal mschap auth speed. Domain joined machine, Samba 3, 100 auths, eapol_test being run across the network from another machine: internal mschap: 6.3s using ntlm_auth exec: 8.1s with socket: 6.5s Only 100 auths in a loop this time (not to hammer the DC too much), but the socket version still manages to get 3 more auths in per second. Finally, domain joined machine, Samba 3, 100 auths, but direct mschap with radtest on the FR host rather than eapol_test remotely: internal mschap: 4.7s using ntlm_auth exec: 6.3s with socket: 4.9s So the real question (apart from whether I've completely missed something in the above results) is whether it's actually any better under real load. I've just done a pull request, but I'm sure there are things that need looking at or fixing even if the idea possibly sane. Let me know. Cheers, Matthew -- Matthew Newton, Ph.D. <mcn4(a)le.ac.uk> Systems Specialist, Infrastructure Services, I.T. Services, University of Leicester, Leicester LE1 7RH, United Kingdom For IT help contact helpdesk extn. 2253, <ithelp(a)le.ac.uk>

5 17

Commit report for master branch
by announce＠freeradius.org 04 Dec '14

04 Dec '14

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Escape filename expansions Attributes used in xlat expansions involving filenames will now be subject to tight escaping rules to prevent injection attacks, and to allow maximum compatibility. A little scary this wasn't done already, but for most systems it would have been pretty hard to exploit in a useful way. Arran Cudbard-Bell@2014-12-04T20:40:39Z Files modified: * src/include/radiusd.h * src/main/util.c * src/modules/rlm_detail/rlm_detail.c * src/modules/rlm_linelog/rlm_linelog.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/0b2710d117ef16f24f4f… ====== Formatting Arran Cudbard-Bell@2014-12-04T20:40:35Z Files modified: * src/lib/print.c * src/lib/value.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/1d51b7ba2dd0a169e0d7… ====== Note on why we don't need to escaping for execve Arran Cudbard-Bell@2014-12-04T20:40:30Z Files modified: * src/main/exec.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/f5b90e786bd1fdd5ca2e… ====== Cache Stripped-User-Domain too Arran Cudbard-Bell@2014-12-04T16:15:01Z Files modified: * src/main/tls.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/b4a3457405567008a400… ====== Update range of cached TLS attributes Arran Cudbard-Bell@2014-12-04T16:12:14Z Files modified: * src/main/tls.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/938e0dcadd5533f2ccfb… ====== Formatting Arran Cudbard-Bell@2014-12-04T16:12:00Z Files modified: * src/main/tls.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/b1b64fbe57a05f92dee1… ====== Duplicate init Arran Cudbard-Bell@2014-12-04T16:11:56Z Files modified: * src/main/tmpl.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/c0f096fa7d08f67f0f35… ====== Slightly better debug output Arran Cudbard-Bell@2014-12-04T02:45:36Z Files modified: * src/lib/pair.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/ac378fd1d8725ec7376a… ====== Escape backslashes only when necessary Alan T. DeKok (via Arran Cudbard-Bell)@2014-12-04T02:36:15Z Files modified: * src/lib/print.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/884edf7addb6038c4df1… ====== Fix issue that caused radclient to default to sending Accounting-Request when auto was specified and Packet-Type was set Arran Cudbard-Bell@2014-12-04T02:35:48Z Files modified: * src/main/radclient.c * src/modules/rlm_eap/radeapclient.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/2c48eaecad4c04aacd2b… ====== -- This commit summary was generated @2014-12-05T00:00:02Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

Commit report for v2.x.x branch
by announce＠freeradius.org 04 Dec '14

04 Dec '14

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Backport the filename escaping fix Arran Cudbard-Bell@2014-12-04T20:49:31Z Files modified: * src/include/radiusd.h * src/main/util.c * src/modules/rlm_detail/rlm_detail.c * src/modules/rlm_linelog/rlm_linelog.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/8dbe4b8400964e4b41b2… ====== -- This commit summary was generated @2014-12-05T00:00:02Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

Commit report for v3.0.x branch
by announce＠freeradius.org 04 Dec '14

04 Dec '14

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Escape filename expansions Attributes used in xlat expansions involving filenames will now be subject to tight escaping rules to prevent injection attacks, and to allow maximum compatibility. A little scary this wasn't done already, but for most systems it would have been pretty hard to exploit in a useful way. Arran Cudbard-Bell@2014-12-04T20:40:20Z Files modified: * src/include/radiusd.h * src/main/util.c * src/modules/rlm_detail/rlm_detail.c * src/modules/rlm_linelog/rlm_linelog.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/acc89c938d3e41b87e4e… ====== Formatting Arran Cudbard-Bell@2014-12-04T20:38:05Z Files modified: * src/lib/print.c * src/lib/value.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/ca7e4eec068356ca5810… ====== Note on why we don't need to escaping for execve Arran Cudbard-Bell@2014-12-04T17:54:33Z Files modified: * src/main/exec.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/dddd1a9e19b7f9831fd7… ====== Cache Stripped-User-Domain too Arran Cudbard-Bell@2014-12-04T16:14:51Z Files modified: * src/main/tls.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/3049ce57da1de8240594… ====== Update range of cached TLS attributes Arran Cudbard-Bell@2014-12-04T16:11:46Z Files modified: * src/main/tls.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/8c30c259d8b1703c9dc3… ====== Formatting Arran Cudbard-Bell@2014-12-04T16:09:57Z Files modified: * src/main/tls.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/0d34974901ecb5ddb3de… ====== Duplicate init Arran Cudbard-Bell@2014-12-04T05:05:30Z Files modified: * src/main/tmpl.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/bda09a9a5c9e18f03039… ====== Slightly better debug output Arran Cudbard-Bell@2014-12-04T02:44:55Z Files modified: * src/lib/pair.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/8d95cf4f4dc00faa5402… ====== Fix issue that caused radclient to default to sending Accounting-Request when auto was specified and Packet-Type was set Arran Cudbard-Bell@2014-12-04T02:35:56Z Files modified: * src/main/radclient.c * src/modules/rlm_eap/radeapclient.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/a13fe5eb4dfd67c3fdbb… ====== -- This commit summary was generated @2014-12-05T00:00:02Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

Commit report for master branch
by announce＠freeradius.org 03 Dec '14

03 Dec '14

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Hmm... paper bags are fun Alan T. DeKok@2014-12-03T20:02:34Z Files modified: * src/include/libradius.h Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/e8a9aeb20913f6a8355c… ====== man: Remove references to naslist and clients Remove references to non-existent naslist and clients manpages as they are confusing. Nikolai Kondrashov (via Arran Cudbard-Bell)@2014-12-03T19:36:16Z Files modified: * man/man5/clients.conf.5 * man/man5/dictionary.5 * man/man5/users.5 Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/b652547da274e70177b3… ====== man: Remove client attribute description Remove attribute description from clients.conf(5) source as it is outdated, lists just a few attributes and wasn't updated for more than a year. Refer to clients.conf file itself, instead. Nikolai Kondrashov (via Arran Cudbard-Bell)@2014-12-03T19:35:58Z Files modified: * man/man5/clients.conf.5 Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/6d0bc87ab7799e4e3102… ====== rlm_cache_rbtree isn't in "stable". It's ALWAYS built. It has no configure script, so we don't need to recurse into it's subdirectory to configure it Alan T. DeKok@2014-12-03T19:20:33Z Files modified: * src/modules/rlm_cache/stable Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/01f7ddc122e99c923535… ====== Delete state correctly Alan T. DeKok@2014-12-03T19:20:31Z Files modified: * src/modules/rlm_eap/mem.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/b1eaf8871ec3081bdeb8… ====== Change references to vp->length to vp->vp_length Arran Cudbard-Bell@2014-12-03T18:59:32Z Files modified: * src/include/libradius.h * src/lib/debug.c * src/lib/pair.c * src/lib/print.c * src/lib/radius.c * src/main/auth.c * src/main/evaluate.c * src/main/listen.c * src/main/map.c * src/main/pair.c * src/main/radclient.c * src/main/radsniff.c * src/main/realms.c * src/main/state.c * src/main/unittest.c * src/main/xlat.c * src/modules/proto_dhcp/dhcp.c * src/modules/proto_dhcp/rlm_dhcp.c * src/modules/proto_vmps/vqp.c * src/modules/rlm_chap/rlm_chap.c * src/modules/rlm_couchbase/rlm_couchbase.c * src/modules/rlm_counter/rlm_counter.c * src/modules/rlm_cram/rlm_cram.c * src/modules/rlm_digest/rlm_digest.c * src/modules/rlm_eap/eap.c * src/modules/rlm_eap/libeap/eap_chbind.c * src/modules/rlm_eap/libeap/eapcommon.c * src/modules/rlm_eap/libeap/eapsimlib.c * src/modules/rlm_eap/libeap/mppe_keys.c * src/modules/rlm_eap/mem.c * src/modules/rlm_eap/radeapclient.c * src/modules/rlm_eap/rlm_eap.c * src/modules/rlm_eap/types/rlm_eap_gtc/rlm_eap_gtc.c * src/modules/rlm_eap/types/rlm_eap_ikev2/ike_conf.c * src/modules/rlm_eap/types/rlm_eap_leap/eap_leap.c * src/modules/rlm_eap/types/rlm_eap_md5/eap_md5.c * src/modules/rlm_eap/types/rlm_eap_mschapv2/rlm_eap_mschapv2.c * src/modules/rlm_eap/types/rlm_eap_peap/peap.c * src/modules/rlm_eap/types/rlm_eap_pwd/rlm_eap_pwd.c * src/modules/rlm_eap/types/rlm_eap_sim/rlm_eap_sim.c * src/modules/rlm_eap/types/rlm_eap_tnc/rlm_eap_tnc.c * src/modules/rlm_eap/types/rlm_eap_ttls/ttls.c * src/modules/rlm_ldap/rlm_ldap.c * src/modules/rlm_mschap/opendir.c * src/modules/rlm_mschap/rlm_mschap.c * src/modules/rlm_otp/otp_mppe.c * src/modules/rlm_otp/otp_pw_valid.c * src/modules/rlm_otp/rlm_otp.c * src/modules/rlm_pap/rlm_pap.c * src/modules/rlm_perl/rlm_perl.c * src/modules/rlm_preprocess/rlm_preprocess.c * src/modules/rlm_radutmp/rlm_radutmp.c * src/modules/rlm_realm/rlm_realm.c * src/modules/rlm_securid/mem.c * src/modules/rlm_securid/rlm_securid.c * src/modules/rlm_soh/rlm_soh.c * src/modules/rlm_sometimes/rlm_sometimes.c * src/modules/rlm_sql/rlm_sql.c * src/modules/rlm_unix/rlm_unix.c * src/modules/rlm_unpack/rlm_unpack.c * src/modules/rlm_utf8/rlm_utf8.c * src/modules/rlm_wimax/rlm_wimax.c * src/modules/rlm_yubikey/decrypt.c * src/modules/rlm_yubikey/rlm_yubikey.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/805a86e8f58745d79a16… ====== Move length out of the VALUE_PAIR structure Arran Cudbard-Bell@2014-12-03T18:59:07Z Files modified: * src/include/libradius.h Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/fe2b63a3aada7ab0b3a2… ====== Switch C99->C1X (C11) Arran Cudbard-Bell@2014-12-03T18:56:05Z Files modified: * configure * configure.ac Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/014529e9d61751666395… ====== Make IP resolution errors a bit clearer Arran Cudbard-Bell@2014-12-03T07:56:45Z Files modified: * src/lib/misc.c * src/main/radclient.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/56faf135eb015ca93606… ====== Use correct type for log_lvl and add prefix to rdebug_pair Arran Cudbard-Bell@2014-12-03T03:58:42Z Files modified: * src/include/log.h * src/include/radiusd.h * src/main/log.c * src/main/pair.c * src/main/radattr.c * src/main/radiusd.c * src/main/radmin.c * src/main/radwho.c * src/main/tls.c * src/main/unittest.c * src/modules/rlm_eap/radeapclient.c * src/modules/rlm_rest/rest.c * src/modules/rlm_sql/rlm_sql.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/b232c3f7e2d8e6aea7e4… ====== Always get the "certs" index for SSL. Alan T. DeKok (via Arran Cudbard-Bell)@2014-12-03T02:49:33Z Files modified: * src/main/tls.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/6e001239f1722dce9dce… ====== Clarify debugging message Alan T. DeKok (via Arran Cudbard-Bell)@2014-12-03T02:49:29Z Files modified: * src/modules/rlm_eap/mem.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/ca885d129d8e57bf1f94… ====== Debug attributes added in cbtls_verify Alan T. DeKok (via Arran Cudbard-Bell)@2014-12-03T02:49:21Z Files modified: * src/main/tls.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/9696c440cbc63faddf79… ====== -- This commit summary was generated @2014-12-04T00:00:01Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

Commit report for v3.0.x branch
by announce＠freeradius.org 03 Dec '14

03 Dec '14

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Escape backslashes only when necessary Alan T. DeKok@2014-12-03T22:15:43Z Files modified: * src/lib/print.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/0d5fdf42d3dc323a2d6b… ====== Merge pull request #847 from spbnick/man_clients_update clients(5) update Arran Cudbard-Bell@2014-12-03T19:31:46Z Files modified: * man/man5/clients.conf.5 * man/man5/dictionary.5 * man/man5/users.5 Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/66bace9da6557af268c8… ====== man: Remove references to naslist and clients Remove references to non-existent naslist and clients manpages as they are confusing. Nikolai Kondrashov@2014-12-02T20:53:32Z Files modified: * man/man5/clients.conf.5 * man/man5/dictionary.5 * man/man5/users.5 Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/f65b317972e5a57aa246… ====== man: Remove client attribute description Remove attribute description from clients.conf(5) source as it is outdated, lists just a few attributes and wasn't updated for more than a year. Refer to clients.conf file itself, instead. Nikolai Kondrashov@2014-12-02T20:53:31Z Files modified: * man/man5/clients.conf.5 Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/78118d54a02ee98ee184… ====== Note recent changes Alan T. DeKok@2014-12-03T19:11:28Z Files modified: * doc/ChangeLog Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/719b9cc5970d1ad32b01… ====== rlm_cache_rbtree isn't in "stable". It's ALWAYS built. It has no configure script, so we don't need to recurse into it's subdirectory to configure it Alan T. DeKok@2014-12-03T19:11:27Z Files modified: * src/modules/rlm_cache/stable Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/d63abeecf59a734df7e8… ====== Delete state correctly Alan T. DeKok@2014-12-03T19:11:27Z Files modified: * src/modules/rlm_eap/mem.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/703829d907b684e1b3fc… ====== Change references to vp->length to vp->vp_length Arran Cudbard-Bell@2014-12-03T19:07:29Z Files modified: * src/include/libradius.h * src/lib/debug.c * src/lib/pair.c * src/lib/print.c * src/lib/radius.c * src/main/auth.c * src/main/evaluate.c * src/main/listen.c * src/main/map.c * src/main/pair.c * src/main/radclient.c * src/main/radsniff.c * src/main/realms.c * src/main/state.c * src/main/unittest.c * src/main/xlat.c * src/modules/proto_dhcp/dhcp.c * src/modules/proto_dhcp/rlm_dhcp.c * src/modules/proto_vmps/vqp.c * src/modules/rlm_chap/rlm_chap.c * src/modules/rlm_couchbase/rlm_couchbase.c * src/modules/rlm_counter/rlm_counter.c * src/modules/rlm_cram/rlm_cram.c * src/modules/rlm_digest/rlm_digest.c * src/modules/rlm_eap/eap.c * src/modules/rlm_eap/libeap/eap_chbind.c * src/modules/rlm_eap/libeap/eapcommon.c * src/modules/rlm_eap/libeap/eapsimlib.c * src/modules/rlm_eap/libeap/mppe_keys.c * src/modules/rlm_eap/mem.c * src/modules/rlm_eap/radeapclient.c * src/modules/rlm_eap/rlm_eap.c * src/modules/rlm_eap/types/rlm_eap_gtc/rlm_eap_gtc.c * src/modules/rlm_eap/types/rlm_eap_ikev2/ike_conf.c * src/modules/rlm_eap/types/rlm_eap_leap/eap_leap.c * src/modules/rlm_eap/types/rlm_eap_md5/eap_md5.c * src/modules/rlm_eap/types/rlm_eap_mschapv2/rlm_eap_mschapv2.c * src/modules/rlm_eap/types/rlm_eap_peap/peap.c * src/modules/rlm_eap/types/rlm_eap_pwd/rlm_eap_pwd.c * src/modules/rlm_eap/types/rlm_eap_sim/rlm_eap_sim.c * src/modules/rlm_eap/types/rlm_eap_tnc/rlm_eap_tnc.c * src/modules/rlm_eap/types/rlm_eap_ttls/ttls.c * src/modules/rlm_ldap/rlm_ldap.c * src/modules/rlm_mschap/opendir.c * src/modules/rlm_mschap/rlm_mschap.c * src/modules/rlm_otp/otp_mppe.c * src/modules/rlm_otp/otp_pw_valid.c * src/modules/rlm_otp/rlm_otp.c * src/modules/rlm_pap/rlm_pap.c * src/modules/rlm_perl/rlm_perl.c * src/modules/rlm_preprocess/rlm_preprocess.c * src/modules/rlm_radutmp/rlm_radutmp.c * src/modules/rlm_realm/rlm_realm.c * src/modules/rlm_securid/mem.c * src/modules/rlm_securid/rlm_securid.c * src/modules/rlm_soh/rlm_soh.c * src/modules/rlm_sometimes/rlm_sometimes.c * src/modules/rlm_sql/rlm_sql.c * src/modules/rlm_unix/rlm_unix.c * src/modules/rlm_unpack/rlm_unpack.c * src/modules/rlm_utf8/rlm_utf8.c * src/modules/rlm_wimax/rlm_wimax.c * src/modules/rlm_yubikey/decrypt.c * src/modules/rlm_yubikey/rlm_yubikey.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/ae3936136afe98cee936… ====== Add vp_length macro (makes it easier to backport changes from master) Arran Cudbard-Bell@2014-12-03T19:00:31Z Files modified: * src/include/libradius.h Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/0bd582b9acd95a2591f8… ====== Make IP resolution errors a bit clearer Arran Cudbard-Bell@2014-12-03T07:56:52Z Files modified: * src/lib/misc.c * src/main/radclient.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/7859280b5b131affa597… ====== Use correct type for log_lvl and add prefix to rdebug_pair Arran Cudbard-Bell@2014-12-03T03:58:49Z Files modified: * src/include/log.h * src/include/radiusd.h * src/main/log.c * src/main/pair.c * src/main/radattr.c * src/main/radiusd.c * src/main/radmin.c * src/main/radwho.c * src/main/tls.c * src/main/unittest.c * src/modules/rlm_eap/radeapclient.c * src/modules/rlm_rest/rest.c * src/modules/rlm_sql/rlm_sql.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/e6783ae31104742673ec… ====== -- This commit summary was generated @2014-12-04T00:00:01Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

Thoughts on -std=c11
by Arran Cudbard-Bell 03 Dec '14

03 Dec '14

What are people's opinions of passing -std=c1x in master? Given that 3.1 or 4.0 is probably at least a year away, is four years enough time? Packages are more or less ubiquitous now, with the exception of Gentoo and other from src distributions, the average user never needs to touch a compiler. Many projects distribute their own packages now (as do we, through NetworkRADIUS). So even if distributions lag behind in providing updated versions of compilers like GCC or clang, or using them internally in their build farms, it's not an huge issue. GCC 4.6 was the first version to accept '-std=c1x'. It was released March 25th 2011, about five months before the standard was ratified (although full support wasn't completed until very recently). clang 3.1 was the first version to implement significant c11 features. It was released 22nd May 2012. We already use some of the major C11 features now like _Thread_local _Static_assert and _Noreturn, though where we use them, we also degrade gracefully to C99 compliant code. The big features that we want to use and can't emulate using compiler extensions, or at least can't emulate and degrade back to C99 behaviour, are anonymous structs and unions, and possibly _Generic. Anonymous unions allow: typedef struct { union { char const *strvalue; //!< Pointer to UTF-8 string. uint8_t const *octets; //!< Pointer to binary string. uint32_t integer; //!< 32bit unsigned integer. struct in_addr ipaddr; //!< IPv4 Address. uint32_t date; //!< Date (32bit Unix timestamp). size_t filter[32/sizeof(size_t)]; //!< Ascend binary format a packed data //!< structure. uint8_t ifid[8]; //!< IPv6 interface ID (should be struct?). struct in6_addr ipv6addr; //!< IPv6 Address. uint8_t ipv6prefix[18]; //!< IPv6 prefix (should be struct?). uint8_t byte; //!< 8bit unsigned integer. uint16_t ushort; //!< 16bit unsigned integer. uint8_t ether[6]; //!< Ethernet (MAC) address. int32_t sinteger; //!< 32bit signed integer. uint64_t integer64; //!< 64bit unsigned integer. uint8_t ipv4prefix[6]; //!< IPv4 prefix (should be struct?). uint8_t *tlv; //!< Nested TLV (should go away). void *ptr; //!< generic pointer. }; size_t length; //!< Length of the value. PW_TYPE type; //!< Type of value. } value_data_t; value_data_t data; data.length = 4; data.integer = 1337; And would allow us to remove the convenience macros like: #define vp_strvalue data.value.strvalue Which are annoying and sometimes confusing. They would become more useful in the near future, as In order to add attribute grouping support, we'll likely need another union within VALUE_PAIRs to hold different collections of attributes. A single VALUE_PAIR could then have a list of values, or a tree of children, and you end up needing something like: vp->data.values->value.strvalue Just to get the string ptr for a VALUE_PAIR. Anonymous unions allow that to be flattened to: vp->values->strvalue Which is much more readable. Aside from syntactical enhancements, the other extremely useful feature in C11 is the atomics. These expose atomic operations like check/set, and handle insertion of memory barriers to prevent reordering. In some cases atomics can be used to replace mutexes, which on some systems still always involve a system call, and are relatively slow. Atomics are not well supported yet, but switching to -std=c1x/-std=c11 would allow us to use them where present, and emulate them using pthread concurrency control where not. TL;DR Do people see a huge issue with requiring a compiler version no more than ~3 years old to build the master branch of the server, given that it'll likely be ~4-5 years when the code is released? Arran Cudbard-Bell <a.cudbardb(a)freeradius.org> FreeRADIUS development team FD31 3077 42EC 7FCD 32FE 5EE2 56CF 27F9 30A8 CAA2

3 5