- Freeradius-Devel - lists.freeradius.org

The server now uses talloc
by Alan DeKok 20 Feb '13

20 Feb '13

For most things. If you pulled recently, you may need to do: $ git pull --force There were a few commits done out of order. But it works. Both valgrind and the talloc memory checker report minimal errors. There are just a few listeners leaked on exit, which is partly intentional. That will be fixed once the listeners are moved to talloc. The changes result in about 800 lines of code removed from the server. That's 1%, which is small but not negligible. We expect more code to be removed as we migrate everything else to talloc. We also expect that supporting "HUP" will become easier. It may have issues today, but talloc makes it easier to have better support for HUP. I haven't done any performance tests. But the Samba people say that talloc is 4% slower than malloc. Our other tests show that most of the CPU time is spent in MD5, SSL, or in accessing external DBs. So I expect that there should be no performance impact here. Alan DeKok.

4 11

Commit report for master branch
by announce＠freeradius.org 19 Feb '13

19 Feb '13

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Fixup documentation Arran Cudbard-Bell@2013-02-19T23:18:31Z Files modified: * src/lib/radius.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/da56f0f0a936f6a3679c… ====== Associate client lists with a parent section. We now have no talloc leaks on exit. We still have a few listeners leaked on exit, but that's mostly because they haven't yet been converted to talloc Alan T. DeKok@2013-02-19T23:17:36Z Files modified: * src/include/radiusd.h * src/main/client.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/7aa8eacb9b07e4d10116… ====== -M implies -m, too Alan T. DeKok@2013-02-19T23:12:54Z Files modified: * src/main/radiusd.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/898a6fbc4c574277e13f… ====== Remove compile warnings Alan T. DeKok@2013-02-19T23:10:28Z Files modified: * src/modules/rlm_exec/rlm_exec.c * src/modules/rlm_expiration/rlm_expiration.c * src/modules/rlm_expr/rlm_expr.c * src/modules/rlm_mschap/rlm_mschap.c * src/modules/rlm_soh/rlm_soh.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/a17a0db2a3517bdb56ef… ====== Re-add TGT_PREREQS for libfreeradius-radius Alan T. DeKok@2013-02-19T23:04:57Z Files modified: * src/main/radiusd.mk Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/7c3fd9ad8978ac678a28… ====== Use destructor Alan T. DeKok@2013-02-19T23:04:56Z Files modified: * src/main/modules.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/55462c5d25df2f3e36f2… ====== Shouldn't be any config when we boot Alan T. DeKok@2013-02-19T23:04:56Z Files modified: * src/main/mainconfig.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/6d0f53cf9d7ab8274d7e… ====== Require that the modules call talloc for their instance handle. The server builds, but it WILL have talloc/malloc conflicts, as the modules have not been updated. The assumption here is that the modules return an instance handle, EVEN IF they haev an error. The server core will now take care of calling the appropriate detach() method. Alan T. DeKok@2013-02-19T23:04:56Z Files modified: * src/main/modules.c * src/modules/rlm_always/rlm_always.c * src/modules/rlm_attr_filter/rlm_attr_filter.c * src/modules/rlm_attr_rewrite/rlm_attr_rewrite.c * src/modules/rlm_cache/rlm_cache.c * src/modules/rlm_checkval/rlm_checkval.c * src/modules/rlm_counter/rlm_counter.c * src/modules/rlm_dbm/rlm_dbm.c * src/modules/rlm_detail/rlm_detail.c * src/modules/rlm_dhcp/rlm_dhcp.c * src/modules/rlm_eap/rlm_eap.c * src/modules/rlm_eap2/rlm_eap2.c * src/modules/rlm_example/rlm_example.c * src/modules/rlm_exec/rlm_exec.c * src/modules/rlm_expiration/rlm_expiration.c * src/modules/rlm_expr/rlm_expr.c * src/modules/rlm_files/rlm_files.c * src/modules/rlm_ippool/rlm_ippool.c * src/modules/rlm_krb5/rlm_krb5.c * src/modules/rlm_ldap/rlm_ldap.c * src/modules/rlm_linelog/rlm_linelog.c * src/modules/rlm_logintime/rlm_logintime.c * src/modules/rlm_mschap/rlm_mschap.c * src/modules/rlm_otp/rlm_otp.c * src/modules/rlm_pam/rlm_pam.c * src/modules/rlm_pap/rlm_pap.c * src/modules/rlm_passwd/rlm_passwd.c * src/modules/rlm_perl/rlm_perl.c * src/modules/rlm_preprocess/rlm_preprocess.c * src/modules/rlm_python/rlm_python.c * src/modules/rlm_radutmp/rlm_radutmp.c * src/modules/rlm_realm/rlm_realm.c * src/modules/rlm_redis/rlm_redis.c * src/modules/rlm_rediswho/rlm_rediswho.c * src/modules/rlm_rest/rlm_rest.c * src/modules/rlm_ruby/rlm_ruby.c * src/modules/rlm_securid/rlm_securid.c * src/modules/rlm_sim_files/rlm_sim_files.c * src/modules/rlm_smsotp/rlm_smsotp.c * src/modules/rlm_soh/rlm_soh.c * src/modules/rlm_sometimes/rlm_sometimes.c * src/modules/rlm_sql/rlm_sql.c * src/modules/rlm_sqlcounter/rlm_sqlcounter.c * src/modules/rlm_sqlhpwippool/rlm_sqlhpwippool.c * src/modules/rlm_sqlippool/rlm_sqlippool.c * src/modules/rlm_unix/rlm_unix.c * src/modules/rlm_wimax/rlm_wimax.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/81c46a695c547b8b3b34… ====== Convert rad_alloc and rad_free to use talloc Arran Cudbard-Bell (via Alan T. DeKok)@2013-02-19T23:04:56Z Files modified: * src/include/libradius.h * src/lib/dhcp.c * src/lib/radius.c * src/lib/tcp.c * src/lib/vqp.c * src/main/command.c * src/main/detail.c * src/main/dhclient.c * src/main/listen.c * src/main/process.c * src/main/radclient.c * src/main/radsniff.c * src/main/realms.c * src/main/tls_listen.c * src/main/util.c * src/modules/rlm_eap/radeapclient.c * src/modules/rlm_replicate/rlm_replicate.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/9774dee53820c00f70ee… ====== Talloc REQUESTs Arran Cudbard-Bell (via Alan T. DeKok)@2013-02-19T23:04:55Z Files modified: * src/main/util.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/b5aa136973b425ea5ab8… ====== Move virtual servers to talloc Alan T. DeKok@2013-02-19T23:04:55Z Files modified: * src/main/modules.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/704c6e77a75862f71321… ====== Clean up modules, etc. before freeing mainconfig Alan T. DeKok@2013-02-19T23:04:55Z Files modified: * src/main/mainconfig.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/490b64709a261b33ce5d… ====== Use talloc for clients.c Alan T. DeKok@2013-02-19T23:04:55Z Files modified: * src/main/client.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/155ea052fba183b692f8… ====== Make modules use talloc Alan T. DeKok@2013-02-19T23:04:55Z Files modified: * src/main/modules.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/c9113bf93b86c59da7a5… ====== Move all conf file stuff to talloc Alan T. DeKok@2013-02-19T23:04:55Z Files modified: * src/include/conffile.h * src/main/client.c * src/main/conffile.c * src/main/connection.c * src/main/listen.c * src/main/mainconfig.c * src/main/modules.c * src/main/radclient.mk * src/main/radmin.mk * src/main/realms.c * src/main/tls.c * src/modules/rlm_eap/mem.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/0f694d046e581d9cb914… ====== Move all pair* to talloc Alan T. DeKok (via Arran Cudbard-Bell)@2013-02-19T22:13:38Z Files modified: * src/include/radiusd.h * src/lib/valuepair.c * src/main/evaluate.c * src/main/util.c * src/main/valuepair.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/455d75f50dcab6d73624… ====== Use talloc functions to allocate and free valuepairs Arran Cudbard-Bell@2013-02-19T22:13:27Z Files modified: * src/lib/valuepair.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/f69f8a81f984d53050b9… ====== Add context pointer to pairalloc Arran Cudbard-Bell@2013-02-19T22:13:17Z Files modified: * src/include/libradius.h * src/lib/radius.c * src/lib/valuepair.c * src/modules/rlm_cache/rlm_cache.c * src/modules/rlm_eap/types/rlm_eap_ttls/ttls.c * src/modules/rlm_ldap/rlm_ldap.c * src/modules/rlm_rest/rest.c * src/modules/rlm_sql/rlm_sql.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/83fca22da68497eef38a… ====== Add talloc memory report on -M Arran Cudbard-Bell@2013-02-19T22:13:05Z Files modified: * src/include/radiusd.h * src/main/log.c * src/main/radiusd.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/228ff628c91236c2969c… ====== Add libtalloc to version.c Arran Cudbard-Bell@2013-02-19T22:12:53Z Files modified: * src/main/version.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/2bd4b32bc6fd85ad02d4… ====== Use talloc Alan T. DeKok (via Arran Cudbard-Bell)@2013-02-19T21:04:07Z Files modified: * src/include/libradius.h Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/e468bff39baa209e8144… ====== Cleanup checkval Arran Cudbard-Bell@2013-02-19T21:03:41Z Files modified: * src/modules/rlm_checkval/rlm_checkval.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/45814cb795c95970d203… ====== Cleanup chap Arran Cudbard-Bell@2013-02-19T21:00:10Z Files modified: * src/modules/rlm_chap/rlm_chap.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/07d10dd6cdc8bc278638… ====== Set vp->next to NULL on copy vp data Arran Cudbard-Bell@2013-02-19T20:14:33Z Files modified: * src/lib/valuepair.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/291f0e1e22d4576a1caa… ====== Update configure script to add -ltalloc Arran Cudbard-Bell@2013-02-19T20:07:16Z Files modified: * Make.inc.in * configure * configure.in * src/main/radiusd.mk Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/f564d88701cdba9441b6… ====== Don't free parsed items Alan T. DeKok@2013-02-19T19:30:59Z Files modified: * src/modules/rlm_cache/rlm_cache.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/5c0b03b69058436aa879… ====== Allocate from the dict pool, not via malloc Alan T. DeKok@2013-02-19T19:20:43Z Files modified: * src/lib/dict.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/9d663b0e8c5d9d03393a… ====== vp_prints should check for NULL da Arran Cudbard-Bell (via Alan T. DeKok)@2013-02-19T19:18:20Z Files modified: * src/lib/print.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/4d6e367ab44678444b29… ====== Print out better message on operations error Alan T. DeKok@2013-02-19T19:18:02Z Files modified: * src/modules/rlm_ldap/rlm_ldap.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/271672cb7b14f5fcef92… ====== Make more debug messages errors So that problems with the client are highlighted Alan T. DeKok@2013-02-19T19:17:58Z Files modified: * src/modules/rlm_eap/eap.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/1ad970f5b72586a1d370… ====== Removed unused definitions for LTDL Alan T. DeKok@2013-02-19T19:15:08Z Files modified: * Make.inc.in * src/main/Makefile.in * src/modules/rlm_eap/Makefile.in * src/modules/rlm_sql/Makefile.in * src/modules/rlm_sqlhpwippool/Makefile.in Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/bdffcaf02f729f575d11… ====== Don't use strncpy Alan T. DeKok@2013-02-19T19:12:49Z Files modified: * src/modules/rlm_eap/types/rlm_eap_pwd/rlm_eap_pwd.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/a61a50f944fe51d8b1a1… ====== Change slightly confusing log message Arran Cudbard-Bell@2013-02-19T18:17:16Z Files modified: * src/modules/rlm_pap/rlm_pap.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/9cafb2c41ca2dd1cde19… ====== dict_attr_free should check pointer value Arran Cudbard-Bell@2013-02-19T01:44:13Z Files modified: * src/lib/dict.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/f5fbfb8117d827bce3ca… ====== -- This commit summary was generated @2013-02-20T00:00:01Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

Export Huntgroup and User Files
by Patrick Ko 19 Feb '13

19 Feb '13

Hello everybody, is it possible to export the Huntgroups and User Files maybe inside an Module ? I want to try to export all the Huntgroup and User Files into an List inside my Module ! Is something possible ? I hope somebody could give me some helpfull Information! Greetz Patrick

3 2

Authorization in a Module
by Patrick Ko 19 Feb '13

19 Feb '13

Hello everybody, I have an Question to you. I Have an C - Module which i included into the authorize-Section of the radiusd.conf File. If If start my Radius the Module will be loaded an runs correctly. Now I'have the question ;) Is it possible to check "inside" a Module if an User is authenticated or not ? ( If yes how ? I only know the retrun Values RLM_MODULE_OK etc. but to check which value an user have i don't know ). Another thing is. Is it possible i have an external list in my Module, where other Users and Passwords are inside. Now a User tries to authenticate and if fails, but now i want that inside the module the list will be checked if it contained the User and if the List contains the User he will be authenticated! Also I have one last Question ;) At which part in the radiusd.conf the authorization is called ? I hope somebody please could help me or give me some Helpfull Information! Greetz Patrick

2 1

Re: It works!
by Alan Buxey 18 Feb '13

18 Feb '13

I assume that coloured output will be the default? I predict a lot of complaints from people saying it should be colorise ;) alan

5 5

Commit report for v2.x.x branch
by announce＠freeradius.org 18 Feb '13

18 Feb '13

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Note recent changes Alan T. DeKok@2013-02-18T20:14:10Z Files modified: * doc/ChangeLog Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/97cba57751abb4d77eba… ====== Free modules before main config Now that the modules are cleaned up correctly Alan T. DeKok@2013-02-18T20:07:46Z Files modified: * src/main/radiusd.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/e8ff8b8b5c9df161eb5d… ====== Call cf_section_parse_free before freeing sub-modules Alan T. DeKok@2013-02-18T20:07:12Z Files modified: * src/modules/rlm_eap/mem.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/15b02b937a42bcd2ec85… ====== No longer need to free conf file stuff manually. Alan T. DeKok@2013-02-18T20:07:04Z Files modified: * src/modules/rlm_sql/rlm_sql.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/c9333d89d516fef52d5a… ====== Call cf_section_parse_free before calling the module detach Alan T. DeKok@2013-02-18T20:05:34Z Files modified: * src/main/modules.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/923b6bdcc2943e91df59… ====== cf_section_parse_free() recurses into sub-sections Alan T. DeKok@2013-02-18T20:05:20Z Files modified: * src/main/conffile.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/1a77268b32d944fd0fa2… ====== One more check for size > 253 Alan T. DeKok@2013-02-18T19:34:36Z Files modified: * src/modules/rlm_eap/types/rlm_eap_ttls/ttls.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/8720e14ab425ecaff56d… ====== Check Ascend Secret length Alan T. DeKok@2013-02-18T19:32:55Z Files modified: * src/lib/radius.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/4f0c1e7a13e1d4db5763… ====== Free tlv on error condition Alan T. DeKok@2013-02-18T19:25:24Z Files modified: * src/lib/dhcp.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/71cad0a09d5c6e2a8e0c… ====== mypriority can be -1, too Alan T. DeKok@2013-02-18T15:17:33Z Files modified: * src/main/modcall.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/65b7cd5f01d80b6e15f4… ====== -- This commit summary was generated @2013-02-19T00:00:01Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

Commit report for master branch
by announce＠freeradius.org 18 Feb '13

18 Feb '13

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Older systems don't have strlcpy Alan T. DeKok@2013-02-18T22:15:05Z Files modified: * scripts/jlibtool.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/98d39b2fe150c5b36a7a… ====== Don't free config data manually. Alan T. DeKok@2013-02-18T22:15:04Z Files modified: * src/modules/rlm_sqlcounter/rlm_sqlcounter.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/933cb7915c253902e225… ====== Set vp_strvalue to NULL if the pair is marked for xlat Arran Cudbard-Bell@2013-02-18T20:14:54Z Files modified: * src/lib/valuepair.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/6ffafa2d38c504e0b913… ====== Call cf_section_parse_free before freeing sub-modules Alan T. DeKok@2013-02-18T20:02:43Z Files modified: * src/modules/rlm_eap/mem.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/323f69076d0672f41e2e… ====== No longer need to free conf file stuff manually. Alan T. DeKok@2013-02-18T20:02:15Z Files modified: * src/modules/rlm_sql/rlm_sql.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/eef14e1e6dd68bff87bd… ====== Call cf_section_parse_free before calling the module detach Alan T. DeKok@2013-02-18T20:01:56Z Files modified: * src/main/modules.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/6a62dadb238bbd6ab19e… ====== cf_section_parse_free() recurses into sub-sections Alan T. DeKok@2013-02-18T20:01:32Z Files modified: * src/main/conffile.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/ba044534e3efa8faf57a… ====== Fix coverity errors Alan T. DeKok@2013-02-18T19:31:57Z Files modified: * scripts/jlibtool.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/9e7df356f97da46855cc… ====== Unlock mutex when we find a matching connection Alan T. DeKok@2013-02-18T19:31:57Z Files modified: * src/main/connection.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/84fa208a76fc6415d4e5… ====== Free newfd on error Alan T. DeKok@2013-02-18T19:31:57Z Files modified: * src/lib/tcp.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/d300674a738f5c31b8d8… ====== Free correct VP Alan T. DeKok@2013-02-18T19:31:57Z Files modified: * src/lib/dhcp.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/152071b09c27e8817a92… ====== One more check for size > 253 Alan T. DeKok@2013-02-18T19:31:57Z Files modified: * src/modules/rlm_eap/types/rlm_eap_ttls/ttls.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/caffb59352261c6478bc… ====== Add empty field to struct Alan T. DeKok@2013-02-18T19:31:56Z Files modified: * src/modules/rlm_dhcp/rlm_dhcp.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/283472f3735ed9eaa0bf… ====== Fix for coverity (missed mutex free) Arran Cudbard-Bell@2013-02-18T19:03:56Z Files modified: * src/modules/rlm_cache/rlm_cache.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/ff753daca9d46d6d7b33… ====== More debug macros DEBUGE, DEBUGW, for errors / warnings. RDEBUG*, too. This lets the errors and warnings have a common format, so that the messages don't need to use an explicit "WARNING" string. It also means that they are now colorized: warning = bold + yellow error = bold + red This should hopefully help people who have issues reading the debug output Alan T. DeKok@2013-02-18T18:18:55Z Files modified: * src/include/radiusd.h * src/main/auth.c * src/main/client.c * src/main/command.c * src/main/conffile.c * src/main/detail.c * src/main/evaluate.c * src/main/listen.c * src/main/log.c * src/main/modcall.c * src/main/modules.c * src/main/process.c * src/main/realms.c * src/main/tls.c * src/main/tls_listen.c * src/main/valuepair.c * src/main/xlat.c * src/modules/rlm_cache/rlm_cache.c * src/modules/rlm_chap/rlm_chap.c * src/modules/rlm_detail/rlm_detail.c * src/modules/rlm_dhcp/rlm_dhcp.c * src/modules/rlm_digest/rlm_digest.c * src/modules/rlm_eap/eap.c * src/modules/rlm_eap/libeap/eap_tls.c * src/modules/rlm_eap/mem.c * src/modules/rlm_eap/rlm_eap.c * src/modules/rlm_eap/types/rlm_eap_gtc/rlm_eap_gtc.c * src/modules/rlm_eap/types/rlm_eap_ikev2/ike_conf.c * src/modules/rlm_eap/types/rlm_eap_ttls/ttls.c * src/modules/rlm_exec/rlm_exec.c * src/modules/rlm_files/rlm_files.c * src/modules/rlm_ldap/rlm_ldap.c * src/modules/rlm_mschap/rlm_mschap.c * src/modules/rlm_opendirectory/rlm_opendirectory.c * src/modules/rlm_pap/rlm_pap.c * src/modules/rlm_preprocess/rlm_preprocess.c * src/modules/rlm_radutmp/rlm_radutmp.c * src/modules/rlm_radutmp/rlm_radutmp2.c * src/modules/rlm_replicate/rlm_replicate.c * src/modules/rlm_rest/rest.c * src/modules/rlm_sqlcounter/rlm_sqlcounter.c * src/modules/rlm_wimax/rlm_wimax.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/0096dafa85bd488efa62… ====== Turn colorize off only if it was one Alan T. DeKok@2013-02-18T18:18:55Z Files modified: * src/main/mainconfig.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/5fa07dd2611533680b26… ====== Check return code of pairmark_xlat Arran Cudbard-Bell@2013-02-18T17:45:22Z Files modified: * src/modules/rlm_sql/sql.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/1d0a7422614a9238d074… ====== Whitespace fixes Arran Cudbard-Bell@2013-02-18T17:45:07Z Files modified: * src/main/evaluate.c * src/main/valuepair.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/65853e5d2bec71e214e6… ====== value.xlat should be set to NULL after being freed Arran Cudbard-Bell@2013-02-18T17:33:47Z Files modified: * src/main/evaluate.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/fa2cc787f31a5c0a0e9b… ====== Simplify copying of xlat value Alan T. DeKok@2013-02-18T17:31:21Z Files modified: * src/lib/valuepair.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/186594ebe62985322e75… ====== Remove L_CONS Alan T. DeKok@2013-02-18T17:31:21Z Files modified: * src/include/radiusd.h * src/main/conffile.c * src/main/exec.c * src/main/files.c * src/main/log.c * src/main/modcall.c * src/main/radiusd.c * src/main/realms.c * src/main/session.c * src/modules/rlm_always/rlm_always.c * src/modules/rlm_attr_filter/rlm_attr_filter.c * src/modules/rlm_eap/rlm_eap.c * src/modules/rlm_eap2/rlm_eap2.c * src/modules/rlm_files/rlm_files.c * src/modules/rlm_otp/otp_util.c * src/modules/rlm_otp/rlm_otp.c * src/modules/rlm_preprocess/rlm_preprocess.c * src/modules/rlm_python/rlm_python.c * src/modules/rlm_realm/rlm_realm.c * src/modules/rlm_ruby/rlm_ruby.c * src/modules/rlm_securid/rlm_securid.c * src/modules/rlm_smsotp/rlm_smsotp.c * src/modules/rlm_sometimes/rlm_sometimes.c * src/modules/rlm_sql/drivers/rlm_sql_iodbc/rlm_sql_iodbc.c * src/modules/rlm_sql/rlm_sql.c * src/modules/rlm_sql/sql.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/f37440e79263e5e6c8e5… ====== Remove redundant checks for colourisation Arran Cudbard-Bell@2013-02-18T17:29:50Z Files modified: * src/main/log.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/83d955042f743bf683ec… ====== Check whether it's appropriate to output colourised log messages Arran Cudbard-Bell@2013-02-18T16:42:09Z Files modified: * raddb/radiusd.conf.in * src/main/mainconfig.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/d4790f23dcaaf8e38076… ====== Quick hack for colourising log output to stderr/stdout Arran Cudbard-Bell@2013-02-18T09:02:46Z Files modified: * raddb/radiusd.conf.in * src/include/radiusd.h * src/main/log.c * src/main/mainconfig.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/6943ea14f1a76933b032… ====== Write newline on buffer truncation too Arran Cudbard-Bell@2013-02-18T08:49:51Z Files modified: * src/main/log.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/c4b2de0cfbd9b9c4ec2f… ====== -- This commit summary was generated @2013-02-19T00:00:01Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

Add Attribute inside an Module by Patrick85
by Patrick Ko 18 Feb '13

18 Feb '13

Hello Phil, thanks for your fast Reply. If I add the following the the dictonairy File I got it working: ATTRIBUTE WebPage 4001 string But now I got another Question ;) Why did I not see this Value in the Acces-Dump ? DUMP OF RADIUS PACKET (Net::Radius::Packet=HASH(0x8345f30)) Code: Access-Accept Identifier: 0 Authentic: ... Attributes: Framed-Protocol: PPP Service-Type: Framed END DUMP

2 2

Add Attribute inside an Module
by Patrick Ko 18 Feb '13

18 Feb '13

Hello everybody is it possible to add inside from a Module an Attribute. I have included an C-Modul to my freeradis which works! Now i want do add an individual Attribute like, "Web-Page" = "www.google.de" Which also works it's to change the Attribute-Value if the "State" Attribute, but I also want to have antoher Name like "State". VALUE_PAIR *reply; reply = pairmake("*State*", "*Hello State*", T_OP_EQ); pairadd(&request->reply->vps, reply); This works fine, but If now I want to add an individual Attribute it doens't work. VALUE_PAIR *reply; reply = pairmake("*Web_page*", "*www.google.de*", T_OP_EQ); pairadd(&request->reply->vps, reply); Did everyone know what did I made wrong and could help me please ? Thanks, Greetz Patrick

2 3

Commit report for master branch
by announce＠freeradius.org 17 Feb '13

17 Feb '13

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Be explicit about why were not building rlm_rest Arran Cudbard-Bell@2013-02-17T21:55:11Z Files modified: * src/modules/rlm_rest/configure * src/modules/rlm_rest/configure.in Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/2a9039c6a2555f7e4093… ====== Update autoconf.h.in Arran Cudbard-Bell@2013-02-17T21:45:15Z Files modified: * src/include/autoconf.h.in Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/6b7e8f6594602b5aa474… ====== Check for libcurl >= 17.9.1 Disable definitions for ancient code depending on libcurl Arran Cudbard-Bell@2013-02-17T21:45:15Z Files modified: * src/modules/rlm_rest/configure * src/modules/rlm_rest/configure.in * src/modules/rlm_rest/rest.h Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/e31d57ae947785dea5ee… ====== dir can't be NULL Alan T. DeKok@2013-02-17T21:38:52Z Files modified: * src/lib/dict.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/bb53413fc918049a2491… ====== Check pointers before using them Alan T. DeKok@2013-02-17T21:37:32Z Files modified: * src/modules/rlm_sql/rlm_sql.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/4ce5c62d41dd921e83de… ====== Check length of ascend secrets Alan T. DeKok@2013-02-17T21:35:22Z Files modified: * src/lib/radius.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/5cea200145a381064cff… ====== Remove finger functionality from radwho. No one uses it (or should) Alan T. DeKok@2013-02-17T21:22:30Z Files modified: * man/man1/radwho.1 * src/main/radwho.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/7d9e39991f505a65d09e… ====== Check for NULL before incrementing Alan T. DeKok@2013-02-17T21:19:03Z Files modified: * scripts/jlibtool.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/e731205fd21eb8534d17… ====== Check array[0], not array Alan T. DeKok@2013-02-17T21:16:18Z Files modified: * src/lib/valuepair.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/7c009f3b4890c0b7f956… ====== Error if the dictionaries weren't initialized Alan T. DeKok@2013-02-17T21:15:25Z Files modified: * src/main/dhcpd.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/10f7b6463ead59d654a2… ====== Correct args to memset Alan T. DeKok@2013-02-17T21:14:22Z Files modified: * src/modules/rlm_dhcp/rlm_dhcp.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/9ead7a00c9376c3b6932… ====== Use strlcpy instead of strcpy Alan T. DeKok@2013-02-17T21:13:19Z Files modified: * src/modules/rlm_mschap/smbencrypt.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/1b49c9e223f0893248f7… ====== Use sizeof instead of strlen Alan T. DeKok@2013-02-17T21:12:32Z Files modified: * scripts/jlibtool.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/e6f6cec324ec9d4f7e95… ====== Return on error Alan T. DeKok@2013-02-17T21:11:31Z Files modified: * src/lib/tcp.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/d53bb68b1dc9e169d10b… ====== EOL is EOL Alan T. DeKok@2013-02-17T21:09:16Z Files modified: * src/lib/base64.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/8847b3b9073b605da2c9… ====== EOL is EOL Alan T. DeKok@2013-02-17T21:06:49Z Files modified: * src/include/base64.h Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/59f270b46e7273bb9440… ====== Fix build error Alan T. DeKok@2013-02-17T21:00:15Z Files modified: * src/lib/packet.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/56e4d2e36b806fc1ec73… ====== d_namlen is BSD, not posix Alan T. DeKok@2013-02-17T20:52:05Z Files modified: * scripts/jlibtool.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/cac4dd549c3f258d6f50… ====== Fix for coverity (printf of non null terminated string) Arran Cudbard-Bell@2013-02-17T20:41:20Z Files modified: * src/main/radwho.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/098e1103ec3f7b3f161a… ====== Clean up and sanitize pairread() Should fix a number of coverity issues Alan T. DeKok@2013-02-17T20:37:29Z Files modified: * src/lib/valuepair.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/ac7a8091a8c90b2080c8… ====== Fix for coverity (potential buffer overflow in radlog_request) Arran Cudbard-Bell@2013-02-17T20:23:43Z Files modified: * src/main/log.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/4b1083ae919bd7bc1de4… ====== Fix race condition in conf file Closes Coverity #720457 Alan T. DeKok@2013-02-17T19:32:03Z Files modified: * src/main/conffile.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/7632754dab591a26b8a6… ====== Fix typo Alan T. DeKok@2013-02-17T19:30:39Z Files modified: * src/modules/rlm_otp/otp_radstate.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/612feb2ca22e061c1767… ====== Check for =~ and !~ Fixes Coverity #982075 Alan T. DeKok@2013-02-17T19:24:10Z Files modified: * src/modules/rlm_expr/paircmp.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/770d15d95dd2d5408eaa… ====== Check for no challenge/response in packet Closes Coverity #720480 Alan T. DeKok@2013-02-17T19:23:00Z Files modified: * src/modules/rlm_otp/otp_mppe.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/a596c76d59f86473d5b6… ====== Remove unused variables Alan T. DeKok@2013-02-17T19:23:00Z Files modified: * src/modules/rlm_perl/rlm_perl.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/832f93ced43743bc7e36… ====== Remove unused variable Alan T. DeKok@2013-02-17T19:23:00Z Files modified: * src/modules/rlm_preprocess/rlm_preprocess.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/a3d72b7c772b2755a139… ====== Fix for coverity (redundant default statement) Arran Cudbard-Bell@2013-02-17T19:12:52Z Files modified: * src/modules/rlm_sqlippool/rlm_sqlippool.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/fbecea6756016f3ef651… ====== Fix for coverity (redundant condition) Arran Cudbard-Bell@2013-02-17T19:10:36Z Files modified: * src/main/conffile.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/c219f1699c50f7733270… ====== Fix for coverity (duplicate case statements) Arran Cudbard-Bell@2013-02-17T19:07:38Z Files modified: * src/main/acct.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/2029c2d5a14e503c3bba… ====== Fix for coverity (remove redundant default statement) Arran Cudbard-Bell@2013-02-17T19:04:15Z Files modified: * src/lib/filters.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/68d25bb44c2280f29bf3… ====== Output proper error messages for prthread_setspecific failure in rlm_perl.c and lib/log.c Arran Cudbard-Bell@2013-02-17T19:02:59Z Files modified: * src/lib/log.c * src/modules/rlm_perl/rlm_perl.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/1e3d3d20ee161a7f09c3… ====== Fix for coverity (verify we parsed the proxy config section ok) Arran Cudbard-Bell@2013-02-17T18:53:50Z Files modified: * src/main/realms.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/82395d4dd28b4af8bea6… ====== Fix for covertiy Arran Cudbard-Bell@2013-02-17T18:49:57Z Files modified: * src/main/process.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/17a4a389bce8aea4bf99… ====== Fix for coverity (check setsockopt in listen.c) Arran Cudbard-Bell@2013-02-17T18:48:31Z Files modified: * src/main/listen.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/ef8306e091e2fa104671… ====== Fix for coverity (check return of ip_hton in detail.c) Arran Cudbard-Bell@2013-02-17T18:41:00Z Files modified: * src/main/detail.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/c53bbff9685fb051dcce… ====== Check return code of dup() Closes Coverity #720380, 81, 82 Alan T. DeKok@2013-02-17T18:21:31Z Files modified: * src/main/command.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/5c0a721f842216058097… ====== Don't check array for existence. Closes Coverity #720384 Alan T. DeKok@2013-02-17T18:21:31Z Files modified: * src/modules/rlm_attr_rewrite/rlm_attr_rewrite.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/4dd0b168c4fea9c1c1a5… ====== Don't check an array for existence Closes Coverity #720389 Alan T. DeKok@2013-02-17T18:21:31Z Files modified: * src/modules/rlm_sql/rlm_sql.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/bfc45c05af3f39462950… ====== Fix for coverity (bail if we can't stat the file in detail_recv) Arran Cudbard-Bell@2013-02-17T18:17:37Z Files modified: * src/main/detail.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/fccbe02926a506bced3b… ====== Fix for coverity (more radrecv stuff) Arran Cudbard-Bell@2013-02-17T18:17:36Z Files modified: * src/lib/vqp.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/a888bada6b5a43b669fb… ====== Fix for coverity Arran Cudbard-Bell@2013-02-17T18:17:36Z Files modified: * src/lib/radius.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/2bb9dfc704c80efed9b2… ====== Use strlcpy, and check sizeof module name Closes Covierty #720447 Alan T. DeKok@2013-02-17T18:12:34Z Files modified: * src/main/modules.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/ef206734051919569f79… ====== Use strlcpy Alan T. DeKok@2013-02-17T18:12:34Z Files modified: * src/modules/rlm_realm/rlm_realm.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/a5148102e2cbc4ed3f4a… ====== Fail safely if the directory exists in rad_mkdir Maybe another thread is making the directory. If so, it's OK Closes Coverity #720459 Alan T. DeKok@2013-02-17T18:12:33Z Files modified: * src/main/util.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/be1cb3220b42cc71129b… ====== Initialize IPaddr Closes Coverity #720462 Alan T. DeKok@2013-02-17T18:12:33Z Files modified: * src/main/stats.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/fd22b98fbc41550d0af4… ====== Sign error Closes Coverity #720436 Alan T. DeKok@2013-02-17T18:12:32Z Files modified: * src/modules/rlm_mschap/rlm_mschap.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/df26f8e3092b4b2d9812… ====== Clear memory using correct size Closes Coverity #720439, 40, 41 Alan T. DeKok@2013-02-17T18:12:32Z Files modified: * src/main/conffile.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/7c4090f6fb22bb65f3b3… ====== Don't expand variables if cs==NULL Closes Coverity #720373 Alan T. DeKok@2013-02-17T18:12:32Z Files modified: * src/main/conffile.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/fff985ef94b3dddf009d… ====== Fix for coverity (don't need to check recvfrom return in rad_recv_discard) Arran Cudbard-Bell@2013-02-17T18:06:27Z Files modified: * src/lib/radius.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/acb0e4f38da4d68c0ae3… ====== Fix for coverity (check return value of setsockopt) Arran Cudbard-Bell@2013-02-17T18:00:19Z Files modified: * src/lib/packet.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/a85825bf328e7c18e60d… ====== Fix for coverity Arran Cudbard-Bell@2013-02-17T18:00:18Z Files modified: * src/lib/log.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/17cab809506a036384c1… ====== Remove dead code Closes Coverity #982076 Alan T. DeKok@2013-02-17T17:40:32Z Files modified: * scripts/jlibtool.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/a77d3f53e3bc9d8027a3… ====== Remove dead code. Closes Coverity #982077 Alan T. DeKok@2013-02-17T17:40:32Z Files modified: * scripts/jlibtool.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/c19336641925e3cfd8c8… ====== Use correct flag for check Closes Coverity #982078 Alan T. DeKok@2013-02-17T17:40:32Z Files modified: * src/main/command.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/eb8ad4bf91dac9b0452b… ====== Don't free data returned from gdbm_fetch Closes Coverity #982067, 982068, 982069 Alan T. DeKok@2013-02-17T17:40:32Z Files modified: * src/modules/rlm_ippool/rlm_ippool_tool.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/1cc2f03df968dbb83938… ====== Remove dead code. Closes Coverity #982080, 982079 Alan T. DeKok@2013-02-17T17:40:32Z Files modified: * src/modules/rlm_ippool/rlm_ippool_tool.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/f04478426b17856ad696… ====== Check for NULL da. Only if dictionary files are broken. Closes Coverity #982081 Alan T. DeKok@2013-02-17T17:40:31Z Files modified: * src/lib/radius.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/bd769d812e24d13b1a5c… ====== value may be NULL. Only for admin mistake. Closes Coverity #982082 Alan T. DeKok@2013-02-17T17:40:31Z Files modified: * src/main/mainconfig.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/20f742385b733860352e… ====== Check for NULL. Closes Coverity #982083 (false positive) Alan T. DeKok@2013-02-17T17:40:31Z Files modified: * src/modules/rlm_krb5/rlm_krb5.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/e84e123c05efcabbb847… ====== Limit attrlen to 128K. Closes Coverity #982085 Alan T. DeKok@2013-02-17T17:40:31Z Files modified: * src/lib/radius.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/91a9f1cfa530e5efb80e… ====== Fix for coverity Arran Cudbard-Bell@2013-02-17T17:39:09Z Files modified: * src/modules/rlm_sql/sql.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/5696d1fb433ec3763446… ====== Fix for coverity Arran Cudbard-Bell@2013-02-17T17:35:40Z Files modified: * src/modules/rlm_radutmp/rlm_radutmp.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/8281a5a3b7e14d5b3635… ====== Fix for coverity Arran Cudbard-Bell@2013-02-17T17:27:01Z Files modified: * src/main/tls.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/83e49a1650032f04d3a1… ====== Fix for coverity Arran Cudbard-Bell@2013-02-17T17:23:09Z Files modified: * src/main/dhcpd.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/7f62f2cda675e037155d… ====== Fix for coverity (don't segv if the ruby function returns an array during intiialisation) Arran Cudbard-Bell@2013-02-17T17:17:12Z Files modified: * src/modules/rlm_ruby/rlm_ruby.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/a4b978a3a2a216145178… ====== Fix for coverity (assign return from recvfrom to a local signed variable so we can check for error conditions) Arran Cudbard-Bell@2013-02-17T16:58:22Z Files modified: * src/lib/dhcp.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/f5fd9379b53d992e37c9… ====== Unlock on error Closes Coverity #982086 Alan T. DeKok@2013-02-17T16:44:06Z Files modified: * src/modules/rlm_cache/rlm_cache.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/06f8f31406011a683c4b… ====== Add missing break Closes Coverity #982087 Alan T. DeKok@2013-02-17T16:44:06Z Files modified: * src/modules/rlm_dbm/rlm_dbm_parser.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/42e4d3f8f4106dde0096… ====== Add missing break Closes Coverity #982088 Alan T. DeKok@2013-02-17T16:44:06Z Files modified: * src/modules/rlm_krb5/rlm_krb5.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/d21249cdc0a3c6fa24af… ====== Note fall-through Closes Coverity #982089 Alan T. DeKok@2013-02-17T16:44:06Z Files modified: * src/modules/rlm_ldap/rlm_ldap.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/f3e46e68c4009c95863b… ====== Add missing break closes Coverity #982090 Alan T. DeKok@2013-02-17T16:44:06Z Files modified: * src/modules/rlm_rest/rest.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/b24bded5a3698cace087… ====== Remove unnecessary check Closes Coverity #982093 Alan T. DeKok@2013-02-17T16:44:05Z Files modified: * src/modules/rlm_counter/rlm_counter.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/24c3fbff4b37bfebdde9… ====== Use sizeof(struct) not sizeof(*struct) Closes Coverity #982094 Alan T. DeKok@2013-02-17T16:44:05Z Files modified: * src/modules/rlm_dhcp/rlm_dhcp.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/be2b69a0a88f7b39ecd8… ====== There's no need to memset data to zero Closes Coverity #982095 Alan T. DeKok@2013-02-17T16:44:05Z Files modified: * src/main/tls_listen.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/f31806e62c31860e52f6… ====== Check size of raw attributes in TTLS Closes Coverity #982096 Alan T. DeKok@2013-02-17T16:44:05Z Files modified: * src/modules/rlm_eap/types/rlm_eap_ttls/ttls.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/8079cb3ae0dfb41635d4… ====== Free vp on error Closes Coverity #982097 Alan T. DeKok@2013-02-17T16:44:05Z Files modified: * src/lib/dhcp.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/da3cef52927de4db7b4e… ====== Fix for coverity (check return value of cf_section_parse) Arran Cudbard-Bell@2013-02-17T05:15:17Z Files modified: * src/modules/rlm_rest/rlm_rest.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/a56a79b379b851985b3f… ====== Fix for coverity (potential segv for very long libpaths in run_mode) Arran Cudbard-Bell@2013-02-17T05:06:58Z Files modified: * scripts/jlibtool.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/153acd39b134e124d81d… ====== Fix for coverity (potential segv for argument names over 49 bytes in jlibtool) Arran Cudbard-Bell@2013-02-17T05:01:53Z Files modified: * scripts/jlibtool.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/a6694d004a789fdd26ab… ====== Fix for coverity (fix potential buffer overflow in cleanup_tmp_dir) Arran Cudbard-Bell@2013-02-17T04:58:28Z Files modified: * scripts/jlibtool.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/3f89fc68cb4ba022925c… ====== Fix for coverity (zero out sizeof(*fi) not sizeof(fi) in fr_fifo_free) Arran Cudbard-Bell@2013-02-17T04:49:08Z Files modified: * src/lib/fifo.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/1165b126e74f6f88ad50… ====== Fix for coverity (zero out sizeof(*packet) not sizeof(packet) in fr_dhcp_rcv) Arran Cudbard-Bell@2013-02-17T04:47:17Z Files modified: * src/lib/dhcp.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/99d4186dd12f3b731b0c… ====== Fix const warning in jlibtool Arran Cudbard-Bell@2013-02-17T04:44:36Z Files modified: * scripts/jlibtool.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/0add5a2b425a2fa6e076… ====== Fix for coverity (ensure inst is not NULL before dereferencing it in eap_pwd_initiate) Arran Cudbard-Bell@2013-02-17T04:44:36Z Files modified: * src/modules/rlm_eap/types/rlm_eap_pwd/rlm_eap_pwd.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/4d921cfe4deb2e725379… ====== Fix for covertiy (ensure we have a home_server when insert_into_proxy_hash is called) Arran Cudbard-Bell@2013-02-17T04:44:35Z Files modified: * src/main/process.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/bc2627498bbc9a18caff… ====== Fix for coverity (don't leak memory on run_mode) Arran Cudbard-Bell@2013-02-17T04:33:42Z Files modified: * scripts/jlibtool.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/5e99511fe7a105e4d177… ====== Fix for coverity (fix run command so it doesn't leak memory allocated for the command) Arran Cudbard-Bell@2013-02-17T04:29:58Z Files modified: * scripts/jlibtool.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/2fdf68bb24f3019d717a… ====== Fix for coverity (fix load_install_path so it doesn't leak memory if passed a non absolute path) Arran Cudbard-Bell@2013-02-17T04:23:14Z Files modified: * scripts/jlibtool.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/91f76e5c5f58a93c8d3f… ====== Fix for coverity (fix cleanup_tmp_dir so it doesn't leak directory handles) Arran Cudbard-Bell@2013-02-17T04:20:35Z Files modified: * scripts/jlibtool.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/98e02023b4295d8266d8… ====== Fix for coverity (don't leak memory if the object doesn't exist) Arran Cudbard-Bell@2013-02-17T04:17:53Z Files modified: * scripts/jlibtool.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/e5230679ff0153fff00a… ====== Fix for coverity (don't leak memory if we can't find the library) Arran Cudbard-Bell@2013-02-17T04:16:22Z Files modified: * scripts/jlibtool.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/a14c46cd8b8bfa85408e… ====== Fix for coverity (don't leak memory in add_rpath_noinstall) Arran Cudbard-Bell@2013-02-17T04:06:41Z Files modified: * scripts/jlibtool.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/3fd80b6bade74e77970f… ====== Fix for coverity (should use zu for sizeof) Arran Cudbard-Bell@2013-02-17T04:04:07Z Files modified: * src/lib/dhcp.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/78fecf9ca90a6c180654… ====== Fix for coverity (don't segfault if rlm_realm is called in the recv-coa section and Operator-Name isn't present) Arran Cudbard-Bell@2013-02-17T03:58:22Z Files modified: * src/modules/rlm_realm/rlm_realm.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/f470232910c2d1893fa6… ====== Fix for coverity (may pass NULL char pointer to strstr) Arran Cudbard-Bell@2013-02-17T03:52:22Z Files modified: * scripts/jlibtool.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/58f508192ca42f7ded2e… ====== Fix for coverity (array will always decompose to a pointer which will always be true) Arran Cudbard-Bell@2013-02-17T03:46:37Z Files modified: * src/main/dhcpd.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/6ee893b30fe37ed1f878… ====== Fix for coverity (fall-through is intentional) Arran Cudbard-Bell@2013-02-17T03:43:30Z Files modified: * src/main/valuepair.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/fb6cb54f7099577779f3… ====== For for coverity (don't segfault in cf_log_err if we get a NULL ci) Arran Cudbard-Bell@2013-02-17T03:38:07Z Files modified: * src/main/conffile.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/d1e442601d80f7e87b36… ====== Fix for coverity (fr_server_domain_socket should check is path is NULL) Arran Cudbard-Bell@2013-02-17T03:29:45Z Files modified: * src/main/command.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/4c2df4e13d40fa90b03e… ====== -- This commit summary was generated @2013-02-18T00:00:02Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0