- Freeradius-Devel - lists.freeradius.org

rlm_sql: default Acct-On/Off query for all backends is somewhat bogus
by Stefan Winter 05 May '08

05 May '08

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, the query states (in variants): ~ accounting_onoff_query = "\ ~ UPDATE ${acct_table1} \ ~ SET \ ~ acctstoptime = '%S', \ ~ acctsessiontime = unix_timestamp('%S') - \ ~ unix_timestamp(acctstarttime), \ ~ acctterminatecause = '%{Acct-Terminate-Cause}', \ ~ acctstopdelay = %{%{Acct-Delay-Time}:-0} \ ~ WHERE acctsessiontime = 0 \ ~ AND acctstoptime = NULL \ ~ AND nasipaddress = '%{NAS-IP-Address}' \ ~ AND acctstarttime <= '%S'" and the acctsessiontime = 0 is bad: acctsessiontime gets updated whenever an interim record updates the session. The job of the query should be to close all open sessions, not just all open sessions that have been opened recently enough to not have received an update yet. I suggest to change the WHERE to ~ WHERE acctstoptime = NULL \ ~ AND nasipaddress = '%{NAS-IP-Address}' \ ~ AND acctstarttime <= '%S'" (leaving out the acctsessiontime = 0 constraint) Greetings, Stefan Winter -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4-svn0 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iD8DBQFIFtC/+jm90f8eFWYRAi7SAJ9jFGjLwKl7yyDhSAvWukgKkd8hNQCeKjrj s4DcCitbUu0FIEx+slNwB/A= =qNWG -----END PGP SIGNATURE-----

5 9

Automatic report from sources (radiusd) between 04.05.2008 - 05.05.2008 GMT
by Automatic cvs log generator 05 May '08

05 May '08

CVS log entries from 04.05.2008 (Sun) 08:00:00 - 05.05.2008 (Mon) 08:00:02 GMT ===================================================== Summary by authors ===================================================== Author: aland File: radiusd/src/main/event.c; Revisions: 1.102 File: radiusd/raddb/sql/oracle/ippool.conf; Revisions: 1.2 File: radiusd/raddb/radiusd.conf.in; Revisions: 1.273 ===================================================== Log entries ===================================================== Description: Note user/group Modified files: File: radiusd/raddb/radiusd.conf.in; Revision: 1.273; Date: 2008/05/05 06:07:49; Author: aland; Lines: (+5 -5) ------------------------------- Description: Added header. Removed DOS CR's Modified files: File: radiusd/raddb/sql/oracle/ippool.conf; Revision: 1.2; Date: 2008/05/04 08:48:39; Author: aland; Lines: (+110 -108) ------------------------------- Description: Use correct function here, too Modified files: File: radiusd/src/main/event.c; Revision: 1.102; Date: 2008/05/05 05:59:22; Author: aland; Lines: (+3 -3) ===================================================== Summary of modified files ===================================================== File: radiusd/raddb/radiusd.conf.in Revisions: 1.273 Authors: aland (+5 -5) ------------------------------- File: radiusd/raddb/sql/oracle/ippool.conf Revisions: 1.2 Authors: aland (+110 -108) ------------------------------- File: radiusd/src/main/event.c Revisions: 1.102 Authors: aland (+3 -3) -- Automatic cron job from /web/pages/us.freeradius.org/bin/new_makelog.pl

1 0

Automatic report from sources (radiusd) between 03.05.2008 - 04.05.2008 GMT
by Automatic cvs log generator 04 May '08

04 May '08

CVS log entries from 03.05.2008 (Sat) 08:00:00 - 04.05.2008 (Sun) 08:00:00 GMT ===================================================== Summary by authors ===================================================== Author: aland File: radiusd/src/main/event.c; Revisions: 1.101 Author: pnixon File: radiusd/raddb/sql/oracle/msqlippool.txt; Revisions: 1.1 File: radiusd/raddb/sql/oracle/ippool.conf; Revisions: 1.1 File: radiusd/raddb/sql/mysql/dialup.conf; Revisions: 1.8 ===================================================== Combined list of identical log entries ===================================================== Description: Add IPPOOL setup for Oracle (Untested by me but reported to work) Modified files: File: radiusd/raddb/sql/oracle/ippool.conf; Revision: 1.1; Date: 2008/05/03 17:23:04; Author: pnixon; File: radiusd/raddb/sql/oracle/msqlippool.txt; Revision: 1.1; Date: 2008/05/03 17:23:04; Author: pnixon; ===================================================== Log entries ===================================================== Description: "WHERE acctstoptime = NULL" does NOT do what you think it does! Modified files: File: radiusd/raddb/sql/mysql/dialup.conf; Revision: 1.8; Date: 2008/05/03 17:16:07; Author: pnixon; Lines: (+4 -4) ------------------------------- Description: Enable internal proxying of accounting packets, too Modified files: File: radiusd/src/main/event.c; Revision: 1.101; Date: 2008/05/04 06:51:14; Author: aland; Lines: (+15 -3) ===================================================== Summary of modified files ===================================================== File: radiusd/raddb/sql/mysql/dialup.conf Revisions: 1.8 Authors: pnixon (+4 -4) ------------------------------- File: radiusd/raddb/sql/oracle/ippool.conf Revisions: 1.1 Authors: pnixon ------------------------------- File: radiusd/raddb/sql/oracle/msqlippool.txt Revisions: 1.1 Authors: pnixon ------------------------------- File: radiusd/src/main/event.c Revisions: 1.101 Authors: aland (+15 -3) -- Automatic cron job from /web/pages/us.freeradius.org/bin/new_makelog.pl

1 0

Automatic report from sources (radiusd) between 02.05.2008 - 03.05.2008 GMT
by Automatic cvs log generator 03 May '08

03 May '08

CVS log entries from 02.05.2008 (Fri) 08:00:00 - 03.05.2008 (Sat) 08:00:00 GMT ===================================================== Summary by authors ===================================================== Author: aland File: radiusd/raddb/certs/Makefile; Revisions: 1.10 File: radiusd/src/main/evaluate.c; Revisions: 1.42 ===================================================== Log entries ===================================================== Description: Make ca.der by default Modified files: File: radiusd/raddb/certs/Makefile; Revision: 1.10; Date: 2008/05/02 08:25:49; Author: aland; Lines: (+2 -2) ------------------------------- Description: un-break stuff Modified files: File: radiusd/src/main/evaluate.c; Revision: 1.42; Date: 2008/05/02 09:11:18; Author: aland; Lines: (+35 -17) ===================================================== Summary of modified files ===================================================== File: radiusd/raddb/certs/Makefile Revisions: 1.10 Authors: aland (+2 -2) ------------------------------- File: radiusd/src/main/evaluate.c Revisions: 1.42 Authors: aland (+35 -17) -- Automatic cron job from /web/pages/us.freeradius.org/bin/new_makelog.pl

1 0

Automatic report from sources (radiusd) between 01.05.2008 - 02.05.2008 GMT
by Automatic cvs log generator 02 May '08

02 May '08

CVS log entries from 01.05.2008 (Thu) 08:00:01 - 02.05.2008 (Fri) 08:00:00 GMT ===================================================== Summary by authors ===================================================== Author: aland File: radiusd/share/dictionary.hp; Revisions: 1.5 File: radiusd/src/main/evaluate.c; Revisions: 1.41 ===================================================== Log entries ===================================================== Description: Added duplicate names for HP's attributes Modified files: File: radiusd/share/dictionary.hp; Revision: 1.5; Date: 2008/05/02 00:11:16; Author: aland; Lines: (+8 -1) ------------------------------- Description: Fix handling of request->username Modified files: File: radiusd/src/main/evaluate.c; Revision: 1.41; Date: 2008/05/01 14:48:17; Author: aland; Lines: (+13 -15) ===================================================== Summary of modified files ===================================================== File: radiusd/share/dictionary.hp Revisions: 1.5 Authors: aland (+8 -1) ------------------------------- File: radiusd/src/main/evaluate.c Revisions: 1.41 Authors: aland (+13 -15) -- Automatic cron job from /web/pages/us.freeradius.org/bin/new_makelog.pl

1 0

Automatic report from sources (radiusd) between 30.04.2008 - 01.05.2008 GMT
by Automatic cvs log generator 01 May '08

01 May '08

CVS log entries from 30.04.2008 (Wed) 08:00:00 - 01.05.2008 (Thu) 08:00:01 GMT ===================================================== Summary by authors ===================================================== Author: aland File: radiusd/redhat/freeradius.spec; Revisions: 1.31 File: radiusd/src/include/radiusd.h; Revisions: 1.263 File: radiusd/doc/ChangeLog; Revisions: 1.95 File: radiusd/src/main/Makefile.in; Revisions: 1.76 File: radiusd/src/lib/event.c; Revisions: 1.20 File: radiusd/suse/freeradius.spec; Revisions: 1.27 File: radiusd/src/main/evaluate.c; Revisions: 1.40, 1.39 File: radiusd/raddb/sql/postgresql/admin.sql; Revisions: 1.1 File: radiusd/raddb/sql/mysql/admin.sql; Revisions: 1.1 File: radiusd/debian/changelog; Revisions: 1.80 File: radiusd/src/main/client.c; Revisions: 1.80 File: radiusd/raddb/sql/mssql/dialup.conf; Revisions: 1.4 File: radiusd/raddb/sites-available/README; Revisions: 1.4 File: radiusd/doc/rlm_sql; Revisions: 1.9 File: radiusd/raddb/sql/postgresql/dialup.conf; Revisions: 1.9 File: radiusd/raddb/sql/oracle/dialup.conf; Revisions: 1.4 File: radiusd/raddb/sql/mysql/dialup.conf; Revisions: 1.7 ===================================================== Combined list of identical log entries ===================================================== Description: Note 2.0.4 Modified files: File: radiusd/debian/changelog; Revision: 1.80; Date: 2008/04/30 17:38:57; Author: aland; Lines: (+33 -0) File: radiusd/redhat/freeradius.spec; Revision: 1.31; Date: 2008/04/30 17:38:57; Author: aland; Lines: (+1 -1) File: radiusd/suse/freeradius.spec; Revision: 1.27; Date: 2008/04/30 17:38:57; Author: aland; Lines: (+1 -1) ------------------------------- Description: In the accounting on/off query, remove the restriction that the session time has to be zero. The session MAY have been updated via interim-update before the NAS rebooted. Modified files: File: radiusd/raddb/sql/mssql/dialup.conf; Revision: 1.4; Date: 2008/04/30 08:33:39; Author: aland; Lines: (+2 -2) File: radiusd/raddb/sql/mysql/dialup.conf; Revision: 1.7; Date: 2008/04/30 08:33:39; Author: aland; Lines: (+2 -3) File: radiusd/raddb/sql/oracle/dialup.conf; Revision: 1.4; Date: 2008/04/30 08:33:39; Author: aland; Lines: (+2 -2) File: radiusd/raddb/sql/postgresql/dialup.conf; Revision: 1.9; Date: 2008/04/30 08:33:40; Author: aland; Lines: (+2 -3) ------------------------------- Description: Expose the "fixed" pairmove function Modified files: File: radiusd/src/include/radiusd.h; Revision: 1.263; Date: 2008/04/30 10:00:53; Author: aland; Lines: (+3 -2) File: radiusd/src/main/evaluate.c; Revision: 1.39; Date: 2008/04/30 10:00:53; Author: aland; Lines: (+7 -4) ===================================================== Log entries ===================================================== Description: Note recent changes Modified files: File: radiusd/doc/ChangeLog; Revision: 1.95; Date: 2008/04/30 08:56:40; Author: aland; Lines: (+8 -2) ------------------------------- Description: Note schema location Modified files: File: radiusd/doc/rlm_sql; Revision: 1.9; Date: 2008/04/30 17:41:36; Author: aland; Lines: (+3 -1) ------------------------------- Description: Corrected typo Modified files: File: radiusd/raddb/sites-available/README; Revision: 1.4; Date: 2008/04/30 17:42:15; Author: aland; Lines: (+1 -1) ------------------------------- Description: Sample scripts for creating radius user in SQL. Modified files: File: radiusd/raddb/sql/mysql/admin.sql; Revision: 1.1; Date: 2008/04/30 08:41:30; Author: aland; ------------------------------- Description: Added sample (untested) for PostgreSQL Modified files: File: radiusd/raddb/sql/postgresql/admin.sql; Revision: 1.1; Date: 2008/04/30 08:53:06; Author: aland; ------------------------------- Description: Clean up memory on exit Modified files: File: radiusd/src/lib/event.c; Revision: 1.20; Date: 2008/04/30 08:17:22; Author: aland; Lines: (+9 -2) ------------------------------- Description: Note dependency for dhcpd.c Modified files: File: radiusd/src/main/Makefile.in; Revision: 1.76; Date: 2008/04/30 17:43:19; Author: aland; Lines: (+4 -1) ------------------------------- Description: Clean up more memory Modified files: File: radiusd/src/main/client.c; Revision: 1.80; Date: 2008/04/30 17:43:34; Author: aland; Lines: (+3 -2) ------------------------------- Description: Be a little more careful about updating request->username && request->password Modified files: File: radiusd/src/main/evaluate.c; Revision: 1.40; Date: 2008/04/30 13:23:42; Author: aland; Lines: (+6 -3) ===================================================== Summary of modified files ===================================================== File: radiusd/debian/changelog Revisions: 1.80 Authors: aland (+33 -0) ------------------------------- File: radiusd/doc/ChangeLog Revisions: 1.95 Authors: aland (+8 -2) ------------------------------- File: radiusd/doc/rlm_sql Revisions: 1.9 Authors: aland (+3 -1) ------------------------------- File: radiusd/raddb/sites-available/README Revisions: 1.4 Authors: aland (+1 -1) ------------------------------- File: radiusd/raddb/sql/mssql/dialup.conf Revisions: 1.4 Authors: aland (+2 -2) ------------------------------- File: radiusd/raddb/sql/mysql/admin.sql Revisions: 1.1 Authors: aland ------------------------------- File: radiusd/raddb/sql/mysql/dialup.conf Revisions: 1.7 Authors: aland (+2 -3) ------------------------------- File: radiusd/raddb/sql/oracle/dialup.conf Revisions: 1.4 Authors: aland (+2 -2) ------------------------------- File: radiusd/raddb/sql/postgresql/admin.sql Revisions: 1.1 Authors: aland ------------------------------- File: radiusd/raddb/sql/postgresql/dialup.conf Revisions: 1.9 Authors: aland (+2 -3) ------------------------------- File: radiusd/redhat/freeradius.spec Revisions: 1.31 Authors: aland (+1 -1) ------------------------------- File: radiusd/src/include/radiusd.h Revisions: 1.263 Authors: aland (+3 -2) ------------------------------- File: radiusd/src/lib/event.c Revisions: 1.20 Authors: aland (+9 -2) ------------------------------- File: radiusd/src/main/Makefile.in Revisions: 1.76 Authors: aland (+4 -1) ------------------------------- File: radiusd/src/main/client.c Revisions: 1.80 Authors: aland (+3 -2) ------------------------------- File: radiusd/src/main/evaluate.c Revisions: 1.40, 1.39 Authors: aland (+6 -3), aland (+7 -4) ------------------------------- File: radiusd/suse/freeradius.spec Revisions: 1.27 Authors: aland (+1 -1) -- Automatic cron job from /web/pages/us.freeradius.org/bin/new_makelog.pl

1 0

Automatic report from sources (radiusd) between 29.04.2008 - 30.04.2008 GMT
by Automatic cvs log generator 30 Apr '08

30 Apr '08

CVS log entries from 29.04.2008 (Tue) 08:00:00 - 30.04.2008 (Wed) 08:00:00 GMT ===================================================== Summary by authors ===================================================== Author: aland File: radiusd/doc/ChangeLog; Revisions: 1.94 File: radiusd/raddb/sql/postgresql/nas.sql; Revisions: 1.2 File: radiusd/raddb/sql/oracle/nas.sql; Revisions: 1.2 File: radiusd/raddb/sql/mysql/nas.sql; Revisions: 1.2 File: radiusd/src/modules/rlm_sql/rlm_sql.c; Revisions: 1.179 File: radiusd/scripts/create-users.pl; Revisions: 1.4 ===================================================== Combined list of identical log entries ===================================================== Description: Add example "server" entry (commented out) Modified files: File: radiusd/raddb/sql/mysql/nas.sql; Revision: 1.2; Date: 2008/04/29 08:14:34; Author: aland; Lines: (+1 -0) File: radiusd/raddb/sql/oracle/nas.sql; Revision: 1.2; Date: 2008/04/29 08:14:34; Author: aland; Lines: (+3 -0) File: radiusd/raddb/sql/postgresql/nas.sql; Revision: 1.2; Date: 2008/04/29 08:14:34; Author: aland; Lines: (+3 -0) ===================================================== Log entries ===================================================== Description: Note recent updates Modified files: File: radiusd/doc/ChangeLog; Revision: 1.94; Date: 2008/04/29 08:14:47; Author: aland; Lines: (+4 -1) ------------------------------- Description: Use Cleartext-Password, not User-Password Modified files: File: radiusd/scripts/create-users.pl; Revision: 1.4; Date: 2008/04/29 09:06:20; Author: aland; Lines: (+1 -1) ------------------------------- Description: Added ability to read virtual server from SQL. Patch from Michael Bretterklieber Modified files: File: radiusd/src/modules/rlm_sql/rlm_sql.c; Revision: 1.179; Date: 2008/04/29 08:10:37; Author: aland; Lines: (+10 -5) ===================================================== Summary of modified files ===================================================== File: radiusd/doc/ChangeLog Revisions: 1.94 Authors: aland (+4 -1) ------------------------------- File: radiusd/raddb/sql/mysql/nas.sql Revisions: 1.2 Authors: aland (+1 -0) ------------------------------- File: radiusd/raddb/sql/oracle/nas.sql Revisions: 1.2 Authors: aland (+3 -0) ------------------------------- File: radiusd/raddb/sql/postgresql/nas.sql Revisions: 1.2 Authors: aland (+3 -0) ------------------------------- File: radiusd/scripts/create-users.pl Revisions: 1.4 Authors: aland (+1 -1) ------------------------------- File: radiusd/src/modules/rlm_sql/rlm_sql.c Revisions: 1.179 Authors: aland (+10 -5) -- Automatic cron job from /web/pages/us.freeradius.org/bin/new_makelog.pl

1 0

nas-list from db vs. vserver
by Michael Bretterklieber 29 Apr '08

29 Apr '08

Hi, we found a small issue, when reading the naslist/client-list from a sql-db, it's not possible to get the vserver-name like in the clients.conf. Here's small patch whitch solves the problem: --- rlm_sql.c.orig 2008-04-28 11:49:06.000000000 +0200 +++ rlm_sql.c 2008-04-28 11:49:11.000000000 +0200 @@ -221,6 +221,7 @@ RADCLIENT *c; char *prefix_ptr = NULL; unsigned int i = 0; + int numf = 0; DEBUG("rlm_sql (%s): Processing generate_sql_clients", inst->config->xlat_name); @@ -254,6 +255,7 @@ * 2. Shortname * 3. Type * 4. Secret + * 5. Virtual Server (optional) */ if (!row[0]){ radlog(L_ERR, "rlm_sql (%s): No row id found on pass %d",inst->config->xlat_name,i); @@ -322,16 +324,21 @@ } /* - * Other values (secret, shortname, nastype) + * Other values (secret, shortname, nastype, virtual_server) */ c->secret = strdup(row[4]); c->shortname = strdup(row[2]); if(row[3] != NULL) c->nastype = strdup(row[3]); - DEBUG("rlm_sql (%s): Adding client %s (%s) to clients list", + numf = (inst->module->sql_num_fields)(sqlsocket, inst->config); + if (numf > 5) + if (row[5] != NULL) + c->server = strdup(row[5]); + + DEBUG("rlm_sql (%s): Adding client %s (%s, server=%s) to clients list", inst->config->xlat_name, - c->longname,c->shortname); + c->longname,c->shortname, c->server ? c->server : "<none>"); if (!client_add(NULL, c)) { DEBUG("rlm_sql (%s): Failed to add client %s (%s) to clients list. Maybe there's a duplicate?", inst->config->xlat_name, the NASquery could then look like: nas_query = "SELECT id, nasname, shortname, type, secret, virtual_server FROM ${nas_table}" The additional vserver field is optional, so it's backwards-compatible. any chance to get it commited? thanx, bye, Michi

2 4

Automatic report from sources (radiusd) between 28.04.2008 - 29.04.2008 GMT
by Automatic cvs log generator 29 Apr '08

29 Apr '08

CVS log entries from 28.04.2008 (Mon) 08:00:00 - 29.04.2008 (Tue) 08:00:00 GMT ===================================================== Summary by authors ===================================================== Author: aland File: radiusd/raddb/sites-available/robust-proxy-accounting; Revisions: 1.2 File: radiusd/src/modules/rlm_sqlippool/rlm_sqlippool.c; Revisions: 1.38 ===================================================== Log entries ===================================================== Description: More comments Modified files: File: radiusd/raddb/sites-available/robust-proxy-accounting; Revision: 1.2; Date: 2008/04/28 14:53:17; Author: aland; Lines: (+10 -1) ------------------------------- Description: Re-format for whitespace changes and some debug messages Modified files: File: radiusd/src/modules/rlm_sqlippool/rlm_sqlippool.c; Revision: 1.38; Date: 2008/04/28 12:25:23; Author: aland; Lines: (+169 -95) ===================================================== Summary of modified files ===================================================== File: radiusd/raddb/sites-available/robust-proxy-accounting Revisions: 1.2 Authors: aland (+10 -1) ------------------------------- File: radiusd/src/modules/rlm_sqlippool/rlm_sqlippool.c Revisions: 1.38 Authors: aland (+169 -95) -- Automatic cron job from /web/pages/us.freeradius.org/bin/new_makelog.pl

1 0

freeradius resources
by wlan＠mac.com 28 Apr '08

28 Apr '08

Hello all, If you work with java, this may be of interest. Added to the JRadius subversion is a iBATIS abator configuration and generated files for the mod-sql database. Abator config: http://dev.coova.org/svn/cjradius/abatorConfig.xml Generated files: http://dev.coova.org/svn/cjradius/java/dal/net/ jradius/dal/ In addition to the standard abator data layer classes and xml, there are also generated "JSON" conversion classes (used for a user interface). There is also a development snapshot of JRadius available: http://coova.org/phpBB3/viewtopic.php?f=5&t=707 It uses the above data and json layers to create a user interface for the database - in addition to a work-in-progress GUI for FreeRADIUS itself. Cheers, David

1 0