- Freeradius-Devel - lists.freeradius.org

Automatic report from sources (radiusd) between 04.12.2007 - 05.12.2007 GMT
by Automatic cvs log generator 05 Dec '07

05 Dec '07

CVS log entries from 04.12.2007 (Tue) 09:00:00 - 05.12.2007 (Wed) 09:00:00 GMT ===================================================== Summary by authors ===================================================== Author: nbk File: radiusd/src/main/radrelay.c; Revisions: 1.22.2.3.2.5 ===================================================== Log entries ===================================================== Description: Update radrelay to interact correctly with rlm_detail. This fixes the error message "Failed to aquire filelock" reported to the mailing list. The new method is now: 1. Open detail.work if it exists, or move detail to detail.work 2. Lock detail.work to wait for any rlm_detail to finish writing one last record 3. Read records 4. Close (and unlock) detail.work 5. Delete detail.work Many thanks to Brian De Wolf <bldewolf(a)csupomona.edu> for writing the patch. Modified files: File: radiusd/src/main/radrelay.c; Revision: 1.22.2.3.2.5; Date: 2007/12/04 17:22:53; Author: nbk; Lines: (+32 -97) ===================================================== Summary of modified files ===================================================== File: radiusd/src/main/radrelay.c Revisions: 1.22.2.3.2.5 Authors: nbk (+32 -97) -- Automatic cron job from /web/pages/us.freeradius.org/bin/new_makelog.pl

1 0

1.1.7 rlm_detail locking is broken
by Brian De Wolf 04 Dec '07

04 Dec '07

Hello, I recently installed freeradius and have it forwarding accounting information. I noticed that there were a lot of failed locks in the logs, so I began to investigate. In rlm_detail, I found this loop for locking: do { if (inst->locking) { lseek(outfd, 0L, SEEK_SET); if (rad_lockfd_nonblock(outfd, 0) < 0) { close(outfd); tv.tv_sec = 0; tv.tv_usec = 25000; select(0, NULL, NULL, NULL, &tv); lock_count++; } else { DEBUG("rlm_detail: Acquired filelock, tried %d time(s)", lock_count + 1); locked = 1; } } } while (!locked && inst->locking && lock_count < 80); This loop, if it fails on the first lock, might as well not try again. Why? Because it closes the file descriptor when it fails. All of the following calls just come back with 'bad file descriptor'. The oddest part about this is that I had found this thread: http://osdir.com/ml/freeradius.devel/2005-03/msg00112.html It looks like the locking should work perfectly! But it seems these changes never found their way into the 1.x series, despite having occurred two years ago. I poked around in CVS and found revision 1.43 which is when the corrected locking was added. I took a diff of revision 1.42 and 1.43, and applied it by hand to 1.1.7. I haven't had any complaints from freeradius about locking issues since. I have attached the patch. Is there any reason this never found its way into the 1.x series? I see it's in the CVS head. --- src/modules/rlm_detail/rlm_detail.c.orig 2007-11-21 14:53:45.000000000 -0800 +++ src/modules/rlm_detail/rlm_detail.c 2007-11-26 11:41:58.000000000 -0800 @@ -271,25 +271,24 @@ *p = '/'; } /* else there was no directory delimiter. */ - /* - * Open & create the file, with the given permissions. - */ - if ((outfd = open(buffer, O_WRONLY | O_APPEND | O_CREAT, - inst->detailperm)) < 0) { - radlog(L_ERR, "rlm_detail: Couldn't open file %s: %s", - buffer, strerror(errno)); - return RLM_MODULE_FAIL; - } - - /* - * If we're not using locking, we'll just pass straight though - * the while loop. - * If we fail to aquire the filelock in 80 tries (approximately - * two seconds) we bail out. - */ locked = 0; lock_count = 0; do { + /* + * Open & create the file, with the given + * permissions. + */ + if ((outfd = open(buffer, O_WRONLY | O_APPEND | O_CREAT, + inst->detailperm)) < 0) { + radlog(L_ERR, "rlm_detail: Couldn't open file %s: %s", + buffer, strerror(errno)); + return RLM_MODULE_FAIL; + } + + /* + * If we fail to aquire the filelock in 80 tries + * (approximately two seconds) we bail out. + */ if (inst->locking) { lseek(outfd, 0L, SEEK_SET); if (rad_lockfd_nonblock(outfd, 0) < 0) { @@ -298,15 +297,36 @@ tv.tv_usec = 25000; select(0, NULL, NULL, NULL, &tv); lock_count++; - } else { - DEBUG("rlm_detail: Acquired filelock, tried %d time(s)", - lock_count + 1); - locked = 1; + continue; + } + + /* + * The file might have been deleted by + * radrelay while we tried to acquire + * the lock (race condition) + */ + if (fstat(outfd, &st) != 0) { + radlog(L_ERR, "rlm_detail: Couldn't stat file %s: %s", + buffer, strerror(errno)); + close(outfd); + return RLM_MODULE_FAIL; } + if (st.st_nlink == 0) { + DEBUG("rlm_detail: File %s removed by another program, retrying", + buffer); + close(outfd); + lock_count = 0; + continue; + } + + DEBUG("rlm_detail: Acquired filelock, tried %d time(s)", + lock_count + 1); + locked = 1; } - } while (!locked && inst->locking && lock_count < 80); + } while (inst->locking && !locked && lock_count < 80); - if (!locked && inst->locking && lock_count >= 80) { + if (inst->locking && !locked) { + close(outfd); radlog(L_ERR, "rlm_detail: Failed to aquire filelock for %s, giving up", buffer); return RLM_MODULE_FAIL;

3 8

Automatic report from sources (radiusd) between 02.12.2007 - 03.12.2007 GMT
by Automatic cvs log generator 03 Dec '07

03 Dec '07

CVS log entries from 02.12.2007 (Sun) 09:00:01 - 03.12.2007 (Mon) 09:00:01 GMT ===================================================== Summary by authors ===================================================== Author: aland File: radiusd/src/main/modules.c; Revisions: 1.153 File: radiusd/src/include/smux.h; Revisions: 1.12 File: radiusd/src/main/mainconfig.c; Revisions: 1.135 File: radiusd/src/main/radiusd.c; Revisions: 1.383 File: radiusd/src/modules/rlm_detail/rlm_detail.c; Revisions: 1.65 File: radiusd/src/main/smux.c; Revisions: 1.26 File: radiusd/src/main/radius_snmp.c; Revisions: 1.44 ===================================================== Combined list of identical log entries ===================================================== Description: Call lt_dlexit() AFTER detach modules. Call xlat_free() AFTER detach modules. Move module instances to a tree, in preparation for getting rid of cf_data (which should help with HUP) Modified files: File: radiusd/src/main/mainconfig.c; Revision: 1.135; Date: 2007/12/02 15:48:14; Author: aland; Lines: (+2 -4) File: radiusd/src/main/modules.c; Revision: 1.153; Date: 2007/12/02 15:48:15; Author: aland; Lines: (+53 -12) File: radiusd/src/main/radiusd.c; Revision: 1.383; Date: 2007/12/02 15:48:14; Author: aland; Lines: (+4 -2) ===================================================== Log entries ===================================================== Description: Reference net-snmp API, if it exists Modified files: File: radiusd/src/include/smux.h; Revision: 1.12; Date: 2007/12/02 16:52:51; Author: aland; Lines: (+8 -4) ------------------------------- Description: Fix more compiler warnings Modified files: File: radiusd/src/main/radius_snmp.c; Revision: 1.44; Date: 2007/12/02 16:43:16; Author: aland; Lines: (+62 -62) ------------------------------- Description: Fix all compiler warnings. With luck, this will fix 64-bit issues, too Modified files: File: radiusd/src/main/smux.c; Revision: 1.26; Date: 2007/12/02 16:37:16; Author: aland; Lines: (+44 -43) ------------------------------- Description: Safer way of setting things Modified files: File: radiusd/src/modules/rlm_detail/rlm_detail.c; Revision: 1.65; Date: 2007/12/02 23:40:32; Author: aland; Lines: (+4 -3) ===================================================== Summary of modified files ===================================================== File: radiusd/src/include/smux.h Revisions: 1.12 Authors: aland (+8 -4) ------------------------------- File: radiusd/src/main/mainconfig.c Revisions: 1.135 Authors: aland (+2 -4) ------------------------------- File: radiusd/src/main/modules.c Revisions: 1.153 Authors: aland (+53 -12) ------------------------------- File: radiusd/src/main/radius_snmp.c Revisions: 1.44 Authors: aland (+62 -62) ------------------------------- File: radiusd/src/main/radiusd.c Revisions: 1.383 Authors: aland (+4 -2) ------------------------------- File: radiusd/src/main/smux.c Revisions: 1.26 Authors: aland (+44 -43) ------------------------------- File: radiusd/src/modules/rlm_detail/rlm_detail.c Revisions: 1.65 Authors: aland (+4 -3) -- Automatic cron job from /web/pages/us.freeradius.org/bin/new_makelog.pl

1 0

Automatic report from sources (radiusd) between 01.12.2007 - 02.12.2007 GMT
by Automatic cvs log generator 02 Dec '07

02 Dec '07

CVS log entries from 01.12.2007 (Sat) 09:00:01 - 02.12.2007 (Sun) 09:00:01 GMT ===================================================== Summary by authors ===================================================== Author: aland File: radiusd/src/main/radiusd.c; Revisions: 1.382 ===================================================== Log entries ===================================================== Description: Include file for prototypes Modified files: File: radiusd/src/main/radiusd.c; Revision: 1.382; Date: 2007/12/02 08:17:59; Author: aland; Lines: (+3 -2) ===================================================== Summary of modified files ===================================================== File: radiusd/src/main/radiusd.c Revisions: 1.382 Authors: aland (+3 -2) -- Automatic cron job from /web/pages/us.freeradius.org/bin/new_makelog.pl

1 0

Automatic report from sources (radiusd) between 30.11.2007 - 01.12.2007 GMT
by Automatic cvs log generator 01 Dec '07

01 Dec '07

CVS log entries from 30.11.2007 (Fri) 09:00:00 - 01.12.2007 (Sat) 09:00:01 GMT ===================================================== Summary by authors ===================================================== Author: aland File: radiusd/config.sub; Revisions: 1.3.8.1.2.1 File: radiusd/config.guess; Revisions: 1.4.6.1.2.1 Author: nbk File: radiusd/raddb/radiusd.conf.in; Revisions: 1.257, 1.188.2.4.2.20 File: radiusd/man/man5/rlm_sql_log.5; Revisions: 1.3, 1.2.2.2 ===================================================== Combined list of identical log entries ===================================================== Description: Add an example of the option "sql_user_name" to the config of module "rlm_sql_log" so the users can notice its existence. Modified files: File: radiusd/man/man5/rlm_sql_log.5; Revision: 1.3; Date: 2007/12/01 00:28:10; Author: nbk; Lines: (+3 -1) File: radiusd/man/man5/rlm_sql_log.5; Revision: 1.2.2.2; Date: 2007/12/01 00:28:49; Author: nbk; Lines: (+3 -1) File: radiusd/raddb/radiusd.conf.in; Revision: 1.257; Date: 2007/12/01 00:28:09; Author: nbk; Lines: (+3 -2) File: radiusd/raddb/radiusd.conf.in; Revision: 1.188.2.4.2.20; Date: 2007/12/01 00:28:48; Author: nbk; Lines: (+3 -2) ------------------------------- Description: Pulled from GNU. This should fix bug #496 Modified files: File: radiusd/config.guess; Revision: 1.4.6.1.2.1; Date: 2007/11/30 23:02:54; Author: aland; Lines: (+355 -298) File: radiusd/config.sub; Revision: 1.3.8.1.2.1; Date: 2007/11/30 23:02:54; Author: aland; Lines: (+139 -58) ===================================================== Log entries ===================================================== ===================================================== Summary of modified files ===================================================== File: radiusd/config.guess Revisions: 1.4.6.1.2.1 Authors: aland (+355 -298) ------------------------------- File: radiusd/config.sub Revisions: 1.3.8.1.2.1 Authors: aland (+139 -58) ------------------------------- File: radiusd/man/man5/rlm_sql_log.5 Revisions: 1.3, 1.2.2.2 Authors: nbk (+3 -1), nbk (+3 -1) ------------------------------- File: radiusd/raddb/radiusd.conf.in Revisions: 1.257, 1.188.2.4.2.20 Authors: nbk (+3 -2), nbk (+3 -2) -- Automatic cron job from /web/pages/us.freeradius.org/bin/new_makelog.pl

1 0

Automatic report from sources (radiusd) between 19.11.2007 - 20.11.2007 GMT
by Automatic cvs log generator 30 Nov '07

30 Nov '07

CVS log entries from 19.11.2007 (Mon) 09:00:01 - 20.11.2007 (Tue) 09:00:01 GMT ===================================================== Summary by authors ===================================================== Author: aland File: radiusd/src/modules/rlm_eap/types/rlm_eap_peap/peap.c; Revisions: 1.28 File: radiusd/src/modules/rlm_eap/eap.c; Revisions: 1.68 File: radiusd/src/modules/rlm_eap/rlm_eap.c; Revisions: 1.49 ===================================================== Combined list of identical log entries ===================================================== Description: Permit TLS inside of PEAP/TTLS tunnels. It won't work, but it won't crash the system, either. Maybe enbling it will let someone debug the issues. Modified files: File: radiusd/src/modules/rlm_eap/eap.c; Revision: 1.68; Date: 2007/11/20 08:12:39; Author: aland; Lines: (+3 -4) File: radiusd/src/modules/rlm_eap/rlm_eap.c; Revision: 1.49; Date: 2007/11/20 08:12:38; Author: aland; Lines: (+3 -6) ===================================================== Log entries ===================================================== Description: Handle multiple EAP-Messages inside of a PEAP tunnel. Modified files: File: radiusd/src/modules/rlm_eap/types/rlm_eap_peap/peap.c; Revision: 1.28; Date: 2007/11/20 03:08:05; Author: aland; Lines: (+31 -19) ===================================================== Summary of modified files ===================================================== File: radiusd/src/modules/rlm_eap/eap.c Revisions: 1.68 Authors: aland (+3 -4) ------------------------------- File: radiusd/src/modules/rlm_eap/rlm_eap.c Revisions: 1.49 Authors: aland (+3 -6) ------------------------------- File: radiusd/src/modules/rlm_eap/types/rlm_eap_peap/peap.c Revisions: 1.28 Authors: aland (+31 -19) -- Automatic cron job from /web/pages/us.freeradius.org/bin/new_makelog.pl

5 15

please document SQL-User-Name xlat option in sql-log module (1.1.7)
by Stefan Winter 29 Nov '07

29 Nov '07

Hi, rlm_sql_log has an option record {"sql_user_name", PW_TYPE_STRING_PTR, offsetof(rlm_sql_log_t,sql_user_name), NULL, ""}, This is not documented in the config file. I tried to use %{SQL-User-Name} in my relay config, didn't know of this option's existence, so it was assumed to be NULL. The code then doesn't translate User-Name at all, and my variable subst created INSERT strings with an empty user name. I suggest just copying the text from sql.conf, as the semantics seems to be the same: #################################################################### # Query config: Username ###################################################################### # This is the username that will get substituted, escaped, and added # as attribute 'SQL-User-Name'. '%{SQL-User-Name}' should be used below # everywhere a username substitution is needed so you you can be sure # the username passed from the client is escaped properly. # # Uncomment the next line, if you want the sql_user_name to mean: # # Use Stripped-User-Name, if it's there. # Else use User-Name, if it's there, # Else use hard-coded string "DEFAULT" as the user name. #sql_user_name = "%{Stripped-User-Name:-%{User-Name:-DEFAULT}}" # sql_user_name = "%{User-Name}" Greetings, Stefan -- Stefan WINTER Stiftung RESTENA - Réseau Téléinformatique de l'Education Nationale et de la Recherche Ingenieur Forschung & Entwicklung 6, rue Richard Coudenhove-Kalergi L-1359 Luxembourg E-Mail: stefan.winter(a)restena.lu Tel.: +352 424409-1 http://www.restena.lu Fax: +352 422473

2 1

Unlimit Clients IP Address
by EasyHorpak.com 29 Nov '07

29 Nov '07

Dear Expert . I install my freeeradius server and put the server at ISP. I try to access the server by router (WRT54GL+coova). I can see the login page but when I try to login the login failed. I think the problem is freeradius clients that fix on client.conf that fix the ip. But I can not fix ip cause I get the random ip form ISP, it 's not real ip. How do I set unlimit clients ip address on clients.conf? if it 's not possible , which radius software that support unlimit clients access? Thank you forwards and Best Regards. Chuan

3 2

Automatic report from sources (radiusd) between 28.11.2007 - 29.11.2007 GMT
by Automatic cvs log generator 29 Nov '07

29 Nov '07

CVS log entries from 28.11.2007 (Wed) 09:00:00 - 29.11.2007 (Thu) 09:00:00 GMT ===================================================== Summary by authors ===================================================== Author: aland File: radiusd/src/lib/getaddrinfo.c; Revisions: 1.11 File: radiusd/src/modules/rlm_eap/types/rlm_eap_tnc/tncs_connect.c; Revisions: 1.2 File: radiusd/src/main/radiusd.c; Revisions: 1.381 File: radiusd/src/include/radius.h; Revisions: 1.90 File: radiusd/src/modules/rlm_eap/types/rlm_eap_tnc/rlm_eap_tnc.c; Revisions: 1.8, 1.7, 1.6, 1.5 File: radiusd/share/dictionary.freeradius.internal; Revisions: 1.21 ===================================================== Combined list of identical log entries ===================================================== Description: Define TNC-VLAN-{Access,Isolate}, and look for them in rlm_eap_tnc Modified files: File: radiusd/share/dictionary.freeradius.internal; Revision: 1.21; Date: 2007/11/28 12:32:10; Author: aland; Lines: (+5 -2) File: radiusd/src/include/radius.h; Revision: 1.90; Date: 2007/11/28 12:32:10; Author: aland; Lines: (+3 -1) File: radiusd/src/modules/rlm_eap/types/rlm_eap_tnc/rlm_eap_tnc.c; Revision: 1.6; Date: 2007/11/28 12:32:11; Author: aland; Lines: (+7 -0) ===================================================== Log entries ===================================================== Description: Corrected typo in name added better #ifdef's around possibly used variables Modified files: File: radiusd/src/lib/getaddrinfo.c; Revision: 1.11; Date: 2007/11/28 22:43:16; Author: aland; Lines: (+13 -9) ------------------------------- Description: More OS portability issue Modified files: File: radiusd/src/main/radiusd.c; Revision: 1.381; Date: 2007/11/28 22:50:19; Author: aland; Lines: (+16 -2) ------------------------------- Description: Corrected typos Modified files: File: radiusd/src/modules/rlm_eap/types/rlm_eap_tnc/rlm_eap_tnc.c; Revision: 1.8; Date: 2007/11/28 23:27:14; Author: aland; Lines: (+3 -3) ------------------------------- Description: Corrected typo Modified files: File: radiusd/src/modules/rlm_eap/types/rlm_eap_tnc/rlm_eap_tnc.c; Revision: 1.7; Date: 2007/11/28 17:05:52; Author: aland; Lines: (+1 -1) ------------------------------- Description: Use FreeRADIUS configuration files to set vlan_access and vlan_isolate. Modified files: File: radiusd/src/modules/rlm_eap/types/rlm_eap_tnc/rlm_eap_tnc.c; Revision: 1.5; Date: 2007/11/28 12:27:56; Author: aland; Lines: (+88 -85) ------------------------------- Description: Use libtool for linking, rather than dlopen(). Clean up code a little. Modified files: File: radiusd/src/modules/rlm_eap/types/rlm_eap_tnc/tncs_connect.c; Revision: 1.2; Date: 2007/11/28 12:27:26; Author: aland; Lines: (+12 -11) ===================================================== Summary of modified files ===================================================== File: radiusd/share/dictionary.freeradius.internal Revisions: 1.21 Authors: aland (+5 -2) ------------------------------- File: radiusd/src/include/radius.h Revisions: 1.90 Authors: aland (+3 -1) ------------------------------- File: radiusd/src/lib/getaddrinfo.c Revisions: 1.11 Authors: aland (+13 -9) ------------------------------- File: radiusd/src/main/radiusd.c Revisions: 1.381 Authors: aland (+16 -2) ------------------------------- File: radiusd/src/modules/rlm_eap/types/rlm_eap_tnc/rlm_eap_tnc.c Revisions: 1.8, 1.7, 1.6, 1.5 Authors: aland (+3 -3), aland (+1 -1), aland (+7 -0), aland (+88 -85) ------------------------------- File: radiusd/src/modules/rlm_eap/types/rlm_eap_tnc/tncs_connect.c Revisions: 1.2 Authors: aland (+12 -11) -- Automatic cron job from /web/pages/us.freeradius.org/bin/new_makelog.pl

1 0

EAP SRP-SHA1 support
by Stacy 28 Nov '07

28 Nov '07

Hello all! I've wrote an EAP SRP-SHA1 authentication module for freeradius-1.1.7 it needs three internal config attributes to get info from authorization module. Currently - they are # Range: 1220-1222 # EAP-SRP-SHA1 database interface ATTRIBUTE EAP-SRP-Generator-Idx 1220 integer ATTRIBUTE EAP-SRP-Secret 1221 octets ATTRIBUTE EAP-SRP-Salt 1222 octets (in dictionary freeradius.internal) Would you please confirm this allocation or suggest another range before I'll put the code for public access? TIA, Stacy.

3 5