- Freeradius-Devel - lists.freeradius.org

EAP-AKA
by kalyani gopalabhatla 21 Oct '05

21 Oct '05

Hi, We are doing our final project on EAP-AKA mechanism. We are supposed to implement the EAP-AKA protocol. We have got a few questions regarding this... 1. Can FREERADIUS be used as a server for EAP-AKA? Everywhere it is mentioned that FREERADIUS is used for other EAP types. 2. Is there any code reference for implementing the EAP-AKA on Xsupplicant and Radius? 3.Is EAP-AKA is used for both wireless LAN and UMTS or only for UMTS? Please kindly reply We are very new to this concept. Thanks kal Raji __________________________________ Yahoo! FareChase: Search multiple travel sites in one click. http://farechase.yahoo.com

2 1

Automatic report from sources (radiusd) between 19.10.2005 - 20.10.2005 GMT
by Automatic cvs log generator 20 Oct '05

20 Oct '05

CVS log entries from 19.10.2005 (Wed) 08:00:03 - 20.10.2005 (Thu) 08:00:01 GMT ===================================================== Summary by authors ===================================================== Author: aland File: radiusd/src/lib/valuepair.c; Revisions: 1.99 File: radiusd/src/include/libradius.h; Revisions: 1.108 Author: fcusack File: radiusd/doc/rlm_otp; Revisions: 1.6 Author: mgriego File: radiusd/src/modules/rlm_mschap/rlm_mschap.c; Revisions: 1.59.2.3 ===================================================== Combined list of identical log entries ===================================================== Description: New paircmp() function, which compares two pairs, and nothing else. Modified files: File: radiusd/src/include/libradius.h; Revision: 1.108; Date: 2005/10/19 18:16:16; Author: aland; Lines: (+2 -1) File: radiusd/src/lib/valuepair.c; Revision: 1.99; Date: 2005/10/19 18:16:16; Author: aland; Lines: (+167 -4) ===================================================== Log entries ===================================================== Description: big update Modified files: File: radiusd/doc/rlm_otp; Revision: 1.6; Date: 2005/10/19 15:50:47; Author: fcusack; Lines: (+116 -83) ------------------------------- Description: Pull machine authentication patch from head. Modified files: File: radiusd/src/modules/rlm_mschap/rlm_mschap.c; Revision: 1.59.2.3; Date: 2005/10/19 16:49:46; Author: mgriego; Lines: (+71 -18) ===================================================== Summary of modified files ===================================================== File: radiusd/doc/rlm_otp Revisions: 1.6 Authors: fcusack (+116 -83) ------------------------------- File: radiusd/src/include/libradius.h Revisions: 1.108 Authors: aland (+2 -1) ------------------------------- File: radiusd/src/lib/valuepair.c Revisions: 1.99 Authors: aland (+167 -4) ------------------------------- File: radiusd/src/modules/rlm_mschap/rlm_mschap.c Revisions: 1.59.2.3 Authors: mgriego (+71 -18) -- Automatic cron job from /web/pages/us.freeradius.org/bin/new_makelog.pl

1 0

Patch for -= -* -~ operators, rlm_policy
by Joe Maimon 20 Oct '05

20 Oct '05

The substar regex patch has been discussed previously. It adds the -* and ~- operators, and changes -= operator to behave correctly. The work I did on rlm_policy to suit my needs I split into 2 patches. The rlm_policy-fix patch is the minimum I found to be required to make the module perform for me. rlm-policy-subops patch is the other half of what I use the rlm_policy for. It depends on the -~ operator patch. Included for giggles is my working!! policy.txt file. Thanks to Alan and company for the rlm_policy module! I have high hopes for it. Thanks for any consideration, any and all feedback welcome. Joe #! /bin/sh /usr/share/dpatch/dpatch-run ## 030-substar_regex.patch.dpatch by <joe(a)nameserver3.ttec.com> ## ## All lines beginning with `## DP:' are a description of the patch. ## DP: No description. @DPATCH@ diff -urNad freeradius-1.1.0pre0/man/man5/users.5 /tmp/dpep.fHbaO6/freeradius-1.1.0pre0/man/man5/users.5 --- freeradius-1.1.0pre0/man/man5/users.5 2005-03-17 00:16:58.790666042 -0500 +++ /tmp/dpep.fHbaO6/freeradius-1.1.0pre0/man/man5/users.5 2005-03-17 00:38:40.295848027 -0500 @@ -95,6 +95,25 @@ As a reply item, it has an identical meaning, but the attribute is added to the reply items. + +.TP 0.5i +.B "Attribute -= Value" +As a reply item it means remove matching items from the reply list. +.br +Not allowed as a check item. + +.TP 0.5i +.B "Attribute -* Value" +As a reply item it means remove all "Attribute" attributes items from the reply list. +.br +Not allowed as a check item. + +.TP 0.5i +.B "Attribute -~ Value" +As a reply item it means remove regex matching items from the reply list. +.br +Not allowed as a check item. + .TP 0.5i .B "Attribute != Value" As a check item, matches if the given attribute is in the request, AND diff -urNad freeradius-1.1.0pre0/src/include/token.h /tmp/dpep.fHbaO6/freeradius-1.1.0pre0/src/include/token.h --- freeradius-1.1.0pre0/src/include/token.h 2005-03-17 00:16:58.837659657 -0500 +++ /tmp/dpep.fHbaO6/freeradius-1.1.0pre0/src/include/token.h 2005-03-17 00:38:40.296847890 -0500 @@ -35,6 +35,8 @@ T_OP_ADD, /* += */ T_OP_SUB, /* -= */ + T_OP_SUB_ALL, /* -* */ + T_OP_SUB_REG, /* -~ */ T_OP_SET, /* := */ T_OP_EQ, /* = */ T_OP_NE, /* != */ diff -urNad freeradius-1.1.0pre0/src/lib/print.c /tmp/dpep.fHbaO6/freeradius-1.1.0pre0/src/lib/print.c --- freeradius-1.1.0pre0/src/lib/print.c 2005-03-17 00:16:58.842658978 -0500 +++ /tmp/dpep.fHbaO6/freeradius-1.1.0pre0/src/lib/print.c 2005-03-17 00:38:40.297847754 -0500 @@ -223,6 +223,8 @@ ";", "+=", "-=", + "-*", + "-~", ":=", "=", "!=", diff -urNad freeradius-1.1.0pre0/src/lib/token.c /tmp/dpep.fHbaO6/freeradius-1.1.0pre0/src/lib/token.c --- freeradius-1.1.0pre0/src/lib/token.c 2005-03-17 00:16:58.843658842 -0500 +++ /tmp/dpep.fHbaO6/freeradius-1.1.0pre0/src/lib/token.c 2005-03-17 00:38:40.299847482 -0500 @@ -39,6 +39,8 @@ { ",", T_COMMA, }, { "+=", T_OP_ADD, }, { "-=", T_OP_SUB, }, + { "-*", T_OP_SUB_ALL, }, + { "-~", T_OP_SUB_REG, }, { ":=", T_OP_SET, }, { "=*", T_OP_CMP_TRUE, }, { "!*", T_OP_CMP_FALSE, }, diff -urNad freeradius-1.1.0pre0/src/main/valuepair.c /tmp/dpep.fHbaO6/freeradius-1.1.0pre0/src/main/valuepair.c --- freeradius-1.1.0pre0/src/main/valuepair.c 2005-03-17 00:16:58.861656397 -0500 +++ /tmp/dpep.fHbaO6/freeradius-1.1.0pre0/src/main/valuepair.c 2005-03-17 00:38:40.303846938 -0500 @@ -467,7 +467,128 @@ return paircompare( req, first, second, NULL, NULL ); } +/* + * Compare ONE attribute from a (potential) list. + * Return the first matching one. + */ + +static VALUE_PAIR * paircmpmatchone(REQUEST *req, VALUE_PAIR *first, VALUE_PAIR *second) +{ + VALUE_PAIR *fnext = NULL; + VALUE_PAIR *snext = NULL; + int result = 0; + + for(; second; second = second->next){ + for(; first; first = first->next){ + if(first->attribute == second->attribute){ + /* No matter what, compare only THESE items in chain */ + fnext = first->next; + first->next = NULL; + snext = second->next; + second->next = NULL; + result = paircompare(req,first,second,NULL,NULL); + first->next = fnext; + second->next = snext; + + if(!result) + return first; + } + } + } + return NULL; +} +#ifdef HAVE_REGEX_H +/* + * Regex Compare ONE attribute from a (potential) list. + * Return the first matching one. + */ + +static VALUE_PAIR * pairregmatchone(REQUEST *req, VALUE_PAIR *first, VALUE_PAIR *second) +{ + int result = 0; + regex_t reg; + + for(; second; second = second->next){ + for(; first; first = first->next){ + if(first->attribute == second->attribute) { + if (second->operator == T_OP_REG_EQ || + second->operator == T_OP_REG_NE || + second->operator == T_OP_SUB_REG) + { + regcomp(&reg, (char *)second->vp_strvalue, + REG_EXTENDED); + result = regexec(&reg, (char *)first->vp_strvalue, + 0, NULL, 0); + regfree(&reg); + + if(!result) + return first; + } + if (first->operator == T_OP_REG_EQ || + first->operator == T_OP_REG_NE || + first->operator == T_OP_SUB_REG) + { + + regcomp(&reg, (char *)first->vp_strvalue, + REG_EXTENDED); + result = regexec(&reg, (char *)second->vp_strvalue, + 0, NULL, 0); + regfree(&reg); + + if(!result) + return second; + } + } + } + } + return NULL; +} +#endif + +/* + * Deletes matching attributes. + */ +static void pairdeletematch(REQUEST *req,VALUE_PAIR **first,VALUE_PAIR *second) +{ + VALUE_PAIR *vp, *i; + + while((vp = paircmpmatchone(req,*first,second))){ + if(*first == vp) /* new head of chain */ + *first = vp->next; + else + for(i = *first; i; i = i->next){ + if(i->next == vp){ /* dis-own */ + i->next = vp->next; + break; + } + } + pairbasicfree(vp); + } +} + +#ifdef HAVE_REGEX_H +/* + * deletes matching regex pairs +*/ +static void pairdeleteregmatch(REQUEST *req,VALUE_PAIR **first,VALUE_PAIR *second) +{ + VALUE_PAIR *vp, *i; + + while((vp = pairregmatchone(req,*first,second))){ + if(*first == vp) /* new head of chain */ + *first = vp->next; + else + for(i = *first; i; i = i->next){ + if(i->next == vp){ /* dis-own */ + i->next = vp->next; + break; + } + } + pairbasicfree(vp); + } +} +#endif /* * Move pairs, replacing/over-writing them, and doing xlat. */ @@ -485,6 +606,7 @@ * Point "tailto" to the end of the "to" list. */ tailto = to; + for(i = *to; i; i = i->next) { tailto = &i->next; } @@ -525,30 +647,57 @@ switch (i->operator) { /* - * If a similar attribute is found, - * delete it. + * If a similar attribute are found, + * delete them. */ case T_OP_SUB: /* -= */ if (found) { - if (!i->vp_strvalue[0] || - (strcmp((char *)found->vp_strvalue, - (char *)i->vp_strvalue) == 0)){ - pairdelete(to, found->attribute); - - /* - * 'tailto' may have been - * deleted... - */ + if (!i->vp_strvalue[0]) + goto delete_all; + + pairdeletematch(req,to,i); + /* + * 'tailto' may have been + * deleted... + */ + tailto = to; + for(j = *to; j; j = j->next) { + tailto = &j->next; + } + + } + tailfrom = i; + continue; + break; + case T_OP_SUB_ALL: /* -* */ + if (found) { +delete_all: + pairdelete(to, found->attribute); tailto = to; for(j = *to; j; j = j->next) { tailto = &j->next; } - } } tailfrom = i; continue; break; +#ifdef HAVE_REGEX_H + case T_OP_SUB_REG: /* -~ */ + if (found) { + + pairdeleteregmatch(req,to,i); + + tailto = to; + for(j = *to; j; j = j->next) { + tailto = &j->next; + } + + tailfrom = i; + continue; + break; + } +#endif /* * Add it, if it's not already there. */ #! /bin/sh /usr/share/dpatch/dpatch-run ## 130-rlm-policy-fix.dpatch by <joe(a)nameserver3.ttec.com> ## ## All lines beginning with `## DP:' are a description of the patch. ## DP: No description. @DPATCH@ diff -urNad --exclude=CVS --exclude=.svn ./raddb/policy.txt /tmp/dpep-work.9zGKeC/freeradius-1.1.0/raddb/policy.txt --- ./raddb/policy.txt 2005-10-13 20:41:46.000000000 -0400 +++ /tmp/dpep-work.9zGKeC/freeradius-1.1.0/raddb/policy.txt 2005-10-13 20:49:41.000000000 -0400 @@ -67,5 +67,5 @@ # # Execute "3pm", as if it was in-line here. # -# call 3pm + 3pm() } diff -urNad --exclude=CVS --exclude=.svn ./src/modules/rlm_policy/evaluate.c /tmp/dpep-work.9zGKeC/freeradius-1.1.0/src/modules/rlm_policy/evaluate.c --- ./src/modules/rlm_policy/evaluate.c 2005-10-13 20:41:47.000000000 -0400 +++ /tmp/dpep-work.9zGKeC/freeradius-1.1.0/src/modules/rlm_policy/evaluate.c 2005-10-13 20:49:41.000000000 -0400 @@ -344,13 +344,15 @@ rad_assert(pitem != NULL); rad_assert(state->depth >= 0); - redo: +redo: if (state->depth == 0) { *pitem = NULL; return 0; } *pitem = state->stack[state->depth - 1]; + if(state->depth > 1) + state->depth--; /* * Named policies are on the stack for catching recursion. @@ -490,7 +492,7 @@ { int rcode; const policy_condition_t *this; - VALUE_PAIR *vp; + VALUE_PAIR *vp = NULL; const char *data = NULL; int compare; #ifdef HAVE_REGEX_H @@ -498,6 +500,7 @@ #endif char buffer[256]; char lhs_buffer[2048]; + int next_vp = 0; this = (const policy_condition_t *) item; @@ -533,7 +536,9 @@ rcode = evaluate_condition(state, this->child); rcode = (rcode == FALSE); /* reverse sense of test */ break; - + + case POLICY_LEX_CMP_FALSE: /* no existence */ + /*fall through*/ case POLICY_LEX_CMP_TRUE: /* existence */ if (this->lhs_type == POLICY_LEX_BARE_WORD) { vp = find_vp(state->request, this->lhs); @@ -541,6 +546,8 @@ } else { rcode = (data != NULL); } + if (this->compare == POLICY_LEX_CMP_FALSE) + rcode = !rcode; break; default: /* process other comparisons */ @@ -561,9 +568,15 @@ if (this->lhs_type == POLICY_LEX_BARE_WORD) { VALUE_PAIR *myvp; + vp = find_vp(state->request, this->lhs); +retry_next_vp: + if(vp && next_vp) + { + const DICT_ATTR *dattr = dict_attrbyname(vp->name); + vp = pairfind(vp, dattr->attr); + } - vp = find_vp(state->request, this->lhs); /* * FIXME: Move sanity checks to * post-parse code, so we don't do @@ -638,6 +651,12 @@ int i; regmatch_t rxmatch[REQUEST_MAX_REGEX + 1]; + /* attribute is not in request */ + if (compare == -1) { + rcode = FALSE; + break; + } + /* * Include substring matches. */ @@ -720,6 +739,11 @@ } /* switch over comparison operators */ break; /* default from first switch over compare */ } + if (rcode == FALSE && vp && (vp = vp->next)) + { + next_vp = 1; + goto retry_next_vp; + } /* * No trailing &&, || diff -urNad --exclude=CVS --exclude=.svn ./src/modules/rlm_policy/parse.c /tmp/dpep-work.9zGKeC/freeradius-1.1.0/src/modules/rlm_policy/parse.c --- ./src/modules/rlm_policy/parse.c 2005-10-13 20:41:47.000000000 -0400 +++ /tmp/dpep-work.9zGKeC/freeradius-1.1.0/src/modules/rlm_policy/parse.c 2005-10-13 20:49:41.000000000 -0400 @@ -97,6 +97,8 @@ { "!", POLICY_LEX_L_NOT }, { "=", POLICY_LEX_ASSIGN }, { "==", POLICY_LEX_CMP_EQUALS }, + { "=*", POLICY_LEX_CMP_TRUE }, + { "!*", POLICY_LEX_CMP_FALSE }, { "!=", POLICY_LEX_CMP_NOT_EQUALS }, { "<", POLICY_LEX_LT }, { ">", POLICY_LEX_GT }, @@ -699,8 +701,8 @@ lrad_int2str(rlm_policy_tokens, token, "?")); return 0; } - goto check; } /* else it's a comparison? */ + goto check; case POLICY_LEX_DOUBLE_QUOTED_STRING: this->lhs_type = token; @@ -727,6 +729,8 @@ case POLICY_LEX_GT: case POLICY_LEX_LE: case POLICY_LEX_GE: + case POLICY_LEX_CMP_TRUE: + case POLICY_LEX_CMP_FALSE: break; default: #! /bin/sh /usr/share/dpatch/dpatch-run ## 140-rlm-policy-subops.dpatch by <joe(a)nameserver3.ttec.com> ## ## All lines beginning with `## DP:' are a description of the patch. ## DP: No description. @DPATCH@ diff -urNad --exclude=CVS --exclude=.svn ./src/modules/rlm_policy/evaluate.c /tmp/dpep-work.HBL4sz/freeradius-1.1.0/src/modules/rlm_policy/evaluate.c --- ./src/modules/rlm_policy/evaluate.c 2005-10-13 20:41:47.000000000 -0400 +++ /tmp/dpep-work.HBL4sz/freeradius-1.1.0/src/modules/rlm_policy/evaluate.c 2005-10-13 20:52:12.000000000 -0400 @@ -814,6 +814,19 @@ case POLICY_LEX_PLUS_EQUALS: operator = T_OP_ADD; break; + + case POLICY_LEX_MINUS_EQUALS: + operator = T_OP_SUB; + break; + + case POLICY_LEX_MINUS_TRUE: + operator = T_OP_SUB_ALL; + break; + + case POLICY_LEX_RX_MINUS: + operator = T_OP_SUB_REG; + break; + default: fprintf(stderr, "Expected '=' for operator, not '%s' at line %d\n", @@ -898,12 +911,12 @@ break; case POLICY_LEX_ASSIGN: /* 'union' */ - pairmove(vps, &head); + pairxlatmove(NULL, vps, &head); pairfree(&head); break; case POLICY_LEX_CONCAT_EQUALS: - pairadd(vps, head); + pairxlatmove(NULL, vps, &head); break; default: diff -urNad --exclude=CVS --exclude=.svn ./src/modules/rlm_policy/parse.c /tmp/dpep-work.HBL4sz/freeradius-1.1.0/src/modules/rlm_policy/parse.c --- ./src/modules/rlm_policy/parse.c 2005-10-13 20:41:47.000000000 -0400 +++ /tmp/dpep-work.HBL4sz/freeradius-1.1.0/src/modules/rlm_policy/parse.c 2005-10-13 20:52:15.000000000 -0400 @@ -106,6 +106,9 @@ { "!~", POLICY_LEX_RX_NOT_EQUALS }, { ".=", POLICY_LEX_CONCAT_EQUALS }, { ":=", POLICY_LEX_SET_EQUALS }, + { "-=", POLICY_LEX_MINUS_EQUALS }, + { "-*", POLICY_LEX_MINUS_TRUE }, + { "-~", POLICY_LEX_RX_MINUS }, { "double quoted string", POLICY_LEX_DOUBLE_QUOTED_STRING }, { "single quoted string", POLICY_LEX_SINGLE_QUOTED_STRING }, { "back quoted string", POLICY_LEX_BACK_QUOTED_STRING }, @@ -190,6 +193,16 @@ *token = POLICY_LEX_MINUS_EQUALS; input++; break; + + case '*': + *token = POLICY_LEX_MINUS_TRUE; + input++; + break; + + case '~': + *token = POLICY_LEX_RX_MINUS; + input++; + break; default: *token = POLICY_LEX_MINUS; @@ -1231,6 +1244,9 @@ case POLICY_LEX_AND_EQUALS: case POLICY_LEX_OR_EQUALS: case POLICY_LEX_PLUS_EQUALS: + case POLICY_LEX_MINUS_EQUALS: + case POLICY_LEX_MINUS_TRUE: + case POLICY_LEX_RX_MINUS: break; default: diff -urNad --exclude=CVS --exclude=.svn ./src/modules/rlm_policy/rlm_policy.h /tmp/dpep-work.HBL4sz/freeradius-1.1.0/src/modules/rlm_policy/rlm_policy.h --- ./src/modules/rlm_policy/rlm_policy.h 2005-10-13 20:41:47.000000000 -0400 +++ /tmp/dpep-work.HBL4sz/freeradius-1.1.0/src/modules/rlm_policy/rlm_policy.h 2005-10-13 20:52:02.000000000 -0400 @@ -37,6 +37,7 @@ #include "rad_assert.h" + /* * Internal lexer. */ @@ -74,6 +75,8 @@ POLICY_LEX_OR_EQUALS, /* |= */ POLICY_LEX_PLUS_EQUALS, /* += */ POLICY_LEX_MINUS_EQUALS, /* -= */ + POLICY_LEX_MINUS_TRUE, /* -* */ + POLICY_LEX_RX_MINUS, /* -~*/ POLICY_LEX_CONCAT_EQUALS, /* .= */ POLICY_LEX_VARIABLE, /* %{foo} */ POLICY_LEX_FUNCTION, /* Hmmm... */ #debug print_tokens # as we're parsing this file #debug print_policy # once the file has been parsed #debug evaluate # print limited information during evaluation policy pool_conflict_ipaddr { if ( (proxy-reply:Framed-IP-Address =* "") && (reply:Cisco-Avpair =~ "ip:addr-pool.*")) { reply .= { Cisco-Avpair -~ "ip:addr-pool.*" } } } policy post-proxy { pool_conflict_ipaddr() }

2 2

rlm_attr_filter && pair comparisons
by Alan DeKok 19 Oct '05

19 Oct '05

As part of applying Joe Maimon's patches, I realized just how bad & repetitive some of the code is. So... 1) I've renamed paircmp() to paircompare() 2) added a paircmp(a,b) which does (a->strvalue a->operator b->stvalue) e.g. "foo == bar". 3) Started removing references to "simplepaircmp" Most of which are in rlm_attr_filter. Looking at rlm_attr_filter, it seems there's a lot of repetitive code in it. I've made it use the new paircmp(), and generalized the code a bit. It seems to work in my tests, but I've put a new version on my web page: http://www.striker.ottawa.on.ca/~aland/rlm_attr_filter.c If someone can test it for proxying, and see if it does the same thing as the previous version, I'd be grateful. If it works, I'll check it in, and continue on the code cleanups. As a side-effect of editing rlm_attr_filter, you can now filter in authorization & post-auth, too. Alan DeKok.

1 0

Automatic report from sources (radiusd) between 18.10.2005 - 19.10.2005 GMT
by Automatic cvs log generator 19 Oct '05

19 Oct '05

CVS log entries from 18.10.2005 (Tue) 08:00:04 - 19.10.2005 (Wed) 08:00:03 GMT ===================================================== Summary by authors ===================================================== Author: aland File: radiusd/src/modules/rlm_ldap/rlm_ldap.c; Revisions: 1.161 File: radiusd/src/main/valuepair.c; Revisions: 1.74, 1.73 File: radiusd/src/modules/rlm_files/rlm_files.c; Revisions: 1.69 File: radiusd/src/modules/rlm_dbm/rlm_dbm.c; Revisions: 1.15 File: radiusd/src/modules/rlm_attr_rewrite/rlm_attr_rewrite.c; Revisions: 1.34 File: radiusd/src/include/radiusd.h; Revisions: 1.205 File: radiusd/src/modules/rlm_preprocess/rlm_preprocess.c; Revisions: 1.64 File: radiusd/src/modules/rlm_policy/evaluate.c; Revisions: 1.9 File: radiusd/src/modules/rlm_sql/rlm_sql.c; Revisions: 1.153 File: radiusd/src/modules/rlm_fastusers/rlm_fastusers.c; Revisions: 1.40 File: radiusd/src/modules/rlm_policy/parse.c; Revisions: 1.13 ===================================================== Combined list of identical log entries ===================================================== Description: Patches from Joe Maimon to fix some edge conditions Modified files: File: radiusd/src/modules/rlm_policy/evaluate.c; Revision: 1.9; Date: 2005/10/18 19:05:40; Author: aland; Lines: (+21 -13) File: radiusd/src/modules/rlm_policy/parse.c; Revision: 1.13; Date: 2005/10/18 19:05:40; Author: aland; Lines: (+6 -2) ------------------------------- Description: Renamed paircmp to paircompare, as we should probably have a low-level comparison function, in the lib directory Modified files: File: radiusd/src/include/radiusd.h; Revision: 1.205; Date: 2005/10/18 22:31:26; Author: aland; Lines: (+5 -10) File: radiusd/src/main/valuepair.c; Revision: 1.73; Date: 2005/10/18 22:31:26; Author: aland; Lines: (+7 -15) File: radiusd/src/modules/rlm_attr_rewrite/rlm_attr_rewrite.c; Revision: 1.34; Date: 2005/10/18 22:31:25; Author: aland; Lines: (+3 -3) File: radiusd/src/modules/rlm_dbm/rlm_dbm.c; Revision: 1.15; Date: 2005/10/18 22:31:25; Author: aland; Lines: (+3 -3) File: radiusd/src/modules/rlm_fastusers/rlm_fastusers.c; Revision: 1.40; Date: 2005/10/18 22:31:25; Author: aland; Lines: (+4 -4) File: radiusd/src/modules/rlm_files/rlm_files.c; Revision: 1.69; Date: 2005/10/18 22:31:26; Author: aland; Lines: (+5 -5) File: radiusd/src/modules/rlm_ldap/rlm_ldap.c; Revision: 1.161; Date: 2005/10/18 22:31:25; Author: aland; Lines: (+2 -2) File: radiusd/src/modules/rlm_preprocess/rlm_preprocess.c; Revision: 1.64; Date: 2005/10/18 22:31:25; Author: aland; Lines: (+6 -6) File: radiusd/src/modules/rlm_sql/rlm_sql.c; Revision: 1.153; Date: 2005/10/18 22:31:25; Author: aland; Lines: (+7 -7) ===================================================== Log entries ===================================================== Description: Allow comparisons on IPv6 stuff, too Modified files: File: radiusd/src/main/valuepair.c; Revision: 1.74; Date: 2005/10/18 23:52:49; Author: aland; Lines: (+18 -3) ===================================================== Summary of modified files ===================================================== File: radiusd/src/include/radiusd.h Revisions: 1.205 Authors: aland (+5 -10) ------------------------------- File: radiusd/src/main/valuepair.c Revisions: 1.74, 1.73 Authors: aland (+18 -3), aland (+7 -15) ------------------------------- File: radiusd/src/modules/rlm_attr_rewrite/rlm_attr_rewrite.c Revisions: 1.34 Authors: aland (+3 -3) ------------------------------- File: radiusd/src/modules/rlm_dbm/rlm_dbm.c Revisions: 1.15 Authors: aland (+3 -3) ------------------------------- File: radiusd/src/modules/rlm_fastusers/rlm_fastusers.c Revisions: 1.40 Authors: aland (+4 -4) ------------------------------- File: radiusd/src/modules/rlm_files/rlm_files.c Revisions: 1.69 Authors: aland (+5 -5) ------------------------------- File: radiusd/src/modules/rlm_ldap/rlm_ldap.c Revisions: 1.161 Authors: aland (+2 -2) ------------------------------- File: radiusd/src/modules/rlm_policy/evaluate.c Revisions: 1.9 Authors: aland (+21 -13) ------------------------------- File: radiusd/src/modules/rlm_policy/parse.c Revisions: 1.13 Authors: aland (+6 -2) ------------------------------- File: radiusd/src/modules/rlm_preprocess/rlm_preprocess.c Revisions: 1.64 Authors: aland (+6 -6) ------------------------------- File: radiusd/src/modules/rlm_sql/rlm_sql.c Revisions: 1.153 Authors: aland (+7 -7) -- Automatic cron job from /web/pages/us.freeradius.org/bin/new_makelog.pl

1 0

rlm_mschap patch into release branch?
by Michael Griego 18 Oct '05

18 Oct '05

I know we don't have anymore 1.0 series releases scheduled at the moment, but I was wondering if it would be a problem for anyone if the rlm_mschap patch to aid in PEAP machine auth got included in the next release? It's something that several people have been asking about (and there's a number of interested parties from the .edu side of things). The only other option really for those people who don't want to run CVS versions would be to put out a patched version of rlm_mschap.c for them to replace in their current/1.0 series source trees. --Mike

2 1

SQL clients code
by Michael Griego 18 Oct '05

18 Oct '05

Just as an FYI, with the masking fix, I've been able to verify that the SQL clients code in CVS seems to be working as it should. I don't think anyone had reported on that yet. --Mike

1 0

Automatic report from sources (radiusd) between 17.10.2005 - 18.10.2005 GMT
by Automatic cvs log generator 18 Oct '05

18 Oct '05

CVS log entries from 17.10.2005 (Mon) 08:00:01 - 18.10.2005 (Tue) 08:00:04 GMT ===================================================== Summary by authors ===================================================== Author: aland File: radiusd/src/main/threads.c; Revisions: 1.99, 1.98, 1.77.2.7 File: radiusd/src/main/request_list.c; Revisions: 1.68, 1.67 File: radiusd/src/main/listen.c; Revisions: 1.39 Author: mgriego File: radiusd/src/modules/rlm_mschap/rlm_mschap.c; Revisions: 1.73 ===================================================== Log entries ===================================================== Description: When stealing the fd, steal the rl, too Modified files: File: radiusd/src/main/listen.c; Revision: 1.39; Date: 2005/10/17 17:25:15; Author: aland; Lines: (+5 -2) ------------------------------- Description: Catch even more corner cases. This code is *bad* Modified files: File: radiusd/src/main/request_list.c; Revision: 1.68; Date: 2005/10/17 19:04:07; Author: aland; Lines: (+6 -4) ------------------------------- Description: Catch the time when we're supposed to send delayed rejects. This appears to prevent the loop of "Waiting for 0 seconds" Modified files: File: radiusd/src/main/request_list.c; Revision: 1.67; Date: 2005/10/17 18:00:35; Author: aland; Lines: (+8 -2) ------------------------------- Description: Queue the request, THEN look for more threads Modified files: File: radiusd/src/main/threads.c; Revision: 1.99; Date: 2005/10/17 18:37:27; Author: aland; Lines: (+12 -12) ------------------------------- Description: Increment head *after* deleting it from the queue Modified files: File: radiusd/src/main/threads.c; Revision: 1.98; Date: 2005/10/17 17:19:29; Author: aland; Lines: (+4 -6) ------------------------------- Description: Pull fix from the head Modified files: File: radiusd/src/main/threads.c; Revision: 1.77.2.7; Date: 2005/10/17 18:38:07; Author: aland; Lines: (+11 -11) ------------------------------- Description: Be a little more forgiving about the number of domain components in a User-Name in the form of host/f.q.d.n. Modified files: File: radiusd/src/modules/rlm_mschap/rlm_mschap.c; Revision: 1.73; Date: 2005/10/17 19:09:42; Author: mgriego; Lines: (+21 -13) ===================================================== Summary of modified files ===================================================== File: radiusd/src/main/listen.c Revisions: 1.39 Authors: aland (+5 -2) ------------------------------- File: radiusd/src/main/request_list.c Revisions: 1.68, 1.67 Authors: aland (+6 -4), aland (+8 -2) ------------------------------- File: radiusd/src/main/threads.c Revisions: 1.99, 1.98, 1.77.2.7 Authors: aland (+12 -12), aland (+4 -6), aland (+11 -11) ------------------------------- File: radiusd/src/modules/rlm_mschap/rlm_mschap.c Revisions: 1.73 Authors: mgriego (+21 -13) -- Automatic cron job from /web/pages/us.freeradius.org/bin/new_makelog.pl

1 0

TIMEOUT requests && then Duplicate Requests && then Threads block
by Joe Maimon 17 Oct '05

17 Oct '05

At least I think thats the sequence of events I am troubleshooting now. Here is a snippet in request_process.c case REQUEST_FAIL_SERVER_TIMEOUT: radlog(L_ERR, "TIMEOUT for request %d in module %s, component %s", request->number, request->module ? request->module : "<server core>", request->component ? request->component : "<server core>"); /* * Tell the server to stop processing the request */ request->options |= RAD_REQUEST_OPTION_STOP_NOW; /* This is the line I have added?? */ request->finished = TRUE; break;

2 5

thread_pool_addrequest()
by Joe Maimon 17 Oct '05

17 Oct '05

returns if it cannot spawn a thread per each request. It returns before adding the request to the queue. Does that mean the server will ignore requests if it cannot spawn a thread at the time of arrival? If so, wouldnt it be better to queue it and hope for the availability of threads in the near future? Something like this thread_pool_addrequest() while ((thread_pool.total_threads - thread_pool.active_threads) < lrad_hash_table_num_elements(thread_pool.queue)) { if (spawn_thread(request->timestamp) == NULL) { radlog(L_INFO, "The maximum number of threads (%d) are active, cannot spawn new thread to handle request", thread_pool.max_threads); break; } }

2 1