- Freeradius-Devel - lists.freeradius.org

Release 1.0.5?
by Alan DeKok 03 Sep '05

03 Sep '05

It has a few fixes that are very nice, like MAC OS X support. I'll see if I can fix the thread pool issue soon. Other than that, any reason to hold off on releasing 1.0.5? Alan DeKok.

5 18

Automatic report from sources (radiusd) between 02.09.2005 - 03.09.2005 GMT
by Automatic cvs log generator 03 Sep '05

03 Sep '05

CVS log entries from 02.09.2005 (Fri) 08:00:01 - 03.09.2005 (Sat) 08:00:01 GMT ===================================================== Summary by authors ===================================================== Author: aland File: radiusd/src/main/request_list.c; Revisions: 1.61 File: radiusd/src/main/listen.c; Revisions: 1.33 File: radiusd/src/include/request_list.h; Revisions: 1.11 Author: kkalev File: radiusd/dialup_admin/Changelog; Revisions: 1.248 File: radiusd/dialup_admin/bin/snmpfinger; Revisions: 1.10 Author: phampson File: radiusd/acconfig.h; Revisions: 1.31.2.1 File: radiusd/src/include/autoconf.h.in; Revisions: 1.55.2.5 ===================================================== Combined list of identical log entries ===================================================== Description: Pull 1.55.2.4 changes to src/include/autoconf.h.in into acconfig.h and regenerate src/include/autoconf.h.in with autoheader2.13 Modified files: File: radiusd/acconfig.h; Revision: 1.31.2.1; Date: 2005/09/03 05:08:46; Author: phampson; Lines: (+0 -12) File: radiusd/src/include/autoconf.h.in; Revision: 1.55.2.5; Date: 2005/09/03 05:08:47; Author: phampson; Lines: (+1 -0) ------------------------------- Description: New function: rl_yank(). It works like rl_delete(), but it doesn't free the request. Modified files: File: radiusd/src/include/request_list.h; Revision: 1.11; Date: 2005/09/02 19:10:36; Author: aland; Lines: (+2 -1) File: radiusd/src/main/request_list.c; Revision: 1.61; Date: 2005/09/02 19:10:36; Author: aland; Lines: (+14 -5) ------------------------------- Description: Change the order of OID's used in snmpfinger for cisco NASes Modified files: File: radiusd/dialup_admin/Changelog; Revision: 1.248; Date: 2005/09/02 12:42:25; Author: kkalev; Lines: (+1 -0) File: radiusd/dialup_admin/bin/snmpfinger; Revision: 1.10; Date: 2005/09/02 12:42:25; Author: kkalev; Lines: (+5 -3) ===================================================== Log entries ===================================================== Description: Clear out socket information after we've allocated it. In "common_checks()", don't call request_free(), quickly followed by request_alloc(). Cachegrind analysis indicates that the cost is pretty high. (like 5% overhead for 20k username/pwd tests) Instead, keep the old request, and re-zero it out, so that information isn't being re-used. This appears to make a noticable difference in response time Modified files: File: radiusd/src/main/listen.c; Revision: 1.33; Date: 2005/09/02 19:16:27; Author: aland; Lines: (+33 -12) ===================================================== Summary of modified files ===================================================== File: radiusd/acconfig.h Revisions: 1.31.2.1 Authors: phampson (+0 -12) ------------------------------- File: radiusd/dialup_admin/Changelog Revisions: 1.248 Authors: kkalev (+1 -0) ------------------------------- File: radiusd/dialup_admin/bin/snmpfinger Revisions: 1.10 Authors: kkalev (+5 -3) ------------------------------- File: radiusd/src/include/autoconf.h.in Revisions: 1.55.2.5 Authors: phampson (+1 -0) ------------------------------- File: radiusd/src/include/request_list.h Revisions: 1.11 Authors: aland (+2 -1) ------------------------------- File: radiusd/src/main/listen.c Revisions: 1.33 Authors: aland (+33 -12) ------------------------------- File: radiusd/src/main/request_list.c Revisions: 1.61 Authors: aland (+14 -5) -- Automatic cron job from /web/pages/us.freeradius.org/bin/new_makelog.pl

1 0

Automatic report from sources (radiusd) between 01.09.2005 - 02.09.2005 GMT
by Automatic cvs log generator 02 Sep '05

02 Sep '05

CVS log entries from 01.09.2005 (Thu) 08:00:01 - 02.09.2005 (Fri) 08:00:01 GMT ===================================================== Summary by authors ===================================================== Author: aland File: radiusd/src/modules/rlm_radutmp/rlm_radutmp.c; Revisions: 1.32 File: radiusd/src/modules/rlm_pam/rlm_pam.c; Revisions: 1.37 File: radiusd/src/modules/rlm_eap/libeap/eapsimlib.c; Revisions: 1.11 File: radiusd/src/main/radclient.c; Revisions: 1.91, 1.90 File: radiusd/src/modules/rlm_sqlcounter/rlm_sqlcounter.c; Revisions: 1.19 File: radiusd/src/modules/rlm_expr/paircmp.c; Revisions: 1.3 File: radiusd/src/modules/rlm_pap/rlm_pap.c; Revisions: 1.32, 1.31 File: radiusd/src/modules/rlm_ldap/rlm_ldap.c; Revisions: 1.158, 1.157 File: radiusd/src/modules/rlm_checkval/rlm_checkval.c; Revisions: 1.14 File: radiusd/src/main/modules.c; Revisions: 1.102 File: radiusd/src/main/xlat.c; Revisions: 1.103 File: radiusd/src/lib/radius.c; Revisions: 1.161, 1.160 File: radiusd/src/modules/rlm_smb/rlm_smb.c; Revisions: 1.8 File: radiusd/src/modules/rlm_passwd/rlm_passwd.c; Revisions: 1.25 File: radiusd/src/main/mainconfig.c; Revisions: 1.81 File: radiusd/src/modules/rlm_cram/rlm_cram.c; Revisions: 1.6 File: radiusd/src/modules/rlm_otp/otp_pwe.c; Revisions: 1.2 File: radiusd/src/modules/rlm_krb5/rlm_krb5.c; Revisions: 1.22 File: radiusd/src/lib/print.c; Revisions: 1.36 File: radiusd/src/modules/rlm_radutmp/rlm_radutmp2.c; Revisions: 1.6 File: radiusd/src/main/valuepair.c; Revisions: 1.71 File: radiusd/src/modules/rlm_eap/types/rlm_eap_leap/eap_leap.c; Revisions: 1.9 File: radiusd/src/modules/rlm_chap/rlm_chap.c; Revisions: 1.11, 1.10 File: radiusd/src/modules/rlm_eap/types/rlm_eap_gtc/rlm_eap_gtc.c; Revisions: 1.4 File: radiusd/src/modules/rlm_caching/rlm_caching.c; Revisions: 1.5 File: radiusd/src/modules/rlm_sql/rlm_sql.c; Revisions: 1.150 File: radiusd/src/modules/rlm_digest/rlm_digest.c; Revisions: 1.9, 1.8 File: radiusd/src/modules/rlm_eap/types/rlm_eap_leap/rlm_eap_leap.c; Revisions: 1.9 File: radiusd/src/modules/rlm_realm/rlm_realm.c; Revisions: 1.55 File: radiusd/src/modules/rlm_eap/eap.c; Revisions: 1.58, 1.57 File: radiusd/src/modules/rlm_dbm/rlm_dbm.c; Revisions: 1.14 File: radiusd/src/modules/rlm_eap/types/rlm_eap_peap/peap.c; Revisions: 1.17 File: radiusd/src/modules/rlm_preprocess/rlm_preprocess.c; Revisions: 1.62 File: radiusd/src/include/libradius.h; Revisions: 1.99, 1.98 File: radiusd/src/lib/filters.c; Revisions: 1.43, 1.42 File: radiusd/src/modules/rlm_sim_files/rlm_sim_files.c; Revisions: 1.7 File: radiusd/src/modules/rlm_eap/radeapclient.c; Revisions: 1.13, 1.12, 1.11 File: radiusd/src/main/auth.c; Revisions: 1.151 File: radiusd/src/modules/rlm_eap/types/rlm_eap_tls/mppe_keys.c; Revisions: 1.4 File: radiusd/src/modules/rlm_attr_filter/rlm_attr_filter.c; Revisions: 1.26 File: radiusd/src/modules/rlm_counter/rlm_counter.c; Revisions: 1.49 File: radiusd/src/modules/rlm_fastusers/rlm_fastusers.c; Revisions: 1.39 File: radiusd/src/main/acct.c; Revisions: 1.36 File: radiusd/src/lib/valuepair.c; Revisions: 1.96 File: radiusd/src/include/modules.h; Revisions: 1.27 File: radiusd/src/modules/rlm_expiration/rlm_expiration.c; Revisions: 1.6 File: radiusd/src/modules/rlm_eap/libeap/eapcommon.c; Revisions: 1.7 File: radiusd/src/modules/rlm_eap/types/rlm_eap_ttls/rlm_eap_ttls.c; Revisions: 1.6 File: radiusd/src/modules/rlm_eap/types/rlm_eap_ttls/ttls.c; Revisions: 1.23 File: radiusd/src/main/session.c; Revisions: 1.29 File: radiusd/src/main/conffile.c; Revisions: 1.129 File: radiusd/src/modules/rlm_logintime/rlm_logintime.c; Revisions: 1.6 File: radiusd/src/modules/rlm_sql/sql.c; Revisions: 1.86 File: radiusd/src/modules/rlm_attr_rewrite/rlm_attr_rewrite.c; Revisions: 1.32 File: radiusd/src/modules/rlm_mschap/rlm_mschap.c; Revisions: 1.70, 1.69 File: radiusd/src/modules/rlm_eap/types/rlm_eap_md5/eap_md5.c; Revisions: 1.12 File: radiusd/src/modules/rlm_eap/types/rlm_eap_mschapv2/rlm_eap_mschapv2.c; Revisions: 1.9 File: radiusd/src/modules/rlm_detail/rlm_detail.c; Revisions: 1.46 File: radiusd/src/modules/rlm_files/rlm_files.c; Revisions: 1.68 File: radiusd/src/modules/rlm_ippool/rlm_ippool.c; Revisions: 1.37 File: radiusd/src/modules/rlm_otp/otp_rlm.c; Revisions: 1.6 File: radiusd/src/modules/rlm_unix/rlm_unix.c; Revisions: 1.71 File: radiusd/src/modules/rlm_eap/mem.c; Revisions: 1.16 File: radiusd/src/main/proxy.c; Revisions: 1.87 File: radiusd/src/modules/rlm_eap/rlm_eap.c; Revisions: 1.33 File: radiusd/src/modules/rlm_eap/state.c; Revisions: 1.11 File: radiusd/src/modules/rlm_eap/types/rlm_eap_sim/rlm_eap_sim.c; Revisions: 1.13 Author: nbk File: radiusd/src/main/log.c; Revisions: 1.47, 1.41.2.1 File: radiusd/src/lib/snprintf.h; Revisions: 1.2, 1.1.2.1 File: radiusd/src/include/libradius.h; Revisions: 1.97, 1.76.2.2 File: radiusd/src/lib/snprintf.c; Revisions: 1.6, 1.5.2.1 File: radiusd/src/include/autoconf.h.in; Revisions: 1.55.2.4 ===================================================== Combined list of identical log entries ===================================================== Description: snprintf() and vsnprintf() replacements were not compiled if the autoconf tests didn't find the functions. Modified files: File: radiusd/src/include/libradius.h; Revision: 1.97; Date: 2005/09/01 15:55:02; Author: nbk; Lines: (+5 -12) File: radiusd/src/lib/snprintf.c; Revision: 1.6; Date: 2005/09/01 15:55:02; Author: nbk; Lines: (+6 -8) File: radiusd/src/lib/snprintf.h; Revision: 1.2; Date: 2005/09/01 15:55:02; Author: nbk; Lines: (+6 -2) ------------------------------- Description: s/->strvalue/->vp_strvalue/g Update libradius.h with a union of data, so that we can move to vp->vp_ipv6addr, vp->vp_octets, etc. The surprising thing is that it still builds & works. Modified files: File: radiusd/src/include/libradius.h; Revision: 1.98; Date: 2005/09/01 21:50:55; Author: aland; Lines: (+73 -4) File: radiusd/src/include/modules.h; Revision: 1.27; Date: 2005/09/01 21:50:55; Author: aland; Lines: (+2 -2) File: radiusd/src/lib/filters.c; Revision: 1.42; Date: 2005/09/01 21:50:56; Author: aland; Lines: (+8 -58) File: radiusd/src/lib/print.c; Revision: 1.36; Date: 2005/09/01 21:50:56; Author: aland; Lines: (+13 -13) File: radiusd/src/lib/radius.c; Revision: 1.161; Date: 2005/09/01 21:50:56; Author: aland; Lines: (+28 -28) File: radiusd/src/lib/valuepair.c; Revision: 1.96; Date: 2005/09/01 21:50:57; Author: aland; Lines: (+26 -26) File: radiusd/src/main/acct.c; Revision: 1.36; Date: 2005/09/01 21:50:58; Author: aland; Lines: (+3 -3) File: radiusd/src/main/auth.c; Revision: 1.151; Date: 2005/09/01 21:50:58; Author: aland; Lines: (+22 -22) File: radiusd/src/main/proxy.c; Revision: 1.87; Date: 2005/09/01 21:50:58; Author: aland; Lines: (+10 -10) File: radiusd/src/main/radclient.c; Revision: 1.90; Date: 2005/09/01 21:50:59; Author: aland; Lines: (+13 -13) File: radiusd/src/main/session.c; Revision: 1.29; Date: 2005/09/01 21:50:59; Author: aland; Lines: (+2 -2) File: radiusd/src/main/valuepair.c; Revision: 1.71; Date: 2005/09/01 21:50:59; Author: aland; Lines: (+20 -20) File: radiusd/src/main/xlat.c; Revision: 1.103; Date: 2005/09/01 21:51:00; Author: aland; Lines: (+6 -6) File: radiusd/src/modules/rlm_attr_filter/rlm_attr_filter.c; Revision: 1.26; Date: 2005/09/01 21:51:00; Author: aland; Lines: (+9 -9) File: radiusd/src/modules/rlm_attr_rewrite/rlm_attr_rewrite.c; Revision: 1.32; Date: 2005/09/01 21:51:01; Author: aland; Lines: (+13 -13) File: radiusd/src/modules/rlm_caching/rlm_caching.c; Revision: 1.5; Date: 2005/09/01 21:51:01; Author: aland; Lines: (+10 -10) File: radiusd/src/modules/rlm_chap/rlm_chap.c; Revision: 1.10; Date: 2005/09/01 21:51:01; Author: aland; Lines: (+8 -8) File: radiusd/src/modules/rlm_checkval/rlm_checkval.c; Revision: 1.14; Date: 2005/09/01 21:51:02; Author: aland; Lines: (+7 -7) File: radiusd/src/modules/rlm_counter/rlm_counter.c; Revision: 1.49; Date: 2005/09/01 21:51:02; Author: aland; Lines: (+16 -16) File: radiusd/src/modules/rlm_cram/rlm_cram.c; Revision: 1.6; Date: 2005/09/01 21:51:02; Author: aland; Lines: (+9 -9) File: radiusd/src/modules/rlm_dbm/rlm_dbm.c; Revision: 1.14; Date: 2005/09/01 21:51:03; Author: aland; Lines: (+5 -5) File: radiusd/src/modules/rlm_detail/rlm_detail.c; Revision: 1.46; Date: 2005/09/01 21:51:03; Author: aland; Lines: (+3 -3) File: radiusd/src/modules/rlm_digest/rlm_digest.c; Revision: 1.8; Date: 2005/09/01 21:51:03; Author: aland; Lines: (+24 -24) File: radiusd/src/modules/rlm_eap/eap.c; Revision: 1.57; Date: 2005/09/01 21:51:03; Author: aland; Lines: (+23 -23) File: radiusd/src/modules/rlm_eap/mem.c; Revision: 1.16; Date: 2005/09/01 21:51:04; Author: aland; Lines: (+4 -4) File: radiusd/src/modules/rlm_eap/radeapclient.c; Revision: 1.11; Date: 2005/09/01 21:51:04; Author: aland; Lines: (+43 -43) File: radiusd/src/modules/rlm_eap/rlm_eap.c; Revision: 1.33; Date: 2005/09/01 21:51:04; Author: aland; Lines: (+9 -9) File: radiusd/src/modules/rlm_eap/state.c; Revision: 1.11; Date: 2005/09/01 21:51:05; Author: aland; Lines: (+6 -6) File: radiusd/src/modules/rlm_eap/libeap/eapcommon.c; Revision: 1.7; Date: 2005/09/01 21:51:05; Author: aland; Lines: (+8 -8) File: radiusd/src/modules/rlm_eap/libeap/eapsimlib.c; Revision: 1.11; Date: 2005/09/01 21:51:05; Author: aland; Lines: (+10 -10) File: radiusd/src/modules/rlm_eap/types/rlm_eap_gtc/rlm_eap_gtc.c; Revision: 1.4; Date: 2005/09/01 21:51:06; Author: aland; Lines: (+4 -4) File: radiusd/src/modules/rlm_eap/types/rlm_eap_leap/eap_leap.c; Revision: 1.9; Date: 2005/09/01 21:51:06; Author: aland; Lines: (+11 -11) File: radiusd/src/modules/rlm_eap/types/rlm_eap_leap/rlm_eap_leap.c; Revision: 1.9; Date: 2005/09/01 21:51:07; Author: aland; Lines: (+2 -2) File: radiusd/src/modules/rlm_eap/types/rlm_eap_md5/eap_md5.c; Revision: 1.12; Date: 2005/09/01 21:51:08; Author: aland; Lines: (+2 -2) File: radiusd/src/modules/rlm_eap/types/rlm_eap_mschapv2/rlm_eap_mschapv2.c; Revision: 1.9; Date: 2005/09/01 21:51:08; Author: aland; Lines: (+12 -12) File: radiusd/src/modules/rlm_eap/types/rlm_eap_peap/peap.c; Revision: 1.17; Date: 2005/09/01 21:51:08; Author: aland; Lines: (+16 -16) File: radiusd/src/modules/rlm_eap/types/rlm_eap_sim/rlm_eap_sim.c; Revision: 1.13; Date: 2005/09/01 21:51:08; Author: aland; Lines: (+20 -17) File: radiusd/src/modules/rlm_eap/types/rlm_eap_tls/mppe_keys.c; Revision: 1.4; Date: 2005/09/01 21:51:08; Author: aland; Lines: (+2 -2) File: radiusd/src/modules/rlm_eap/types/rlm_eap_ttls/rlm_eap_ttls.c; Revision: 1.6; Date: 2005/09/01 21:51:09; Author: aland; Lines: (+2 -2) File: radiusd/src/modules/rlm_eap/types/rlm_eap_ttls/ttls.c; Revision: 1.23; Date: 2005/09/01 21:51:09; Author: aland; Lines: (+14 -14) File: radiusd/src/modules/rlm_expiration/rlm_expiration.c; Revision: 1.6; Date: 2005/09/01 21:51:09; Author: aland; Lines: (+4 -4) File: radiusd/src/modules/rlm_expr/paircmp.c; Revision: 1.3; Date: 2005/09/01 21:51:09; Author: aland; Lines: (+14 -14) File: radiusd/src/modules/rlm_fastusers/rlm_fastusers.c; Revision: 1.39; Date: 2005/09/01 21:51:10; Author: aland; Lines: (+3 -3) File: radiusd/src/modules/rlm_files/rlm_files.c; Revision: 1.68; Date: 2005/09/01 21:51:10; Author: aland; Lines: (+7 -7) File: radiusd/src/modules/rlm_ippool/rlm_ippool.c; Revision: 1.37; Date: 2005/09/01 21:51:10; Author: aland; Lines: (+6 -6) File: radiusd/src/modules/rlm_krb5/rlm_krb5.c; Revision: 1.22; Date: 2005/09/01 21:51:10; Author: aland; Lines: (+6 -6) File: radiusd/src/modules/rlm_ldap/rlm_ldap.c; Revision: 1.157; Date: 2005/09/01 21:51:11; Author: aland; Lines: (+49 -49) File: radiusd/src/modules/rlm_logintime/rlm_logintime.c; Revision: 1.6; Date: 2005/09/01 21:51:11; Author: aland; Lines: (+12 -12) File: radiusd/src/modules/rlm_mschap/rlm_mschap.c; Revision: 1.69; Date: 2005/09/01 21:51:11; Author: aland; Lines: (+50 -50) File: radiusd/src/modules/rlm_otp/otp_pwe.c; Revision: 1.2; Date: 2005/09/01 21:51:12; Author: aland; Lines: (+19 -19) File: radiusd/src/modules/rlm_otp/otp_rlm.c; Revision: 1.6; Date: 2005/09/01 21:51:12; Author: aland; Lines: (+9 -9) File: radiusd/src/modules/rlm_pam/rlm_pam.c; Revision: 1.37; Date: 2005/09/01 21:51:12; Author: aland; Lines: (+4 -4) File: radiusd/src/modules/rlm_pap/rlm_pap.c; Revision: 1.31; Date: 2005/09/01 21:51:12; Author: aland; Lines: (+42 -42) File: radiusd/src/modules/rlm_passwd/rlm_passwd.c; Revision: 1.25; Date: 2005/09/01 21:51:13; Author: aland; Lines: (+1 -1) File: radiusd/src/modules/rlm_preprocess/rlm_preprocess.c; Revision: 1.62; Date: 2005/09/01 21:51:13; Author: aland; Lines: (+22 -22) File: radiusd/src/modules/rlm_radutmp/rlm_radutmp.c; Revision: 1.32; Date: 2005/09/01 21:51:13; Author: aland; Lines: (+6 -6) File: radiusd/src/modules/rlm_radutmp/rlm_radutmp2.c; Revision: 1.6; Date: 2005/09/01 21:51:13; Author: aland; Lines: (+7 -7) File: radiusd/src/modules/rlm_realm/rlm_realm.c; Revision: 1.55; Date: 2005/09/01 21:51:14; Author: aland; Lines: (+9 -9) File: radiusd/src/modules/rlm_sim_files/rlm_sim_files.c; Revision: 1.7; Date: 2005/09/01 21:51:14; Author: aland; Lines: (+3 -3) File: radiusd/src/modules/rlm_smb/rlm_smb.c; Revision: 1.8; Date: 2005/09/01 21:51:14; Author: aland; Lines: (+4 -4) File: radiusd/src/modules/rlm_sql/rlm_sql.c; Revision: 1.150; Date: 2005/09/01 21:51:14; Author: aland; Lines: (+8 -8) File: radiusd/src/modules/rlm_sql/sql.c; Revision: 1.86; Date: 2005/09/01 21:51:14; Author: aland; Lines: (+2 -2) File: radiusd/src/modules/rlm_sqlcounter/rlm_sqlcounter.c; Revision: 1.19; Date: 2005/09/01 21:51:15; Author: aland; Lines: (+5 -5) File: radiusd/src/modules/rlm_unix/rlm_unix.c; Revision: 1.71; Date: 2005/09/01 21:51:15; Author: aland; Lines: (+10 -10) ------------------------------- Description: octets fixes Modified files: File: radiusd/src/modules/rlm_chap/rlm_chap.c; Revision: 1.11; Date: 2005/09/01 22:34:11; Author: aland; Lines: (+22 -10) File: radiusd/src/modules/rlm_digest/rlm_digest.c; Revision: 1.9; Date: 2005/09/01 22:16:05; Author: aland; Lines: (+20 -18) File: radiusd/src/modules/rlm_mschap/rlm_mschap.c; Revision: 1.70; Date: 2005/09/01 22:28:38; Author: aland; Lines: (+37 -35) File: radiusd/src/modules/rlm_pap/rlm_pap.c; Revision: 1.32; Date: 2005/09/01 22:40:33; Author: aland; Lines: (+19 -18) ------------------------------- Description: Pull from CVS head: snprintf() and vsnprintf() replacements were not compiled if the autoconf tests didn't find the functions. Modified files: File: radiusd/src/include/autoconf.h.in; Revision: 1.55.2.4; Date: 2005/09/01 15:55:13; Author: nbk; Lines: (+0 -11) File: radiusd/src/include/libradius.h; Revision: 1.76.2.2; Date: 2005/09/01 15:55:13; Author: nbk; Lines: (+6 -3) File: radiusd/src/lib/snprintf.c; Revision: 1.5.2.1; Date: 2005/09/01 15:55:13; Author: nbk; Lines: (+6 -8) File: radiusd/src/lib/snprintf.h; Revision: 1.1.2.1; Date: 2005/09/01 15:55:14; Author: nbk; Lines: (+6 -2) ------------------------------- Description: Updated vp_filter. Use it in filters Modified files: File: radiusd/src/include/libradius.h; Revision: 1.99; Date: 2005/09/01 23:17:20; Author: aland; Lines: (+3 -53) File: radiusd/src/lib/filters.c; Revision: 1.43; Date: 2005/09/01 23:17:20; Author: aland; Lines: (+123 -65) ------------------------------- Description: Update the way we handle parsing subsections, to avoid compiler warnings Modified files: File: radiusd/src/main/conffile.c; Revision: 1.129; Date: 2005/09/01 23:25:45; Author: aland; Lines: (+3 -3) File: radiusd/src/main/mainconfig.c; Revision: 1.81; Date: 2005/09/01 23:25:45; Author: aland; Lines: (+5 -4) File: radiusd/src/modules/rlm_ldap/rlm_ldap.c; Revision: 1.158; Date: 2005/09/01 23:25:45; Author: aland; Lines: (+2 -2) ===================================================== Log entries ===================================================== Description: Churn the random pool less often Modified files: File: radiusd/src/lib/radius.c; Revision: 1.160; Date: 2005/09/01 18:59:10; Author: aland; Lines: (+6 -6) ------------------------------- Description: #ifdef HAVE_VSNPRINTF isn't needed, as we have a replacement in src/lib/snprintf.c Modified files: File: radiusd/src/main/log.c; Revision: 1.47; Date: 2005/09/01 16:07:22; Author: nbk; Lines: (+3 -10) ------------------------------- Description: Pull from CVS head: #ifdef HAVE_VSNPRINTF isn't needed, as we have a replacement in src/lib/snprintf.c Modified files: File: radiusd/src/main/log.c; Revision: 1.41.2.1; Date: 2005/09/01 16:07:30; Author: nbk; Lines: (+3 -10) ------------------------------- Description: Don't make values with high bit set, it confuses rad_check_password Modified files: File: radiusd/src/main/modules.c; Revision: 1.102; Date: 2005/09/01 17:02:44; Author: aland; Lines: (+4 -4) ------------------------------- Description: Octets fixes. Use vp_ipv6addr, as it's already in the buffer. Fix weird code that was using wrong parameters to strNcpy Modified files: File: radiusd/src/main/radclient.c; Revision: 1.91; Date: 2005/09/01 22:21:23; Author: aland; Lines: (+23 -20) ------------------------------- Description: Use vp_octets in more places. "char" may be signed on some platforms, so doing array[vp->vp_strvalue[0]] may result in negative indices to arrays Modified files: File: radiusd/src/modules/rlm_eap/eap.c; Revision: 1.58; Date: 2005/09/01 22:10:42; Author: aland; Lines: (+19 -19) ------------------------------- Description: More octets fixes Modified files: File: radiusd/src/modules/rlm_eap/radeapclient.c; Revision: 1.13; Date: 2005/09/01 22:12:38; Author: aland; Lines: (+10 -10) ------------------------------- Description: Use octets in more places Modified files: File: radiusd/src/modules/rlm_eap/radeapclient.c; Revision: 1.12; Date: 2005/09/01 22:10:54; Author: aland; Lines: (+6 -6) ===================================================== Summary of modified files ===================================================== File: radiusd/src/include/autoconf.h.in Revisions: 1.55.2.4 Authors: nbk (+0 -11) ------------------------------- File: radiusd/src/include/libradius.h Revisions: 1.99, 1.98, 1.97, 1.76.2.2 Authors: aland (+3 -53), aland (+73 -4), nbk (+5 -12), nbk (+6 -3) ------------------------------- File: radiusd/src/include/modules.h Revisions: 1.27 Authors: aland (+2 -2) ------------------------------- File: radiusd/src/lib/filters.c Revisions: 1.43, 1.42 Authors: aland (+123 -65), aland (+8 -58) ------------------------------- File: radiusd/src/lib/print.c Revisions: 1.36 Authors: aland (+13 -13) ------------------------------- File: radiusd/src/lib/radius.c Revisions: 1.161, 1.160 Authors: aland (+28 -28), aland (+6 -6) ------------------------------- File: radiusd/src/lib/snprintf.c Revisions: 1.6, 1.5.2.1 Authors: nbk (+6 -8), nbk (+6 -8) ------------------------------- File: radiusd/src/lib/snprintf.h Revisions: 1.2, 1.1.2.1 Authors: nbk (+6 -2), nbk (+6 -2) ------------------------------- File: radiusd/src/lib/valuepair.c Revisions: 1.96 Authors: aland (+26 -26) ------------------------------- File: radiusd/src/main/acct.c Revisions: 1.36 Authors: aland (+3 -3) ------------------------------- File: radiusd/src/main/auth.c Revisions: 1.151 Authors: aland (+22 -22) ------------------------------- File: radiusd/src/main/conffile.c Revisions: 1.129 Authors: aland (+3 -3) ------------------------------- File: radiusd/src/main/log.c Revisions: 1.47, 1.41.2.1 Authors: nbk (+3 -10), nbk (+3 -10) ------------------------------- File: radiusd/src/main/mainconfig.c Revisions: 1.81 Authors: aland (+5 -4) ------------------------------- File: radiusd/src/main/modules.c Revisions: 1.102 Authors: aland (+4 -4) ------------------------------- File: radiusd/src/main/proxy.c Revisions: 1.87 Authors: aland (+10 -10) ------------------------------- File: radiusd/src/main/radclient.c Revisions: 1.91, 1.90 Authors: aland (+23 -20), aland (+13 -13) ------------------------------- File: radiusd/src/main/session.c Revisions: 1.29 Authors: aland (+2 -2) ------------------------------- File: radiusd/src/main/valuepair.c Revisions: 1.71 Authors: aland (+20 -20) ------------------------------- File: radiusd/src/main/xlat.c Revisions: 1.103 Authors: aland (+6 -6) ------------------------------- File: radiusd/src/modules/rlm_attr_filter/rlm_attr_filter.c Revisions: 1.26 Authors: aland (+9 -9) ------------------------------- File: radiusd/src/modules/rlm_attr_rewrite/rlm_attr_rewrite.c Revisions: 1.32 Authors: aland (+13 -13) ------------------------------- File: radiusd/src/modules/rlm_caching/rlm_caching.c Revisions: 1.5 Authors: aland (+10 -10) ------------------------------- File: radiusd/src/modules/rlm_chap/rlm_chap.c Revisions: 1.11, 1.10 Authors: aland (+22 -10), aland (+8 -8) ------------------------------- File: radiusd/src/modules/rlm_checkval/rlm_checkval.c Revisions: 1.14 Authors: aland (+7 -7) ------------------------------- File: radiusd/src/modules/rlm_counter/rlm_counter.c Revisions: 1.49 Authors: aland (+16 -16) ------------------------------- File: radiusd/src/modules/rlm_cram/rlm_cram.c Revisions: 1.6 Authors: aland (+9 -9) ------------------------------- File: radiusd/src/modules/rlm_dbm/rlm_dbm.c Revisions: 1.14 Authors: aland (+5 -5) ------------------------------- File: radiusd/src/modules/rlm_detail/rlm_detail.c Revisions: 1.46 Authors: aland (+3 -3) ------------------------------- File: radiusd/src/modules/rlm_digest/rlm_digest.c Revisions: 1.9, 1.8 Authors: aland (+20 -18), aland (+24 -24) ------------------------------- File: radiusd/src/modules/rlm_eap/eap.c Revisions: 1.58, 1.57 Authors: aland (+19 -19), aland (+23 -23) ------------------------------- File: radiusd/src/modules/rlm_eap/libeap/eapcommon.c Revisions: 1.7 Authors: aland (+8 -8) ------------------------------- File: radiusd/src/modules/rlm_eap/libeap/eapsimlib.c Revisions: 1.11 Authors: aland (+10 -10) ------------------------------- File: radiusd/src/modules/rlm_eap/mem.c Revisions: 1.16 Authors: aland (+4 -4) ------------------------------- File: radiusd/src/modules/rlm_eap/radeapclient.c Revisions: 1.13, 1.12, 1.11 Authors: aland (+10 -10), aland (+6 -6), aland (+43 -43) ------------------------------- File: radiusd/src/modules/rlm_eap/rlm_eap.c Revisions: 1.33 Authors: aland (+9 -9) ------------------------------- File: radiusd/src/modules/rlm_eap/state.c Revisions: 1.11 Authors: aland (+6 -6) ------------------------------- File: radiusd/src/modules/rlm_eap/types/rlm_eap_gtc/rlm_eap_gtc.c Revisions: 1.4 Authors: aland (+4 -4) ------------------------------- File: radiusd/src/modules/rlm_eap/types/rlm_eap_leap/eap_leap.c Revisions: 1.9 Authors: aland (+11 -11) ------------------------------- File: radiusd/src/modules/rlm_eap/types/rlm_eap_leap/rlm_eap_leap.c Revisions: 1.9 Authors: aland (+2 -2) ------------------------------- File: radiusd/src/modules/rlm_eap/types/rlm_eap_md5/eap_md5.c Revisions: 1.12 Authors: aland (+2 -2) ------------------------------- File: radiusd/src/modules/rlm_eap/types/rlm_eap_mschapv2/rlm_eap_mschapv2.c Revisions: 1.9 Authors: aland (+12 -12) ------------------------------- File: radiusd/src/modules/rlm_eap/types/rlm_eap_peap/peap.c Revisions: 1.17 Authors: aland (+16 -16) ------------------------------- File: radiusd/src/modules/rlm_eap/types/rlm_eap_sim/rlm_eap_sim.c Revisions: 1.13 Authors: aland (+20 -17) ------------------------------- File: radiusd/src/modules/rlm_eap/types/rlm_eap_tls/mppe_keys.c Revisions: 1.4 Authors: aland (+2 -2) ------------------------------- File: radiusd/src/modules/rlm_eap/types/rlm_eap_ttls/rlm_eap_ttls.c Revisions: 1.6 Authors: aland (+2 -2) ------------------------------- File: radiusd/src/modules/rlm_eap/types/rlm_eap_ttls/ttls.c Revisions: 1.23 Authors: aland (+14 -14) ------------------------------- File: radiusd/src/modules/rlm_expiration/rlm_expiration.c Revisions: 1.6 Authors: aland (+4 -4) ------------------------------- File: radiusd/src/modules/rlm_expr/paircmp.c Revisions: 1.3 Authors: aland (+14 -14) ------------------------------- File: radiusd/src/modules/rlm_fastusers/rlm_fastusers.c Revisions: 1.39 Authors: aland (+3 -3) ------------------------------- File: radiusd/src/modules/rlm_files/rlm_files.c Revisions: 1.68 Authors: aland (+7 -7) ------------------------------- File: radiusd/src/modules/rlm_ippool/rlm_ippool.c Revisions: 1.37 Authors: aland (+6 -6) ------------------------------- File: radiusd/src/modules/rlm_krb5/rlm_krb5.c Revisions: 1.22 Authors: aland (+6 -6) ------------------------------- File: radiusd/src/modules/rlm_ldap/rlm_ldap.c Revisions: 1.158, 1.157 Authors: aland (+2 -2), aland (+49 -49) ------------------------------- File: radiusd/src/modules/rlm_logintime/rlm_logintime.c Revisions: 1.6 Authors: aland (+12 -12) ------------------------------- File: radiusd/src/modules/rlm_mschap/rlm_mschap.c Revisions: 1.70, 1.69 Authors: aland (+37 -35), aland (+50 -50) ------------------------------- File: radiusd/src/modules/rlm_otp/otp_pwe.c Revisions: 1.2 Authors: aland (+19 -19) ------------------------------- File: radiusd/src/modules/rlm_otp/otp_rlm.c Revisions: 1.6 Authors: aland (+9 -9) ------------------------------- File: radiusd/src/modules/rlm_pam/rlm_pam.c Revisions: 1.37 Authors: aland (+4 -4) ------------------------------- File: radiusd/src/modules/rlm_pap/rlm_pap.c Revisions: 1.32, 1.31 Authors: aland (+19 -18), aland (+42 -42) ------------------------------- File: radiusd/src/modules/rlm_passwd/rlm_passwd.c Revisions: 1.25 Authors: aland (+1 -1) ------------------------------- File: radiusd/src/modules/rlm_preprocess/rlm_preprocess.c Revisions: 1.62 Authors: aland (+22 -22) ------------------------------- File: radiusd/src/modules/rlm_radutmp/rlm_radutmp.c Revisions: 1.32 Authors: aland (+6 -6) ------------------------------- File: radiusd/src/modules/rlm_radutmp/rlm_radutmp2.c Revisions: 1.6 Authors: aland (+7 -7) ------------------------------- File: radiusd/src/modules/rlm_realm/rlm_realm.c Revisions: 1.55 Authors: aland (+9 -9) ------------------------------- File: radiusd/src/modules/rlm_sim_files/rlm_sim_files.c Revisions: 1.7 Authors: aland (+3 -3) ------------------------------- File: radiusd/src/modules/rlm_smb/rlm_smb.c Revisions: 1.8 Authors: aland (+4 -4) ------------------------------- File: radiusd/src/modules/rlm_sql/rlm_sql.c Revisions: 1.150 Authors: aland (+8 -8) ------------------------------- File: radiusd/src/modules/rlm_sql/sql.c Revisions: 1.86 Authors: aland (+2 -2) ------------------------------- File: radiusd/src/modules/rlm_sqlcounter/rlm_sqlcounter.c Revisions: 1.19 Authors: aland (+5 -5) ------------------------------- File: radiusd/src/modules/rlm_unix/rlm_unix.c Revisions: 1.71 Authors: aland (+10 -10) -- Automatic cron job from /web/pages/us.freeradius.org/bin/new_makelog.pl

1 0

unions in VALUE_PAIR
by Alan DeKok 01 Sep '05

01 Sep '05

Surprisingly, it works. And builds. And answers requests. I've committed a whack of changes that will let us move to using elements from the union. Now all we have to do is audit the rest of the source to make the code use the right element, rather than vp->vp_strvalue everywhere. Alan DeKok.

1 0

Re: [Bug 269] Many compiler warnings with gcc 4.0
by Alan DeKok 01 Sep '05

01 Sep '05

bugzilla-daemon(a)dump.segv.org wrote: > ------- Additional Comments From nbk(a)sitadelle.com 2005-08-24 09:58 ------- > Many thanks for second patch! I've added it to the CVS branch 1.0, > so your fixes will be in release 1.0.5. > > There're still problems of incompatible pointer types, but I need > Alan's opinion about bringing so many casts in the > source. (personally I don't like the idea) Neither do I. They make the code harder to read & maintain. Alan DeKok.

4 14

Automatic report from sources (radiusd) between 31.08.2005 - 01.09.2005 GMT
by Automatic cvs log generator 01 Sep '05

01 Sep '05

CVS log entries from 31.08.2005 (Wed) 08:00:01 - 01.09.2005 (Thu) 08:00:01 GMT ===================================================== Summary by authors ===================================================== Author: aland File: radiusd/src/lib/radius.c; Revisions: 1.159 File: radiusd/src/include/md5.h; Revisions: 1.14 File: radiusd/src/main/mainconfig.c; Revisions: 1.80 File: radiusd/src/lib/valuepair.c; Revisions: 1.95 File: radiusd/src/lib/hmac.c; Revisions: 1.8 File: radiusd/src/lib/filters.c; Revisions: 1.41 File: radiusd/src/lib/misc.c; Revisions: 1.63 File: radiusd/src/modules/rlm_eap/radeapclient.c; Revisions: 1.10 File: radiusd/scripts/xpextensions; Revisions: 1.2 File: radiusd/src/include/libradius.h; Revisions: 1.96, 1.95 File: radiusd/src/lib/dict.c; Revisions: 1.71 File: radiusd/src/lib/rbtree.c; Revisions: 1.17 File: radiusd/src/lib/hmacsha1.c; Revisions: 1.8 File: radiusd/src/lib/md5.c; Revisions: 1.16 Author: nbk File: radiusd/src/modules/rlm_sql/rlm_sql.c; Revisions: 1.149, 1.131.2.4 ===================================================== Combined list of identical log entries ===================================================== Description: Compiler warning fixes Modified files: File: radiusd/src/lib/dict.c; Revision: 1.71; Date: 2005/08/31 21:02:25; Author: aland; Lines: (+6 -6) File: radiusd/src/lib/valuepair.c; Revision: 1.95; Date: 2005/08/31 21:02:26; Author: aland; Lines: (+3 -3) ------------------------------- Description: uint8_t fixes Modified files: File: radiusd/src/include/libradius.h; Revision: 1.96; Date: 2005/08/31 20:49:30; Author: aland; Lines: (+10 -10) File: radiusd/src/lib/filters.c; Revision: 1.41; Date: 2005/08/31 20:49:57; Author: aland; Lines: (+4 -4) File: radiusd/src/lib/hmac.c; Revision: 1.8; Date: 2005/08/31 20:49:31; Author: aland; Lines: (+20 -20) File: radiusd/src/lib/hmacsha1.c; Revision: 1.8; Date: 2005/08/31 20:49:30; Author: aland; Lines: (+12 -12) File: radiusd/src/lib/md5.c; Revision: 1.16; Date: 2005/08/31 20:49:30; Author: aland; Lines: (+14 -16) File: radiusd/src/lib/misc.c; Revision: 1.63; Date: 2005/08/31 20:49:31; Author: aland; Lines: (+4 -4) File: radiusd/src/lib/rbtree.c; Revision: 1.17; Date: 2005/08/31 20:49:31; Author: aland; Lines: (+3 -3) ------------------------------- Description: Signed/unsigned issues. Use "uint8_t" in more places. Modified files: File: radiusd/src/include/libradius.h; Revision: 1.95; Date: 2005/08/31 20:34:17; Author: aland; Lines: (+13 -8) File: radiusd/src/include/md5.h; Revision: 1.14; Date: 2005/08/31 20:34:17; Author: aland; Lines: (+13 -12) File: radiusd/src/lib/radius.c; Revision: 1.159; Date: 2005/08/31 20:34:18; Author: aland; Lines: (+42 -43) File: radiusd/src/modules/rlm_eap/radeapclient.c; Revision: 1.10; Date: 2005/08/31 20:34:17; Author: aland; Lines: (+8 -8) ===================================================== Log entries ===================================================== Description: Added note on OID for machine authentication Modified files: File: radiusd/scripts/xpextensions; Revision: 1.2; Date: 2005/08/31 16:55:08; Author: aland; Lines: (+12 -0) ------------------------------- Description: Don't return NULL from a function that returns 'int' Modified files: File: radiusd/src/main/mainconfig.c; Revision: 1.80; Date: 2005/08/31 21:05:38; Author: aland; Lines: (+7 -5) ------------------------------- Description: Resize the buffer for the SQL-User-Name, and update the comments to help people (...) to figure out why there is no escaping in sql_escape_func(). Modified files: File: radiusd/src/modules/rlm_sql/rlm_sql.c; Revision: 1.149; Date: 2005/08/31 12:49:46; Author: nbk; Lines: (+23 -24) ------------------------------- Description: Pull from CVS head: Resize the buffer for the SQL-User-Name, and update the comments to help people (...) to figure out why there is no escaping in sql_escape_func(). Modified files: File: radiusd/src/modules/rlm_sql/rlm_sql.c; Revision: 1.131.2.4; Date: 2005/08/31 12:49:52; Author: nbk; Lines: (+21 -22) ===================================================== Summary of modified files ===================================================== File: radiusd/scripts/xpextensions Revisions: 1.2 Authors: aland (+12 -0) ------------------------------- File: radiusd/src/include/libradius.h Revisions: 1.96, 1.95 Authors: aland (+10 -10), aland (+13 -8) ------------------------------- File: radiusd/src/include/md5.h Revisions: 1.14 Authors: aland (+13 -12) ------------------------------- File: radiusd/src/lib/dict.c Revisions: 1.71 Authors: aland (+6 -6) ------------------------------- File: radiusd/src/lib/filters.c Revisions: 1.41 Authors: aland (+4 -4) ------------------------------- File: radiusd/src/lib/hmac.c Revisions: 1.8 Authors: aland (+20 -20) ------------------------------- File: radiusd/src/lib/hmacsha1.c Revisions: 1.8 Authors: aland (+12 -12) ------------------------------- File: radiusd/src/lib/md5.c Revisions: 1.16 Authors: aland (+14 -16) ------------------------------- File: radiusd/src/lib/misc.c Revisions: 1.63 Authors: aland (+4 -4) ------------------------------- File: radiusd/src/lib/radius.c Revisions: 1.159 Authors: aland (+42 -43) ------------------------------- File: radiusd/src/lib/rbtree.c Revisions: 1.17 Authors: aland (+3 -3) ------------------------------- File: radiusd/src/lib/valuepair.c Revisions: 1.95 Authors: aland (+3 -3) ------------------------------- File: radiusd/src/main/mainconfig.c Revisions: 1.80 Authors: aland (+7 -5) ------------------------------- File: radiusd/src/modules/rlm_eap/radeapclient.c Revisions: 1.10 Authors: aland (+8 -8) ------------------------------- File: radiusd/src/modules/rlm_sql/rlm_sql.c Revisions: 1.149, 1.131.2.4 Authors: nbk (+23 -24), nbk (+21 -22) -- Automatic cron job from /web/pages/us.freeradius.org/bin/new_makelog.pl

1 0

Fw: question about realms file format
by Thanh Lim 31 Aug '05

31 Aug '05

Oops. Sorry, sent to the wrong list. -thanh ----- Original Message ----- From: "Thanh Lim" <limt(a)corp.earthlink.net> To: <freeradius-devel-request(a)lists.freeradius.org> Sent: Tuesday, August 30, 2005 2:46 PM Subject: question about realms file format > How much longer will we need to support the old realms file format? I'm > looking into updating all code dealing with the REALM structure, and > improving performance for lookups, etc. and am unsure if I should be > updating that code as well. > > Also, I notice within the REALM structure, every single time, a linked > list iteration occurs, many times, the active and account active flag is > checked, and set, even if it's not the ip address and port that we are > looking for. Why was it done this way, and shouldn't we just update the > active flag only when we find the right one(s)? > > Thanks, > -thanh >

2 1

how to change free radius attributes like (type, value )pair dynamically
by 6ackpace 31 Aug '05

31 Aug '05

hi group, i wannt to change the replys from freeradius to the switch.can anyone help me? i have tried rlm_files module and used pair_add function to change responses but failed. please guide me thank you,

1 0

Automatic report from sources (radiusd) between 30.08.2005 - 31.08.2005 GMT
by Automatic cvs log generator 31 Aug '05

31 Aug '05

CVS log entries from 30.08.2005 (Tue) 08:00:01 - 31.08.2005 (Wed) 08:00:01 GMT ===================================================== Summary by authors ===================================================== Author: aland File: radiusd/src/lib/radius.c; Revisions: 1.158 File: radiusd/src/include/libradius.h; Revisions: 1.94 File: radiusd/src/lib/dict.c; Revisions: 1.70, 1.69 Author: fcusack File: radiusd/src/modules/rlm_ldap/rlm_ldap.c; Revisions: 1.156 ===================================================== Combined list of identical log entries ===================================================== Description: We don't have differences between vendorpec & vendorcode any more Modified files: File: radiusd/src/include/libradius.h; Revision: 1.94; Date: 2005/08/30 21:45:07; Author: aland; Lines: (+2 -9) File: radiusd/src/lib/radius.c; Revision: 1.158; Date: 2005/08/30 21:45:07; Author: aland; Lines: (+6 -21) ===================================================== Log entries ===================================================== Description: More sanity checks on the dictionary. VSA's can't be tagged, and only string & integer attributes can be tagged Modified files: File: radiusd/src/lib/dict.c; Revision: 1.70; Date: 2005/08/30 23:05:18; Author: aland; Lines: (+33 -2) ------------------------------- Description: Add "internal" structs for attributes, etc. Use a hash for them, which makes lookups much faster. Hmm... we should probably just go to a hash table for ATTRIBUTEs and VALUEs, as that would be even better.. Modified files: File: radiusd/src/lib/dict.c; Revision: 1.69; Date: 2005/08/30 23:03:21; Author: aland; Lines: (+332 -197) ------------------------------- Description: fix bug #278: connection status must not be tested until after acquiring mutex protecting it Modified files: File: radiusd/src/modules/rlm_ldap/rlm_ldap.c; Revision: 1.156; Date: 2005/08/30 22:27:00; Author: fcusack; Lines: (+8 -3) ===================================================== Summary of modified files ===================================================== File: radiusd/src/include/libradius.h Revisions: 1.94 Authors: aland (+2 -9) ------------------------------- File: radiusd/src/lib/dict.c Revisions: 1.70, 1.69 Authors: aland (+33 -2), aland (+332 -197) ------------------------------- File: radiusd/src/lib/radius.c Revisions: 1.158 Authors: aland (+6 -21) ------------------------------- File: radiusd/src/modules/rlm_ldap/rlm_ldap.c Revisions: 1.156 Authors: fcusack (+8 -3) -- Automatic cron job from /web/pages/us.freeradius.org/bin/new_makelog.pl

1 0

per-module per-thread constructors and destructors
by Frank Cusack 30 Aug '05

30 Aug '05

I need to add a thread local variable to rlm_otp. It's a per-thread fd which connects to another program running locally. rlm_otp makes requests of it and it returns results. The semantics of that program does not guarantee sequencing of results unless each request thread has its own connection. That is, if I have a global fd, the response received by one thread may not be to the correct request: t1 t2 get_state(foo) get_state(bar) -> write(foo) -> write(bar) -> read() -> read() -> bar -> foo The other program may return bar first, and even if it returned results in the order received, because both threads are blocked in read(), either might pick up the result for the other. An fd per thread fixes this. It also fixes the problem that writes() might interleave (atomic writes are only guaranteed in certain cases which won't be met here), but that is just icing for the cake. The problem, though, is that on thread exit no cleanup is done. I want to add two functions to threads.c: register_constructor() and register_destructor(). When a module is instantiated, it can call these to register functions to be called on thread creation and destruction. (rlm_otp will register a destructor which closes the fd.) It's fairly trivial, but it touches the "core" of freeradius, and it affects thread behavior, so I wanted to be sure there were no objections before adding it. -frank

2 8