November 2005 - Freeradius-Devel - lists.freeradius.org

Automatic report from sources (radiusd) between 08.11.2005 - 09.11.2005 GMT
by Automatic cvs log generator 09 Nov '05

09 Nov '05

CVS log entries from 08.11.2005 (Tue) 09:00:00 - 09.11.2005 (Wed) 09:00:00 GMT ===================================================== Summary by authors ===================================================== Author: fcusack File: radiusd/src/modules/rlm_otp/otp_x99.c; Revisions: 1.7 File: radiusd/src/modules/rlm_otp/otp_rlm.c; Revisions: 1.18, 1.17, 1.16 File: radiusd/src/modules/rlm_otp/otp_hotp.c; Revisions: 1.4 File: radiusd/src/modules/rlm_otp/otp_rad.h; Revisions: 1.5 File: radiusd/src/modules/rlm_otp/otp_pwe.c; Revisions: 1.7 File: radiusd/src/modules/rlm_otp/otp_cardops.c; Revisions: 1.62, 1.61, 1.60 File: radiusd/src/modules/rlm_otp/otp_util.c; Revisions: 1.13, 1.12 File: radiusd/src/modules/rlm_otp/otp_state.c; Revisions: 1.23 File: radiusd/src/modules/rlm_otp/otp_pwe.h; Revisions: 1.4 File: radiusd/src/modules/rlm_otp/otp_log.c; Revisions: 1.4 File: radiusd/src/modules/rlm_otp/cardops/cryptocard.c; Revisions: 1.39 File: radiusd/src/modules/rlm_otp/otp_site.c; Revisions: 1.5 File: radiusd/src/modules/rlm_otp/otp.h; Revisions: 1.28, 1.27, 1.26 ===================================================== Combined list of identical log entries ===================================================== Description: fix logging: - add __func__ to otp_log(), where missing - don't prepend MODULE_NAME in otp_log(), instead make it part of log_prefix (as appropriate) Modified files: File: radiusd/src/modules/rlm_otp/otp.h; Revision: 1.27; Date: 2005/11/08 10:51:43; Author: fcusack; Lines: (+6 -5) File: radiusd/src/modules/rlm_otp/otp_cardops.c; Revision: 1.61; Date: 2005/11/08 10:51:43; Author: fcusack; Lines: (+61 -66) File: radiusd/src/modules/rlm_otp/otp_hotp.c; Revision: 1.4; Date: 2005/11/08 10:51:43; Author: fcusack; Lines: (+3 -3) File: radiusd/src/modules/rlm_otp/otp_log.c; Revision: 1.4; Date: 2005/11/08 10:51:43; Author: fcusack; Lines: (+4 -14) File: radiusd/src/modules/rlm_otp/otp_pwe.c; Revision: 1.7; Date: 2005/11/08 10:51:43; Author: fcusack; Lines: (+29 -20) File: radiusd/src/modules/rlm_otp/otp_pwe.h; Revision: 1.4; Date: 2005/11/08 10:51:43; Author: fcusack; Lines: (+1 -1) File: radiusd/src/modules/rlm_otp/otp_rad.h; Revision: 1.5; Date: 2005/11/08 10:51:43; Author: fcusack; Lines: (+3 -3) File: radiusd/src/modules/rlm_otp/otp_rlm.c; Revision: 1.17; Date: 2005/11/08 10:51:43; Author: fcusack; Lines: (+76 -47) File: radiusd/src/modules/rlm_otp/otp_state.c; Revision: 1.23; Date: 2005/11/08 10:51:44; Author: fcusack; Lines: (+78 -73) File: radiusd/src/modules/rlm_otp/otp_util.c; Revision: 1.12; Date: 2005/11/08 10:51:44; Author: fcusack; Lines: (+40 -35) File: radiusd/src/modules/rlm_otp/otp_x99.c; Revision: 1.7; Date: 2005/11/08 10:51:44; Author: fcusack; Lines: (+4 -4) File: radiusd/src/modules/rlm_otp/cardops/cryptocard.c; Revision: 1.39; Date: 2005/11/08 10:51:44; Author: fcusack; Lines: (+5 -5) ------------------------------- Description: s/otp_get_challenge/otp_async_challenge/ to avoid confusion with sync challenge Modified files: File: radiusd/src/modules/rlm_otp/otp.h; Revision: 1.28; Date: 2005/11/08 11:00:34; Author: fcusack; Lines: (+2 -2) File: radiusd/src/modules/rlm_otp/otp_rlm.c; Revision: 1.18; Date: 2005/11/08 11:00:34; Author: fcusack; Lines: (+3 -3) File: radiusd/src/modules/rlm_otp/otp_util.c; Revision: 1.13; Date: 2005/11/08 11:00:34; Author: fcusack; Lines: (+4 -4) ------------------------------- Description: combine FR and PAM debug options Modified files: File: radiusd/src/modules/rlm_otp/otp.h; Revision: 1.26; Date: 2005/11/08 09:06:45; Author: fcusack; Lines: (+2 -6) File: radiusd/src/modules/rlm_otp/otp_cardops.c; Revision: 1.60; Date: 2005/11/08 09:06:45; Author: fcusack; Lines: (+17 -40) File: radiusd/src/modules/rlm_otp/otp_rlm.c; Revision: 1.16; Date: 2005/11/08 09:06:45; Author: fcusack; Lines: (+10 -22) ===================================================== Log entries ===================================================== Description: combine another FR and PAM debug option (missed earlier) Modified files: File: radiusd/src/modules/rlm_otp/otp_cardops.c; Revision: 1.62; Date: 2005/11/08 10:56:49; Author: fcusack; Lines: (+3 -8) ------------------------------- Description: fix signed/unsigned comparison Modified files: File: radiusd/src/modules/rlm_otp/otp_site.c; Revision: 1.5; Date: 2005/11/08 10:43:20; Author: fcusack; Lines: (+3 -3) ===================================================== Summary of modified files ===================================================== File: radiusd/src/modules/rlm_otp/cardops/cryptocard.c Revisions: 1.39 Authors: fcusack (+5 -5) ------------------------------- File: radiusd/src/modules/rlm_otp/otp.h Revisions: 1.28, 1.27, 1.26 Authors: fcusack (+2 -2), fcusack (+6 -5), fcusack (+2 -6) ------------------------------- File: radiusd/src/modules/rlm_otp/otp_cardops.c Revisions: 1.62, 1.61, 1.60 Authors: fcusack (+3 -8), fcusack (+61 -66), fcusack (+17 -40) ------------------------------- File: radiusd/src/modules/rlm_otp/otp_hotp.c Revisions: 1.4 Authors: fcusack (+3 -3) ------------------------------- File: radiusd/src/modules/rlm_otp/otp_log.c Revisions: 1.4 Authors: fcusack (+4 -14) ------------------------------- File: radiusd/src/modules/rlm_otp/otp_pwe.c Revisions: 1.7 Authors: fcusack (+29 -20) ------------------------------- File: radiusd/src/modules/rlm_otp/otp_pwe.h Revisions: 1.4 Authors: fcusack (+1 -1) ------------------------------- File: radiusd/src/modules/rlm_otp/otp_rad.h Revisions: 1.5 Authors: fcusack (+3 -3) ------------------------------- File: radiusd/src/modules/rlm_otp/otp_rlm.c Revisions: 1.18, 1.17, 1.16 Authors: fcusack (+3 -3), fcusack (+76 -47), fcusack (+10 -22) ------------------------------- File: radiusd/src/modules/rlm_otp/otp_site.c Revisions: 1.5 Authors: fcusack (+3 -3) ------------------------------- File: radiusd/src/modules/rlm_otp/otp_state.c Revisions: 1.23 Authors: fcusack (+78 -73) ------------------------------- File: radiusd/src/modules/rlm_otp/otp_util.c Revisions: 1.13, 1.12 Authors: fcusack (+4 -4), fcusack (+40 -35) ------------------------------- File: radiusd/src/modules/rlm_otp/otp_x99.c Revisions: 1.7 Authors: fcusack (+4 -4) -- Automatic cron job from /web/pages/us.freeradius.org/bin/new_makelog.pl

1 0

Automatic report from sources (radiusd) between 07.11.2005 - 08.11.2005 GMT
by Automatic cvs log generator 08 Nov '05

08 Nov '05

CVS log entries from 07.11.2005 (Mon) 09:00:00 - 08.11.2005 (Tue) 09:00:00 GMT ===================================================== Summary by authors ===================================================== Author: aland File: radiusd/src/main/request_list.c; Revisions: 1.69 Author: fcusack File: radiusd/src/modules/rlm_otp/otp_radstate.c; Revisions: 1.4 File: radiusd/src/modules/rlm_otp/cardops/cryptocard.h; Revisions: 1.37, 1.36 File: radiusd/src/modules/rlm_otp/otp_x99.c; Revisions: 1.6 File: radiusd/src/modules/rlm_otp/otp_rlm.c; Revisions: 1.15 File: radiusd/src/modules/rlm_otp/otp_rad.h; Revisions: 1.4 File: radiusd/src/modules/rlm_otp/otp_cardops.c; Revisions: 1.59, 1.58 File: radiusd/src/modules/rlm_otp/otp_util.c; Revisions: 1.11, 1.10 File: radiusd/src/modules/rlm_otp/otp_cardops.h; Revisions: 1.41, 1.40 File: radiusd/src/modules/rlm_otp/otp_state.c; Revisions: 1.22 File: radiusd/src/modules/rlm_otp/cardops/cryptocard.c; Revisions: 1.38, 1.37 File: radiusd/src/modules/rlm_otp/otp_site.c; Revisions: 1.4 File: radiusd/src/modules/rlm_otp/otp.h; Revisions: 1.25, 1.24, 1.23 ===================================================== Combined list of identical log entries ===================================================== Description: s/user_info/card_info/ Modified files: File: radiusd/src/modules/rlm_otp/otp.h; Revision: 1.23; Date: 2005/11/07 09:28:33; Author: fcusack; Lines: (+4 -4) File: radiusd/src/modules/rlm_otp/otp_cardops.c; Revision: 1.58; Date: 2005/11/07 09:28:33; Author: fcusack; Lines: (+30 -30) File: radiusd/src/modules/rlm_otp/otp_cardops.h; Revision: 1.40; Date: 2005/11/07 09:28:33; Author: fcusack; Lines: (+7 -7) File: radiusd/src/modules/rlm_otp/otp_util.c; Revision: 1.10; Date: 2005/11/07 09:28:34; Author: fcusack; Lines: (+26 -26) File: radiusd/src/modules/rlm_otp/otp_x99.c; Revision: 1.6; Date: 2005/11/07 09:28:34; Author: fcusack; Lines: (+3 -3) File: radiusd/src/modules/rlm_otp/cardops/cryptocard.c; Revision: 1.37; Date: 2005/11/07 09:28:34; Author: fcusack; Lines: (+12 -12) File: radiusd/src/modules/rlm_otp/cardops/cryptocard.h; Revision: 1.36; Date: 2005/11/07 09:28:34; Author: fcusack; Lines: (+7 -7) ------------------------------- Description: Change user_state 'challenge' field from string to uchar, which makes more sense for crypto and other manipulation. Unfortunately, it is a huge change for such a small gain (basically avoiding sprintf() and sscanf() conversions.) Notable changes: - otp.h: add 'clen' field to user_state; update it wherever the 'challenge' field is set - otp_cardops.h: add printchallenge() method, OTP_CF_C8 and OTP_CF_C4 Card Feature macros - cardops keystring2keyblock() method and otp_keystring2keyblock() now return keylen (instead of 0) on success - otp_keyblock2keystring() now takes a length arg and returns char * for easy printing - remove [unused] 'card_info' and 'log_prefix' args to cardops updatecsd() method - otp_gen_challenge() noted as cryptocard-specific with quirky behavior - otp_challenge_transform() explicitly returns new challenge length - cryptocard.c:cryptocard_challenge(): Remove hardcoded challenge length of 8. Yes, *sync* challenge length must be 8 but challenge might be a different size due to resync with an async challenge. This worked before but became a bug when we changed the user_state 'challenge' field to be the previous (instead of the next) challenge. Modified files: File: radiusd/src/modules/rlm_otp/otp.h; Revision: 1.25; Date: 2005/11/08 08:56:21; Author: fcusack; Lines: (+10 -7) File: radiusd/src/modules/rlm_otp/otp_cardops.c; Revision: 1.59; Date: 2005/11/08 08:56:22; Author: fcusack; Lines: (+47 -27) File: radiusd/src/modules/rlm_otp/otp_cardops.h; Revision: 1.41; Date: 2005/11/08 08:56:22; Author: fcusack; Lines: (+25 -18) File: radiusd/src/modules/rlm_otp/otp_rad.h; Revision: 1.4; Date: 2005/11/08 08:56:22; Author: fcusack; Lines: (+3 -3) File: radiusd/src/modules/rlm_otp/otp_radstate.c; Revision: 1.4; Date: 2005/11/08 08:56:22; Author: fcusack; Lines: (+22 -36) File: radiusd/src/modules/rlm_otp/otp_rlm.c; Revision: 1.15; Date: 2005/11/08 08:56:22; Author: fcusack; Lines: (+10 -11) File: radiusd/src/modules/rlm_otp/otp_site.c; Revision: 1.4; Date: 2005/11/08 08:56:22; Author: fcusack; Lines: (+11 -7) File: radiusd/src/modules/rlm_otp/otp_state.c; Revision: 1.22; Date: 2005/11/08 08:56:22; Author: fcusack; Lines: (+18 -6) File: radiusd/src/modules/rlm_otp/otp_util.c; Revision: 1.11; Date: 2005/11/08 08:56:22; Author: fcusack; Lines: (+21 -18) File: radiusd/src/modules/rlm_otp/cardops/cryptocard.c; Revision: 1.38; Date: 2005/11/08 08:56:23; Author: fcusack; Lines: (+27 -31) File: radiusd/src/modules/rlm_otp/cardops/cryptocard.h; Revision: 1.37; Date: 2005/11/08 08:56:23; Author: fcusack; Lines: (+16 -14) ===================================================== Log entries ===================================================== Description: On deleting the request list, kill any live threads that are processing the request, and mark the request has having no child pid. We should fix up the thread pool, too, to catch the case of "disappeared" child threads Modified files: File: radiusd/src/main/request_list.c; Revision: 1.69; Date: 2005/11/07 19:46:30; Author: aland; Lines: (+13 -2) ------------------------------- Description: add sratch3 back to user_state, to hold csd offset Modified files: File: radiusd/src/modules/rlm_otp/otp.h; Revision: 1.24; Date: 2005/11/08 04:02:20; Author: fcusack; Lines: (+2 -1) ===================================================== Summary of modified files ===================================================== File: radiusd/src/main/request_list.c Revisions: 1.69 Authors: aland (+13 -2) ------------------------------- File: radiusd/src/modules/rlm_otp/cardops/cryptocard.c Revisions: 1.38, 1.37 Authors: fcusack (+27 -31), fcusack (+12 -12) ------------------------------- File: radiusd/src/modules/rlm_otp/cardops/cryptocard.h Revisions: 1.37, 1.36 Authors: fcusack (+16 -14), fcusack (+7 -7) ------------------------------- File: radiusd/src/modules/rlm_otp/otp.h Revisions: 1.25, 1.24, 1.23 Authors: fcusack (+10 -7), fcusack (+2 -1), fcusack (+4 -4) ------------------------------- File: radiusd/src/modules/rlm_otp/otp_cardops.c Revisions: 1.59, 1.58 Authors: fcusack (+47 -27), fcusack (+30 -30) ------------------------------- File: radiusd/src/modules/rlm_otp/otp_cardops.h Revisions: 1.41, 1.40 Authors: fcusack (+25 -18), fcusack (+7 -7) ------------------------------- File: radiusd/src/modules/rlm_otp/otp_rad.h Revisions: 1.4 Authors: fcusack (+3 -3) ------------------------------- File: radiusd/src/modules/rlm_otp/otp_radstate.c Revisions: 1.4 Authors: fcusack (+22 -36) ------------------------------- File: radiusd/src/modules/rlm_otp/otp_rlm.c Revisions: 1.15 Authors: fcusack (+10 -11) ------------------------------- File: radiusd/src/modules/rlm_otp/otp_site.c Revisions: 1.4 Authors: fcusack (+11 -7) ------------------------------- File: radiusd/src/modules/rlm_otp/otp_state.c Revisions: 1.22 Authors: fcusack (+18 -6) ------------------------------- File: radiusd/src/modules/rlm_otp/otp_util.c Revisions: 1.11, 1.10 Authors: fcusack (+21 -18), fcusack (+26 -26) ------------------------------- File: radiusd/src/modules/rlm_otp/otp_x99.c Revisions: 1.6 Authors: fcusack (+3 -3) -- Automatic cron job from /web/pages/us.freeradius.org/bin/new_makelog.pl

3 2

!= and !~ operators
by Joe Maimon 08 Nov '05

08 Nov '05

Wouldnt it make more sense if these operators matched if no attributes were present that matched or that no attributes were present at all? After all, == and =~ DONT match if there is no attribute present. If one wanted to check that the attribute was present but did not contain value X, they would use Attribute =* "", Attribute != "X" Fixing the other problems mentioned below while keeping the questioned behavior would seem to require keeping track that the auth_item was ever not null in some other variable before the "goto try_again;" The attached patch for src/main/valuepair.c changes the behavior of paircompare() in these ways * if !* matched, no further check attributes were tried * if !* or != or !~ operators and the attribute is not found, consider that a successfull match and try the next check attribute * if =* and we find the attribute in the request there is no need to actually compare the value * It should be considered an error condition to have matching case statements for !* or =* after the call to compare_pair(), since they should have been handled already. * != and !~ are considered successfull as soon as there is an attribute in the request that does not match. If there was an attribute that matched, and then another one that didnt (or vice versa), it would succeed. The patch changes that If check != request try next one If check == request return -1 for not match I have tested it to an extent and would appreciate feedback. Thanks, Joe --- ../../cvs/cvs-20051029/radiusd/src/main/valuepair.c 2005-10-18 19:52:49.000000000 -0400 +++ src/main/valuepair.c 2005-11-05 19:32:46.000000000 -0500 @@ -298,8 +298,13 @@ * Didn't find it. If we were *trying* * to not find it, then we succeeded. */ - if (check_item->operator == T_OP_CMP_FALSE) - return 0; + if (check_item->operator == T_OP_CMP_FALSE || +#ifdef HAVE_REGEX_H + check_item->operator == T_OP_REG_NE || +#endif + check_item->operator == T_OP_NE + ) + continue; else return -1; } @@ -310,7 +315,10 @@ */ if (check_item->operator == T_OP_CMP_FALSE) return -1; - + + /* no comparison needed if it exists */ + if (check_item->operator == T_OP_CMP_TRUE) + continue; /* * We've got to xlat the string before doing @@ -342,14 +350,14 @@ radlog(L_INFO, "Invalid operator for item %s: " "reverting to '=='", check_item->name); /*FALLTHRU*/ - case T_OP_CMP_TRUE: /* compare always == 0 */ - case T_OP_CMP_FALSE: /* compare always == 1 */ case T_OP_CMP_EQ: if (compare != 0) result = -1; break; case T_OP_NE: - if (compare == 0) result = -1; + /* != only succeeds if NO reply values match*/ + if (compare == 0) return -1; + result = -1; /*check the rest for no match */ break; case T_OP_LT: @@ -457,7 +465,9 @@ compare = regexec(&reg, (char *)auth_item->vp_strvalue, 0, NULL, 0); regfree(&reg); - if (compare == 0) result = -1; + /* !~ only succeeds if NO matches are found in reply pair */ + if (compare == 0) return -1; + result = -1; /*check the rest for no match */ break; #endif @@ -487,7 +497,128 @@ return compare_pair( req, first, second, NULL, NULL ); } +/* + * Compare ONE attribute from a (potential) list. + * Return the first matching one. + */ + +static VALUE_PAIR * paircmpmatchone(REQUEST *req, VALUE_PAIR *first, VALUE_PAIR *second) +{ + VALUE_PAIR *fnext = NULL; + VALUE_PAIR *snext = NULL; + int result = 0; + + for(; second; second = second->next){ + for(; first; first = first->next){ + if(first->attribute == second->attribute){ + /* No matter what, compare only THESE items in chain */ + fnext = first->next; + first->next = NULL; + snext = second->next; + second->next = NULL; + result = simplepaircmp(req, first, second); + first->next = fnext; + second->next = snext; + + if(!result) + return first; + } + } + } + return NULL; +} + +#ifdef HAVE_REGEX_H +/* + * Regex Compare ONE attribute from a (potential) list. + * Return the first matching one. + */ + +static VALUE_PAIR * pairregmatchone(REQUEST *req, VALUE_PAIR *first, VALUE_PAIR *second) +{ + int result = 0; + regex_t reg; + + for(; second; second = second->next){ + for(; first; first = first->next){ + if(first->attribute == second->attribute) { + if (second->operator == T_OP_REG_EQ || + second->operator == T_OP_REG_NE || + second->operator == T_OP_SUB_REG) + { + regcomp(&reg, (char *)second->vp_strvalue, + REG_EXTENDED); + result = regexec(&reg, (char *)first->vp_strvalue, + 0, NULL, 0); + regfree(&reg); + + if(!result) + return first; + } + if (first->operator == T_OP_REG_EQ || + first->operator == T_OP_REG_NE || + first->operator == T_OP_SUB_REG) + { + + regcomp(&reg, (char *)first->vp_strvalue, + REG_EXTENDED); + result = regexec(&reg, (char *)second->vp_strvalue, + 0, NULL, 0); + regfree(&reg); + + if(!result) + return second; + } + } + } + } + return NULL; +} +#endif + +/* + * Deletes matching attributes. + */ +static void pairdeletematch(REQUEST *req,VALUE_PAIR **first,VALUE_PAIR *second) +{ + VALUE_PAIR *vp, *i; + + while((vp = paircmpmatchone(req,*first,second))){ + if(*first == vp) /* new head of chain */ + *first = vp->next; + else + for(i = *first; i; i = i->next){ + if(i->next == vp){ /* dis-own */ + i->next = vp->next; + break; + } + } + pairbasicfree(vp); + } +} + +#ifdef HAVE_REGEX_H +/* + * deletes matching regex pairs +*/ +static void pairdeleteregmatch(REQUEST *req,VALUE_PAIR **first,VALUE_PAIR *second) +{ + VALUE_PAIR *vp, *i; + while((vp = pairregmatchone(req,*first,second))){ + if(*first == vp) /* new head of chain */ + *first = vp->next; + else + for(i = *first; i; i = i->next){ + if(i->next == vp){ /* dis-own */ + i->next = vp->next; + break; + } + } + pairbasicfree(vp); + } +} +#endif /* * Move pairs, replacing/over-writing them, and doing xlat. */ @@ -505,6 +636,7 @@ * Point "tailto" to the end of the "to" list. */ tailto = to; + for(i = *to; i; i = i->next) { tailto = &i->next; } @@ -545,30 +677,57 @@ switch (i->operator) { /* - * If a similar attribute is found, - * delete it. + * If a similar attribute are found, + * delete them. */ case T_OP_SUB: /* -= */ if (found) { - if (!i->vp_strvalue[0] || - (strcmp((char *)found->vp_strvalue, - (char *)i->vp_strvalue) == 0)){ - pairdelete(to, found->attribute); - - /* - * 'tailto' may have been - * deleted... - */ + if (!i->vp_strvalue[0]) + goto delete_all; + + pairdeletematch(req,to,i); + /* + * 'tailto' may have been + * deleted... + */ + tailto = to; + for(j = *to; j; j = j->next) { + tailto = &j->next; + } + + } + tailfrom = i; + continue; + break; + case T_OP_SUB_ALL: /* -* */ + if (found) { +delete_all: + pairdelete(to, found->attribute); tailto = to; for(j = *to; j; j = j->next) { tailto = &j->next; } - } } tailfrom = i; continue; break; +#ifdef HAVE_REGEX_H + case T_OP_SUB_REG: /* -~ */ + if (found) { + + pairdeleteregmatch(req,to,i); + + tailto = to; + for(j = *to; j; j = j->next) { + tailto = &j->next; + } + + tailfrom = i; + continue; + break; + } +#endif /* * Add it, if it's not already there. */

2 5

Automatic report from sources (radiusd) between 06.11.2005 - 07.11.2005 GMT
by Automatic cvs log generator 07 Nov '05

07 Nov '05

CVS log entries from 06.11.2005 (Sun) 09:00:01 - 07.11.2005 (Mon) 09:00:00 GMT ===================================================== Summary by authors ===================================================== Author: fcusack File: radiusd/src/modules/rlm_otp/cardops/cryptocard.h; Revisions: 1.35 File: radiusd/src/modules/rlm_otp/otp_cardops.h; Revisions: 1.39 File: radiusd/src/modules/rlm_otp/cardops/cryptocard.c; Revisions: 1.36 File: radiusd/src/modules/rlm_otp/otp_cardops.c; Revisions: 1.57 File: radiusd/src/modules/rlm_otp/otp.h; Revisions: 1.22, 1.21 ===================================================== Combined list of identical log entries ===================================================== Description: - otp.h: add scratch data fields to otp_user_state_t, for tmp use by cardops methods - change 'user_state' arg to cardops challenge() method to non-const, so that state can be updated with scratch data for later methods - remove [unused] 'challenge' arg to cardops updatecsd() method, and reorder 'when' arg to be consistent with challenge() method - remove 'twin' arg to cardops isconsecutive() method; time data now stored as scratch data (twin data is meaningless, it must be converted to a time counter which is already done in challenge(), so don't do it again) Modified files: File: radiusd/src/modules/rlm_otp/otp.h; Revision: 1.21; Date: 2005/11/07 03:46:07; Author: fcusack; Lines: (+5 -1) File: radiusd/src/modules/rlm_otp/otp_cardops.c; Revision: 1.57; Date: 2005/11/07 03:46:07; Author: fcusack; Lines: (+5 -5) File: radiusd/src/modules/rlm_otp/otp_cardops.h; Revision: 1.39; Date: 2005/11/07 03:46:07; Author: fcusack; Lines: (+4 -5) File: radiusd/src/modules/rlm_otp/cardops/cryptocard.c; Revision: 1.36; Date: 2005/11/07 03:46:07; Author: fcusack; Lines: (+10 -15) File: radiusd/src/modules/rlm_otp/cardops/cryptocard.h; Revision: 1.35; Date: 2005/11/07 03:46:07; Author: fcusack; Lines: (+4 -6) ===================================================== Log entries ===================================================== Description: remove extra scratch field from user_state Modified files: File: radiusd/src/modules/rlm_otp/otp.h; Revision: 1.22; Date: 2005/11/07 06:19:05; Author: fcusack; Lines: (+1 -2) ===================================================== Summary of modified files ===================================================== File: radiusd/src/modules/rlm_otp/cardops/cryptocard.c Revisions: 1.36 Authors: fcusack (+10 -15) ------------------------------- File: radiusd/src/modules/rlm_otp/cardops/cryptocard.h Revisions: 1.35 Authors: fcusack (+4 -6) ------------------------------- File: radiusd/src/modules/rlm_otp/otp.h Revisions: 1.22, 1.21 Authors: fcusack (+1 -2), fcusack (+5 -1) ------------------------------- File: radiusd/src/modules/rlm_otp/otp_cardops.c Revisions: 1.57 Authors: fcusack (+5 -5) ------------------------------- File: radiusd/src/modules/rlm_otp/otp_cardops.h Revisions: 1.39 Authors: fcusack (+4 -5) -- Automatic cron job from /web/pages/us.freeradius.org/bin/new_makelog.pl

1 0

Automatic report from sources (radiusd) between 04.11.2005 - 05.11.2005 GMT
by Automatic cvs log generator 05 Nov '05

05 Nov '05

CVS log entries from 04.11.2005 (Fri) 09:00:00 - 05.11.2005 (Sat) 09:00:01 GMT ===================================================== Summary by authors ===================================================== Author: aland File: radiusd/src/modules/rlm_caching/rlm_caching.c; Revisions: 1.6 File: radiusd/src/main/xlat.c; Revisions: 1.104 File: radiusd/src/main/log.c; Revisions: 1.48 File: radiusd/src/modules/rlm_exec/exec.c; Revisions: 1.4 File: radiusd/src/main/listen.c; Revisions: 1.42 Author: cparker File: radiusd/configure.in; Revisions: 1.223 Author: fcusack File: radiusd/src/modules/rlm_otp/cardops/cryptocard.h; Revisions: 1.34, 1.33, 1.32, 1.31 File: radiusd/src/modules/rlm_otp/otp_cardops.h; Revisions: 1.38, 1.37, 1.36, 1.35 File: radiusd/src/modules/rlm_otp/cardops/cryptocard.c; Revisions: 1.35, 1.34, 1.33, 1.32 File: radiusd/src/modules/rlm_otp/otp_cardops.c; Revisions: 1.56, 1.55, 1.54, 1.53 ===================================================== Combined list of identical log entries ===================================================== Description: remove csd arg to cardops response() method Modified files: File: radiusd/src/modules/rlm_otp/otp_cardops.c; Revision: 1.56; Date: 2005/11/05 08:43:37; Author: fcusack; Lines: (+4 -4) File: radiusd/src/modules/rlm_otp/otp_cardops.h; Revision: 1.38; Date: 2005/11/05 08:43:37; Author: fcusack; Lines: (+2 -3) File: radiusd/src/modules/rlm_otp/cardops/cryptocard.c; Revision: 1.35; Date: 2005/11/05 08:43:37; Author: fcusack; Lines: (+1 -5) File: radiusd/src/modules/rlm_otp/cardops/cryptocard.h; Revision: 1.34; Date: 2005/11/05 08:43:37; Author: fcusack; Lines: (+1 -2) ------------------------------- Description: Description: update cardops challenge() method: change order of 'challenge' and 'when' args, change 'twin' and 'ewin' args to type int Modified files: File: radiusd/src/modules/rlm_otp/otp_cardops.c; Revision: 1.53; Date: 2005/11/05 00:52:40; Author: fcusack; Lines: (+4 -4) File: radiusd/src/modules/rlm_otp/otp_cardops.h; Revision: 1.35; Date: 2005/11/05 00:52:40; Author: fcusack; Lines: (+3 -3) File: radiusd/src/modules/rlm_otp/cardops/cryptocard.c; Revision: 1.32; Date: 2005/11/05 00:52:40; Author: fcusack; Lines: (+4 -4) File: radiusd/src/modules/rlm_otp/cardops/cryptocard.h; Revision: 1.31; Date: 2005/11/05 00:52:40; Author: fcusack; Lines: (+4 -4) ------------------------------- Description: remove 'now' arg from cardops maxtwin() method Modified files: File: radiusd/src/modules/rlm_otp/otp_cardops.c; Revision: 1.54; Date: 2005/11/05 01:07:13; Author: fcusack; Lines: (+3 -3) File: radiusd/src/modules/rlm_otp/otp_cardops.h; Revision: 1.36; Date: 2005/11/05 01:07:13; Author: fcusack; Lines: (+2 -3) File: radiusd/src/modules/rlm_otp/cardops/cryptocard.c; Revision: 1.33; Date: 2005/11/05 01:07:13; Author: fcusack; Lines: (+2 -6) File: radiusd/src/modules/rlm_otp/cardops/cryptocard.h; Revision: 1.32; Date: 2005/11/05 01:07:13; Author: fcusack; Lines: (+2 -2) ------------------------------- Description: remove cardops isearly() method, instead the challenge() method now returns multiple error codes, eliminating some duplicate code and saving a function call Modified files: File: radiusd/src/modules/rlm_otp/otp_cardops.c; Revision: 1.55; Date: 2005/11/05 02:11:03; Author: fcusack; Lines: (+17 -18) File: radiusd/src/modules/rlm_otp/otp_cardops.h; Revision: 1.37; Date: 2005/11/05 02:11:03; Author: fcusack; Lines: (+2 -4) File: radiusd/src/modules/rlm_otp/cardops/cryptocard.c; Revision: 1.34; Date: 2005/11/05 02:11:03; Author: fcusack; Lines: (+4 -24) File: radiusd/src/modules/rlm_otp/cardops/cryptocard.h; Revision: 1.33; Date: 2005/11/05 02:11:03; Author: fcusack; Lines: (+2 -5) ===================================================== Log entries ===================================================== Description: Updated check program for 'sockaddr_storage' to include <sys/socket.h> and detect it's existance on Solaris 8 systems ( and presumably other Solaris variants ). Modified files: File: radiusd/configure.in; Revision: 1.223; Date: 2005/11/04 18:42:40; Author: cparker; Lines: (+4 -1) ------------------------------- Description: On HUP, move proxy sockets, too Modified files: File: radiusd/src/main/listen.c; Revision: 1.42; Date: 2005/11/04 19:01:14; Author: aland; Lines: (+29 -1) ------------------------------- Description: Allow tabs Modified files: File: radiusd/src/main/log.c; Revision: 1.48; Date: 2005/11/04 19:28:52; Author: aland; Lines: (+3 -2) ------------------------------- Description: Catch NULL ptr Modified files: File: radiusd/src/main/xlat.c; Revision: 1.104; Date: 2005/11/04 19:21:23; Author: aland; Lines: (+4 -2) ------------------------------- Description: Spelling. Modified files: File: radiusd/src/modules/rlm_caching/rlm_caching.c; Revision: 1.6; Date: 2005/11/04 19:29:54; Author: aland; Lines: (+3 -3) ------------------------------- Description: Use closefrom Modified files: File: radiusd/src/modules/rlm_exec/exec.c; Revision: 1.4; Date: 2005/11/04 19:30:40; Author: aland; Lines: (+4 -13) ===================================================== Summary of modified files ===================================================== File: radiusd/configure.in Revisions: 1.223 Authors: cparker (+4 -1) ------------------------------- File: radiusd/src/main/listen.c Revisions: 1.42 Authors: aland (+29 -1) ------------------------------- File: radiusd/src/main/log.c Revisions: 1.48 Authors: aland (+3 -2) ------------------------------- File: radiusd/src/main/xlat.c Revisions: 1.104 Authors: aland (+4 -2) ------------------------------- File: radiusd/src/modules/rlm_caching/rlm_caching.c Revisions: 1.6 Authors: aland (+3 -3) ------------------------------- File: radiusd/src/modules/rlm_exec/exec.c Revisions: 1.4 Authors: aland (+4 -13) ------------------------------- File: radiusd/src/modules/rlm_otp/cardops/cryptocard.c Revisions: 1.35, 1.34, 1.33, 1.32 Authors: fcusack (+1 -5), fcusack (+4 -24), fcusack (+2 -6), fcusack (+4 -4) ------------------------------- File: radiusd/src/modules/rlm_otp/cardops/cryptocard.h Revisions: 1.34, 1.33, 1.32, 1.31 Authors: fcusack (+1 -2), fcusack (+2 -5), fcusack (+2 -2), fcusack (+4 -4) ------------------------------- File: radiusd/src/modules/rlm_otp/otp_cardops.c Revisions: 1.56, 1.55, 1.54, 1.53 Authors: fcusack (+4 -4), fcusack (+17 -18), fcusack (+3 -3), fcusack (+4 -4) ------------------------------- File: radiusd/src/modules/rlm_otp/otp_cardops.h Revisions: 1.38, 1.37, 1.36, 1.35 Authors: fcusack (+2 -3), fcusack (+2 -4), fcusack (+2 -3), fcusack (+3 -3) -- Automatic cron job from /web/pages/us.freeradius.org/bin/new_makelog.pl

1 0

Solaris sockaddr_storage check fails + patch
by Chris Parker 04 Nov '05

04 Nov '05

It appears that sockaddr_storage check is failing. From ./configure : ... checking for struct in6_addr... yes checking for struct sockaddr_storage... no checking for struct sockaddr_in6... yes checking for struct addrinfo... yes ... So it gets included in 'missing.h'. Subsequent make now chokes with: gcc -g -O2 -D_REENTRANT -D_POSIX_PTHREAD_SEMANTICS -DOPENSSL_NO_KRB5 - D_LIBRADIUS -I../include -DHMAC_SHA1_DATA_PROBLEMS -c dict.c -fPIC - DPIC -o .libs/dict.o In file included from ../include/libradius.h:37, from dict.c:42: /usr/include/sys/socket.h:239: redefinition of `struct sockaddr_storage' gmake[4]: *** [dict.lo] Error 1 gmake[4]: Leaving directory `/work/working-code/radiusd/src/lib' gmake[3]: *** [common] Error 2 gmake[3]: Leaving directory `/work/working-code/radiusd/src' gmake[2]: *** [all] Error 2 gmake[2]: Leaving directory `/work/working-code/radiusd/src' gmake[1]: *** [common] Error 2 gmake[1]: Leaving directory `/work/working-code/radiusd' *** Error code 2 make: Fatal error: Command failed for target `all' config.log shows: .... configure:23179: checking for struct sockaddr_storage configure:23208: gcc -c -g -O2 -D_REENTRANT - D_POSIX_PTHREAD_SEMANTICS -DOPENSSL_NO_KRB5 conftest.c >&5 conftest.c: In function `main': conftest.c:69: sizeof applied to an incomplete type configure:23214: $? = 1 configure: failed program was: | /* confdefs.h. */ | | #define PACKAGE_NAME "" | #define PACKAGE_TARNAME "" | #define PACKAGE_VERSION "" | #define PACKAGE_STRING "" | #define PACKAGE_BUGREPORT "" | #ifdef __cplusplus | extern "C" void std::exit (int) throw (); using std::exit; | #endif | #define _FILE_OFFSET_BITS 64 | #define WORDS_BIGENDIAN 1 | #define STDC_HEADERS 1 | #define HAVE_SYS_TYPES_H 1 | #define HAVE_SYS_STAT_H 1 | #define HAVE_STDLIB_H 1 | #define HAVE_STRING_H 1 | #define HAVE_MEMORY_H 1 | #define HAVE_STRINGS_H 1 | #define HAVE_INTTYPES_H 1 | #define HAVE_UNISTD_H 1 | #define HAVE_DLFCN_H 1 | #define ASCEND_BINARY | #define HAVE_PTHREAD_H 1 | #define HAVE_LIBSOCKET 1 | #define HAVE_LIBRESOLV 1 | #define HAVE_LIBNSL 1 | #define HAVE_DIRENT_H 1 | #define STDC_HEADERS 1 | #define TIME_WITH_SYS_TIME 1 | #define HAVE_SYS_WAIT_H 1 | #define HAVE_UNISTD_H 1 | #define HAVE_CRYPT_H 1 | #define HAVE_ERRNO_H 1 | #define HAVE_MALLOC_H 1 | #define HAVE_UTMP_H 1 | #define HAVE_UTMPX_H 1 | #define HAVE_SIGNAL_H 1 | #define HAVE_SYS_SELECT_H 1 | #define HAVE_SYSLOG_H 1 | #define HAVE_INTTYPES_H 1 | #define HAVE_STDIO_H 1 | #define HAVE_NETDB_H 1 | #define HAVE_SEMAPHORE_H 1 | #define HAVE_ARPA_INET_H 1 | #define HAVE_NETINET_IN_H 1 | #define HAVE_SYS_TYPES_H 1 | #define HAVE_SYS_SOCKET_H 1 | #define HAVE_SYS_TIME_H 1 | #define HAVE_SYS_WAIT_H 1 | #define HAVE_FCNTL_H 1 | #define HAVE_SYS_FCNTL_H 1 | #define HAVE_NET_IF_H 1 | #define HAVE_REGEX_H | #define HAVE_REG_EXTENDED | #define HAVE_STRUCT_IN6_ADDR 1 | /* end confdefs.h. */ | | #ifdef HAVE_NETINET_IN_H | #include <netinet/in.h> | #endif | | | int | main () | { | if ((struct sockaddr_storage *) 0) | return 0; | if (sizeof (struct sockaddr_storage)) | return 0; | ; | return 0; | } configure:23237: result: no ..... Adding an '#include <sys/socket.h>' to the conftest file passes the test. Possible patch: Index: configure.in =================================================================== RCS file: /source/radiusd/configure.in,v retrieving revision 1.222 diff -p -r1.222 configure.in *** configure.in 1 Nov 2005 19:04:49 -0000 1.222 --- configure.in 4 Nov 2005 17:01:57 -0000 *************** AC_CHECK_TYPE(struct sockaddr_storage, A *** 662,667 **** --- 662,670 ---- #ifdef HAVE_NETINET_IN_H #include <netinet/in.h> #endif + #ifdef HAVE_SYS_SOCKET_H + #include <sys/socket.h> + #endif ]) AC_CHECK_TYPE(struct sockaddr_in6, AC_DEFINE (HAVE_STRUCT_SOCKADDR_IN6, 1, [IPv6 socket addresses]), [], [ -Chris -- Chris Parker Director, Engineering StarNet A Service of US LEC (888)212-0099 Fax (847)963-1302 Wholesale Internet Services http://www.megapop.net VoiceEclipse, The Fresh Alternative http://www.voiceeclipse.com NOTICE: Message is sent IN CONFIDENCE to addressees. It may contain information that is privileged, proprietary or confidential.

2 3

Possible Bug in valuepair / rlm_file etc etc.
by Alister Winfield 04 Nov '05

04 Nov '05

I have found a potential bug in the way rlm_file or valuepair does the xlat of %{var} items. These are supposedly dynamic, being based on a per-packet replacement. The following example can be done a different way but its the simplest example I can think of ;-) Take the following from a users file (X-MyCLI filled in from some db in an earlier module). DEFAULT X-MyCLI != "%{Calling-Station-Id}", Auth-Type:="Reject" The db of valid CLI's might contain. user cli --------------- one 12345 two 54321 If you do two queries that should auth one thats sending: username=one, callingid=12345; the other username=two, callingid=54321. Only the first works the second failing because the in memory config for the check will have changed to read X-MyCLI != 12345 ...!!! Looking at the code this appears to be due to paircmp expanding the %{} on the structure passed to it (a potentially bad idea for so many reasons). The best solution, I suspect, is to copy the data sent to paircmp and work on the copy and not the original. The copy can be done on a per-pair way and if deemed expensive only for things that need xlat. .............................................. In sudo code: for (check; check->next ; ..... memcpy(&blah, check, sizeof(check)); Do the comparison using blah instead of check. memcpy(check, &blah, sizeof(check)); ............................................... I don't have a detailed patch yet as I have only done half the work required to avoid trashing the config but thus far it does fix my case. PS: Although I have only looked at 1.0.2 this appears to hold true of the CVS head as well. Am I missing something here and if not I'll be back soon with a complete patch (Currently I just save the old check_item and put it back which is fine in a single thread but not so clever in a threaded system). -- Alister Winfield

3 6

Automatic report from sources (radiusd) between 03.11.2005 - 04.11.2005 GMT
by Automatic cvs log generator 04 Nov '05

04 Nov '05

CVS log entries from 03.11.2005 (Thu) 09:00:01 - 04.11.2005 (Fri) 09:00:00 GMT ===================================================== Summary by authors ===================================================== Author: aland File: radiusd/src/main/listen.c; Revisions: 1.41, 1.40 Author: fcusack File: radiusd/src/modules/rlm_otp/cardops/cryptocard.h; Revisions: 1.30, 1.29 File: radiusd/src/modules/rlm_otp/otp_state.c; Revisions: 1.21, 1.20, 1.19 File: radiusd/src/modules/rlm_otp/otp_cardops.h; Revisions: 1.34, 1.33 File: radiusd/src/modules/rlm_otp/cardops/cryptocard.c; Revisions: 1.31, 1.30 File: radiusd/src/modules/rlm_otp/otp_cardops.c; Revisions: 1.52, 1.51 File: radiusd/src/modules/rlm_otp/otp.h; Revisions: 1.20, 1.19, 1.18 ===================================================== Combined list of identical log entries ===================================================== Description: change state fields failcount and minewin from int to uint32, for portability (really this time) Modified files: File: radiusd/src/modules/rlm_otp/otp.h; Revision: 1.19; Date: 2005/11/04 05:00:35; Author: fcusack; Lines: (+3 -3) File: radiusd/src/modules/rlm_otp/otp_state.c; Revision: 1.20; Date: 2005/11/04 05:00:35; Author: fcusack; Lines: (+14 -11) ------------------------------- Description: - change state field minauthtime to mincardtime - change state fields failcount and minewin from int to uint32 Modified files: File: radiusd/src/modules/rlm_otp/otp.h; Revision: 1.18; Date: 2005/11/04 04:54:52; Author: fcusack; Lines: (+2 -2) File: radiusd/src/modules/rlm_otp/otp_cardops.c; Revision: 1.51; Date: 2005/11/04 04:54:53; Author: fcusack; Lines: (+9 -9) File: radiusd/src/modules/rlm_otp/otp_cardops.h; Revision: 1.33; Date: 2005/11/04 04:54:53; Author: fcusack; Lines: (+2 -2) File: radiusd/src/modules/rlm_otp/otp_state.c; Revision: 1.19; Date: 2005/11/04 04:54:53; Author: fcusack; Lines: (+8 -8) File: radiusd/src/modules/rlm_otp/cardops/cryptocard.c; Revision: 1.30; Date: 2005/11/04 04:54:53; Author: fcusack; Lines: (+3 -3) File: radiusd/src/modules/rlm_otp/cardops/cryptocard.h; Revision: 1.29; Date: 2005/11/04 04:54:53; Author: fcusack; Lines: (+2 -2) ------------------------------- Description: - Remove duplicate work in cardops twin2cardtime() method by removing the method altogether. Now we call challenge() before isearly(), and pass the challenge in, instead of cardtime. - mincardtime is now saved in the updatecsd() method instead of in otp_cardops.c - remove minewin state field (still version 5) Modified files: File: radiusd/src/modules/rlm_otp/otp.h; Revision: 1.20; Date: 2005/11/04 07:28:58; Author: fcusack; Lines: (+1 -2) File: radiusd/src/modules/rlm_otp/otp_cardops.c; Revision: 1.52; Date: 2005/11/04 07:28:58; Author: fcusack; Lines: (+15 -28) File: radiusd/src/modules/rlm_otp/otp_cardops.h; Revision: 1.34; Date: 2005/11/04 07:28:58; Author: fcusack; Lines: (+3 -4) File: radiusd/src/modules/rlm_otp/otp_state.c; Revision: 1.21; Date: 2005/11/04 07:28:58; Author: fcusack; Lines: (+4 -20) File: radiusd/src/modules/rlm_otp/cardops/cryptocard.c; Revision: 1.31; Date: 2005/11/04 07:28:58; Author: fcusack; Lines: (+3 -25) File: radiusd/src/modules/rlm_otp/cardops/cryptocard.h; Revision: 1.30; Date: 2005/11/04 07:28:58; Author: fcusack; Lines: (+4 -4) ===================================================== Log entries ===================================================== Description: More cleanups & leak fixes Modified files: File: radiusd/src/main/listen.c; Revision: 1.41; Date: 2005/11/04 00:40:48; Author: aland; Lines: (+31 -22) ------------------------------- Description: Abstract code some more. Actually free stuff on errors Modified files: File: radiusd/src/main/listen.c; Revision: 1.40; Date: 2005/11/03 23:51:50; Author: aland; Lines: (+55 -61) ===================================================== Summary of modified files ===================================================== File: radiusd/src/main/listen.c Revisions: 1.41, 1.40 Authors: aland (+31 -22), aland (+55 -61) ------------------------------- File: radiusd/src/modules/rlm_otp/cardops/cryptocard.c Revisions: 1.31, 1.30 Authors: fcusack (+3 -25), fcusack (+3 -3) ------------------------------- File: radiusd/src/modules/rlm_otp/cardops/cryptocard.h Revisions: 1.30, 1.29 Authors: fcusack (+4 -4), fcusack (+2 -2) ------------------------------- File: radiusd/src/modules/rlm_otp/otp.h Revisions: 1.20, 1.19, 1.18 Authors: fcusack (+1 -2), fcusack (+3 -3), fcusack (+2 -2) ------------------------------- File: radiusd/src/modules/rlm_otp/otp_cardops.c Revisions: 1.52, 1.51 Authors: fcusack (+15 -28), fcusack (+9 -9) ------------------------------- File: radiusd/src/modules/rlm_otp/otp_cardops.h Revisions: 1.34, 1.33 Authors: fcusack (+3 -4), fcusack (+2 -2) ------------------------------- File: radiusd/src/modules/rlm_otp/otp_state.c Revisions: 1.21, 1.20, 1.19 Authors: fcusack (+4 -20), fcusack (+14 -11), fcusack (+8 -8) -- Automatic cron job from /web/pages/us.freeradius.org/bin/new_makelog.pl

1 0

radius segv some time after HUP?
by Joe Maimon 03 Nov '05

03 Nov '05

Running under valgrind Line 484 in request_proccess.c reads rcode = proxy_send(request); I havent really started debugging this yet, but thought I would give valgrind a try after all the recent suggestions. If this is usefull or I can make it more so, Id be glad to. ==23224== Memcheck, a memory error detector for x86-linux. ==23224== Copyright (C) 2002-2005, and GNU GPL'd, by Julian Seward et al. ==23224== Using valgrind-2.4.0, a program supervision framework for x86-linux. ==23224== Copyright (C) 2000-2005, and GNU GPL'd, by Julian Seward et al. ==23224== ==23224== My PID = 23224, parent PID = 3602. Prog and args are: ==23224== ./src/main/.libs/radiusd ==23224== -fxx ==23224== For more details, rerun with: -v ==23224== ==23224== Conditional jump or move depends on uninitialised value(s) ==23224== at 0x1B8ECB13: (within /lib/ld-2.3.5.so) ==23224== by 0x1B8E631C: (within /lib/ld-2.3.5.so) ==23224== by 0x1B8F2BDD: (within /lib/ld-2.3.5.so) ==23224== by 0x1B8E7675: (within /lib/ld-2.3.5.so) ==23224== by 0x1B8E47C6: (within /lib/ld-2.3.5.so) ==23224== ==23224== Conditional jump or move depends on uninitialised value(s) ==23224== at 0x1B8EC7D3: (within /lib/ld-2.3.5.so) ==23224== by 0x1B8E631C: (within /lib/ld-2.3.5.so) ==23224== by 0x1B8F2BDD: (within /lib/ld-2.3.5.so) ==23224== by 0x1B8E7675: (within /lib/ld-2.3.5.so) ==23224== by 0x1B8E47C6: (within /lib/ld-2.3.5.so) ==23224== ==23224== Conditional jump or move depends on uninitialised value(s) ==23224== at 0x1B8EC6B6: (within /lib/ld-2.3.5.so) ==23224== by 0x1B8E6376: (within /lib/ld-2.3.5.so) ==23224== by 0x1B8F2BDD: (within /lib/ld-2.3.5.so) ==23224== by 0x1B8E7675: (within /lib/ld-2.3.5.so) ==23224== by 0x1B8E47C6: (within /lib/ld-2.3.5.so) ==23224== ==23224== Conditional jump or move depends on uninitialised value(s) ==23224== at 0x1B8EC6C2: (within /lib/ld-2.3.5.so) ==23224== by 0x1B8E6376: (within /lib/ld-2.3.5.so) ==23224== by 0x1B8F2BDD: (within /lib/ld-2.3.5.so) ==23224== by 0x1B8E7675: (within /lib/ld-2.3.5.so) ==23224== by 0x1B8E47C6: (within /lib/ld-2.3.5.so) ==23224== ==23224== Conditional jump or move depends on uninitialised value(s) ==23224== at 0x1B8EC7D3: (within /lib/ld-2.3.5.so) ==23224== by 0x1B8E6376: (within /lib/ld-2.3.5.so) ==23224== by 0x1B8F2BDD: (within /lib/ld-2.3.5.so) ==23224== by 0x1B8E7675: (within /lib/ld-2.3.5.so) ==23224== by 0x1B8E47C6: (within /lib/ld-2.3.5.so) ==23224== ==23224== Conditional jump or move depends on uninitialised value(s) ==23224== at 0x1B8ECB13: (within /lib/ld-2.3.5.so) ==23224== by 0x1BCC24BA: (within /lib/tls/libc-2.3.5.so) ==23224== by 0x1B8EF026: (within /lib/ld-2.3.5.so) ==23224== by 0x1BCC2B85: _dl_open (in /lib/tls/libc-2.3.5.so) ==23224== by 0x1BCC407C: (within /lib/tls/libc-2.3.5.so) ==23224== by 0x1B8EF026: (within /lib/ld-2.3.5.so) ==23224== by 0x1BCC41DD: __libc_dlopen_mode (in /lib/tls/libc-2.3.5.so) ==23224== by 0x1BC9EE68: __nss_lookup_function (in /lib/tls/libc-2.3.5.so) ==23224== by 0x1BC9F00E: (within /lib/tls/libc-2.3.5.so) ==23224== by 0x1BCA0BCF: __nss_passwd_lookup (in /lib/tls/libc-2.3.5.so) ==23224== by 0x1BC4D1BB: getpwnam_r (in /lib/tls/libc-2.3.5.so) ==23224== by 0x1BC4CB41: getpwnam (in /lib/tls/libc-2.3.5.so) ==23224== ==23224== Conditional jump or move depends on uninitialised value(s) ==23224== at 0x1B8EC7D3: (within /lib/ld-2.3.5.so) ==23224== by 0x1BCC24BA: (within /lib/tls/libc-2.3.5.so) ==23224== by 0x1B8EF026: (within /lib/ld-2.3.5.so) ==23224== by 0x1BCC2B85: _dl_open (in /lib/tls/libc-2.3.5.so) ==23224== by 0x1BCC407C: (within /lib/tls/libc-2.3.5.so) ==23224== by 0x1B8EF026: (within /lib/ld-2.3.5.so) ==23224== by 0x1BCC41DD: __libc_dlopen_mode (in /lib/tls/libc-2.3.5.so) ==23224== by 0x1BC9EE68: __nss_lookup_function (in /lib/tls/libc-2.3.5.so) ==23224== by 0x1BC9F00E: (within /lib/tls/libc-2.3.5.so) ==23224== by 0x1BCA0BCF: __nss_passwd_lookup (in /lib/tls/libc-2.3.5.so) ==23224== by 0x1BC4D1BB: getpwnam_r (in /lib/tls/libc-2.3.5.so) ==23224== by 0x1BC4CB41: getpwnam (in /lib/tls/libc-2.3.5.so) ==23224== ==23224== Thread 2: ==23224== Use of uninitialised value of size 4 ==23224== at 0x1B909FA4: ??? ==23224== by 0x1B90AD8B: ??? ==23224== by 0x8056974: call_modsingle (modcall.c:254) ==23224== by 0x805707A: modcall (modcall.c:590) ==23224== by 0x8056A24: call_one (modcall.c:287) ==23224== by 0x8056B1E: call_modgroup (modcall.c:342) ==23224== by 0x8056FE9: modcall (modcall.c:575) ==23224== by 0x80559B1: indexed_modcall (modules.c:428) ==23224== by 0x8056527: module_accounting (modules.c:960) ==23224== by 0x804F6E6: rad_accounting (acct.c:68) ==23224== by 0x8065FFC: rad_respond (request_process.c:453) ==23224== by 0x805AF10: request_handler_thread (threads.c:590) ==23224== ==23224== Thread 5: ==23224== Invalid read of size 4 ==23224== at 0x80514B8: proxy_send (proxy.c:531) ==23224== by 0x8066081: rad_respond (request_process.c:484) ==23224== by 0x805AF10: request_handler_thread (threads.c:590) ==23224== by 0x1B943CCC: start_thread (in /lib/tls/libpthread-2.3.5.so) ==23224== by 0x1BC8DB0D: clone (in /lib/tls/libc-2.3.5.so) ==23224== Address 0x1BFE5EB0 is 24 bytes inside a block of size 40 free'd ==23224== at 0x1B904B04: free (vg_replace_malloc.c:152) ==23224== by 0x80659F9: listen_free (listen.c:2123) ==23224== by 0x8062226: read_mainconfig (mainconfig.c:1045) ==23224== by 0x804D50A: main (radiusd.c:549) ==23224== ==23224== Invalid read of size 4 ==23224== at 0x8051539: proxy_send (proxy.c:544) ==23224== by 0x8066081: rad_respond (request_process.c:484) ==23224== by 0x805AF10: request_handler_thread (threads.c:590) ==23224== by 0x1B943CCC: start_thread (in /lib/tls/libpthread-2.3.5.so) ==23224== by 0x1BC8DB0D: clone (in /lib/tls/libc-2.3.5.so) ==23224== Address 0x1BFE5EB0 is 24 bytes inside a block of size 40 free'd ==23224== at 0x1B904B04: free (vg_replace_malloc.c:152) ==23224== by 0x80659F9: listen_free (listen.c:2123) ==23224== by 0x8062226: read_mainconfig (mainconfig.c:1045) ==23224== by 0x804D50A: main (radiusd.c:549) ==23224== ==23224== Invalid read of size 4 ==23224== at 0x80632AC: proxy_socket_send (listen.c:635) ==23224== by 0x805154A: proxy_send (proxy.c:544) ==23224== by 0x8066081: rad_respond (request_process.c:484) ==23224== by 0x805AF10: request_handler_thread (threads.c:590) ==23224== by 0x1B943CCC: start_thread (in /lib/tls/libpthread-2.3.5.so) ==23224== by 0x1BC8DB0D: clone (in /lib/tls/libc-2.3.5.so) ==23224== Address 0x1BFE5EBC is 36 bytes inside a block of size 40 free'd ==23224== at 0x1B904B04: free (vg_replace_malloc.c:152) ==23224== by 0x80659F9: listen_free (listen.c:2123) ==23224== by 0x8062226: read_mainconfig (mainconfig.c:1045) ==23224== by 0x804D50A: main (radiusd.c:549) ==23224== ==23224== Invalid read of size 4 ==23224== at 0x80632D5: proxy_socket_send (listen.c:638) ==23224== by 0x805154A: proxy_send (proxy.c:544) ==23224== by 0x8066081: rad_respond (request_process.c:484) ==23224== by 0x805AF10: request_handler_thread (threads.c:590) ==23224== by 0x1B943CCC: start_thread (in /lib/tls/libpthread-2.3.5.so) ==23224== by 0x1BC8DB0D: clone (in /lib/tls/libc-2.3.5.so) ==23224== Address 0x1BFE5EB0 is 24 bytes inside a block of size 40 free'd ==23224== at 0x1B904B04: free (vg_replace_malloc.c:152) ==23224== by 0x80659F9: listen_free (listen.c:2123) ==23224== by 0x8062226: read_mainconfig (mainconfig.c:1045) ==23224== by 0x804D50A: main (radiusd.c:549) ==23224== ==23224== Invalid read of size 4 ==23224== at 0x806330A: proxy_socket_send (listen.c:640) ==23224== by 0x805154A: proxy_send (proxy.c:544) ==23224== by 0x8066081: rad_respond (request_process.c:484) ==23224== by 0x805AF10: request_handler_thread (threads.c:590) ==23224== by 0x1B943CCC: start_thread (in /lib/tls/libpthread-2.3.5.so) ==23224== by 0x1BC8DB0D: clone (in /lib/tls/libc-2.3.5.so) ==23224== Address 0x1BFE5EF0 is 0 bytes inside a block of size 28 free'd ==23224== at 0x1B904B04: free (vg_replace_malloc.c:152) ==23224== by 0x80659EB: listen_free (listen.c:2122) ==23224== by 0x8062226: read_mainconfig (mainconfig.c:1045) ==23224== by 0x804D50A: main (radiusd.c:549) ==23224== ==23224== Invalid read of size 4 ==23224== at 0x8063315: proxy_socket_send (listen.c:641) ==23224== by 0x805154A: proxy_send (proxy.c:544) ==23224== by 0x8066081: rad_respond (request_process.c:484) ==23224== by 0x805AF10: request_handler_thread (threads.c:590) ==23224== by 0x1B943CCC: start_thread (in /lib/tls/libpthread-2.3.5.so) ==23224== by 0x1BC8DB0D: clone (in /lib/tls/libc-2.3.5.so) ==23224== Address 0x1BFE5F04 is 20 bytes inside a block of size 28 free'd ==23224== at 0x1B904B04: free (vg_replace_malloc.c:152) ==23224== by 0x80659EB: listen_free (listen.c:2122) ==23224== by 0x8062226: read_mainconfig (mainconfig.c:1045) ==23224== by 0x804D50A: main (radiusd.c:549) ==23224== ==23224== Thread 6: ==23224== Jump to the invalid address stated on the next line ==23224== at 0x48: ??? ==23224== by 0x8066081: rad_respond (request_process.c:484) ==23224== by 0x805AF10: request_handler_thread (threads.c:590) ==23224== by 0x1B943CCC: start_thread (in /lib/tls/libpthread-2.3.5.so) ==23224== by 0x1BC8DB0D: clone (in /lib/tls/libc-2.3.5.so) ==23224== Address 0x48 is not stack'd, malloc'd or (recently) free'd ==23224== ==23224== Process terminating with default action of signal 11 (SIGSEGV): dumping core ==23224== Access not within mapped region at address 0x48 ==23224== at 0x48: ??? ==23224== by 0x8066081: rad_respond (request_process.c:484) ==23224== by 0x805AF10: request_handler_thread (threads.c:590) ==23224== by 0x1B943CCC: start_thread (in /lib/tls/libpthread-2.3.5.so) ==23224== by 0x1BC8DB0D: clone (in /lib/tls/libc-2.3.5.so) ==23224== ==23224== ERROR SUMMARY: 794 errors from 15 contexts (suppressed: 0 from 0) ==23224== malloc/free: in use at exit: 1222706 bytes in 28495 blocks. ==23224== malloc/free: 48871 allocs, 20376 frees, 9806171 bytes allocated. ==23224== For counts of detected errors, rerun with: -v ==23224== searching for pointers to 28495 not-freed blocks. ==23224== checked 102635084 bytes. ==23224== ==23224== ==23224== 3 bytes in 1 blocks are definitely lost in loss record 1 of 39 ==23224== at 0x1B90459D: malloc (vg_replace_malloc.c:130) ==23224== by 0x1BC29D4F: strdup (in /lib/tls/libc-2.3.5.so) ==23224== by 0x8053783: cf_item_parse (conffile.c:747) ==23224== by 0x8053C40: cf_section_parse (conffile.c:896) ==23224== by 0x1C2C8E9E: ??? ==23224== by 0x80556C1: find_module_instance (modules.c:314) ==23224== by 0x80573D4: do_compile_modsingle (modcall.c:1038) ==23224== by 0x8057720: compile_modsingle (modcall.c:1142) ==23224== by 0x8055CA2: load_component_section (modules.c:554) ==23224== by 0x8056462: setup_modules (modules.c:908) ==23224== by 0x806230F: read_mainconfig (mainconfig.c:1088) ==23224== by 0x804D05B: main (radiusd.c:281) ==23224== ==23224== ==23224== 78 bytes in 3 blocks are definitely lost in loss record 5 of 39 ==23224== at 0x1B90459D: malloc (vg_replace_malloc.c:130) ==23224== by 0x1C0F13E7: ??? ==23224== by 0x1C0F1296: ??? ==23224== by 0x1C0CC145: ??? ==23224== by 0x1C0C49E2: ??? ==23224== by 0x1C0C4982: ??? ==23224== by 0x1C02E62D: ??? ==23224== by 0x1C02E717: ??? ==23224== by 0x1C02DEC5: ??? ==23224== by 0x1C02E0EF: ??? ==23224== by 0x1BCA5142: getservbyname_r (in /lib/tls/libc-2.3.5.so) ==23224== by 0x1BCA4FD8: getservbyname (in /lib/tls/libc-2.3.5.so) ==23224== ==23224== ==23224== 492 (108 direct, 384 indirect) bytes in 3 blocks are definitely lost in loss record 9 of 39 ==23224== at 0x1B90459D: malloc (vg_replace_malloc.c:130) ==23224== by 0x1BC9F179: (within /lib/tls/libc-2.3.5.so) ==23224== by 0x1BC9F7C1: __nss_database_lookup (in /lib/tls/libc-2.3.5.so) ==23224== by 0x1C00A139: ??? ==23224== by 0x1C00B8F4: ??? ==23224== by 0x1BC4D0B9: getpwnam_r (in /lib/tls/libc-2.3.5.so) ==23224== by 0x1BC4CB41: getpwnam (in /lib/tls/libc-2.3.5.so) ==23224== by 0x80610A1: radlogdir_iswritable (mainconfig.c:480) ==23224== by 0x8062175: read_mainconfig (mainconfig.c:1010) ==23224== by 0x804D05B: main (radiusd.c:281) ==23224== ==23224== ==23224== 528 bytes in 1 blocks are definitely lost in loss record 12 of 39 ==23224== at 0x1B904F75: calloc (vg_replace_malloc.c:175) ==23224== by 0x805E5D5: clients_init (client.c:143) ==23224== by 0x805EAD6: clients_parse_section (client.c:395) ==23224== by 0x80622BD: read_mainconfig (mainconfig.c:1071) ==23224== by 0x804D05B: main (radiusd.c:281) ==23224== ==23224== ==23224== 816 bytes in 12 blocks are possibly lost in loss record 15 of 39 ==23224== at 0x1B904F75: calloc (vg_replace_malloc.c:175) ==23224== by 0x1B8F16A7: (within /lib/ld-2.3.5.so) ==23224== by 0x1B8F197B: _dl_allocate_tls (in /lib/ld-2.3.5.so) ==23224== by 0x1B9434F0: pthread_create@@GLIBC_2.1 (in /lib/tls/libpthread-2.3.5.so) ==23224== by 0x805B1AD: spawn_thread (threads.c:720) ==23224== by 0x805B75D: thread_pool_clean (threads.c:1007) ==23224== by 0x804D88C: main (radiusd.c:735) ==23224== ==23224== ==23224== 816 bytes in 34 blocks are definitely lost in loss record 16 of 39 ==23224== at 0x1B90459D: malloc (vg_replace_malloc.c:130) ==23224== by 0x1B95FFA4: rbtree_create (rbtree.c:99) ==23224== by 0x805E81C: client_add (client.c:234) ==23224== by 0x805EDC9: clients_parse_section (client.c:487) ==23224== by 0x80622BD: read_mainconfig (mainconfig.c:1071) ==23224== by 0x804D50A: main (radiusd.c:549) ==23224== ==23224== LEAK SUMMARY: ==23224== definitely lost: 1533 bytes in 42 blocks. ==23224== indirectly lost: 384 bytes in 32 blocks. ==23224== possibly lost: 816 bytes in 12 blocks. ==23224== still reachable: 1219973 bytes in 28409 blocks. ==23224== suppressed: 0 bytes in 0 blocks. ==23224== Reachable blocks (those to which a pointer was found) are not shown. ==23224== To see them, rerun with: --show-reachable=yes ==13538== Memcheck, a memory error detector for x86-linux. ==13538== Copyright (C) 2002-2005, and GNU GPL'd, by Julian Seward et al. ==13538== Using valgrind-2.4.0, a program supervision framework for x86-linux. ==13538== Copyright (C) 2000-2005, and GNU GPL'd, by Julian Seward et al. ==13538== ==13538== My PID = 13538, parent PID = 3602. Prog and args are: ==13538== ./src/main/.libs/radiusd ==13538== -fxx ==13538== For more details, rerun with: -v ==13538== ==13538== Conditional jump or move depends on uninitialised value(s) ==13538== at 0x1B8ECB13: (within /lib/ld-2.3.5.so) ==13538== by 0x1B8E631C: (within /lib/ld-2.3.5.so) ==13538== by 0x1B8F2BDD: (within /lib/ld-2.3.5.so) ==13538== by 0x1B8E7675: (within /lib/ld-2.3.5.so) ==13538== by 0x1B8E47C6: (within /lib/ld-2.3.5.so) ==13538== ==13538== Conditional jump or move depends on uninitialised value(s) ==13538== at 0x1B8EC7D3: (within /lib/ld-2.3.5.so) ==13538== by 0x1B8E631C: (within /lib/ld-2.3.5.so) ==13538== by 0x1B8F2BDD: (within /lib/ld-2.3.5.so) ==13538== by 0x1B8E7675: (within /lib/ld-2.3.5.so) ==13538== by 0x1B8E47C6: (within /lib/ld-2.3.5.so) ==13538== ==13538== Conditional jump or move depends on uninitialised value(s) ==13538== at 0x1B8EC6B6: (within /lib/ld-2.3.5.so) ==13538== by 0x1B8E6376: (within /lib/ld-2.3.5.so) ==13538== by 0x1B8F2BDD: (within /lib/ld-2.3.5.so) ==13538== by 0x1B8E7675: (within /lib/ld-2.3.5.so) ==13538== by 0x1B8E47C6: (within /lib/ld-2.3.5.so) ==13538== ==13538== Conditional jump or move depends on uninitialised value(s) ==13538== at 0x1B8EC6C2: (within /lib/ld-2.3.5.so) ==13538== by 0x1B8E6376: (within /lib/ld-2.3.5.so) ==13538== by 0x1B8F2BDD: (within /lib/ld-2.3.5.so) ==13538== by 0x1B8E7675: (within /lib/ld-2.3.5.so) ==13538== by 0x1B8E47C6: (within /lib/ld-2.3.5.so) ==13538== ==13538== Conditional jump or move depends on uninitialised value(s) ==13538== at 0x1B8EC7D3: (within /lib/ld-2.3.5.so) ==13538== by 0x1B8E6376: (within /lib/ld-2.3.5.so) ==13538== by 0x1B8F2BDD: (within /lib/ld-2.3.5.so) ==13538== by 0x1B8E7675: (within /lib/ld-2.3.5.so) ==13538== by 0x1B8E47C6: (within /lib/ld-2.3.5.so) ==13538== ==13538== Conditional jump or move depends on uninitialised value(s) ==13538== at 0x1B8ECB13: (within /lib/ld-2.3.5.so) ==13538== by 0x1BCC24BA: (within /lib/tls/libc-2.3.5.so) ==13538== by 0x1B8EF026: (within /lib/ld-2.3.5.so) ==13538== by 0x1BCC2B85: _dl_open (in /lib/tls/libc-2.3.5.so) ==13538== by 0x1BCC407C: (within /lib/tls/libc-2.3.5.so) ==13538== by 0x1B8EF026: (within /lib/ld-2.3.5.so) ==13538== by 0x1BCC41DD: __libc_dlopen_mode (in /lib/tls/libc-2.3.5.so) ==13538== by 0x1BC9EE68: __nss_lookup_function (in /lib/tls/libc-2.3.5.so) ==13538== by 0x1BC9F00E: (within /lib/tls/libc-2.3.5.so) ==13538== by 0x1BCA0BCF: __nss_passwd_lookup (in /lib/tls/libc-2.3.5.so) ==13538== by 0x1BC4D1BB: getpwnam_r (in /lib/tls/libc-2.3.5.so) ==13538== by 0x1BC4CB41: getpwnam (in /lib/tls/libc-2.3.5.so) ==13538== ==13538== Conditional jump or move depends on uninitialised value(s) ==13538== at 0x1B8EC7D3: (within /lib/ld-2.3.5.so) ==13538== by 0x1BCC24BA: (within /lib/tls/libc-2.3.5.so) ==13538== by 0x1B8EF026: (within /lib/ld-2.3.5.so) ==13538== by 0x1BCC2B85: _dl_open (in /lib/tls/libc-2.3.5.so) ==13538== by 0x1BCC407C: (within /lib/tls/libc-2.3.5.so) ==13538== by 0x1B8EF026: (within /lib/ld-2.3.5.so) ==13538== by 0x1BCC41DD: __libc_dlopen_mode (in /lib/tls/libc-2.3.5.so) ==13538== by 0x1BC9EE68: __nss_lookup_function (in /lib/tls/libc-2.3.5.so) ==13538== by 0x1BC9F00E: (within /lib/tls/libc-2.3.5.so) ==13538== by 0x1BCA0BCF: __nss_passwd_lookup (in /lib/tls/libc-2.3.5.so) ==13538== by 0x1BC4D1BB: getpwnam_r (in /lib/tls/libc-2.3.5.so) ==13538== by 0x1BC4CB41: getpwnam (in /lib/tls/libc-2.3.5.so) ==13538== ==13538== Thread 3: ==13538== Use of uninitialised value of size 4 ==13538== at 0x1B909FA4: ??? ==13538== by 0x1B90AD8B: ??? ==13538== by 0x8056974: call_modsingle (modcall.c:254) ==13538== by 0x805707A: modcall (modcall.c:590) ==13538== by 0x8056A24: call_one (modcall.c:287) ==13538== by 0x8056B1E: call_modgroup (modcall.c:342) ==13538== by 0x8056FE9: modcall (modcall.c:575) ==13538== by 0x80559B1: indexed_modcall (modules.c:428) ==13538== by 0x8056527: module_accounting (modules.c:960) ==13538== by 0x804F6E6: rad_accounting (acct.c:68) ==13538== by 0x8065FFC: rad_respond (request_process.c:453) ==13538== by 0x805AF10: request_handler_thread (threads.c:590) ==13538== ==13538== Thread 8: ==13538== Invalid read of size 4 ==13538== at 0x80514B8: proxy_send (proxy.c:531) ==13538== by 0x8066081: rad_respond (request_process.c:484) ==13538== by 0x805AF10: request_handler_thread (threads.c:590) ==13538== by 0x1B943CCC: start_thread (in /lib/tls/libpthread-2.3.5.so) ==13538== by 0x1BC8DB0D: clone (in /lib/tls/libc-2.3.5.so) ==13538== Address 0x1BFE5EB0 is 24 bytes inside a block of size 40 free'd ==13538== at 0x1B904B04: free (vg_replace_malloc.c:152) ==13538== by 0x80659F9: listen_free (listen.c:2123) ==13538== by 0x8062226: read_mainconfig (mainconfig.c:1045) ==13538== by 0x804D50A: main (radiusd.c:549) ==13538== ==13538== Invalid read of size 4 ==13538== at 0x8051539: proxy_send (proxy.c:544) ==13538== by 0x8066081: rad_respond (request_process.c:484) ==13538== by 0x805AF10: request_handler_thread (threads.c:590) ==13538== by 0x1B943CCC: start_thread (in /lib/tls/libpthread-2.3.5.so) ==13538== by 0x1BC8DB0D: clone (in /lib/tls/libc-2.3.5.so) ==13538== Address 0x1BFE5EB0 is 24 bytes inside a block of size 40 free'd ==13538== at 0x1B904B04: free (vg_replace_malloc.c:152) ==13538== by 0x80659F9: listen_free (listen.c:2123) ==13538== by 0x8062226: read_mainconfig (mainconfig.c:1045) ==13538== by 0x804D50A: main (radiusd.c:549) ==13538== ==13538== Invalid read of size 4 ==13538== at 0x80632AC: proxy_socket_send (listen.c:635) ==13538== by 0x805154A: proxy_send (proxy.c:544) ==13538== by 0x8066081: rad_respond (request_process.c:484) ==13538== by 0x805AF10: request_handler_thread (threads.c:590) ==13538== by 0x1B943CCC: start_thread (in /lib/tls/libpthread-2.3.5.so) ==13538== by 0x1BC8DB0D: clone (in /lib/tls/libc-2.3.5.so) ==13538== Address 0x1BFE5EBC is 36 bytes inside a block of size 40 free'd ==13538== at 0x1B904B04: free (vg_replace_malloc.c:152) ==13538== by 0x80659F9: listen_free (listen.c:2123) ==13538== by 0x8062226: read_mainconfig (mainconfig.c:1045) ==13538== by 0x804D50A: main (radiusd.c:549) ==13538== ==13538== Invalid read of size 4 ==13538== at 0x80632D5: proxy_socket_send (listen.c:638) ==13538== by 0x805154A: proxy_send (proxy.c:544) ==13538== by 0x8066081: rad_respond (request_process.c:484) ==13538== by 0x805AF10: request_handler_thread (threads.c:590) ==13538== by 0x1B943CCC: start_thread (in /lib/tls/libpthread-2.3.5.so) ==13538== by 0x1BC8DB0D: clone (in /lib/tls/libc-2.3.5.so) ==13538== Address 0x1BFE5EB0 is 24 bytes inside a block of size 40 free'd ==13538== at 0x1B904B04: free (vg_replace_malloc.c:152) ==13538== by 0x80659F9: listen_free (listen.c:2123) ==13538== by 0x8062226: read_mainconfig (mainconfig.c:1045) ==13538== by 0x804D50A: main (radiusd.c:549) ==13538== ==13538== Invalid read of size 4 ==13538== at 0x806330A: proxy_socket_send (listen.c:640) ==13538== by 0x805154A: proxy_send (proxy.c:544) ==13538== by 0x8066081: rad_respond (request_process.c:484) ==13538== by 0x805AF10: request_handler_thread (threads.c:590) ==13538== by 0x1B943CCC: start_thread (in /lib/tls/libpthread-2.3.5.so) ==13538== by 0x1BC8DB0D: clone (in /lib/tls/libc-2.3.5.so) ==13538== Address 0x1BFE5EF0 is 0 bytes inside a block of size 28 free'd ==13538== at 0x1B904B04: free (vg_replace_malloc.c:152) ==13538== by 0x80659EB: listen_free (listen.c:2122) ==13538== by 0x8062226: read_mainconfig (mainconfig.c:1045) ==13538== by 0x804D50A: main (radiusd.c:549) ==13538== ==13538== Invalid read of size 4 ==13538== at 0x8063315: proxy_socket_send (listen.c:641) ==13538== by 0x805154A: proxy_send (proxy.c:544) ==13538== by 0x8066081: rad_respond (request_process.c:484) ==13538== by 0x805AF10: request_handler_thread (threads.c:590) ==13538== by 0x1B943CCC: start_thread (in /lib/tls/libpthread-2.3.5.so) ==13538== by 0x1BC8DB0D: clone (in /lib/tls/libc-2.3.5.so) ==13538== Address 0x1BFE5F04 is 20 bytes inside a block of size 28 free'd ==13538== at 0x1B904B04: free (vg_replace_malloc.c:152) ==13538== by 0x80659EB: listen_free (listen.c:2122) ==13538== by 0x8062226: read_mainconfig (mainconfig.c:1045) ==13538== by 0x804D50A: main (radiusd.c:549) ==13538== ==13538== Thread 1: ==13538== Invalid read of size 4 ==13538== at 0x80608FC: refresh_request (request_list.c:1283) ==13538== by 0x1B958537: lrad_hash_table_walk (hash.c:408) ==13538== by 0x806098A: rl_clean_list (request_list.c:1324) ==13538== by 0x80648D5: generic_update (listen.c:1513) ==13538== by 0x804D829: main (radiusd.c:719) ==13538== Address 0x1BFE5EB0 is 24 bytes inside a block of size 40 free'd ==13538== at 0x1B904B04: free (vg_replace_malloc.c:152) ==13538== by 0x80659F9: listen_free (listen.c:2123) ==13538== by 0x8062226: read_mainconfig (mainconfig.c:1045) ==13538== by 0x804D50A: main (radiusd.c:549) ==13538== ==13538== Invalid read of size 4 ==13538== at 0x80632AC: proxy_socket_send (listen.c:635) ==13538== by 0x806090D: refresh_request (request_list.c:1283) ==13538== by 0x1B958537: lrad_hash_table_walk (hash.c:408) ==13538== by 0x806098A: rl_clean_list (request_list.c:1324) ==13538== by 0x80648D5: generic_update (listen.c:1513) ==13538== by 0x804D829: main (radiusd.c:719) ==13538== Address 0x1BFE5EBC is 36 bytes inside a block of size 40 free'd ==13538== at 0x1B904B04: free (vg_replace_malloc.c:152) ==13538== by 0x80659F9: listen_free (listen.c:2123) ==13538== by 0x8062226: read_mainconfig (mainconfig.c:1045) ==13538== by 0x804D50A: main (radiusd.c:549) ==13538== ==13538== Invalid read of size 4 ==13538== at 0x80632D5: proxy_socket_send (listen.c:638) ==13538== by 0x806090D: refresh_request (request_list.c:1283) ==13538== by 0x1B958537: lrad_hash_table_walk (hash.c:408) ==13538== by 0x806098A: rl_clean_list (request_list.c:1324) ==13538== by 0x80648D5: generic_update (listen.c:1513) ==13538== by 0x804D829: main (radiusd.c:719) ==13538== Address 0x1BFE5EB0 is 24 bytes inside a block of size 40 free'd ==13538== at 0x1B904B04: free (vg_replace_malloc.c:152) ==13538== by 0x80659F9: listen_free (listen.c:2123) ==13538== by 0x8062226: read_mainconfig (mainconfig.c:1045) ==13538== by 0x804D50A: main (radiusd.c:549) ==13538== ==13538== Invalid read of size 4 ==13538== at 0x806330A: proxy_socket_send (listen.c:640) ==13538== by 0x806090D: refresh_request (request_list.c:1283) ==13538== by 0x1B958537: lrad_hash_table_walk (hash.c:408) ==13538== by 0x806098A: rl_clean_list (request_list.c:1324) ==13538== by 0x80648D5: generic_update (listen.c:1513) ==13538== by 0x804D829: main (radiusd.c:719) ==13538== Address 0x1BFE5EF0 is 0 bytes inside a block of size 28 free'd ==13538== at 0x1B904B04: free (vg_replace_malloc.c:152) ==13538== by 0x80659EB: listen_free (listen.c:2122) ==13538== by 0x8062226: read_mainconfig (mainconfig.c:1045) ==13538== by 0x804D50A: main (radiusd.c:549) ==13538== ==13538== Invalid read of size 4 ==13538== at 0x8063315: proxy_socket_send (listen.c:641) ==13538== by 0x806090D: refresh_request (request_list.c:1283) ==13538== by 0x1B958537: lrad_hash_table_walk (hash.c:408) ==13538== by 0x806098A: rl_clean_list (request_list.c:1324) ==13538== by 0x80648D5: generic_update (listen.c:1513) ==13538== by 0x804D829: main (radiusd.c:719) ==13538== Address 0x1BFE5F04 is 20 bytes inside a block of size 28 free'd ==13538== at 0x1B904B04: free (vg_replace_malloc.c:152) ==13538== by 0x80659EB: listen_free (listen.c:2122) ==13538== by 0x8062226: read_mainconfig (mainconfig.c:1045) ==13538== by 0x804D50A: main (radiusd.c:549) ==13538== ==13538== Thread 30: ==13538== Jump to the invalid address stated on the next line ==13538== at 0x4: ??? ==13538== by 0x8066081: rad_respond (request_process.c:484) ==13538== by 0x805AF10: request_handler_thread (threads.c:590) ==13538== by 0x1B943CCC: start_thread (in /lib/tls/libpthread-2.3.5.so) ==13538== by 0x1BC8DB0D: clone (in /lib/tls/libc-2.3.5.so) ==13538== Address 0x4 is not stack'd, malloc'd or (recently) free'd ==13538== ==13538== Process terminating with default action of signal 11 (SIGSEGV): dumping core ==13538== Access not within mapped region at address 0x4 ==13538== at 0x4: ??? ==13538== by 0x8066081: rad_respond (request_process.c:484) ==13538== by 0x805AF10: request_handler_thread (threads.c:590) ==13538== by 0x1B943CCC: start_thread (in /lib/tls/libpthread-2.3.5.so) ==13538== by 0x1BC8DB0D: clone (in /lib/tls/libc-2.3.5.so) ==13538== ==13538== ERROR SUMMARY: 15178 errors from 20 contexts (suppressed: 0 from 0) ==13538== malloc/free: in use at exit: 1228480 bytes in 28534 blocks. ==13538== malloc/free: 795431 allocs, 766897 frees, 330805373 bytes allocated. ==13538== For counts of detected errors, rerun with: -v ==13538== searching for pointers to 28534 not-freed blocks. ==13538== checked 77486988 bytes. ==13538== ==13538== ==13538== 3 bytes in 1 blocks are definitely lost in loss record 1 of 40 ==13538== at 0x1B90459D: malloc (vg_replace_malloc.c:130) ==13538== by 0x1BC29D4F: strdup (in /lib/tls/libc-2.3.5.so) ==13538== by 0x8053783: cf_item_parse (conffile.c:747) ==13538== by 0x8053C40: cf_section_parse (conffile.c:896) ==13538== by 0x1C2C8E9E: ??? ==13538== by 0x80556C1: find_module_instance (modules.c:314) ==13538== by 0x80573D4: do_compile_modsingle (modcall.c:1038) ==13538== by 0x8057720: compile_modsingle (modcall.c:1142) ==13538== by 0x8055CA2: load_component_section (modules.c:554) ==13538== by 0x8056462: setup_modules (modules.c:908) ==13538== by 0x806230F: read_mainconfig (mainconfig.c:1088) ==13538== by 0x804D05B: main (radiusd.c:281) ==13538== ==13538== ==13538== 78 bytes in 3 blocks are definitely lost in loss record 5 of 40 ==13538== at 0x1B90459D: malloc (vg_replace_malloc.c:130) ==13538== by 0x1C0F13E7: ??? ==13538== by 0x1C0F1296: ??? ==13538== by 0x1C0CC145: ??? ==13538== by 0x1C0C49E2: ??? ==13538== by 0x1C0C4982: ??? ==13538== by 0x1C02E62D: ??? ==13538== by 0x1C02E717: ??? ==13538== by 0x1C02DEC5: ??? ==13538== by 0x1C02E0EF: ??? ==13538== by 0x1BCA5142: getservbyname_r (in /lib/tls/libc-2.3.5.so) ==13538== by 0x1BCA4FD8: getservbyname (in /lib/tls/libc-2.3.5.so) ==13538== ==13538== ==13538== 492 (108 direct, 384 indirect) bytes in 3 blocks are definitely lost in loss record 8 of 40 ==13538== at 0x1B90459D: malloc (vg_replace_malloc.c:130) ==13538== by 0x1BC9F179: (within /lib/tls/libc-2.3.5.so) ==13538== by 0x1BC9F7C1: __nss_database_lookup (in /lib/tls/libc-2.3.5.so) ==13538== by 0x1C00A139: ??? ==13538== by 0x1C00B8F4: ??? ==13538== by 0x1BC4D0B9: getpwnam_r (in /lib/tls/libc-2.3.5.so) ==13538== by 0x1BC4CB41: getpwnam (in /lib/tls/libc-2.3.5.so) ==13538== by 0x80610A1: radlogdir_iswritable (mainconfig.c:480) ==13538== by 0x8062175: read_mainconfig (mainconfig.c:1010) ==13538== by 0x804D05B: main (radiusd.c:281) ==13538== ==13538== ==13538== 324 bytes in 1 blocks are definitely lost in loss record 12 of 40 ==13538== at 0x1B90459D: malloc (vg_replace_malloc.c:130) ==13538== by 0x1B96501D: pairmake (valuepair.c:1131) ==13538== by 0x1C2DDB41: ??? ==13538== by 0x1C2DDF7C: ??? ==13538== by 0x1C2DE74D: ??? ==13538== by 0x1C2DAC16: ??? ==13538== by 0x8056974: call_modsingle (modcall.c:254) ==13538== by 0x805707A: modcall (modcall.c:590) ==13538== by 0x8056A24: call_one (modcall.c:287) ==13538== by 0x8056B1E: call_modgroup (modcall.c:342) ==13538== by 0x8056FE9: modcall (modcall.c:575) ==13538== by 0x80559B1: indexed_modcall (modules.c:428) ==13538== ==13538== ==13538== 528 bytes in 1 blocks are definitely lost in loss record 13 of 40 ==13538== at 0x1B904F75: calloc (vg_replace_malloc.c:175) ==13538== by 0x805E5D5: clients_init (client.c:143) ==13538== by 0x805EAD6: clients_parse_section (client.c:395) ==13538== by 0x80622BD: read_mainconfig (mainconfig.c:1071) ==13538== by 0x804D05B: main (radiusd.c:281) ==13538== ==13538== ==13538== 612 bytes in 9 blocks are possibly lost in loss record 15 of 40 ==13538== at 0x1B904F75: calloc (vg_replace_malloc.c:175) ==13538== by 0x1B8F16A7: (within /lib/ld-2.3.5.so) ==13538== by 0x1B8F197B: _dl_allocate_tls (in /lib/ld-2.3.5.so) ==13538== by 0x1B9434F0: pthread_create@@GLIBC_2.1 (in /lib/tls/libpthread-2.3.5.so) ==13538== by 0x805B1AD: spawn_thread (threads.c:720) ==13538== by 0x805B75D: thread_pool_clean (threads.c:1007) ==13538== by 0x804D88C: main (radiusd.c:735) ==13538== ==13538== ==13538== 816 bytes in 34 blocks are definitely lost in loss record 16 of 40 ==13538== at 0x1B90459D: malloc (vg_replace_malloc.c:130) ==13538== by 0x1B95FFA4: rbtree_create (rbtree.c:99) ==13538== by 0x805E81C: client_add (client.c:234) ==13538== by 0x805EDC9: clients_parse_section (client.c:487) ==13538== by 0x80622BD: read_mainconfig (mainconfig.c:1071) ==13538== by 0x804D50A: main (radiusd.c:549) ==13538== ==13538== LEAK SUMMARY: ==13538== definitely lost: 1857 bytes in 43 blocks. ==13538== indirectly lost: 384 bytes in 32 blocks. ==13538== possibly lost: 612 bytes in 9 blocks. ==13538== still reachable: 1225627 bytes in 28450 blocks. ==13538== suppressed: 0 bytes in 0 blocks. ==13538== Reachable blocks (those to which a pointer was found) are not shown. ==13538== To see them, rerun with: --show-reachable=yes

2 1

Automatic report from sources (radiusd) between 02.11.2005 - 03.11.2005 GMT
by Automatic cvs log generator 03 Nov '05

03 Nov '05

CVS log entries from 02.11.2005 (Wed) 09:00:00 - 03.11.2005 (Thu) 09:00:01 GMT ===================================================== Summary by authors ===================================================== Author: aland File: radiusd/src/modules/rlm_digest/rlm_digest.c; Revisions: 1.12 Author: fcusack File: radiusd/src/modules/rlm_otp/cardops/cryptocard.h; Revisions: 1.28, 1.27, 1.26, 1.25 File: radiusd/src/modules/rlm_otp/otp_state.c; Revisions: 1.18 File: radiusd/src/modules/rlm_otp/otp_cardops.h; Revisions: 1.32, 1.31, 1.30, 1.29 File: radiusd/src/modules/rlm_otp/cardops/cryptocard.c; Revisions: 1.29, 1.28, 1.27, 1.26 File: radiusd/src/modules/rlm_otp/otp_cardops.c; Revisions: 1.50, 1.49, 1.48 File: radiusd/src/modules/rlm_otp/otp.h; Revisions: 1.17 ===================================================== Combined list of identical log entries ===================================================== Description: cardops updatecsd() method twin arg is int, not unsigned Modified files: File: radiusd/src/modules/rlm_otp/otp_cardops.h; Revision: 1.30; Date: 2005/11/02 22:41:15; Author: fcusack; Lines: (+2 -2) File: radiusd/src/modules/rlm_otp/cardops/cryptocard.c; Revision: 1.27; Date: 2005/11/02 22:41:15; Author: fcusack; Lines: (+2 -2) File: radiusd/src/modules/rlm_otp/cardops/cryptocard.h; Revision: 1.26; Date: 2005/11/02 22:41:15; Author: fcusack; Lines: (+2 -2) ------------------------------- Description: - change csd and challenge args to cardops response() method to char[] instead of char*, to document expected array length - change csd arg to cardops response() method to const - remove now superfluous (since cl 421) local copy of user_state.csd Modified files: File: radiusd/src/modules/rlm_otp/otp_cardops.c; Revision: 1.48; Date: 2005/11/02 22:19:32; Author: fcusack; Lines: (+9 -13) File: radiusd/src/modules/rlm_otp/otp_cardops.h; Revision: 1.29; Date: 2005/11/02 22:19:32; Author: fcusack; Lines: (+3 -2) File: radiusd/src/modules/rlm_otp/cardops/cryptocard.c; Revision: 1.26; Date: 2005/11/02 22:19:32; Author: fcusack; Lines: (+3 -3) File: radiusd/src/modules/rlm_otp/cardops/cryptocard.h; Revision: 1.25; Date: 2005/11/02 22:19:32; Author: fcusack; Lines: (+4 -2) ------------------------------- Description: - add back time restriction to rwindow override, mistakenly removed in previous change - add logging when a window position is skipped for being too early Modified files: File: radiusd/src/modules/rlm_otp/otp_cardops.c; Revision: 1.50; Date: 2005/11/03 00:54:15; Author: fcusack; Lines: (+48 -19) File: radiusd/src/modules/rlm_otp/otp_cardops.h; Revision: 1.32; Date: 2005/11/03 00:54:15; Author: fcusack; Lines: (+2 -2) File: radiusd/src/modules/rlm_otp/cardops/cryptocard.c; Revision: 1.29; Date: 2005/11/03 00:54:15; Author: fcusack; Lines: (+2 -6) File: radiusd/src/modules/rlm_otp/cardops/cryptocard.h; Revision: 1.28; Date: 2005/11/03 00:54:15; Author: fcusack; Lines: (+2 -3) ------------------------------- Description: Make isconsecutive() a cardops method instead of trying to account for all cases in otp_cardops.c: - remove nexttwin() method - save rwindow data as card-specific 'rd' field, instead of generic authewin and authtwin fields - updatecsd() method now has to update rd as well - bump state to version 5 Modified files: File: radiusd/src/modules/rlm_otp/otp.h; Revision: 1.17; Date: 2005/11/03 00:13:10; Author: fcusack; Lines: (+6 -5) File: radiusd/src/modules/rlm_otp/otp_cardops.c; Revision: 1.49; Date: 2005/11/03 00:13:10; Author: fcusack; Lines: (+8 -71) File: radiusd/src/modules/rlm_otp/otp_cardops.h; Revision: 1.31; Date: 2005/11/03 00:13:10; Author: fcusack; Lines: (+4 -3) File: radiusd/src/modules/rlm_otp/otp_state.c; Revision: 1.18; Date: 2005/11/03 00:13:10; Author: fcusack; Lines: (+18 -33) File: radiusd/src/modules/rlm_otp/cardops/cryptocard.c; Revision: 1.28; Date: 2005/11/03 00:13:10; Author: fcusack; Lines: (+39 -13) File: radiusd/src/modules/rlm_otp/cardops/cryptocard.h; Revision: 1.27; Date: 2005/11/03 00:13:11; Author: fcusack; Lines: (+5 -3) ===================================================== Log entries ===================================================== Description: Removed duplicate function. Patch from Phillipe Sultan Modified files: File: radiusd/src/modules/rlm_digest/rlm_digest.c; Revision: 1.12; Date: 2005/11/02 18:46:24; Author: aland; Lines: (+6 -23) ===================================================== Summary of modified files ===================================================== File: radiusd/src/modules/rlm_digest/rlm_digest.c Revisions: 1.12 Authors: aland (+6 -23) ------------------------------- File: radiusd/src/modules/rlm_otp/cardops/cryptocard.c Revisions: 1.29, 1.28, 1.27, 1.26 Authors: fcusack (+2 -6), fcusack (+39 -13), fcusack (+2 -2), fcusack (+3 -3) ------------------------------- File: radiusd/src/modules/rlm_otp/cardops/cryptocard.h Revisions: 1.28, 1.27, 1.26, 1.25 Authors: fcusack (+2 -3), fcusack (+5 -3), fcusack (+2 -2), fcusack (+4 -2) ------------------------------- File: radiusd/src/modules/rlm_otp/otp.h Revisions: 1.17 Authors: fcusack (+6 -5) ------------------------------- File: radiusd/src/modules/rlm_otp/otp_cardops.c Revisions: 1.50, 1.49, 1.48 Authors: fcusack (+48 -19), fcusack (+8 -71), fcusack (+9 -13) ------------------------------- File: radiusd/src/modules/rlm_otp/otp_cardops.h Revisions: 1.32, 1.31, 1.30, 1.29 Authors: fcusack (+2 -2), fcusack (+4 -3), fcusack (+2 -2), fcusack (+3 -2) ------------------------------- File: radiusd/src/modules/rlm_otp/otp_state.c Revisions: 1.18 Authors: fcusack (+18 -33) -- Automatic cron job from /web/pages/us.freeradius.org/bin/new_makelog.pl

1 0