June 2006 - Freeradius-Devel - lists.freeradius.org

proxy deleting the attributes valu pair??
by Laurent LOINGEVILLE 30 Jun '06

30 Jun '06

Hi ! I've got the following chain: *client>>>>>proxy>>>>>>Server*. When the proxy send back the response of the server to the client, it delete the attributes value pair. What can i do to force the proxy not to delete the attributes? Thanks a lot!

2 3

deleting or xlat not configure?
by Laurent LOINGEVILLE 30 Jun '06

30 Jun '06

*Hi ! I've got the following chain: client>>>>>proxy>>>>>>Server. When the proxy send back the response of the server(reject message) to the client, it delete the attributes value pair. What can i do to force the proxy not to delete the attributes?* ** In fact, i think the radius proxy doesn't re-copy the attribute value-pair of the radius server on the interface where is connected the client. I thought that it was in the xlat section of the radiusd.conf file but it doesn't work. I have maybe make a bad manipulation? Do you have an idea? Thank you

1 0

specify an interface to proxy!
by Laurent LOINGEVILLE 28 Jun '06

28 Jun '06

Hi! Is it possible to specify on a proxy freeradius on which interface proxy the request? Thanks a lot!

3 3

Bug in libs/valuepair.c pairmake function
by Mitchell, Michael J 28 Jun '06

28 Jun '06

Hi Alan and developers, I've found a small bug in libs/valuepair.c in the pairmake() function when trying to call pairmake on an attribute with a tag (eg tunnel attributes from dictionary.tunnel). For example pairmake("Tunnel-Preference:1", "1", T_OP_EQ) The code searches for a ":" in the attribute name which has been passed in, and if it finds a valid tag, sets the position of the ":" to 0 (a null). However, the attribute name is declared as a "const char *". I resolved the issue by doing a strdup on the attribute name to a local char * variable and then using that variable in the rest of the function. Making attribute non const doesn't seem like a good idea. cheers, Mike

1 0

Pb concerning the re-sending interfaces in proxy radius configuration
by Laurent LOINGEVILLE 27 Jun '06

27 Jun '06

Hi! I'va installed freeradius on my Computer as a reverse proxy.This computer has 2 network interfaces (eth0 and eth1).The problem is this one: -the proxy receive the radius packet on the front interface (eth0) but can't re-send the packet on the eth1 interface. The configuration of the proxy seems to be good because this one display to me a message telling: "re-sending" the packet to 192.168.2.1 (radius server).Moreover, there is a rule in the routing table in order to go to the server 192.168.2.1.If i launch a tcpdump on the eth1 interface, no packet are leaving. Is there something to do in the configuration of the proxy to tell him the interface to re-send the packets? Thanks a lot in advance! Cordialy

2 1

Custom Reply-Message for Simultaneous-Use
by Josh Howlett 27 Jun '06

27 Jun '06

Hi, I need to be able to return a user-specific Reply-Message attribute in the event of simultaneous-use being detected. In auth.c, this message is currently hard-coded. I'm considering the following approach: if sim-use is detected, look for a new attribute in the reply items list whose value is the custom message. If it exists, use it for the Reply-Message; if not, use the existing hard-coded value. Is this a sensible approach? If not, what should I do? Many thanks, josh. Josh Howlett, Networking Specialist, University of Bristol. email: josh.howlett(a)bristol.ac.uk | phone: +44 (0)7867 907076 | interal: 7850

4 4

Re: lt_dllopenext() returns invalid handle (was: 1.1.2 is broken if you have closefrom() )
by Frank Cusack 26 Jun '06

26 Jun '06

On June 15, 2006 4:30:19 PM -0400 Alan DeKok <aland(a)nitros9.org> wrote: > Frank Cusack <fcusack(a)fcusack.com> wrote: >> Dunno if you didn't find time, or weren't able to reproduce it > > I couldn't bear the though of fighting with that crap again. > > Look at the code, it does the following: > > ... > strcat (tmp, archive_ext); > errors = try_dlopen (&handle, tmp); > if (errors) return 0; > > /* If we found FILENAME, stop searching -- whether we were able to > load the file as a module or not. If the file exists but loading > failed, it is better to return an error message here than to > report FILE_NOT_FOUND when the alternatives (foo.so etc) are not > in the module search path. */ > if (handle || ((errors > 0) && !file_not_found ())) > { > LT_DLFREE (tmp); > return handle; > } > ... > > Note that if (errors > 0) AND the file was found, it returns the > handle. i.e. It finds the CURRENT library, but not one that the > current library needs. > > The idea of returning the handle if (errors > 0) is something that > is mind-blowingly retarded. If the file was found, but errors > 0, handle is supposed to be NULL. I couldn't find a case (from inspection) where this isn't true. Dependencies are loaded before the library itself is loaded (if there is a .la file and dependencies are known), and if this fails handle is returned as NULL. If dependencies are not known, the system dlopen() is used which will implicitly load dependencies, and again, fail and return NULL if a dependency cannot be loaded. Apparently, it CAN happen that handle is not NULL, but I have to assume that this line of code doesn't think that can happen. (Because of course, it is a pretty bad idea to return a non-NULL handle on failure, and ltdl is obviously not written by idiots.) You can't just read this one line of code and say "handle is returned!", you have to look at what is expected from try_dlopen(). >> But anyway, it looks easy to address in freeradius (as opposed to >> ltdl.c) so I'm going to try that. > > I don't see how. The problem is that the handle is returned, but is > NOT completely populated. So ltdl_sym() de-references a NULL entry in > the handle, and dies. > > Since the handle structure is opaque, it's impossible for FreeRADIUS > to know if the returned handle is OK, is is broken. So I have no idea > how you would handle this in FreeRADIUS. Bah. I didn't realize lt_dlhandle was opaque (because how does gdb know what it looks like). phooey. OK, we'll need to patch ltdl.c, but otherwise (ie autoconf stuff) we can still get away with untouched original source. -frank

5 11

bug report
by Joao Marcelo Ceron 25 Jun '06

25 Jun '06

Hello, We have tested 802.1X with eap/ttls/mschapv2 using freeradius. Every things works fine with Cisco, but, when we tested the solution with extreme networks products (Alpine3804 and summit48si) the solution did not work as expected. Apparently, the problem is a different RFC interpretation. The EAP implemented in freeradius make a unnecessary check in handle->identity variable. So we build a path for freeradius (only taking off some lines;-). Please , consider that change to next version. Joao Marcelo Ceron Leandro Bertholdo +++ eap.patch.c Sun Jun 25 21:04:58 2006 @@ -1046,13 +1046,18 @@ * request as the NAS is doing something * funny. */ - if (strncmp(handler->identity, vp->strvalue, - MAX_STRING_LEN) != 0) { - radlog(L_ERR, "rlm_eap: Identity does not match User-Name. Authentication failed."); - free(*eap_packet_p); - *eap_packet_p = NULL; - return NULL; - } + + // Commented here <Leandro Bertholdo/Joao Marcelo Ceron> + + // Changed by <Leandro Bertholdo/Joao Marcelo Ceron> + /* if (strncmp(handler->identity, vp->strvalue, + * MAX_STRING_LEN) != 0) { + * radlog(L_ERR, "rlm_eap: Identity does not match User-Name. Authentication failed."); + * free(*eap_packet_p); + * *eap_packet_p = NULL; + * return NULL; + *} + */ } } else { /* packet was EAP identity */ handler = eap_handler_alloc(); @@ -1101,14 +1106,17 @@ * identity, the NAS is doing something * funny, so reject the request. */ - if (strncmp(handler->identity, vp->strvalue, - MAX_STRING_LEN) != 0) { - radlog(L_ERR, "rlm_eap: Identity does not match User-Name, setting from EAP Identity."); - free(*eap_packet_p); - *eap_packet_p = NULL; - eap_handler_free(handler); - return NULL; - } + + // Changed by <Leandro Bertholdo/Joao Marcelo Ceron> + /* if (strncmp(handler->identity, vp->strvalue, + * MAX_STRING_LEN) != 0) { + * radlog(L_ERR, "rlm_eap: Identity does not match User-Name, setting from EAP Identity."); + * free(*eap_packet_p); + * *eap_packet_p = NULL; + * eap_handler_free(handler);

2 2

Automatic report from sources (radiusd) between 22.06.2006 - 23.06.2006 GMT
by Automatic cvs log generator 23 Jun '06

23 Jun '06

CVS log entries from 22.06.2006 (Thu) 08:00:00 - 23.06.2006 (Fri) 08:00:01 GMT ===================================================== Summary by authors ===================================================== Author: fcusack File: radiusd/libltdl/config-h.in; Revisions: 1.1.10.1 File: radiusd/libltdl/acconfig.h; Revisions: 1.1.10.1 File: radiusd/libltdl/config.h.in; Revisions: 1.1.10.1 File: radiusd/configure.in; Revisions: 1.198.2.15.2.8 File: radiusd/libltdl/configure.ac; Revisions: 1.1, 1.1.2.1 File: radiusd/Make.inc.in; Revisions: 1.48.4.2 File: radiusd/libltdl/acinclude.m4; Revisions: 1.2.10.1 File: radiusd/doc/ChangeLog; Revisions: 1.57.2.31.2.25, 1.57.2.31.2.24 File: radiusd/ltmain.sh; Revisions: 1.3.6.1 File: radiusd/libltdl/missing; Revisions: 1.1.2.2 File: radiusd/libltdl/Makefile.am; Revisions: 1.3.10.1 File: radiusd/libltdl/aclocal.m4; Revisions: 1.2.10.1 File: radiusd/libltdl/COPYING.LIB; Revisions: 1.1.10.1 File: radiusd/libltdl/stamp-h.in; Revisions: 1.1.10.1 File: radiusd/libltdl/install-sh; Revisions: 1.1.2.2 File: radiusd/libltdl/ltdl.c; Revisions: 1.5.4.3, 1.5.4.2 File: radiusd/libltdl/configure; Revisions: 1.2.8.1.2.1 File: radiusd/libltdl/Makefile.in; Revisions: 1.6.10.1 File: radiusd/libltdl/ltdl.h; Revisions: 1.2.10.2, 1.2.10.1 File: radiusd/libltdl/configure.in; Revisions: 1.2.10.1 File: radiusd/aclocal.m4; Revisions: 1.24.2.2.2.3 File: radiusd/Makefile; Revisions: 1.44.2.2.2.3 File: radiusd/libltdl/config.guess; Revisions: 1.1.2.2 File: radiusd/configure; Revisions: 1.95.2.12.2.6 File: radiusd/libltdl/ltmain.sh; Revisions: 1.1.2.2 File: radiusd/libltdl/config.sub; Revisions: 1.1.2.2 File: radiusd/libtool.m4; Revisions: 1.1, 1.1.2.1 File: radiusd/libltdl/README; Revisions: 1.1.10.1 Author: nbk File: radiusd/dialup_admin/bin/truncate_radacct; Revisions: 1.7.4.1 File: radiusd/dialup_admin/bin/monthly_tot_stats; Revisions: 1.6.4.1 File: radiusd/dialup_admin/Changelog; Revisions: 1.195.4.3 File: radiusd/dialup_admin/bin/log_badlogins; Revisions: 1.21.4.1 File: radiusd/dialup_admin/bin/clean_radacct; Revisions: 1.7.4.1 ===================================================== Combined list of identical log entries ===================================================== Description: update libtool and libltdl to 1.5.22, and improve the integration by not requiring source modification (except for one change to ltdl.c [for a bug] to follow) Modified files: File: radiusd/Make.inc.in; Revision: 1.48.4.2; Date: 2006/06/23 04:31:58; Author: fcusack; Lines: (+3 -3) File: radiusd/Makefile; Revision: 1.44.2.2.2.3; Date: 2006/06/23 04:31:58; Author: fcusack; Lines: (+6 -2) File: radiusd/aclocal.m4; Revision: 1.24.2.2.2.3; Date: 2006/06/23 04:31:58; Author: fcusack; Lines: (+4 -3611) File: radiusd/configure; Revision: 1.95.2.12.2.6; Date: 2006/06/23 04:32:00; Author: fcusack; Lines: (+21808 -5953) File: radiusd/configure.in; Revision: 1.198.2.15.2.8; Date: 2006/06/23 04:32:13; Author: fcusack; Lines: (+9 -17) File: radiusd/libtool.m4; Revision: 1.1.2.1; Date: 2006/06/23 04:32:13; Author: fcusack; Lines: (+6397 -0) File: radiusd/ltmain.sh; Revision: 1.3.6.1; Date: 2006/06/23 04:32:14; Author: fcusack; Lines: (+2790 -915) File: radiusd/doc/ChangeLog; Revision: 1.57.2.31.2.24; Date: 2006/06/23 04:32:16; Author: fcusack; Lines: (+6 -3) File: radiusd/libltdl/COPYING.LIB; Revision: 1.1.10.1; Date: 2006/06/23 04:32:16; Author: fcusack; Lines: (+2 -2) File: radiusd/libltdl/Makefile.am; Revision: 1.3.10.1; Date: 2006/06/23 04:32:17; Author: fcusack; Lines: (+2 -18) File: radiusd/libltdl/Makefile.in; Revision: 1.6.10.1; Date: 2006/06/23 04:32:17; Author: fcusack; Lines: (+505 -312) File: radiusd/libltdl/README; Revision: 1.1.10.1; Date: 2006/06/23 04:32:17; Author: fcusack; Lines: (+1 -0) File: radiusd/libltdl/acconfig.h; Revision: 1.1.10.1; Date: 2006/06/23 04:32:17; Author: fcusack; Lines: (+0 -0) File: radiusd/libltdl/acinclude.m4; Revision: 1.2.10.1; Date: 2006/06/23 04:32:18; Author: fcusack; Lines: (+5843 -2926) File: radiusd/libltdl/aclocal.m4; Revision: 1.2.10.1; Date: 2006/06/23 04:32:19; Author: fcusack; Lines: (+677 -4180) File: radiusd/libltdl/config-h.in; Revision: 1.1.10.1; Date: 2006/06/23 04:32:20; Author: fcusack; Lines: (+130 -87) File: radiusd/libltdl/config.guess; Revision: 1.1.2.2; Date: 2006/06/23 04:32:20; Author: fcusack; Lines: (+1471 -0) File: radiusd/libltdl/config.h.in; Revision: 1.1.10.1; Date: 2006/06/23 04:32:21; Author: fcusack; Lines: (+0 -0) File: radiusd/libltdl/config.sub; Revision: 1.1.2.2; Date: 2006/06/23 04:32:21; Author: fcusack; Lines: (+1599 -0) File: radiusd/libltdl/configure; Revision: 1.2.8.1.2.1; Date: 2006/06/23 04:32:21; Author: fcusack; Lines: (+21384 -5429) File: radiusd/libltdl/configure.ac; Revision: 1.1.2.1; Date: 2006/06/23 04:32:25; Author: fcusack; Lines: (+79 -0) File: radiusd/libltdl/configure.in; Revision: 1.2.10.1; Date: 2006/06/23 04:32:26; Author: fcusack; Lines: (+0 -0) File: radiusd/libltdl/install-sh; Revision: 1.1.2.2; Date: 2006/06/23 04:32:26; Author: fcusack; Lines: (+401 -0) File: radiusd/libltdl/ltdl.c; Revision: 1.5.4.2; Date: 2006/06/23 04:32:26; Author: fcusack; Lines: (+677 -127) File: radiusd/libltdl/ltdl.h; Revision: 1.2.10.1; Date: 2006/06/23 04:32:27; Author: fcusack; Lines: (+39 -34) File: radiusd/libltdl/ltmain.sh; Revision: 1.1.2.2; Date: 2006/06/23 04:32:28; Author: fcusack; Lines: (+6863 -0) File: radiusd/libltdl/missing; Revision: 1.1.2.2; Date: 2006/06/23 04:32:29; Author: fcusack; Lines: (+353 -0) File: radiusd/libltdl/stamp-h.in; Revision: 1.1.10.1; Date: 2006/06/23 04:32:29; Author: fcusack; Lines: (+0 -0) ------------------------------- Description: try_dlopen() has a bug: it sometimes returns a handle if a dependency library can't be loaded. It also returns an error status, however lt_dlopenext() doesn't handle this well and returns the invalid handle. This causes a segfault instead of a graceful exit. Update ltdl to give an error telling the user to report the problem, so that we can try to reproduce it and report to the libtool folks. We could just leave ltdl unpatched; FR will exit either way. Modified files: File: radiusd/libltdl/ltdl.c; Revision: 1.5.4.3; Date: 2006/06/23 04:55:50; Author: fcusack; Lines: (+8 -0) File: radiusd/libltdl/ltdl.h; Revision: 1.2.10.2; Date: 2006/06/23 04:55:51; Author: fcusack; Lines: (+2 -1) ------------------------------- Description: Test for unset variable, rather than empty variable in clean_radacct, monthly_tot_stats and truncate_radacct. http://bugs.debian.org/374053 Thanks to Rudy Godoy <rudy(a)kernel-panik.org> and Stephen Gran <sgran(a)debian.org>. Modified files: File: radiusd/dialup_admin/Changelog; Revision: 1.195.4.3; Date: 2006/06/22 08:46:00; Author: nbk; Lines: (+4 -0) File: radiusd/dialup_admin/bin/clean_radacct; Revision: 1.7.4.1; Date: 2006/06/22 08:46:00; Author: nbk; Lines: (+1 -1) File: radiusd/dialup_admin/bin/log_badlogins; Revision: 1.21.4.1; Date: 2006/06/22 08:46:00; Author: nbk; Lines: (+1 -1) File: radiusd/dialup_admin/bin/monthly_tot_stats; Revision: 1.6.4.1; Date: 2006/06/22 08:46:01; Author: nbk; Lines: (+1 -1) File: radiusd/dialup_admin/bin/truncate_radacct; Revision: 1.7.4.1; Date: 2006/06/22 08:46:01; Author: nbk; Lines: (+1 -1) ===================================================== Log entries ===================================================== Description: note libltdl patch Modified files: File: radiusd/doc/ChangeLog; Revision: 1.57.2.31.2.25; Date: 2006/06/23 04:57:51; Author: fcusack; Lines: (+3 -3) ------------------------------- Description: file configure.ac was initially added on branch branch_1_1. Modified files: File: radiusd/libltdl/configure.ac; Revision: 1.1; Date: 2006/06/23 04:32:25; Author: fcusack; ------------------------------- Description: file libtool.m4 was initially added on branch branch_1_1. Modified files: File: radiusd/libtool.m4; Revision: 1.1; Date: 2006/06/23 04:32:13; Author: fcusack; ===================================================== Summary of modified files ===================================================== File: radiusd/Make.inc.in Revisions: 1.48.4.2 Authors: fcusack (+3 -3) ------------------------------- File: radiusd/Makefile Revisions: 1.44.2.2.2.3 Authors: fcusack (+6 -2) ------------------------------- File: radiusd/aclocal.m4 Revisions: 1.24.2.2.2.3 Authors: fcusack (+4 -3611) ------------------------------- File: radiusd/configure Revisions: 1.95.2.12.2.6 Authors: fcusack (+21808 -5953) ------------------------------- File: radiusd/configure.in Revisions: 1.198.2.15.2.8 Authors: fcusack (+9 -17) ------------------------------- File: radiusd/dialup_admin/Changelog Revisions: 1.195.4.3 Authors: nbk (+4 -0) ------------------------------- File: radiusd/dialup_admin/bin/clean_radacct Revisions: 1.7.4.1 Authors: nbk (+1 -1) ------------------------------- File: radiusd/dialup_admin/bin/log_badlogins Revisions: 1.21.4.1 Authors: nbk (+1 -1) ------------------------------- File: radiusd/dialup_admin/bin/monthly_tot_stats Revisions: 1.6.4.1 Authors: nbk (+1 -1) ------------------------------- File: radiusd/dialup_admin/bin/truncate_radacct Revisions: 1.7.4.1 Authors: nbk (+1 -1) ------------------------------- File: radiusd/doc/ChangeLog Revisions: 1.57.2.31.2.25, 1.57.2.31.2.24 Authors: fcusack (+3 -3), fcusack (+6 -3) ------------------------------- File: radiusd/libltdl/COPYING.LIB Revisions: 1.1.10.1 Authors: fcusack (+2 -2) ------------------------------- File: radiusd/libltdl/Makefile.am Revisions: 1.3.10.1 Authors: fcusack (+2 -18) ------------------------------- File: radiusd/libltdl/Makefile.in Revisions: 1.6.10.1 Authors: fcusack (+505 -312) ------------------------------- File: radiusd/libltdl/README Revisions: 1.1.10.1 Authors: fcusack (+1 -0) ------------------------------- File: radiusd/libltdl/acconfig.h Revisions: 1.1.10.1 Authors: fcusack (+0 -0) ------------------------------- File: radiusd/libltdl/acinclude.m4 Revisions: 1.2.10.1 Authors: fcusack (+5843 -2926) ------------------------------- File: radiusd/libltdl/aclocal.m4 Revisions: 1.2.10.1 Authors: fcusack (+677 -4180) ------------------------------- File: radiusd/libltdl/config-h.in Revisions: 1.1.10.1 Authors: fcusack (+130 -87) ------------------------------- File: radiusd/libltdl/config.guess Revisions: 1.1.2.2 Authors: fcusack (+1471 -0) ------------------------------- File: radiusd/libltdl/config.h.in Revisions: 1.1.10.1 Authors: fcusack (+0 -0) ------------------------------- File: radiusd/libltdl/config.sub Revisions: 1.1.2.2 Authors: fcusack (+1599 -0) ------------------------------- File: radiusd/libltdl/configure Revisions: 1.2.8.1.2.1 Authors: fcusack (+21384 -5429) ------------------------------- File: radiusd/libltdl/configure.ac Revisions: 1.1, 1.1.2.1 Authors: fcusack, fcusack (+79 -0) ------------------------------- File: radiusd/libltdl/configure.in Revisions: 1.2.10.1 Authors: fcusack (+0 -0) ------------------------------- File: radiusd/libltdl/install-sh Revisions: 1.1.2.2 Authors: fcusack (+401 -0) ------------------------------- File: radiusd/libltdl/ltdl.c Revisions: 1.5.4.3, 1.5.4.2 Authors: fcusack (+8 -0), fcusack (+677 -127) ------------------------------- File: radiusd/libltdl/ltdl.h Revisions: 1.2.10.2, 1.2.10.1 Authors: fcusack (+2 -1), fcusack (+39 -34) ------------------------------- File: radiusd/libltdl/ltmain.sh Revisions: 1.1.2.2 Authors: fcusack (+6863 -0) ------------------------------- File: radiusd/libltdl/missing Revisions: 1.1.2.2 Authors: fcusack (+353 -0) ------------------------------- File: radiusd/libltdl/stamp-h.in Revisions: 1.1.10.1 Authors: fcusack (+0 -0) ------------------------------- File: radiusd/libtool.m4 Revisions: 1.1, 1.1.2.1 Authors: fcusack, fcusack (+6397 -0) ------------------------------- File: radiusd/ltmain.sh Revisions: 1.3.6.1 Authors: fcusack (+2790 -915) -- Automatic cron job from /web/pages/us.freeradius.org/bin/new_makelog.pl

1 0

Patch for dialupadmin
by Stephen Gran 22 Jun '06

22 Jun '06

Hello all, It looks like I am going to be doing some work with freeradius for Debian. So, I just wanted to say hello, and send along a patch. This fixes a bug when the variable in question is actually NULL, rather than just empty. Thanks, --- dialup_admin/bin/clean_radacct +++ dialup_admin/bin/clean_radacct @@ -28,7 +28,7 @@ die "sql_command directive is not set in admin.conf\n" if ($sqlcmd eq ''); die "Could not find sql binary. Please make sure that the \$sqlcmd variable points to the right location\n" if (! -x $sqlcmd); -$sql_password = ($sql_password eq '') ? '' : "-p$sql_password"; +$sql_password = (!$sql_password) ? '' : "-p$sql_password"; ($sec,$min,$hour,$mday,$mon,$year,$wday,$yday,$isdst) = localtime; $date = POSIX::strftime("%Y-%m-%d %T",$sec,$min,$hour,($mday - $back_days),$mon,$year,$wday,$yday,$isdst); --- dialup_admin/bin/log_badlogins +++ dialup_admin/bin/log_badlogins @@ -93,7 +93,7 @@ $realm_del = '@' if ($realm_del eq ''); $realm_for = 'suffix' if ($realm_for eq ''); -$pass = ($sql_password ne '') ? "-p$sql_password" : ''; +$pass = (!$sql_password) ? '' : "-p$sql_password"; die "SQL server not defined\n" if ($sql_server eq ''); die "sql_command directive is not set in admin.conf\n" if ($sqlcmd eq ''); --- dialup_admin/bin/truncate_radacct +++ dialup_admin/bin/truncate_radacct @@ -28,7 +28,7 @@ die "sql_command directive is not set in admin.conf\n" if ($sqlcmd eq ''); die "Could not find sql binary. Please make sure that the \$sqlcmd variable points to the right location\n" if (! -x $sqlcmd); -$sql_password = ($sql_password eq '') ? '' : "-p$sql_password"; +$sql_password = (!$sql_password) ? '' : "-p$sql_password"; ($sec,$min,$hour,$mday,$mon,$year,$wday,$yday,$isdst) = localtime; $date = POSIX::strftime("%Y-%m-%d %T",$sec,$min,$hour,($mday - $back_days),$mon,$year,$wday,$yday,$isdst); --- dialup_admin/bin/monthly_tot_stats +++ dialup_admin/bin/monthly_tot_stats @@ -29,7 +29,7 @@ die "sql_command directive is not set in admin.conf\n" if ($sqlcmd eq ''); die "Could not find sql binary. Please make sure that the \$sqlcmd variable points to the right location\n" if (! -x $sqlcmd); -$sql_password = ($sql_password == '') ? '' : "-p$sql_password"; +$sql_password = (!$sql_password) ? '' : "-p$sql_password"; ($sec,$min,$hour,$mday,$mon,$year,$wday,$yday,$isdst) = localtime; if ($mday == 1){ -- -------------------------------------------------------------------------- | Stephen Gran | Why isn't there some cheap and easy way | | steve(a)lobefin.net | to prove how much she means to me? | | http://www.lobefin.net/~steve | | --------------------------------------------------------------------------

2 1