August 2007 - Freeradius-Devel - lists.freeradius.org

Logging to file stops before modules are detached
by Enrik Berkhan 10 Aug '07

10 Aug '07

Hi, when logging to file, logging stops before modules get detached. AFAICS, this happens because the log file name stored in mainconfig.log_file gets free()d before modules get detached. In effect, modules can't log anything to a log file while detaching. A small test case using rlm_perl is: radiusd.conf: ... modules { perl test { module = ${raddbdir}/test.pl } } ... authorize { test } ... test.pl: END { radiusd::radlog(3, 'ENDing...'); } While running in debug mode, the perl END section will happily log its ENDing... line to stdout. When running in daemon mode and logging to file, these lines will never appear in the file. I haven't found a clean solution for this problem but tested a very ugly hack to confirm that logging to file will keep working when mainconfig.log_file isn't free()d: Index: src/main/conffile.c =================================================================== RCS file: /source/radiusd/src/main/conffile.c,v retrieving revision 1.176 diff -u -r1.176 conffile.c --- src/main/conffile.c 4 Jul 2007 05:54:17 -0000 1.176 +++ src/main/conffile.c 10 Aug 2007 09:36:48 -0000 @@ -307,8 +307,10 @@ p = (char **) (((char *)base) + variables[i].offset); } - free(*p); - *p = NULL; + if (*p != mainconfig.log_file) { + free(*p); + *p = NULL; + } } } Has anybody any suggestions for a clean solution? Enrik

1 0

Automatic report from sources (radiusd) between 09.08.2007 - 10.08.2007 GMT
by Automatic cvs log generator 10 Aug '07

10 Aug '07

CVS log entries from 09.08.2007 (Thu) 08:00:00 - 10.08.2007 (Fri) 08:00:00 GMT ===================================================== Summary by authors ===================================================== Author: aland File: radiusd/src/main/evaluate.c; Revisions: 1.25 ===================================================== Log entries ===================================================== Description: Corrected typo Modified files: File: radiusd/src/main/evaluate.c; Revision: 1.25; Date: 2007/08/09 13:01:52; Author: aland; Lines: (+3 -3) ===================================================== Summary of modified files ===================================================== File: radiusd/src/main/evaluate.c Revisions: 1.25 Authors: aland (+3 -3) -- Automatic cron job from /web/pages/us.freeradius.org/bin/new_makelog.pl

1 0

Problem with setting substring match variables (%{1} etc.)
by Enrik Berkhan 09 Aug '07

09 Aug '07

Hi, there seems to be a subtle problem with setting the substring match variables like %{1} etc. when an optionally matching subexpression does not match, but the expression as a whole does. Example: The expression ^(a|b)?(.)$ will match for example 'ax', 'bx', and 'x'. The first two cases will work like expected setting %{1} = 'a', %{2} = 'x' and so on. In the last case, the first substring is actually empty with rxmatch[1].rm_so == -1, but the second substring contains 'x' (rxmatch[2].rm_so == 0, rxmatch[2].rm_eo == 1). The code setting the substring match variables stops on the first rxmatch[].rm_so == -1 unless the variable has an old value(?), so %{2} might be never set in the last example. Is this expected behaviour? If not, how can this be fixed? Just leave out the 'break' in the for loop? (Code from valuepair.c) > /* > * Add %{0}, %{1}, etc. > */ > for (i = 0; i <= REQUEST_MAX_REGEX; i++) { > char *p; > char buffer[sizeof(check->vp_strvalue)]; > > /* > * Didn't match: delete old > * match, if it existed. > */ > if ((compare != 0) || > (rxmatch[i].rm_so == -1)) { > p = request_data_get(request, request, > REQUEST_DATA_REGEX | i); > if (p) { > free(p); > continue; > } > > /* > * No previous match > * to delete, stop. > */ > break; > } > ...; > } Enrik

3 8

Automatic report from sources (radiusclient) between 07.08.2007 - 08.08.2007 GMT
by Automatic cvs log generator 08 Aug '07

08 Aug '07

CVS log entries from 07.08.2007 (Tue) 07:00:01 - 08.08.2007 (Wed) 07:00:00 GMT ===================================================== Summary by authors ===================================================== Author: cparker File: radiusclient/include/freeradius-client.h; Revisions: 1.8 File: radiusclient/lib/sendserver.c; Revisions: 1.24 ===================================================== Combined list of identical log entries ===================================================== Description: More type cleanups: u_char -> uint8_t u_short -> uint16_t Modified files: File: radiusclient/include/freeradius-client.h; Revision: 1.8; Date: 2007/08/07 14:26:29; Author: cparker; Lines: (+13 -13) File: radiusclient/lib/sendserver.c; Revision: 1.24; Date: 2007/08/07 14:26:29; Author: cparker; Lines: (+3 -4) ===================================================== Log entries ===================================================== ===================================================== Summary of modified files ===================================================== File: radiusclient/include/freeradius-client.h Revisions: 1.8 Authors: cparker (+13 -13) ------------------------------- File: radiusclient/lib/sendserver.c Revisions: 1.24 Authors: cparker (+3 -4) -- Automatic cron job from /web/pages/us.freeradius.org/bin/rc-new_makelog.pl

1 0

NAS-Port or NAS-Port-Id change of type request
by Toledo, Luis Carlos 07 Aug '07

07 Aug '07

Is it possible to change de NAS-Port (or NAS-Port-Id) variable to string ? The moderns NASs send null/fixed value or another unique key for NAS-Port. This way is impossible to send dynamic ips using rlm_ippool for sample. Can anyone make this change or help me to make this? Thank you! Toledo, Luis Carlos

1 0

Error: FATAL Failed to initialize semaphore: Function not implemented
by Arran Cudbard-Bell 06 Aug '07

06 Aug '07

Hi, Haven't built a new copy of the server for a while, as I was mostly debugging config stuff. When I have built a new copy of the server from CVS i've always ran it in full foreground debugging mode which disables threads... Which is why I don't know exactly when the commit that causes this was done ... In Full debugging mode radiusd -X is fine However running in daemon mode with debugging on I get: Thu Aug 2 12:15:22 2007 : Debug: } Thu Aug 2 12:15:22 2007 : Debug: Initializing the thread pool... Thu Aug 2 12:15:22 2007 : Debug: thread pool { Thu Aug 2 12:15:22 2007 : Debug: start_servers = 5 Thu Aug 2 12:15:22 2007 : Debug: max_servers = 32 Thu Aug 2 12:15:22 2007 : Debug: min_spare_servers = 3 Thu Aug 2 12:15:22 2007 : Debug: max_spare_servers = 10 Thu Aug 2 12:15:22 2007 : Debug: max_requests_per_server = 20 Thu Aug 2 12:15:22 2007 : Debug: cleanup_delay = 5 Thu Aug 2 12:15:22 2007 : Debug: max_queue_size = 65536 Thu Aug 2 12:15:22 2007 : Debug: } Thu Aug 2 12:15:22 2007 : Error: FATAL: Failed to initialize semaphore: Function not implemented At which point GDB reports that the program exited normally, and so won't give me the backtrace of the stack. *sigh* According to my colleague (who has now gone off on holiday) : "there's an issue to do with the way semaphores are implemented on OS X (basically, you can't use "unnamed" ones -- there's a very old thread about this in the freeradius-users list from 2004, with workarounds). I'm guessing that there's something wrong in the "configure" for OS X, meaning that it isn't using the right flavour of semaphore initialisation, OR that 2.0 has a regression to the previous problem that was fixed in 1.x" Any chance someone could take a look at this ? Be happy to provide any extra information required. Thanks, Arran

3 15

Automatic report from sources (radiusd) between 05.08.2007 - 06.08.2007 GMT
by Automatic cvs log generator 06 Aug '07

06 Aug '07

CVS log entries from 05.08.2007 (Sun) 08:00:00 - 06.08.2007 (Mon) 08:00:00 GMT ===================================================== Summary by authors ===================================================== Author: aland File: radiusd/Makefile; Revisions: 1.51 File: radiusd/configure.in; Revisions: 1.247 File: radiusd/configure; Revisions: 1.134 ===================================================== Combined list of identical log entries ===================================================== Description: Add Apple stuff Modified files: File: radiusd/configure; Revision: 1.134; Date: 2007/08/05 23:38:44; Author: aland; Lines: (+7 -1) File: radiusd/configure.in; Revision: 1.247; Date: 2007/08/05 23:38:46; Author: aland; Lines: (+2 -1) ===================================================== Log entries ===================================================== Description: We no longer have acconfig.h Modified files: File: radiusd/Makefile; Revision: 1.51; Date: 2007/08/05 23:37:31; Author: aland; Lines: (+3 -3) ===================================================== Summary of modified files ===================================================== File: radiusd/Makefile Revisions: 1.51 Authors: aland (+3 -3) ------------------------------- File: radiusd/configure Revisions: 1.134 Authors: aland (+7 -1) ------------------------------- File: radiusd/configure.in Revisions: 1.247 Authors: aland (+2 -1) -- Automatic cron job from /web/pages/us.freeradius.org/bin/new_makelog.pl

1 0

Assertion on cvs head
by Stephan Jaeger 06 Aug '07

06 Aug '07

Hello, running latest CVS head i get an: Assertion failed in threads.c, line 540 After the second request. In debug mode (-X) everything is running fine. Regards Stephan Jaeger -- Mit freundlichen Grüßen i.A. Stephan Jäger Abteilung Dienste Telefon: (0441) 8000-2873 Telefax: (0441) 8000-2799 mailto:stephan.jaeger@ewetel.de ___________________________________ EWE TEL GmbH Cloppenburger Straße 310 26133 Oldenburg Handelsregister Amtsgericht Oldenburg HRB 3723 Vorsitzender des Aufsichtsrates: Heiko Harms Geschäftsführung: Hans-Joachim Iken, Dirk Thole, Jürgen Wehlend Homepage: http://www.ewetel.de ___________________________________

2 6

Automatic report from sources (radiusd) between 03.08.2007 - 04.08.2007 GMT
by Automatic cvs log generator 04 Aug '07

04 Aug '07

CVS log entries from 03.08.2007 (Fri) 08:00:01 - 04.08.2007 (Sat) 08:00:01 GMT ===================================================== Summary by authors ===================================================== Author: aland File: radiusd/src/modules/rlm_mschap/opendir.c; Revisions: 1.2, 1.1 File: radiusd/src/main/threads.c; Revisions: 1.131, 1.130 File: radiusd/src/modules/rlm_mschap/Makefile; Revisions: 1.21 File: radiusd/src/include/missing.h; Revisions: 1.38 File: radiusd/src/modules/rlm_mschap/rlm_mschap.c; Revisions: 1.91, 1.90 ===================================================== Combined list of identical log entries ===================================================== Description: OpenDirectory support from Apple Inc. Their patch has it in rlm_mschap.c. We've placed it in a separate file to keep license and copyright issues clear. Modified files: File: radiusd/src/modules/rlm_mschap/Makefile; Revision: 1.21; Date: 2007/08/03 19:04:35; Author: aland; Lines: (+2 -2) File: radiusd/src/modules/rlm_mschap/opendir.c; Revision: 1.1; Date: 2007/08/03 19:04:36; Author: aland; File: radiusd/src/modules/rlm_mschap/rlm_mschap.c; Revision: 1.90; Date: 2007/08/03 19:04:36; Author: aland; Lines: (+23 -2) ===================================================== Log entries ===================================================== Description: Define DARWIN Modified files: File: radiusd/src/include/missing.h; Revision: 1.38; Date: 2007/08/03 19:12:42; Author: aland; Lines: (+7 -2) ------------------------------- Description: Set self->request to NULL before exiting Modified files: File: radiusd/src/main/threads.c; Revision: 1.131; Date: 2007/08/03 20:36:56; Author: aland; Lines: (+3 -2) ------------------------------- Description: Catch corner cases Modified files: File: radiusd/src/main/threads.c; Revision: 1.130; Date: 2007/08/03 19:51:49; Author: aland; Lines: (+12 -2) ------------------------------- Description: Patch was for 1.1.4, which has vp->strvalue. We now use vp->vp_strvalue. Modified files: File: radiusd/src/modules/rlm_mschap/opendir.c; Revision: 1.2; Date: 2007/08/03 20:16:38; Author: aland; Lines: (+13 -13) ------------------------------- Description: Whoops... forgot semi-colon Modified files: File: radiusd/src/modules/rlm_mschap/rlm_mschap.c; Revision: 1.91; Date: 2007/08/03 19:53:40; Author: aland; Lines: (+3 -3) ===================================================== Summary of modified files ===================================================== File: radiusd/src/include/missing.h Revisions: 1.38 Authors: aland (+7 -2) ------------------------------- File: radiusd/src/main/threads.c Revisions: 1.131, 1.130 Authors: aland (+3 -2), aland (+12 -2) ------------------------------- File: radiusd/src/modules/rlm_mschap/Makefile Revisions: 1.21 Authors: aland (+2 -2) ------------------------------- File: radiusd/src/modules/rlm_mschap/opendir.c Revisions: 1.2, 1.1 Authors: aland (+13 -13), aland ------------------------------- File: radiusd/src/modules/rlm_mschap/rlm_mschap.c Revisions: 1.91, 1.90 Authors: aland (+3 -3), aland (+23 -2) -- Automatic cron job from /web/pages/us.freeradius.org/bin/new_makelog.pl

1 0

Duplicate clients
by Stephan Jaeger 03 Aug '07

03 Aug '07

Hello, if you have duplicate clients in clients.conf/sql, there is few output from the server just a "Failed to add client %s". The attached patch also logs an "Duplicate client ip: 1.2.3.4 (foobar)" to L_ERR. In case of a failure in client_add() rlm_sql does only log "generate_sql_clients() returned error". The attached patch also logs "rlm_sql (%s): Failed to add client foobar" like the config parser does. Regards Stephan Jaeger -- Stephan Jaeger <stephan.jaeger(a)ewetel.de> EWE TEL GmbH

3 6