October 2009 - Freeradius-Devel - lists.freeradius.org

GIT Log for 2009-10-23 23:33 GMT
by aland＠deployingradius.com 23 Oct '09

23 Oct '09

commit 1700127c8a7150f57056495a2980fd132dafdb92 Author: Alan T. DeKok <aland(a)freeradius.org> Date: Fri Oct 23 11:37:44 2009 +0200 As posted to the list share/dictionary.huawei | 37 +++++++++++++++++++++++++++++++++++-- 1 files changed, 35 insertions(+), 2 deletions(-)

1 0

2.1.8 and 2.2.0
by Alan DeKok 23 Oct '09

23 Oct '09

Is it worth having two versions of the server? i.e. releasing 2.1.8 *and* 2.2.0 at the same time? The reason is that current "stable" branch contains some fairly major changes (TCP), and more are on the way. The next things involve changing the internal API, which pretty much mandates a 2.2.0. However, there are also a number of bug fixes which could go into 2.1.7 and any following release. The question then is, do we want to have BOTH: 2.1.8 = 2.1.7 + bug fixes ONLY 2.2.0 = major new features + any fixes OR, do we want to give up on 2.1.8, and just release 2.2.0? There are pros and cons both ways. Having a stable 2.1.8 is good. But maintaining two versions could confuse people. Alan DeKok.

5 8

[PATCH] Add more attributes to share/dictionary.huawei
by Alexandr Kovalenko 23 Oct '09

23 Oct '09

Hello! This is patch against latest git revision of development branch to add few more Huawei vendor specific attributes. -- Alexandr Kovalenko http://uafug.org.ua/

2 1

GIT Log for 2009-10-21 23:33 GMT
by aland＠deployingradius.com 21 Oct '09

21 Oct '09

commit 8fa1a08726aad4f379c7bcc6df608f8d79594a34 Author: Alan T. DeKok <aland(a)freeradius.org> Date: Wed Oct 21 15:15:28 2009 +0200 Removed recursive mutexes. Some systems don't support recursive mutexes. Instead, they hang. So... we've got to re-write the code so that it doesn't depend on recursive mutexes. src/main/event.c | 137 ++++++++++++++++++++++-------------------------------- 1 files changed, 56 insertions(+), 81 deletions(-)

1 0

Detail listeners halt on invalid signature when proxying
by John Morrissey 21 Oct '09

21 Oct '09

We write all accounting to detail files, which is then picked up by detail listener(s) and proxied to remote hosts. Recently, one of the home servers in a load balanced pool was configured with the wrong secret, triggering this code in received_proxy_response(): if (rad_verify(packet, request->proxy, request->home_server->secret) != 0) { DEBUG("Ignoring spoofed proxy reply. Signature is invalid"); return NULL; } Since the proxy response is ignored and detail_send() is never called, the detail listener stays in STATE_RUNNING. detail_recv() short-circuits during STATE_RUNNING, so the failed request is never retransmitted and all detail processing for that listener halts until FreeRADIUS is restarted. When received_proxy_response() is modified to fall through (instead of returning NULL) for detail listeners, rad_accounting() overrides request->reply->code, setting it to PW_ACCOUNTING_RESPONSE. When detail_send() is called, there's no way for it to tell that the request hasn't been processed successfully. It skips the current detail entry and continues processing. Adding more state information to the request to inform rad_accounting()'s (or detail_send()'s) decision making seems kludgy. Maybe allow received_proxy_response() to override the handler function (pfun in proxy_socket_recv()) to avoid rad_accounting() in this case? Alan, any feedback on your desired way to do this? john -- John Morrissey _o /\ ---- __o jwm(a)horde.net _-< \_ / \ ---- < \, www.horde.net/ __(_)/_(_)________/ \_______(_) /_(_)__

2 2

GIT Log for 2009-10-20 23:33 GMT
by aland＠deployingradius.com 20 Oct '09

20 Oct '09

commit d9dd62aae7baa5346f19236cead4414c03546d45 Author: Alan T. DeKok <aland(a)freeradius.org> Date: Tue Oct 20 16:28:58 2009 +0200 Conf for debugging Files changed: raddb/debug.conf | 10 ++++++++++ 1 files changed, 10 insertions(+), 0 deletions(-) ====================================================================== commit b853a84e6c4ccd5d9e2c4ad9da2c421a234e887f Author: Alan T. DeKok <aland(a)freeradius.org> Date: Tue Oct 20 16:07:18 2009 +0200 Fix openssl checks Files changed: configure.in | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) ====================================================================== commit 6a6d2b450fd7ddff65e9f73bbe96ba3f5f914f08 Author: Alan T. DeKok <aland(a)freeradius.org> Date: Tue Oct 20 15:05:05 2009 +0200 Check src_port, not dst_port Files changed: src/lib/packet.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) ====================================================================== commit a6e46823d1756782b974257184e35d4e796c98a3 Author: Alan T. DeKok <aland(a)freeradius.org> Date: Tue Oct 20 15:03:54 2009 +0200 Always initialize proto Files changed: src/main/listen.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) ====================================================================== commit 817e64f14df0e5816d87784f995e8fc4a240e048 Author: Alan T. DeKok <aland(a)freeradius.org> Date: Tue Oct 20 15:03:20 2009 +0200 Initialize proto for old-style realms Files changed: src/main/realms.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) ====================================================================== commit 092f0ea30cdfc2d669afe47061fafb9407269641 Author: Alan T. DeKok <aland(a)freeradius.org> Date: Tue Oct 20 14:53:38 2009 +0200 Initialize via attr Files changed: src/main/event.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) ====================================================================== commit 98b22609015439b16cc62cf45e4472a14377da2a Author: Alan T. DeKok <aland(a)freeradius.org> Date: Tue Oct 20 12:14:36 2009 +0200 Retry if there was no response to the packet. Files changed: src/modules/frs_detail/frs_detail.c | 15 ++++++++++++--- 1 files changed, 12 insertions(+), 3 deletions(-) ====================================================================== commit 9b70af0c517daad7d374f4cc948488429d3a9cc0 Author: Alan T. DeKok <aland(a)freeradius.org> Date: Sun Oct 18 17:19:22 2009 +0200 Print env vars in parent, not child Files changed: src/main/exec.c | 141 +++++++++++++++++++++---------------------------------- 1 files changed, 53 insertions(+), 88 deletions(-) ======================================================================

1 0

GIT Log for 2009-10-18 23:33 GMT
by aland＠deployingradius.com 18 Oct '09

18 Oct '09

commit 5aa01c58d91063b5bbbf5aef941137d7cf638bbe Author: Alan T. DeKok <aland(a)freeradius.org> Date: Sun Oct 18 13:47:06 2009 +0200 Changed stop packet msg to debug rather than error Files changed: src/modules/rlm_sql/rlm_sql.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) ====================================================================== commit f2d96581f98990d24991c99a681d018a3df85e92 Author: Alan T. DeKok <aland(a)freeradius.org> Date: Sun Oct 18 09:04:36 2009 +0200 Define names Files changed: src/main/modcall.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) ====================================================================== commit 30adbf8230730a7503f5e3654df90c5c2a38a8ed Author: Alan T. DeKok <aland(a)freeradius.org> Date: Fri Oct 16 18:53:49 2009 +0200 Call detach only if function exists Files changed: src/modules/rlm_perl/rlm_perl.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) ======================================================================

1 0

Proxy port allocation failure
by Pavel Levshin 14 Oct '09

14 Oct '09

Hi all. When proxying some traffic, and when home server becomes unresponsive, after some time within timeout, freeradius fails to allocate new proxy socket with this message: Error: Failed binding to proxy address * port 5815: Address already in use Note that the base proxy address is 5814 in my case. Some requests gone through port 5815 before server had started complaining. Dump shows that total of 512 unresponded requests were sent, then the error occured. Attached is my patch for this problem. It corrects two separate mistakes, which in summary caused undesired behaviour. -- Pavel Levshin OJSC "Megafon" diff -ur freeradius-server-2.1.7/src/main/listen.c freeradius-server-2.1.7-patch/src/main/listen.c --- freeradius-server-2.1.7/src/main/listen.c 2009-09-14 18:43:29.000000000 +0400 +++ freeradius-server-2.1.7-patch/src/main/listen.c 2009-10-14 17:37:30.000000000 +0400 @@ -1701,7 +1701,7 @@ } if (sock->port > last_proxy_port) { - last_proxy_port = sock->port + 1; + last_proxy_port = sock->port; } if (!old) old = sock; @@ -1733,15 +1733,14 @@ /* * Keep going until we find an unused port. */ - for (port = last_proxy_port; port < 64000; port++) { + for (port = last_proxy_port + 1; port < 64000; port++) { int rcode; sock->port = port; rcode = listen_bind(this); if (rcode < 0) { - listen_free(&this); - return NULL; + continue; } /*

2 1

GIT Log for 2009-10-13 23:33 GMT
by aland＠deployingradius.com 13 Oct '09

13 Oct '09

commit b1e815d0b4bec01f9721d4b92786960b2218f149 Author: Alan T. DeKok <aland(a)freeradius.org> Date: Tue Oct 13 12:53:49 2009 +0200 Write the PID file as late as possible i.e. after checking the config, and after opening any sockets Files changed: src/main/radiusd.c | 48 ++++++++++++++++++++++++------------------------ 1 files changed, 24 insertions(+), 24 deletions(-) ====================================================================== commit a92700b3fb88239ccb0db9f5ece68dd430937df3 Author: Alan T. DeKok <aland(a)freeradius.org> Date: Tue Oct 13 12:52:12 2009 +0200 Fix typo Files changed: src/modules/rlm_eap/rlm_eap.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) ====================================================================== commit a4202aeb848174ed430fd29573e3dd2db78ae2a1 Author: Alexander Clouter <alex(a)digriz.org.uk> Date: Sat Oct 10 13:25:29 2009 +0100 fix debian/rules to honour CFLAGS Fixed up debian/rules to allow CFLAGS to be honoured. Signed-off-by: Alexander Clouter <alex(a)digriz.org.uk> Files changed: debian/rules | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) ======================================================================

1 0

[PATCH] fix debian/rules to honour CFLAGS
by Alexander Clouter 13 Oct '09

13 Oct '09

Fixed up debian/rules to allow CFLAGS to be honoured. Signed-off-by: Alexander Clouter <alex(a)digriz.org.uk> --- debian/rules | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/debian/rules b/debian/rules index 9de0214..702bec5 100755 --- a/debian/rules +++ b/debian/rules @@ -27,7 +27,7 @@ modulelist=krb5 ldap sql_mysql sql_iodbc sql_postgresql export DEB_HOST_GNU_TYPE ?= $(shell dpkg-architecture -qDEB_HOST_GNU_TYPE) export DEB_BUILD_GNU_TYPE ?= $(shell dpkg-architecture -qDEB_BUILD_GNU_TYPE) -export CFLAGS = -Wall -g +CFLAGS := $(CFLAGS) -Wall -g ifneq (,$(findstring noopt,$(DEB_BUILD_OPTIONS))) CFLAGS += -O0 @@ -35,6 +35,8 @@ else CFLAGS += -O2 endif +export CFLAGS + # Autoconf 2.52+ arch support ifeq ($(DEB_BUILD_GNU_TYPE), $(DEB_HOST_GNU_TYPE)) confflags += --build $(DEB_HOST_GNU_TYPE) -- 1.5.6.5

2 1