October 2009 - Freeradius-Devel - lists.freeradius.org

GIT Log for 2009-10-12 23:33 GMT
by aland＠deployingradius.com 12 Oct '09

12 Oct '09

commit fe4bf0a8d6d7e168e0c6729115df1315abbe5e20 Author: Alan T. DeKok <aland(a)freeradius.org> Date: Mon Oct 12 13:56:49 2009 +0200 Fix typo Files changed: src/main/listen.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) ====================================================================== commit 057c7ac764a4639f715edcbde7dc22491b79be62 Author: Alan T. DeKok <aland(a)freeradius.org> Date: Mon Oct 12 13:17:26 2009 +0200 Don't use source IP for EAP packets. We control State, so it should be unique, too Files changed: src/modules/rlm_eap/rlm_eap.c | 14 ++++++++++++-- 1 files changed, 12 insertions(+), 2 deletions(-) ====================================================================== commit d711a368ebf0e057e54596d22584ca2ce37e209c Author: Alan T. DeKok <aland(a)freeradius.org> Date: Mon Oct 12 13:14:09 2009 +0200 Make client/port/key-balance more like fail-over Previously, they would default to load-balancing across all found servers. Now they don't. This makes keyed-balance proxying more robust with EAP Files changed: src/main/realms.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) ====================================================================== commit 12ead56dffca9b3ecddc8a7860a1ef5b5361b374 Author: Alan T. DeKok <aland(a)freeradius.org> Date: Mon Oct 12 12:14:09 2009 +0200 Return rather than use the same ptr twice Files changed: src/modules/rlm_sql/rlm_sql.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) ======================================================================

1 0

Fix to CISCO_ACCOUNTING_HACK
by Pavel Levshin 12 Oct '09

12 Oct '09

Hi all. We had some random crashes while processing ~600 RPS of accounting with freeradius 2.1.7 and rlm_sql (MySQL). Coredumps showed that crashes occurs mostly in MySQL library. MySQL handle was used twice by different threads. Problem is so simple that I wonder why it has not been catched long ago. Here comes a patch: --- freeradius-server-2.1.7/src/modules/rlm_sql/rlm_sql.c 2009-09-14 10:43:29.000000000 -0400 +++ freeradius-server-2.1.7-patched/src/modules/rlm_sql/rlm_sql.c 2009-10-11 15:03:12.000000000 -0400 @@ -1323,7 +1323,7 @@ radius_xlat(logstr, sizeof(logstr), "stop packet with zero session length. [user '%{User-Name}', nas '%{NAS-IP-Address}']", request, NULL); radlog_request(L_ERR, 0, request, "%s", logstr); sql_release_socket(inst, sqlsocket); - ret = RLM_MODULE_NOOP; + return RLM_MODULE_NOOP; } #endif Mutex is released in sql_release_socket, but socket is still used below. This is not what CISCO_ACCOUNTING_HACK is supposed to do. Processing should stop here. It looks like this bug has been fixed in ic-radius 0.17 at 2001. -- Pavel Levshin OJSC "Megafon", North-West branch

2 1

Error: Received conflicting packet
by rihad 11 Oct '09

11 Oct '09

Hi, all, Sometimes when there are too many requests from a NAS, like right after rebooting it and thus breaking current sessions, etc., freeradius 2.1.3 under FreeBSD begins loggin many many lines like this after the NAS re-sends unanswered packets: Error: Received conflicting packet from client 10.10.70.94 port 1646 - ID: 220 due to unfinished request 511166. Giving up on old request. I looked in src/main/event.c and found this code: default: gettimeofday(&when, NULL); when.tv_sec -= 1; /* * If the cached request was received * within the last second, then we * discard the NEW request instead of the * old one. This will happen ONLY when * the client is severely broken, and is * sending conflicting packets very * quickly. */ if (timercmp(&when, &request->received, <)) { radlog(L_ERR, "Discarding conflicting packet from " "client %s port %d - ID: %d due to recent request %d.", client->shortname, packet->src_port, packet->id, request->number); return 0; } received_conflicting_request(request, client); ^^^ request = NULL; break; Our authorization/accounting happens through rlm_perl and is written in Perl. Perhaps it's not fast enough to process many many requests in under 1 second (when.tv_sec), but aborting the current packet instead of the new duplicate one can hardly be justified. Please look at the line marked with ^^^ - it's where the error is logged and the current request is aborted, unless it was caught earlier by "Discarding conflicting packet", in which case the _new_ duplicate request is aborted, which is more correct. I propose that when.tv_sec be configurable in radiusd.conf, and not hardcoded like that.

1 0

--with-system-libtldl broken on stable
by Jakob Hirsch 09 Oct '09

09 Oct '09

Hi, easy fix: diff --git a/configure.in b/configure.in index 770068d..c7d41e6 100644 --- a/configure.in +++ b/configure.in @@ -75,7 +75,7 @@ fi AC_ARG_WITH(system-libtldl, [ --with-system-libtldl Use the libtltdl installed in your system (default=use our own)], [ -LIBLTDL="-ltdl" +LIBLTDL="-lltdl" INCLTDL= LTDL_SUBDIRS= ], I'm not a expert in these things, so please excuse my dumb asking: Why does freeradius want to use his own libtool and libltdl? Are the ones out there that broken or is there any other reason? And are there disadvantages of using the ones included in FR? Debian seems to prefer the system's... Regards, Jakob

2 1

GIT Log for 2009-10-06 23:33 GMT
by aland＠deployingradius.com 06 Oct '09

06 Oct '09

commit f2273694594b65174b30680bef077485c9372f92 Author: Alan T. DeKok <aland(a)freeradius.org> Date: Tue Oct 6 11:28:36 2009 +0200 Forgot to include this... Files changed: src/include/smodule.h | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) ====================================================================== commit 9261f3e0026323b2c397af13d02fbc5780908143 Author: Alan T. DeKok <aland(a)freeradius.org> Date: Tue Oct 6 10:21:45 2009 +0200 Ensure that there is a cleanup event for proxied packets If there was no reply, clean up, reject, etc. the request. This doesn't matter so much for normal clients, as they will retransmit and cause the old request to be deleted from the request hash. But detail requests have random ports (for other reasons), so they won't be cleaned up by new packets. Therefore, we need to clean them up... Files changed: src/main/event.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) ====================================================================== commit e69be18535bd8b9a2cfb50a9df7cb44e3129ab4c Author: Alan T. DeKok <aland(a)freeradius.org> Date: Tue Oct 6 10:21:17 2009 +0200 Added more debugging messages Files changed: src/modules/frs_detail/frs_detail.c | 12 +++++++----- 1 files changed, 7 insertions(+), 5 deletions(-) ====================================================================== commit 6e45792b73caf67c01e4776065c52acc62d28d2b Author: Alan T. DeKok <aland(a)freeradius.org> Date: Tue Oct 6 08:48:02 2009 +0200 Mark home server dead if it doesn't respond to pings Files changed: src/main/event.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) ======================================================================

1 0

GIT Log for 2009-10-05 23:33 GMT
by aland＠deployingradius.com 05 Oct '09

05 Oct '09

commit 64700e41098a874581d683c8606c94f9ad23079d Author: Alan T. DeKok <aland(a)freeradius.org> Date: Mon Oct 5 17:32:39 2009 +0200 Check for undefined types, too Files changed: src/lib/radius.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) ====================================================================== commit ecf751a2a662d8749f45fa77f8b023b37b01056c Author: Alan T. DeKok <aland(a)freeradius.org> Date: Mon Oct 5 17:12:33 2009 +0200 Set broadcast && reuseaddr before binding to socket Files changed: src/main/listen.c | 59 +++++++++++++++++++++++++++++++++++++++ src/modules/frs_dhcp/frs_dhcp.c | 15 ---------- 2 files changed, 59 insertions(+), 15 deletions(-) ====================================================================== commit f6e2dba8a7e4dd31d36d5b8ee434d21600e3f99f Author: Alan T. DeKok <aland(a)freeradius.org> Date: Sun Oct 4 18:12:12 2009 +0200 Simplify the code Files changed: src/lib/valuepair.c | 40 ++++++++-------------------------------- 1 files changed, 8 insertions(+), 32 deletions(-) ====================================================================== commit 83c2cd412b1208e67381372baa73c779cd2848f6 Author: Alan T. DeKok <aland(a)freeradius.org> Date: Sat Oct 3 20:07:53 2009 +0200 More detailed debugging for detail Files changed: src/modules/frs_detail/frs_detail.c | 25 +++++++++++++++++++++++++ 1 files changed, 25 insertions(+), 0 deletions(-) ====================================================================== commit 1628ef2387d9f7a89b3c2ff8945f49777eb135f1 Author: Alan T. DeKok <aland(a)freeradius.org> Date: Sat Oct 3 20:07:22 2009 +0200 Be more restrictive on bad input Addresses bug #27 Files changed: src/lib/token.c | 9 ++++++++- src/main/conffile.c | 6 ++++++ 2 files changed, 14 insertions(+), 1 deletions(-) ====================================================================== commit 1013e94b66064f24170e394e63ba4f093c141d74 Author: Alan T. DeKok <aland(a)freeradius.org> Date: Sat Oct 3 19:58:17 2009 +0200 Start simplifying the code that encodes attributes Files changed: src/lib/radius.c | 176 +++++++++++++++++++++++++++++++++++------------------ 1 files changed, 116 insertions(+), 60 deletions(-) ====================================================================== commit e6c108b5e68f0ebe1f8a5d4a1c08500bbadcdab4 Author: Alan T. DeKok <aland(a)freeradius.org> Date: Fri Oct 2 10:52:44 2009 +0200 Fix passwords to have even length Files changed: scripts/create-users.pl | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) ======================================================================

1 0

GIT Log for 2009-10-01 23:33 GMT
by aland＠deployingradius.com 01 Oct '09

01 Oct '09

commit 751e9a39b2221a2623001a4611021a8e01cf4375 Author: Alan T. DeKok <aland(a)freeradius.org> Date: Thu Oct 1 15:07:51 2009 +0200 Increase max_sessions Files changed: raddb/eap.conf | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) ====================================================================== commit 382b6c2223ba1a233ca9f4d248beb888a0123f3e Author: Alan T. DeKok <aland(a)freeradius.org> Date: Thu Oct 1 15:06:59 2009 +0200 Print more descriptive error message for too many EAP sessions Files changed: src/modules/rlm_eap/mem.c | 17 ++++++++++++++--- 1 files changed, 14 insertions(+), 3 deletions(-) ====================================================================== commit e237107e1dca922dab291c5b011468ee24b768c2 Author: Alan T. DeKok <aland(a)freeradius.org> Date: Thu Oct 1 11:15:55 2009 +0200 event.c frees the listener, so we don't need to Files changed: src/modules/frs_control/frs_control.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) ====================================================================== commit 2065201e7df32961cc870d7e862ca9b2f9ae59f7 Author: Alan T. DeKok <aland(a)freeradius.org> Date: Thu Oct 1 10:39:22 2009 +0200 Moved illegal attributes to the new dictionary Files changed: share/dictionary | 1 + share/dictionary.usr | 38 ---------------------------------- share/dictionary.usr.illegal | 46 ++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 47 insertions(+), 38 deletions(-) ======================================================================

1 0