January 2014 - Freeradius-Devel - lists.freeradius.org

Commit report for v3.0.x branch
by announce＠freeradius.org 21 Jan '14

21 Jan '14

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Arg no longer used Arran Cudbard-Bell@2014-01-21T23:57:34Z Files modified: * src/modules/rlm_rest/rest.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/aaad2442018cfadde865… ====== Update ChangeLog Arran Cudbard-Bell@2014-01-21T23:54:30Z Files modified: * doc/ChangeLog Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/4f7ddf75944fb11bedc4… ====== Missed break Arran Cudbard-Bell@2014-01-21T23:42:43Z Files modified: * src/lib/valuepair.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/f6d7584ab3968736e3a1… ====== Doxygen Arran Cudbard-Bell@2014-01-21T23:40:54Z Files modified: * src/main/log.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/fbe1fff63496451761d0… ====== Fixup format strings Arran Cudbard-Bell@2014-01-21T23:37:59Z Files modified: * src/main/process.c * src/modules/rlm_eap/eap.c * src/modules/rlm_eap/rlm_eap.c * src/modules/rlm_ldap/ldap.c * src/modules/rlm_mschap/opendir.c * src/modules/rlm_mschap/rlm_mschap.c * src/modules/rlm_rest/rest.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/26d9f62f0993075a7d4c… ====== Fix operation of fr_strerror() A while back a flag was added to fr_strerror() to stop the same error message being output multiple times (and leading to confusing debug output). Unfortunately the macro for RERROR() and pals, inadvertently called fr_strerror() multiple times as ## __VA_ARGS__ was passed both to module_failure_msg() and radlog_request(), with the arguments to the macro being evaluated once per call. The solution is to switch the logging functions to use va_list instead of the ellipses, add a helper to convert ## __VA_ARGS__ into va_list, and then use va_copy to create a copy of the arguments for the radlog_request() call. As a side effect, it appears to of enabled printf format validation for more macros, so the next commit will be to fix all the places where that was previously unreported... Arran Cudbard-Bell@2014-01-21T23:37:59Z Files modified: * src/include/log.h * src/include/radiusd.h * src/main/log.c * src/main/process.c * src/main/unittest.c * src/main/util.c * src/main/valuepair.c * src/main/xlat.c * src/modules/rlm_eap/radeapclient.c * src/modules/rlm_sqlhpwippool/rlm_sqlhpwippool.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/d253c7306dc5170972dc… ====== Formatting and extra error messages Arran Cudbard-Bell@2014-01-21T23:37:59Z Files modified: * src/lib/valuepair.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/bb8c62240a7cd31fc104… ====== Unsigned comes after "int" Alan T. DeKok@2014-01-21T20:41:03Z Files modified: * raddb/mods-config/sql/main/mysql/schema.sql Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/30d0f2e9351d40663898… ====== reconnect can be called with an unused connection handle. Fixes #507 Alan T. DeKok@2014-01-21T20:39:40Z Files modified: * src/main/connection.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/d89cdb253465f953a6ce… ====== Fix scan warnings Alan T. DeKok@2014-01-21T19:14:50Z Files modified: * src/main/conffile.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/30fc7ef4fa4d3dd2d6e4… ====== Remove unused assignment Alan T. DeKok@2014-01-21T19:14:50Z Files modified: * src/main/radattr.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/36149d2dbb31172f9adc… ====== Add comparisons for SIGNED and ETHERNET types Conflicts: src/lib/valuepair.c Arran Cudbard-Bell@2014-01-21T13:54:07Z Files modified: * src/lib/valuepair.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/5580706cba0799671642… ====== Do NOT just return 0 silently if we don't support the type in paircmp, that's a great way to mess up any trees which use the function Arran Cudbard-Bell@2014-01-21T13:53:20Z Files modified: * src/lib/valuepair.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/690b3f057af014e1ce3c… ====== Fix merge issue... Arran Cudbard-Bell@2014-01-21T10:38:07Z Files modified: * share/dictionary.h3c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/1f3e57d28795843df0d8… ====== Extend the H3C dictionary based on public manuals Try to extend the H3C dictionary based on what is scattered on their pages. At least most of it is found quite consistently in the product-specific "Security Configuration Guides". This compilation/crosschecking is based H3C documentation for listed devices: - H3C S12500 and S6800 Switches - H3C WA WLAN Access Points - H3C MSR Routers Remarks: Does not stick with H3C's use of of underline in attribute naming. Conflicts: share/dictionary.h3c Mathieu Simon (via Arran Cudbard-Bell)@2014-01-21T10:02:09Z Files modified: * share/dictionary.h3c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/d7d7670a1a9ad2e1de19… ====== -- This commit summary was generated @2014-01-22T00:00:02Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

Commit report for master branch
by announce＠freeradius.org 21 Jan '14

21 Jan '14

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Arg no longer used Arran Cudbard-Bell@2014-01-21T23:57:54Z Files modified: * src/modules/rlm_rest/rest.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/f7e3080c7f6b2ebfd919… ====== Update ChangeLog Arran Cudbard-Bell@2014-01-21T23:50:49Z Files modified: * doc/ChangeLog Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/70b623ce62d3b6585f32… ====== Doxygen Arran Cudbard-Bell@2014-01-21T23:41:09Z Files modified: * src/main/log.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/ebdb81ef298c6b24168c… ====== Fixup format strings Arran Cudbard-Bell@2014-01-21T23:37:34Z Files modified: * src/main/process.c * src/modules/rlm_eap/eap.c * src/modules/rlm_eap/rlm_eap.c * src/modules/rlm_ldap/ldap.c * src/modules/rlm_mschap/opendir.c * src/modules/rlm_mschap/rlm_mschap.c * src/modules/rlm_rest/rest.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/002045e46c57c539f2b8… ====== Fix operation of fr_strerror() A while back a flag was added to fr_strerror() to stop the same error message being output multiple times (and leading to confusing debug output). Unfortunately the macro for RERROR() and pals, inadvertently called fr_strerror() multiple times as ## __VA_ARGS__ was passed both to module_failure_msg() and radlog_request(), with the arguments to the macro being evaluated once per call. The solution is to switch the logging functions to use va_list instead of the ellipses, add a helper to convert ## __VA_ARGS__ into va_list, and then use va_copy to create a copy of the arguments for the radlog_request() call. As a side effect, it appears to of enabled printf format validation for more macros, so the next commit will be to fix all the places where that was previously unreported... Arran Cudbard-Bell@2014-01-21T23:37:33Z Files modified: * src/include/log.h * src/include/radiusd.h * src/main/log.c * src/main/modcall.c * src/main/process.c * src/main/unittest.c * src/main/util.c * src/main/valuepair.c * src/main/xlat.c * src/modules/proto_bfd/bfd.c * src/modules/rlm_eap/radeapclient.c * src/modules/rlm_sqlhpwippool/rlm_sqlhpwippool.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/3b5642d06eb8526815ec… ====== Formatting and extra error messages Arran Cudbard-Bell@2014-01-21T23:37:33Z Files modified: * src/lib/valuepair.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/cf4533443893355eff57… ====== Split paircmp_value from paircmp_op. paircmp_value is trinary (and so can be used as cmp function in btree) paircmp_op is just binary. Arran Cudbard-Bell@2014-01-21T23:37:33Z Files modified: * src/include/libradius.h * src/lib/valuepair.c * src/modules/rlm_expr/paircmp.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/49e5385845758a56378b… ====== Unsigned comes after "int" Alan T. DeKok@2014-01-21T20:41:17Z Files modified: * raddb/mods-config/sql/main/mysql/schema.sql Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/d0759a6fec9abafdefad… ====== reconnect can be called with an unused connection handle. Fixes #507 Alan T. DeKok@2014-01-21T20:40:04Z Files modified: * src/main/connection.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/6e68c3ef6d1fbd355ca7… ====== Add comparisons for SIGNED and ETHERNET types Arran Cudbard-Bell@2014-01-21T13:52:36Z Files modified: * src/lib/valuepair.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/8de2a7079752a4c23d25… ====== Do NOT just return 0 silently if we don't support the type in paircmp, that's a great way to mess up any trees which use the function Arran Cudbard-Bell@2014-01-21T13:51:55Z Files modified: * src/lib/valuepair.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/3f53f5b967e26f252092… ====== Correct comments Arran Cudbard-Bell@2014-01-21T13:38:30Z Files modified: * src/main/radsniff.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/96fb26d15b09f6de5554… ====== Extend the H3C dictionary based on public manuals Try to extend the H3C dictionary based on what is scattered on their pages. At least most of it is found quite consistently in the product-specific "Security Configuration Guides". This compilation/crosschecking is based H3C documentation for listed devices: - H3C S12500 and S6800 Switches - H3C WA WLAN Access Points - H3C MSR Routers Remarks: Does not stick with H3C's use of of underline in attribute naming. Mathieu Simon (via Arran Cudbard-Bell)@2014-01-21T10:04:30Z Files modified: * share/dictionary.h3c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/803477f565678f56bac8… ====== Revisit H3C Exec-Privilege Try to match H3C terminology as close as to their documentation. - The Attribute name seems to not exactly match documentation, found consistently user i.e. in: - H3C S12500: Configurations Guides - H3C WA Series: Security Configuration Guide - Rename privilege levels to match H3C's documentation (previously likely more 3Com-ish). The levels naming are being used consistently mentioned throughout: - H3C SecPath F1000-E: Operational Manual - H3C S5500-SI: Operation Manual Mathieu Simon (via Arran Cudbard-Bell)@2014-01-21T10:04:30Z Files modified: * share/dictionary.h3c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/3046419a3a40d0146cea… ====== -- This commit summary was generated @2014-01-22T00:00:02Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

reply attributes not always sent (radius_paircreate() problem seen in rlm_ippool)
by John Dennis 21 Jan '14

21 Jan '14

-- John

5 14

mysql schema currently broken in 3.0.1
by John Dennis 21 Jan '14

21 Jan '14

This commit 3d00eb1 "Acctsession time is unsigned int" broke the mysql schema, it generates a SQL Syntax Error The problem is the unsigned qualifier must come after the type declaration, not before it. Attached is a trivial one line fix. Not sure what other branches this might have been committed to (master?), if so it needs to be updated there too. -- John

2 1

Commit report for v3.0.x branch
by announce＠freeradius.org 20 Jan '14

20 Jan '14

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Missed Arran Cudbard-Bell@2014-01-20T14:39:16Z Files modified: * src/modules/rlm_mschap/rlm_mschap.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/78ae3efc1cf2ae01a02a… ====== Fix mschap host/ xlat Arran Cudbard-Bell@2014-01-20T14:37:44Z Files modified: * src/modules/rlm_mschap/rlm_mschap.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/8147b1db8312bd0295f8… ====== Add additional Cisco-Disconnect-Cause Values Obtained from Cisco documentation, some additional Disconnect-Causes as i.e. used by IOS 15.x and likely previous versions. Mathieu Simon (via Arran Cudbard-Bell)@2014-01-20T11:52:02Z Files modified: * share/dictionary.cisco Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/f9df1ab08628e7d7b68c… ====== -- This commit summary was generated @2014-01-21T00:00:01Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

Commit report for master branch
by announce＠freeradius.org 20 Jan '14

20 Jan '14

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Missed Arran Cudbard-Bell@2014-01-20T14:39:23Z Files modified: * src/modules/rlm_mschap/rlm_mschap.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/e927d536e912883e5982… ====== Fix mschap host/ xlat Arran Cudbard-Bell@2014-01-20T14:37:31Z Files modified: * src/modules/rlm_mschap/rlm_mschap.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/fb69c0e04fe3adfca707… ====== Merge pull request #502 from matsimon/master-cisco-values Add additional Cisco-Disconnect-Cause Values Arran Cudbard-Bell@2014-01-20T11:49:54Z Files modified: * share/dictionary.cisco Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/61c9e2305076adb2b8d4… ====== Add additional Cisco-Disconnect-Cause Values Obtained from Cisco documentation, some additional Disconnect-Causes as i.e. used by IOS 15.x and likely previous versions. Mathieu Simon@2014-01-20T10:29:23Z Files modified: * share/dictionary.cisco Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/8988bc5f7d8266eac563… ====== -- This commit summary was generated @2014-01-21T00:00:01Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

Commit report for v2.x.x branch
by announce＠freeradius.org 19 Jan '14

19 Jan '14

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Add missing pipe Arran Cudbard-Bell@2014-01-19T10:13:44Z Files modified: * src/main/radiusd.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/54818d9f4cbed55c70f6… ====== -- This commit summary was generated @2014-01-20T00:00:01Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

Commit report for v3.0.x branch
by announce＠freeradius.org 19 Jan '14

19 Jan '14

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Formatting Arran Cudbard-Bell@2014-01-19T23:46:06Z Files modified: * share/dictionary.rfc7055 * share/dictionary.wimax.wichorus * share/dictionary.xylan Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/58c7ad6938a1745e3866… ====== Add H3C HW-Exec-Privilege as posted by Mathieu Simon Arran Cudbard-Bell@2014-01-19T23:45:58Z Files modified: * share/dictionary.h3c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/ce13dcf62393d8c85fb1… ====== Change priority of encoding error messages Arran Cudbard-Bell@2014-01-19T23:26:46Z Files modified: * src/lib/radius.c * src/main/tls_listen.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/7fa1c87806c0e614d18d… ====== Print errors when decoding RADSEC packets Arran Cudbard-Bell@2014-01-19T23:19:34Z Files modified: * src/main/listen.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/f7649bf23a24b6a7a4eb… ====== Document that 'max' should be the maximum number of threads Alan T. DeKok@2014-01-19T17:02:22Z Files modified: * raddb/mods-available/ldap * raddb/mods-available/sql Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/9777851c4258174e909f… ====== -- This commit summary was generated @2014-01-20T00:00:01Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

Commit report for master branch
by announce＠freeradius.org 19 Jan '14

19 Jan '14

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Formatting Arran Cudbard-Bell@2014-01-19T23:46:34Z Files modified: * share/dictionary.rfc7055 * share/dictionary.wimax.wichorus * share/dictionary.xylan Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/27980a7363e671139c19… ====== Add H3C HW-Exec-Privilege as posted by Mathieu Simon Arran Cudbard-Bell@2014-01-19T23:46:28Z Files modified: * share/dictionary.h3c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/6182027784b9a81af57f… ====== Change priority of encoding error messages Conflicts: src/lib/radius.c Arran Cudbard-Bell@2014-01-19T23:27:55Z Files modified: * src/lib/radius.c * src/main/tls_listen.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/e0b32401e4dd7fc9d236… ====== Print errors when decoding RADSEC packets Arran Cudbard-Bell@2014-01-19T23:19:08Z Files modified: * src/main/listen.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/92728372863706626f61… ====== Document that 'max' should be the maximum number of threads Alan T. DeKok@2014-01-19T17:02:50Z Files modified: * raddb/mods-available/ldap * raddb/mods-available/sql Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/2e41f946fb4368b7a906… ====== Set the default length for the attributes Alan T. DeKok@2014-01-19T17:02:48Z Files modified: * src/lib/valuepair.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/f6b8c8f2580b3f4c3231… ====== -- This commit summary was generated @2014-01-20T00:00:01Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

gcc and gdb bug caused by imacros usage (gdb emits only <command-line>)
by John Dennis 19 Jan '14

19 Jan '14

Heads up to those performing debugging on 3.x Recently when I was trying to perform symbolic debugging on components built from the 3.x tree I discovered I was unable to get any source file information in gdb, it would only emit <command-line> as the source filename and I could not get gdb to list source, show it in a backtrace, etc. Thanks to Nalin Dahyabhai who discovered the root cause, it's covered in this bugzilla. https://bugzilla.redhat.com/show_bug.cgi?id=1004526 Apparently using -imacros causes the failure. To be honest I wasn't all that familiar with -imacros myself. The workaround I came up with was to replace -imacros in Make.inc.in with -include. I don't know which version of the gcc/gdb tool chain this shows up in or if it's specific to how debuginfo packages are produced during the RPM build process. But if you do hit this issue you'll discover it's almost impossible to do any useful debugging, so heads up, HTH -- John

4 4