- Freeradius-Devel - lists.freeradius.org

Trouble with 7bae7c8e and radsec clients causing mutex crash
by Sam Hartman 10 Jul '14

10 Jul '14

Hi. I have a bug that is manifesting on 32-bit intel but not on x86_64. Configurations are similar and I have fairly high confidence that the changes don't matter; making the configurations identical is difficult. Notes about the configuration: * dynamic is true in proxy.conf * sites-available/tls is the same as the stock configuration except that I've added a default radsec client: client default { ipaddr = 0.0.0.0 netmask = 0 proto = tls secret = radsec } When I try and connect using radsec I get: Listening on auth+acct proto tcp address * port 2083 (TLS) as server default Listening on auth address 127.0.0.1 port 18120 as server inner-tunnel Listening on auth address * port 1812 as server default Listening on acct address * port 1813 as server default Listening on auth address :: port 1812 as server default Listening on acct address :: port 1813 as server default Opening new proxy socket 'proxy address * port 0' Listening on proxy address * port 56457 Ready to process requests ... new connection request on TCP socket freeradius: tpp.c:63: __pthread_tpp_change_priority: Assertion `new_prio == -1 || (new_prio >= __sched_fifo_min_prio && new_prio <= __sched_fifo_max_prio)' failed. Aborted (gdb) bt #0 0xb7fe1424 in __kernel_vsyscall () #1 0xb7b54941 in *__GI_raise (sig=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:64 #2 0xb7b57d72 in *__GI_abort () at abort.c:92 #3 0xb7b4db58 in *__GI___assert_fail (assertion=0xb7d0e64c "new_prio == -1 || (new_prio >= __sched_fifo_min_prio && new_prio <= __sched_fifo_max_prio)", file=0xb7d0e628 "tpp.c", line=63, function=0xb7d0e62e "__pthread_tpp_change_priority") at assert.c:81 #4 0xb7d0c724 in __pthread_tpp_change_priority (previous_prio=-1, new_prio=5881) at tpp.c:61 #5 0xb7d04c9d in __pthread_mutex_lock_full (mutex=0xb7c8a63c) at pthread_mutex_lock.c:415 #6 0xb7f9f8fb in rbtree_find (tree=0xb7c8a628, data=0xbffff454) at src/lib/rbtree.c:513 #7 0xb7f9f983 in rbtree_finddata (tree=0xb7c8a628, data=data@entry=0xbffff454) at src/lib/rbtree.c:539 #8 0x0805636c in client_find (clients=clients@entry=0x82f53e8, ipaddr=ipaddr@entry=0xbffff884, proto=6) at src/main/client.c:399 #9 0x0805efd4 in client_listener_find (listener=listener@entry=0x82f0ee0, ipaddr=ipaddr@entry=0xbffff884, src_port=48007) at src/main/listen.c:134 #10 0x0805fe51 in dual_tcp_accept (listener=0x82f0ee0) at src/main/listen.c:574 #11 0x08072775 in event_socket_handler (xel=0x80b2798, fd=16, ctx=0x82f0ee0) at src/main/process.c:4076 #12 0xb7fa82a9 in fr_event_loop (el=0x80b2798) at src/lib/event.c:495 #13 0x08077fd3 in radius_event_process () at src/main/process.c:4977 #14 0x08053d9f in main (argc=4, argv=0xbffffcf4) at src/main/radiusd.c:582 (gdb) f 6 #6 0xb7f9f8fb in rbtree_find (tree=0xb7c8a628, data=0xbffff454) at src/lib/rbtree.c:513 513 src/lib/rbtree.c: No such file or directory. (gdb) p tree $1 = (rbtree_t *) 0xb7c8a628 (gdb) p *tree $2 = {root = 0xb7c8a620, num_elements = -1211587040, compare = 0xb7c8a628 <main_arena+616>, free = 0xb7c8a628 <main_arena+616>, replace = 48, lock = 166, mutex = { __data = {__lock = -1211587024, __count = 3083380280, __owner = -1211587016, __kind = -1211587008, __nusers = 3083380288, {__spins = -1211587000, __list = { __next = 0xb7c8a648}}}, __size = "0\246ȷ8\246ȷ8\246ȷ@\246ȷ@\246ȷH\246ȷ", __align = -1211587024}} Needless to say, some random offset inside main_arena looks entirely out of place as a compare function. And the lock valueand num_elements don't look so good either. 399 src/main/client.c: No such file or directory. (gdb) p clients $3 = (const RADCLIENT_LIST *) 0x82f53e8 (gdb) p *clients $4 = {trees = {0x82f8800, 0x0 <repeats 31 times>, 0x82f56a8, 0x0 <repeats 96 times>}, min_prefix = 0} (gdb) p *$6 $7 = {root = 0x82f8860, num_elements = 1, compare = 0x8056050 <client_ipaddr_cmp>, free = 0, replace = false, lock = false, mutex = {__data = {__lock = 0, __count = 0, __owner = 0, __kind = 0, __nusers = 0, {__spins = 0, __list = {__next = 0x0}}}, __size = '\000' <repeats 23 times>, __align = 0}} I'd appreciate any help trying to track this down.

3 8

Commit report for master branch
by announce＠freeradius.org 09 Jul '14

09 Jul '14

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Use loop index to get description. Closes #729 Alan T. DeKok@2014-07-09T21:33:52Z Files modified: * src/main/tls.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/836edc3d32acec6433e1… ====== A parent config section might not exist when dynamically adding a home server. Alan T. DeKok@2014-07-09T21:29:21Z Files modified: * src/main/realms.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/1d0b35b201537621f452… ====== Formatting Arran Cudbard-Bell@2014-07-09T02:09:29Z Files modified: * src/include/token.h Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/785a190d49d7f5f845b8… ====== Fixup Sqlite schema Arran Cudbard-Bell@2014-07-09T02:09:26Z Files modified: * raddb/mods-config/sql/main/sqlite/schema.sql Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/c1153cd0d46a803deacf… ====== -- This commit summary was generated @2014-07-10T00:00:01Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

Commit report for v3.0.x branch
by announce＠freeradius.org 09 Jul '14

09 Jul '14

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Use loop index to get description. Closes #729 Alan T. DeKok@2014-07-09T21:33:24Z Files modified: * src/main/tls.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/1d25e515d28108e3cb8b… ====== A parent config section might not exist when dynamically adding a home server. Alan T. DeKok@2014-07-09T21:29:09Z Files modified: * src/main/realms.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/cf608881626bcf93ab74… ====== Remove useless extern declarations Arran Cudbard-Bell@2014-07-09T18:35:03Z Files modified: * src/include/libradius.h * src/include/missing-h * src/include/rad_assert.h * src/include/radiusd.h * src/include/tls-h * src/lib/dict.c * src/lib/print.c * src/lib/radius.c * src/main/mainconfig.c * src/main/tls.c * src/main/tls_listen.c * src/modules/rlm_eap/libeap/eap_chbind.h * src/modules/rlm_eap/libeap/eap_tls.c * src/modules/rlm_eap/libeap/eap_types.h * src/modules/rlm_mschap/opendir.c * src/modules/rlm_mschap/rlm_mschap.c * src/modules/rlm_opendirectory/rlm_opendirectory.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/37917ad89540da122e5d… ====== Cleanup EAP-SIM macros Arran Cudbard-Bell@2014-07-09T18:35:03Z Files modified: * src/modules/rlm_eap/libeap/eap_sim.h * src/modules/rlm_eap/libeap/eapsimlib.c * src/modules/rlm_eap/radeapclient.c * src/modules/rlm_eap/types/rlm_eap_sim/rlm_eap_sim.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/b92da9313a5ee8135e6a… ====== Debug condition is now a fr_cond_t Arran Cudbard-Bell@2014-07-09T18:35:02Z Files modified: * src/main/mainconfig.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/1d60c47e73727c795b1c… ====== Limit which operators can be used with LDAP group comparison and other minor cleanups Arran Cudbard-Bell@2014-07-09T18:34:55Z Files modified: * src/modules/rlm_ldap/groups.c * src/modules/rlm_ldap/rlm_ldap.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/62a8a4ed8e505b511179… ====== Formatting Arran Cudbard-Bell@2014-07-09T02:09:19Z Files modified: * src/include/token.h Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/e5a743c8be8b7eada07e… ====== Fixup Sqlite schema Arran Cudbard-Bell@2014-07-09T02:09:00Z Files modified: * raddb/mods-config/sql/main/sqlite/schema.sql Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/77d7284333b953702b50… ====== -- This commit summary was generated @2014-07-10T00:00:01Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

Commit report for v3.0.x branch
by announce＠freeradius.org 08 Jul '14

08 Jul '14

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Update cui Updated comments to clarify the dual purpose of the unlang fragment. Stefan Paetow (via Arran Cudbard-Bell)@2014-07-08T13:51:32Z Files modified: * raddb/policy.d/cui Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/448bc0e0727d406825fa… ====== Try and make dlopen library search messages clearer Arran Cudbard-Bell@2014-07-08T05:24:31Z Files modified: * src/main/modules.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/2059032d31e38393ffd3… ====== Remove reply:User-Name only if there's a reply:CUI Alan T. DeKok@2014-07-08T04:35:28Z Files modified: * raddb/policy.d/cui Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/3d9a6e9957835180e198… ====== -- This commit summary was generated @2014-07-09T00:00:01Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

Commit report for master branch
by announce＠freeradius.org 08 Jul '14

08 Jul '14

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Merge pull request #728 from spaetow/patch-1 Update cui Arran Cudbard-Bell@2014-07-08T13:50:47Z Files modified: * raddb/policy.d/cui Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/56f0bd126467af919f17… ====== Update cui Updated comments to clarify the dual purpose of the unlang fragment. Stefan Paetow@2014-07-08T10:45:01Z Files modified: * raddb/policy.d/cui Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/3875518cef0a654e744b… ====== Try and make dlopen library search messages clearer Arran Cudbard-Bell@2014-07-08T05:24:53Z Files modified: * src/main/modules.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/a063aa327d86ab3554db… ====== Remove reply:User-Name only if there's a reply:CUI Alan T. DeKok@2014-07-08T04:35:41Z Files modified: * raddb/policy.d/cui Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/1827f88607f287d841ea… ====== -- This commit summary was generated @2014-07-09T00:00:01Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

Commit report for master branch
by announce＠freeradius.org 07 Jul '14

07 Jul '14

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Formatting Arran Cudbard-Bell@2014-07-07T20:28:21Z Files modified: * src/modules/rlm_ldap/groups.c * src/modules/rlm_ldap/rlm_ldap.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/fe4970c8613e232e63b0… ====== Merge pull request #726 from herwinw/peap_proxy_as_eap_boolean Some cleanups in rlm_eap{peap,ttls} headers Arran Cudbard-Bell@2014-07-07T20:04:01Z Files modified: * src/modules/rlm_eap/types/rlm_eap_peap/eap_peap.h * src/modules/rlm_eap/types/rlm_eap_ttls/eap_ttls.h Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/5929a1d63f19881b276f… ====== Use enums instead of define lists in rlm_eap_peap But only for the values that are only used internally. Herwin Weststrate@2014-07-06T12:55:03Z Files modified: * src/modules/rlm_eap/types/rlm_eap_peap/eap_peap.h Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/06ebd7ef91a97ab19f18… ====== Changed integer type for rlm_eap_{ttls,peap} tunnel types to bool where applicable Herwin Weststrate@2014-07-06T12:37:27Z Files modified: * src/modules/rlm_eap/types/rlm_eap_peap/eap_peap.h * src/modules/rlm_eap/types/rlm_eap_ttls/eap_ttls.h Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/995e77fb5c260f28feff… ====== As posted to the list Alan T. DeKok@2014-07-07T18:10:05Z Files modified: * share/dictionary * share/dictionary.dragonwave Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/d88c3145fa9c361850a4… ====== -- This commit summary was generated @2014-07-08T00:00:01Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

Commit report for v3.0.x branch
by announce＠freeradius.org 07 Jul '14

07 Jul '14

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Changed integer type for rlm_eap_{ttls,peap} tunnel types to bool where applicable Herwin Weststrate (via Arran Cudbard-Bell)@2014-07-07T20:31:03Z Files modified: * src/modules/rlm_eap/types/rlm_eap_peap/eap_peap.h * src/modules/rlm_eap/types/rlm_eap_ttls/eap_ttls.h Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/9851f2c759de4307aeb7… ====== Use enums instead of define lists in rlm_eap_peap But only for the values that are only used internally. Herwin Weststrate (via Arran Cudbard-Bell)@2014-07-07T20:29:54Z Files modified: * src/modules/rlm_eap/types/rlm_eap_peap/eap_peap.h Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/09ea27662cf245be6dc0… ====== Formatting Arran Cudbard-Bell@2014-07-07T20:28:29Z Files modified: * src/modules/rlm_ldap/groups.c * src/modules/rlm_ldap/rlm_ldap.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/7c201641c1527cae7033… ====== As posted to the list Alan T. DeKok@2014-07-07T18:09:51Z Files modified: * share/dictionary * share/dictionary.dragonwave Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/8cc903f285be0fcba4ec… ====== -- This commit summary was generated @2014-07-08T00:00:01Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

Commit report for v2.x.x branch
by announce＠freeradius.org 07 Jul '14

07 Jul '14

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== As posted to the list Alan T. DeKok@2014-07-07T18:09:28Z Files modified: * share/dictionary * share/dictionary.dragonwave Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/426e1cea8618b10b3835… ====== whitespace Alan T. DeKok@2014-07-07T18:07:41Z Files modified: * doc/ChangeLog Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/9aa5225ddcec38a737d3… ====== -- This commit summary was generated @2014-07-08T00:00:01Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

Commit report for v3.0.x branch
by announce＠freeradius.org 04 Jul '14

04 Jul '14

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Merge pull request #725 from nchaigne/v3.0.x radeapclient - fix send_packet Arran Cudbard-Bell@2014-07-04T17:08:19Z Files modified: * src/modules/rlm_eap/radeapclient.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/f3100c303c7cf6e5f509… ====== radeapclient - fix send_packet I spotted two errors in radeapclient.c, introduced in the following previous commits. With this fix, radeapclient is now useable again. 1) Commit: c8a062a112f17a5810d311dc0e0acfe963b2d440 (2014/06/13) - send_packet(rep, &req); - - if (!req) return -1; + send_packet(req, &rep); + if (!rep) { Arguments got reversed. Hence segmentation fault later when doing: for (vp = req->vps; vp != NULL; vp = vpnext) { Bit of caution on the wording used in radeapclient: "req" is the request coming FROM the server. (because this is not a "request" in RADIUS sense, but an EAP-Request within the EAP-SIM transaction.) "rep" is the response from the client TO the server (EAP-Response). 2) Commit: bc3676835c3dcc220ab518d4c3c35962bc0f8be2 (2014/05/02) In "send_packet": + if (!req || !rep || !*rep) return -1; *rep == NULL is the expected behaviour... Nicolas C@2014-07-04T17:03:33Z Files modified: * src/modules/rlm_eap/radeapclient.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/53c1ce349b07a6e51dcc… ====== In redhat spec file, update dependency on json-c to version 0.10 as 0.11 only exists for fedora and 0.10 builds ok Philippe Wooding (via Alan T. DeKok)@2014-07-04T16:01:54Z Files modified: * redhat/freeradius.spec Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/c0e3a5330804c0873621… ====== Update redhat spec file to reflect the fact rlm_host is no longer experimental. Philippe Wooding (via Alan T. DeKok)@2014-07-04T16:01:34Z Files modified: * redhat/freeradius.spec Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/3fb6571b943ae2f1eb48… ====== -- This commit summary was generated @2014-07-05T00:00:02Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0

Commit report for master branch
by announce＠freeradius.org 04 Jul '14

04 Jul '14

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== radeapclient - fix send_packet I spotted two errors in radeapclient.c, introduced in the following previous commits. With this fix, radeapclient is now useable again. 1) Commit: c8a062a112f17a5810d311dc0e0acfe963b2d440 (2014/06/13) - send_packet(rep, &req); - - if (!req) return -1; + send_packet(req, &rep); + if (!rep) { Arguments got reversed. Hence segmentation fault later when doing: for (vp = req->vps; vp != NULL; vp = vpnext) { Bit of caution on the wording used in radeapclient: "req" is the request coming FROM the server. (because this is not a "request" in RADIUS sense, but an EAP-Request within the EAP-SIM transaction.) "rep" is the response from the client TO the server (EAP-Response). 2) Commit: bc3676835c3dcc220ab518d4c3c35962bc0f8be2 (2014/05/02) In "send_packet": + if (!req || !rep || !*rep) return -1; *rep == NULL is the expected behaviour... Nicolas C (via Arran Cudbard-Bell)@2014-07-04T17:09:17Z Files modified: * src/modules/rlm_eap/radeapclient.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/4f50d728a9e3f5fb6aea… ====== Merge pull request #724 from pwdng/master Update redhat spec file Arran Cudbard-Bell@2014-07-04T15:54:54Z Files modified: * redhat/freeradius.spec Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/1ff282afcc477b90869d… ====== In redhat spec file, update dependency on json-c to version 0.10 as 0.11 only exists for fedora and 0.10 builds ok Philippe Wooding@2014-07-04T14:03:19Z Files modified: * redhat/freeradius.spec Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/30efae5bc96185eab3e9… ====== Update list of installed files in redhat spec file Philippe Wooding@2014-07-04T14:03:19Z Files modified: * redhat/freeradius.spec Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/472b5574d7423bc4fb5e… ====== Update redhat spec file to reflect the fact rlm_host is no longer experimental. Philippe Wooding@2014-07-04T12:30:39Z Files modified: * redhat/freeradius.spec Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/a9084db4c17dc77d2d32… ====== Revert version to 3.1.0 in redhat spec. Philippe Wooding@2014-07-04T12:13:30Z Files modified: * redhat/freeradius.spec Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/b1ce69e0e2fd9f290759… ====== -- This commit summary was generated @2014-07-05T00:00:02Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed)

1 0